This is an automated email from Gerrit.

Tomasz CEDRO ([email protected]) just uploaded a new patch set to Gerrit, which 
you can find at http://openocd.zylin.com/1075

-- gerrit

commit 2bd123315fa0f692e1a1a8849c5337c39a9d7b4b
Author: Tomek CEDRO <[email protected]>
Date:   Mon Nov 12 00:25:51 2012 +0100

    Minor reorganization of includes in transport. Header file should only 
contain self declarations, no other includes.
    
    Change-Id: I9b6e443f7c44a767b241587819126bb895ee3a2f
    Signed-off-by: Tomek CEDRO <[email protected]>

diff --git a/src/target/adi_v5_swd.c b/src/target/adi_v5_swd.c
index a40d80c..a30943e 100644
--- a/src/target/adi_v5_swd.c
+++ b/src/target/adi_v5_swd.c
@@ -52,9 +52,7 @@
 #include "arm.h"
 #include "arm_adi_v5.h"
 #include <helper/time_support.h>
-
-#include <transport/transport.h>
-
+#include <jtag/interface.h>
 #include <jtag/swd.h>
 
 static int swd_queue_dp_read(struct adiv5_dap *dap, unsigned reg,
diff --git a/src/transport/transport.c b/src/transport/transport.c
index 89f0f97..827d509 100644
--- a/src/transport/transport.c
+++ b/src/transport/transport.c
@@ -19,10 +19,6 @@
  * Inc., 59 Temple Place, Suite 330, Boston, MA  02111-1307  USA
  */
 
-#ifdef HAVE_CONFIG_H
-#include "config.h"
-#endif
-
 /** @file
  * Infrastructure for specifying and managing the transport protocol
  * used in a given debug or programming session.
@@ -45,8 +41,15 @@
  * messaging and error handling.
  */
 
-#include <helper/log.h>
+#ifdef HAVE_CONFIG_H
+#include "config.h"
+#endif
+
+#include <interface/interface.h>
 #include <transport/transport.h>
+#include <target/arm.h>
+#include <target/arm_adi_v5.h>
+#include <helper/log.h>
 
 extern struct command_context *global_cmd_ctx;
 
@@ -365,3 +368,4 @@ int oocd_transport_register_commands(struct command_context 
*ctx)
 {
        return register_commands(ctx, NULL, oocd_transport_group);
 }
+
diff --git a/src/transport/transport.h b/src/transport/transport.h
index 9028ae1..4185d9d 100644
--- a/src/transport/transport.h
+++ b/src/transport/transport.h
@@ -21,15 +21,9 @@
  * Inc., 59 Temple Place, Suite 330, Boston, MA  02111-1307  USA
  */
 
-#ifdef HAVE_CONFIG_H
-#include "config.h"
-#endif
-
 #ifndef OOCD_TRANSPORT_H
 #define OOCD_TRANSPORT_H
 
-#include "helper/command.h"
-
 /**
  * Wrapper for transport lifecycle operations.
  *
@@ -94,7 +88,4 @@ int oocd_transport_select_jim(Jim_Interp *interp, int argc, 
Jim_Obj * const *arg
 
 COMMAND_HELPER(oocd_transport_list_parse, char ***vector);
 
-/* TODO: Remove ASAP when interface becomes JTAG independent. */
-#include <jtag/interface.h>
-
 #endif

-- 

------------------------------------------------------------------------------
LogMeIn Rescue: Anywhere, Anytime Remote support for IT. Free Trial
Remotely access PCs and mobile devices and provide instant support
Improve your efficiency, and focus on delivering more value-add services
Discover what IT Professionals Know. Rescue delivers
http://p.sf.net/sfu/logmein_12329d2d
_______________________________________________
OpenOCD-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/openocd-devel

Reply via email to