Hallo Paul:

I uploaded Patchset 4 half an hour ago, Jenkins appended "Verified
+1" shortly afterwards, but I got no e-mail about it. I believe you
also get no e-mail if the build fails.

Build failure notifications are relatively important because, if you
patch fails the build, no reviewer is probably going to bother
reviewing the patch until the author at least fixes the build.

As the patch author, you may assume that the CI system needs some
time, and that you will get an e-mail sooner or later, so you may
forget about your patch (at least temporarily, we are all busy
people). This is what happened to me with this particular
patch. Even if you remember later, a timely build failure
notification would still help because you are more likely to have
the code fresh in you head.

On 12.11.24 11:20, Paul Fertser wrote:
I fully agree! The relevant configuration knob found and tweaked, hope
it works properly now.

For the reference, before the big software upgrade few years ago
Jenkins was using "gerrit review" commands to post results and that
used default nofication level "all". Then it was switched to Gerrit
REST API and started to honour a somewhat hidden "Notification Level"
setting in the "Miscellaneous" section which somehow was set to
"none".
[...]

I am having the same problem again, this time with the following patch:

https://review.openocd.org/c/openocd/+/9281

I have checked my spam folder to no avail.

Has something changed in Gerrit again?

Thanks in advance,
  rdiez

Reply via email to