On Wed, Dec 21, 2011 at 3:54 PM, Øyvind Harboe <oyvind.har...@zylin.com> wrote:
> Please run this in gdb and do a bt(backtrace).
Seems to be working fine, at least OpenOCD does not break.
I have in the end of the listing
Backtrace stopped: previous frame identical to this frame (corrupt stack?)
but I guess not related to this problem.
I can see that this was recent commit :
[ddraskovic@lardos:/home/ddraskovic/openocd]>git show a30a4f0f
commit a30a4f0fc76b72936a6557e08d6b55b3a46eaafd
Author: Øyvind Harboe <oyvind.har...@zylin.com>
Date: Tue Dec 13 23:44:34 2011 +0100
jtag: make caller always allocate buffer
simplifies the API and there is only one remaining user at this point.
Is the implementation busted where the check does not actually happen
now?
Change-Id: I776a43766f5576a08df320f6fe41a2750d101bde
Signed-off-by: Øyvind Harboe <oyvind.har...@zylin.com>
Reviewed-on: http://openocd.zylin.com/264
Tested-by: jenkins
Reviewed-by: Spencer Oliver <s...@spen-soft.co.uk>
diff --git a/src/jtag/core.c b/src/jtag/core.c
index 3090ddd..529e9bc 100644
--- a/src/jtag/core.c
+++ b/src/jtag/core.c
@@ -417,12 +417,8 @@ static void jtag_add_scan_check(struct jtag_tap
*active, void (*jtag_add_scan)(s
for (int i = 0; i < in_num_fields; i++)
{
struct scan_field *field = &in_fields[i];
- field->allocated = 0;
- field->modified = 0;
- if (field->check_value || field->in_value)
- continue;
- interface_jtag_add_scan_check_alloc(field);
- field->modified = 1;
+ /* caller must provide in_buffer if needed for callback */
+ assert((field->check_value == NULL) || (field->in_value != NULL));
}
Seems to be introducing a bit of regression... Some unchanged files remain ?
BR,
Drasko
>
>
>
> On Wed, Dec 21, 2011 at 3:52 PM, Drasko DRASKOVIC
> <drasko.drasko...@gmail.com> wrote:
>> Hi all,
>> with new git repo clone of OpenOCD I have been hitting this assert
>> during the scan chain init :
>> openocd: core.c:421: jtag_add_scan_check: Assertion
>> `(field->check_value == ((void *)0)) || (field->in_value != ((void
>> *)0))' failed.
>>
>> Commenting out this assert everything seems to be OK.
>>
>> I am using libftdi-0.19, and have seen same issue on both ARM946 and
>> MIPS targets.
>>
>> BR,
>> Drasko
>> _______________________________________________
>> Openocd-development mailing list
>> Openocd-development@lists.berlios.de
>> https://lists.berlios.de/mailman/listinfo/openocd-development
>
>
>
> --
> Øyvind Harboe - Can Zylin Consulting help on your project?
> US toll free 1-866-980-3434
> http://www.zylin.com/
_______________________________________________
Openocd-development mailing list
Openocd-development@lists.berlios.de
https://lists.berlios.de/mailman/listinfo/openocd-development
