On Tue, 20 Feb 2007, Dan Price wrote:
Hi folks, I'd like to start codereview for the following wad: PSARC/2007/045 I2O EOL and EOF 4863632 Hey Hey! Ho Ho! I2O Has Got to Go! Codereview materials and pointers to the ARC case are posted at: http://cr.grommit.com/~dp/i2o-del All relevant approvals have been sought and obtained-- so codereview, RTI, and finding enough time are my only stumbling blocks. Thanks, -dp
I didn't see any replies, so here are some comments: - The framed diffs were empty when I looked at the webrev. - Should the I2O lines be removed from usr/src/common/pci/pci_strings.c? - Should the i2o device_path entry be removed from usr/src/uts/i86pc/sys/biosdisk.h? - What about the i2o entry in the class code table in usr/src/uts/intel/io/hotplug/pcicfg/pcicfg.c? - It looks like the webrev is missing the removal of usr/src/uts/intel/pci_to_i2o, and removal of PCI_I2ONEXUS_OBJS from usr/src/uts/common/Makefile.files? - Is it worth figuring out the nature of the typo in usr/src/uts/common/sys/smbios.h, in which the comment for macro name SMB_BIOSXB1_I20 refers to I2O? - That still leaves some unused I2O-related macros in usr/src/uts/sun4u/sys/pci/db21554_csr.h and usr/src/grub/grub-0.95/netboot/pci_ids.h, but it's probably not worth removing them. - I think you're missing an update to usr/src/tools/scripts/bfu.sh. - I think I'm annoyed that the class action script updates look correct, but that the actual invocation of those is essentially a side effect of some other action, because none of them are actually used by either of the two packages that you're actually modifying. But that's not something I expect you to fix, I'm just griping. --Mark _______________________________________________ opensolaris-code mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/opensolaris-code
