On Tue, Nov 01, 2005 at 10:18:42AM +0100, Kurt Roeckx via RT wrote:
> 
> So this looks like an error that doesn't get cleared, and I have
> to wonder who should clear it.  I don't think COMP_zlib() should
> return that it was actually succesful in opening the library,
> so it should atleast return zlib_method_nozlib in case it's
> failing.  And I think it would be best if it cleared the error at
> that time too.

After thinking about this some more, I think the proper place to
clear the error would be SSL_COMP_add_compression_method().  From
what I understand, you're always supposed to call that after
calling COMP_zlib().

The openssl source always seems to check the method->type to be
!= NID_undef, but I don't think applications should do that, and
SSL_COMP_add_compression_method checks it too.

Anyway, I'm not really sure where the proper way to clear that
error is.


Kurt

______________________________________________________________________
OpenSSL Project                                 http://www.openssl.org
Development Mailing List                       [email protected]
Automated List Manager                           [EMAIL PROTECTED]

Reply via email to