I merged the https://review.openstack.org/#/c/197302/ as we had agreed that once we had enough +1's on the EL7 review we would merge it.
The Puppet4 spec tests had already been approved. -- David Moreau Simard Cloud Engineering | Operations On 2015-06-30 07:06 PM, Andrew Woodward wrote: On Tue, Jun 30, 2015 at 6:28 AM Emilien Macchi <[email protected]<mailto:[email protected]>> wrote: On 06/29/2015 11:16 PM, Matt Fischer wrote: > Ah, I don't have +2 on that repo, but the lgtm so your original plan is > fine. > > On Mon, Jun 29, 2015 at 5:59 PM, Matt Fischer > <<mailto:[email protected]>[email protected]<mailto:[email protected]> > <mailto:[email protected]<mailto:[email protected]>>> wrote: > > I can take a look at these tonight. Maybe also Clayton can review > them? Neither of us were involved in the patches to my knowledge. > > On Jun 29, 2015 5:09 PM, "Andrew Woodward" > <<mailto:[email protected]>[email protected]<mailto:[email protected]> > <mailto:[email protected]<mailto:[email protected]>>> wrote: > > Hi > > Recent changes in the puppet modules infra left > stackforge/puppet-ceph CI broken. We've resolved the issues in > [1][2] However we are short on non-involved core-reviewers. You'll have to sqash the commits because our CI is voting for puppet4 & beaker. Thanks David squished it up into [3]. The same message applies I'm going to use lazy census here and if we don't have any negative feed back we should just merge it so we get CI back to passing [3] https://review.openstack.org/#/c/197302/ If this module does not fit for you, you can still patch project-config, otherwise you'll need to fix everything in one single commit. > I propose that we leave the patchs open through Wednesday and > use lazy consensus and merge it if we don't receive any negative > feedback. > > [1] https://review.openstack.org/#/c/179645/ > [2] https://review.openstack.org/#/c/195959/ > -- > > -- > > Andrew Woodward > > Mirantis > > Fuel Community Ambassador > > Ceph Community > > > > __________________________________________________________________________ > OpenStack Development Mailing List (not for usage questions) > Unsubscribe: > > [email protected]?subject:unsubscribe<http://[email protected]?subject:unsubscribe> > <http://[email protected]?subject:unsubscribe> > http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev > > > > > __________________________________________________________________________ > OpenStack Development Mailing List (not for usage questions) > Unsubscribe: > [email protected]?subject:unsubscribe<http://[email protected]?subject:unsubscribe> > http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev > -- Emilien Macchi __________________________________________________________________________ OpenStack Development Mailing List (not for usage questions) Unsubscribe: [email protected]?subject:unsubscribe<http://[email protected]?subject:unsubscribe> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev -- -- Andrew Woodward Mirantis Fuel Community Ambassador Ceph Community
__________________________________________________________________________ OpenStack Development Mailing List (not for usage questions) Unsubscribe: [email protected]?subject:unsubscribe http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
