On 01/07/2016 01:07 PM, Sofer Athlan-Guyot wrote:
> Hi,
>
> There are a few places where I would like to be able to check for IPv6
> address and add bracket to the parameters. I think that would be a nice
> addition to the puppet-openstacklib/lib/puppet/parser.
>
> Here the interface I have in mind with the puppet-nova module:
>
> class nova::vncproxy::common (
> $vncproxy_host = undef,
> $vncproxy_protocol = undef,
> $vncproxy_port = undef,
> $vncproxy_path = undef,
> ) {
>
> include ::nova::deps
>
> $vncproxy_host_real = pick(
> ipv6_add_bracket_maybe($vncproxy_host,
> $::nova::compute::vncproxy_host,
> $::nova::vncproxy::host,
> false)
>
>
> This would returns an array with the host decorated with "[]" if the
> value is an IPv6 address. Ideally the function could take only one
> value and return it or take an array and return an array for seamless
> integration in the code.
>
> WDYT?
> The design looks okay to me, but on long term I would rather see the code in puppetlabs/stdlib rather than in our forge. In short term, I agree to have this kind of code in openstacklib. Does it means we'll have to patch all our modules that contain host values? -- Emilien Macchi
signature.asc
Description: OpenPGP digital signature
__________________________________________________________________________ OpenStack Development Mailing List (not for usage questions) Unsubscribe: [email protected]?subject:unsubscribe http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
