LGTM On Tue, Nov 29, 2016 at 6:38 PM Weyl, Alexey (Nokia - IL) < [email protected]> wrote:
> Sounds good to me :) > > From: Afek, Ifat (Nokia - IL) [mailto:[email protected]] > Sent: Tuesday, November 29, 2016 11:23 AM > To: OpenStack Development Mailing List (not for usage questions) > Subject: Suspected SPAM - Re: [openstack-dev] Suspected SPAM - [vitrage] > datasources terminology > > Hi, > > A new suggestion: > > • event_type: the type of event/notification that comes from the > datasource. For example: ‘compute.instance.delete.end’, > ‘volume.detach.start’ > • graph_action: used to tell the evaluator what to do with the entity - > create, update or delete it. > • datasource_action: the type of action that was performed by the driver: > init_snapshot, snapshot or update. > > What do you think? > Ifat. > > > From: "Afek, Ifat (Nokia - IL)" > Reply-To: "OpenStack Development Mailing List (not for usage questions)" > Date: Tuesday, 29 November 2016 at 09:26 > To: "OpenStack Development Mailing List (not for usage questions)" > Subject: Suspected SPAM - [openstack-dev] [vitrage] datasources terminology > > Hi, > > I think we have a confusing terminology in Vitrage datasources. > > The following parameters are used in the drivers and transformers: > • event_type: the type of event/notification that comes from the > datasource. For example: ‘compute.instance.delete.end’, > ‘volume.detach.start’ > • event_action: used to tell the evaluator what to do with the entity - > create, update or delete it. > • action_type: the type of action that was performed by the driver: > init_snapshot, snapshot or update. > > Personally I find these names very confusing. > My suggestion is to rename action_type to datasource_mode, or something > similar. > > Your thoughts? > > Thanks, > Ifat. > > __________________________________________________________________________ > OpenStack Development Mailing List (not for usage questions) > Unsubscribe: [email protected]?subject:unsubscribe > http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev >
__________________________________________________________________________ OpenStack Development Mailing List (not for usage questions) Unsubscribe: [email protected]?subject:unsubscribe http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
