To clarify point #2: always check the logs to see the cause of the failure. If it's due to a bug in the submitted code, fix and resubmit. If it's caused by something else, check if it's an open bug, and if not open a new bug report - in either case, do "recheck bug #####". If it's really not caused by any bug, do "recheck no bug".
Thanks, Avishay From: Eugene Nikanorov <[email protected]> To: OpenStack Development Mailing List <[email protected]>, Date: 10/23/2013 12:07 PM Subject: Re: [openstack-dev] Testing before sending for review Hi, 1. It's not necessary to abandon your patch if it has failed jenkins tests. 2. Before submitting the new patch for review it's better to run unit tests (tox -epy27) and pep8 check (tox -epep8) Integration testing is being done by check-tempest-devstack-vm-neutron* suites and some of them fail from time to time due to other known bugs. In case of such failure just put 'recheck no bug' in general review comment, (or 'recheck bug xxxxxx' if you know which bug you are hitting). Sometimes integration test failures are caused by the patch itself, in this case you need to analyze the logs and fix the code. But I believe it's not your case. Thanks, Eugene. On Wed, Oct 23, 2013 at 9:38 AM, S Sridhar <[email protected]> wrote: Hi All, I posted a review earlier - https://review.openstack.org/#/c/53160/, which failed Jenkins test. I realized that changes required in other files too. I 'Abandoned Changes' so that I can post review set again. I have made the changes now, but want to test them before sending for review. It is suggested in https://wiki.openstack.org/wiki/GerritWorkflow to run 'tox' before checking in. Is this enough or there are any other steps I need to follow for unit testing? Please suggest. Regards Sridhar _______________________________________________ OpenStack-dev mailing list [email protected] http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev _______________________________________________ OpenStack-dev mailing list [email protected] http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev _______________________________________________ OpenStack-dev mailing list [email protected] http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
