Hello community, here is the log from the commit of package telepathy-gabble for openSUSE:11.4 checked in at Mon Feb 21 23:32:22 CET 2011.
-------- --- old-versions/11.4/all/telepathy-gabble/telepathy-gabble.changes 2010-11-18 10:42:57.000000000 +0100 +++ 11.4/telepathy-gabble/telepathy-gabble.changes 2011-02-21 16:20:31.000000000 +0100 @@ -1,0 +2,7 @@ +Mon Feb 21 16:14:51 CET 2011 - [email protected] + +- Add telepathy-gabble-CVE-2011-1000.patch: this fixes insufficient + input validation, that could be exploited. Fix CVE-2011-1000 and + bnc#673257. + +------------------------------------------------------------------- calling whatdependson for 11.4-i586 New: ---- telepathy-gabble-CVE-2011-1000.patch ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Other differences: ------------------ ++++++ telepathy-gabble.spec ++++++ --- /var/tmp/diff_new_pack.gTXdkb/_old 2011-02-21 23:31:50.000000000 +0100 +++ /var/tmp/diff_new_pack.gTXdkb/_new 2011-02-21 23:31:50.000000000 +0100 @@ -1,7 +1,7 @@ # -# spec file for package telepathy-gabble (Version 0.10.4) +# spec file for package telepathy-gabble # -# Copyright (c) 2010 SUSE LINUX Products GmbH, Nuernberg, Germany. +# Copyright (c) 2011 SUSE LINUX Products GmbH, Nuernberg, Germany. # # All modifications and additions to the file contributed by third parties # remain the property of their copyright owners, unless otherwise agreed @@ -19,12 +19,14 @@ Name: telepathy-gabble Version: 0.10.4 -Release: 1 +Release: 3.<RELEASE2> License: LGPLv2.1+ Summary: XMPP connection manager for Telepathy Url: http://telepathy.freedesktop.org/wiki/ Group: Productivity/Networking/Instant Messenger Source: %{name}-%{version}.tar.bz2 +# PATCH-FIX-UPSTREAM telepathy-gabble-CVE-2011-1000.patch CVE-2011-1000 bnc#673257 fdo#34048 [email protected] -- insufficient input validation, taken from upstream +Patch0: telepathy-gabble-CVE-2011-1000.patch BuildRequires: dbus-1-glib-devel BuildRequires: libgnutls-devel BuildRequires: libnice-devel @@ -58,6 +60,7 @@ %prep %setup -q +%patch0 -p1 %build %configure \ ++++++ telepathy-gabble-CVE-2011-1000.patch ++++++ >From 5ab349b6837389d21a2664a71db464d1b9c6644c Mon Sep 17 00:00:00 2001 From: Will Thompson <[email protected]> Date: Tue, 8 Feb 2011 18:43:21 +0000 Subject: [PATCH] Ignore google:jingleinfo pushes from contacts. Previously, Gabble would erroneously process google:jingleinfo updates sent by anybody, rather than only paying attention to those sent by the user's server. This may theoretically allow an attacker to trick Gabble into relaying streamed media through a server of the attacker's choosing, enabling them to intercept, obstruct or modify the user's audio and video calls. This patch addresses this flaw, following the same pattern as the corresponding check in the roster code. Note that even without this flaw, no security guarantees on media in calls can be provided in the presence of malicious network admins or insecure networks: an attacker who can eavesdrop the network traffic still has the ability to intercept the content of the call, as the media is transmitted unencrypted. --- src/jingle-factory.c | 16 ++++++++++++++++ 1 files changed, 16 insertions(+), 0 deletions(-) diff --git a/src/jingle-factory.c b/src/jingle-factory.c index 4a1cf6c..07d9542 100644 --- a/src/jingle-factory.c +++ b/src/jingle-factory.c @@ -259,6 +259,22 @@ got_jingle_info_stanza (GabbleJingleFactory *fac, GabbleJingleFactoryPrivate *priv = fac->priv; LmMessageSubType sub_type; LmMessageNode *query_node, *node; + const gchar *from = wocky_stanza_get_from (message); + + if (from != NULL) + { + TpBaseConnection *base_conn = TP_BASE_CONNECTION (priv->conn); + TpHandleRepoIface *contact_repo = tp_base_connection_get_handles ( + base_conn, TP_HANDLE_TYPE_CONTACT); + TpHandle sender = tp_handle_lookup (contact_repo, from, NULL, NULL); + + if (sender != base_conn->self_handle) + { + DEBUG ("ignoring jingleinfo from '%s', not ourself nor the server", + from); + return LM_HANDLER_RESULT_ALLOW_MORE_HANDLERS; + } + } query_node = lm_message_node_get_child_with_namespace ( wocky_stanza_get_top_node (message), "query", NS_GOOGLE_JINGLE_INFO); -- 1.7.2.3 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Remember to have fun... -- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
