Hello community, here is the log from the commit of package libmodplug for openSUSE:11.2 checked in at Tue Apr 12 10:32:48 CEST 2011.
-------- --- old-versions/11.2/all/libmodplug/libmodplug.changes 2009-05-06 18:31:17.000000000 +0200 +++ 11.2/libmodplug/libmodplug.changes 2011-04-11 19:26:42.000000000 +0200 @@ -1,0 +2,5 @@ +Mon Apr 11 19:23:46 CEST 2011 - [email protected] + +- Fixed S3M stack overflow (bnc#686624). + +------------------------------------------------------------------- Package does not exist at destination yet. Using Fallback old-versions/11.2/all/libmodplug Destination is old-versions/11.2/UPDATES/all/libmodplug calling whatdependson for 11.2-i586 New: ---- libmodplug-s3m-stack-overflow.patch ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Other differences: ------------------ ++++++ libmodplug.spec ++++++ --- /var/tmp/diff_new_pack.AVYqSN/_old 2011-04-12 10:32:28.000000000 +0200 +++ /var/tmp/diff_new_pack.AVYqSN/_new 2011-04-12 10:32:28.000000000 +0200 @@ -1,7 +1,7 @@ # -# spec file for package libmodplug (Version 0.8.7) +# spec file for package libmodplug # -# Copyright (c) 2009 SUSE LINUX Products GmbH, Nuernberg, Germany. +# Copyright (c) 2011 SUSE LINUX Products GmbH, Nuernberg, Germany. # # All modifications and additions to the file contributed by third parties # remain the property of their copyright owners, unless otherwise agreed @@ -20,13 +20,15 @@ Name: libmodplug Summary: MOD-Playing Sound Library Version: 0.8.7 -Release: 1 +Release: 11.<RELEASE2> Group: System/Libraries License: Public Domain, Freeware Url: http://modplug-xmms.sourceforge.net/ Source: %{name}-%{version}.tar.bz2 # PATCH-FIX-OPENSUSE libmodplug-timidity.patch -- set paths to openSUSE timidity package Patch1: libmodplug-timidity.patch +# PATCH-FIX-SECURITY libmodplug-s3m-stack-overflow.patch bnc686624 [email protected] -- Fix stack overflow fulnerability in S3M decoder. https://www.sec-consult.com/files/20110407-0_libmodplug_stackoverflow.txt +Patch2: libmodplug-s3m-stack-overflow.patch BuildRequires: gcc-c++ BuildRoot: %{_tmppath}/%{name}-%{version}-build @@ -131,6 +133,7 @@ %prep %setup -q %patch1 +%patch2 -p1 %build autoreconf -f -i ++++++ libmodplug-s3m-stack-overflow.patch ++++++ diff -ur libmodplug-0.8.8.1/src/load_s3m.cpp libmodplug-0.8.8.2/src/load_s3m.cpp --- libmodplug-0.8.8.1/src/load_s3m.cpp 2010-04-04 14:15:24.000000000 +0200 +++ libmodplug-0.8.8.2/src/load_s3m.cpp 2011-03-25 23:17:18.000000000 +0100 @@ -257,6 +257,10 @@ patnum = npat = psfh.patnum; if (patnum > MAX_PATTERNS) patnum = MAX_PATTERNS; memset(ptr, 0, sizeof(ptr)); + + // Ignore file if it has a corrupted header. + if (nins+npat > 256) return FALSE; + if (nins+npat) { memcpy(ptr, lpStream+dwMemPos, 2*(nins+npat)); ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Remember to have fun... -- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
