Hello community, here is the log from the commit of package rpmlint for openSUSE:Factory checked in at Tue Apr 26 16:54:21 CEST 2011.
-------- --- rpmlint/rpmlint.changes 2011-04-21 15:01:05.000000000 +0200 +++ /mounts/work_src_done/STABLE/rpmlint/rpmlint.changes 2011-04-23 11:26:24.000000000 +0200 @@ -1,0 +2,6 @@ +Sat Apr 23 11:11:37 CEST 2011 - [email protected] + +- fix abort in BinariesCheck +- fix sysv5-init-check.diff for real + +------------------------------------------------------------------- calling whatdependson for head-i586 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Other differences: ------------------ ++++++ rpmlint.spec ++++++ --- /var/tmp/diff_new_pack.yvc8kJ/_old 2011-04-26 16:53:39.000000000 +0200 +++ /var/tmp/diff_new_pack.yvc8kJ/_new 2011-04-26 16:53:39.000000000 +0200 @@ -23,7 +23,7 @@ BuildRequires: rpm-python Summary: Rpm correctness checker Version: 1.1 -Release: 27 +Release: 29 Source0: %{name}-%{version}.tar.bz2 Source1: config Source1001: config.in ++++++ suse-binarieschecks.diff ++++++ --- /var/tmp/diff_new_pack.yvc8kJ/_old 2011-04-26 16:53:39.000000000 +0200 +++ /var/tmp/diff_new_pack.yvc8kJ/_new 2011-04-26 16:53:39.000000000 +0200 @@ -1,8 +1,6 @@ -Index: BinariesCheck.py -=================================================================== ---- BinariesCheck.py.orig +--- BinariesCheck.py +++ BinariesCheck.py -@@ -10,6 +10,7 @@ +@@ -10,13 +10,15 @@ import re import stat @@ -10,7 +8,8 @@ import rpm -@@ -17,6 +18,7 @@ from Filter import addDetails, printErro +-from Filter import addDetails, printError, printWarning ++from Filter import addDetails, printError, printWarning, printInfo import AbstractCheck import Config import Pkg @@ -18,7 +17,7 @@ DEFAULT_SYSTEM_LIB_PATHS = ( -@@ -37,6 +39,9 @@ class BinaryInfo: +@@ -37,6 +39,9 @@ unused_regex = re.compile('^\s+(\S+)') exit_call_regex = re.compile('\s+FUNC\s+.*?\s+(_?exit(?:@\S+)?)(?:\s|$)') fork_call_regex = re.compile('\s+FUNC\s+.*?\s+(fork(?:@\S+)?)(?:\s|$)') @@ -28,7 +27,7 @@ def __init__(self, pkg, path, file, is_ar, is_shlib): self.readelf_error = False -@@ -50,7 +55,10 @@ class BinaryInfo: +@@ -50,7 +55,10 @@ self.stack = False self.exec_stack = False self.exit_calls = [] @@ -39,7 +38,7 @@ self.tail = '' is_debug = path.endswith('.debug') -@@ -93,6 +101,11 @@ class BinaryInfo: +@@ -93,6 +101,11 @@ self.exec_stack = True continue @@ -51,7 +50,7 @@ if is_shlib: r = BinaryInfo.exit_call_regex.search(l) if r: -@@ -103,6 +116,14 @@ class BinaryInfo: +@@ -103,6 +116,14 @@ fork_called = True continue @@ -66,7 +65,7 @@ if self.non_pic: self.non_pic = 'TEXTREL' in res[1] -@@ -263,13 +284,26 @@ class BinariesCheck(AbstractCheck.Abstra +@@ -263,13 +284,26 @@ continue # stripped ? @@ -94,7 +93,7 @@ if is_shlib: has_lib = True -@@ -319,6 +353,10 @@ class BinariesCheck(AbstractCheck.Abstra +@@ -319,6 +353,10 @@ for ec in bin_info.exit_calls: printWarning(pkg, 'shared-lib-calls-exit', fname, ec) @@ -105,7 +104,7 @@ # rpath ? if bin_info.rpath: for p in bin_info.rpath: -@@ -504,6 +542,14 @@ with the intended shared libraries only. +@@ -504,6 +542,14 @@ 'ldd-failed', '''Executing ldd on this file failed, all checks could not be run.''', @@ -120,7 +119,7 @@ 'executable-stack', '''The binary declares the stack as executable. Executable stack is usually an error as it is only needed if the code contains GCC trampolines or similar -@@ -516,6 +562,10 @@ don\'t define a proper .note.GNU-stack s +@@ -516,6 +562,10 @@ make the stack executable. Usual suspects include use of a non-GNU linker or an old GNU linker version.''', @@ -131,7 +130,7 @@ 'shared-lib-calls-exit', '''This library package calls exit() or _exit(), probably in a non-fork() context. Doing so from a library is strongly discouraged - when a library -@@ -533,6 +583,12 @@ form, make sure that rpmbuild does not s +@@ -533,6 +583,12 @@ that use prelink, make sure that prelink does not strip it either, usually by placing a blacklist file in /etc/prelink.conf.d. For more information, see http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=256900#49''', ++++++ sysv5-init-checks.diff ++++++ --- /var/tmp/diff_new_pack.yvc8kJ/_old 2011-04-26 16:53:39.000000000 +0200 +++ /var/tmp/diff_new_pack.yvc8kJ/_new 2011-04-26 16:53:39.000000000 +0200 @@ -1,8 +1,6 @@ -Index: InitScriptCheck.py -=================================================================== ---- InitScriptCheck.py.orig +--- InitScriptCheck.py +++ InitScriptCheck.py -@@ -29,6 +29,10 @@ dot_in_name_regex = re.compile('.*\..*') +@@ -29,6 +29,10 @@ use_deflevels = Config.getOption('UseDefaultRunlevels', True) lsb_tags_regex = re.compile('^# ([\w-]+):\s*(.*?)\s*$') lsb_cont_regex = re.compile('^#(?:\t| )(.*?)\s*$') @@ -13,7 +11,7 @@ LSB_KEYWORDS = ('Provides', 'Required-Start', 'Required-Stop', 'Should-Start', 'Should-Stop', 'Default-Start', 'Default-Stop', -@@ -47,6 +51,13 @@ class InitScriptCheck(AbstractCheck.Abst +@@ -47,6 +51,13 @@ return initscript_list = [] @@ -27,7 +25,7 @@ for fname, pkgfile in pkg.files().items(): if not fname.startswith('/etc/init.d/') and \ -@@ -60,18 +71,19 @@ class InitScriptCheck(AbstractCheck.Abst +@@ -60,18 +71,19 @@ if dot_in_name_regex.match(basename): printError(pkg, 'init-script-name-with-dot', fname) @@ -44,7 +42,7 @@ - elif not chkconfig_regex.search(preun): - printError(pkg, 'preun-without-chkconfig', fname) + printError(pkg, 'init-script-without-%stop_on_removal-preun', fname) -+ elif not stop_on_removal_regex.search(postin): ++ elif not stop_on_removal_regex.search(preun): + printError(pkg, 'preun-without-%stop_on_removal-preun', fname) + + if not postun: @@ -57,7 +55,7 @@ status_found = False reload_found = False -@@ -202,10 +214,18 @@ a call to chkconfig.''', +@@ -202,10 +214,18 @@ '''The package contains an init script but doesn't call chkconfig in its %post script.''', @@ -77,7 +75,7 @@ 'preun-without-chkconfig', '''The package contains an init script but doesn't call chkconfig in its %preun script.''', -@@ -264,6 +284,24 @@ of chkconfig don't work as expected with +@@ -264,6 +284,24 @@ 'init-script-non-executable', '''The init script should have at least the execution bit set for root in order for it to run at boot time.''', ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Remember to have fun... -- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
