Hello community, here is the log from the commit of package ypserv for openSUSE:Factory checked in at Thu Aug 25 10:47:44 CEST 2011.
-------- --- ypserv/ypserv.changes 2010-09-24 12:39:25.000000000 +0200 +++ /mounts/work_src_done/STABLE/ypserv/ypserv.changes 2011-05-02 17:33:41.000000000 +0200 @@ -1,0 +2,6 @@ +Mon May 2 17:32:57 CEST 2011 - [email protected] + +- Update to version 2.25 + - Fix small issues found by tool analysis + +------------------------------------------------------------------- calling whatdependson for head-i586 Old: ---- ypserv-2.24.diff ypserv-2.24.tar.bz2 New: ---- ypserv-2.25.diff ypserv-2.25.tar.bz2 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Other differences: ------------------ ++++++ ypserv.spec ++++++ --- /var/tmp/diff_new_pack.FkO8F1/_old 2011-08-25 10:46:41.000000000 +0200 +++ /var/tmp/diff_new_pack.FkO8F1/_new 2011-08-25 10:46:41.000000000 +0200 @@ -1,7 +1,7 @@ # -# spec file for package ypserv (Version 2.24) +# spec file for package ypserv # -# Copyright (c) 2010 SUSE LINUX Products GmbH, Nuernberg, Germany. +# Copyright (c) 2011 SUSE LINUX Products GmbH, Nuernberg, Germany. # # All modifications and additions to the file contributed by third parties # remain the property of their copyright owners, unless otherwise agreed @@ -25,7 +25,7 @@ Requires: make portmap gawk AutoReqProv: on BuildRoot: %{_tmppath}/%{name}-%{version}-build -Version: 2.24 +Version: 2.25 Release: 1 Summary: YP - (NIS)-Server PreReq: %insserv_prereq %fillup_prereq ++++++ ypserv-2.24.diff -> ypserv-2.25.diff ++++++ ++++++ ypserv-2.24.tar.bz2 -> ypserv-2.25.tar.bz2 ++++++ diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/ypserv-2.24/ChangeLog new/ypserv-2.25/ChangeLog --- old/ypserv-2.24/ChangeLog 2010-09-24 11:45:36.000000000 +0200 +++ new/ypserv-2.25/ChangeLog 2011-04-29 16:35:58.000000000 +0200 @@ -1,3 +1,22 @@ +2011-04-29 Thorsten Kukuk <[email protected]> + + * yphelper/yphelper.c (is_master): Fix memory leak. + * rpc.yppasswdd/yppasswdd.c (main): Check if we could open + /dev/null. + * ypserv/ypserv.c (main): Likewise. + * rpc.yppasswdd/update.c (update_files): Close all files. + * revnetgroup/getnetgrent.c: Return if malloc fails. + * makedbm/makedbm.c (create_file): Close file if not stdin. + * lib/yp_db.c (_db_open): Document not implemented cache size. + * lib/pidfile.c (create_pidfile): Exit if we cannot create + pid file. + Based on patches from Honza Horak <[email protected]>. + +2010-10-29 Thorsten Kukuk <[email protected]> + + * rpc.yppasswdd/update.c (remove_password): Remove password + for logging. + 2010-09-24 Thorsten Kukuk <[email protected]> * release version 2.24 diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/ypserv-2.24/NEWS new/ypserv-2.25/NEWS --- old/ypserv-2.24/NEWS 2010-09-24 11:47:46.000000000 +0200 +++ new/ypserv-2.25/NEWS 2011-04-29 15:51:40.000000000 +0200 @@ -5,6 +5,9 @@ Please send bug reports, questions and suggestions to <[email protected]>. +Version 2.25 +* Lot of small bug fixes/improved error handling + Version 2.24 * rpc.yppasswdd: Fix -x option diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/ypserv-2.24/configure new/ypserv-2.25/configure --- old/ypserv-2.24/configure 2010-09-24 11:58:44.000000000 +0200 +++ new/ypserv-2.25/configure 2011-04-29 16:36:22.000000000 +0200 @@ -1,6 +1,6 @@ #! /bin/sh # Guess values for system-dependent variables and create Makefiles. -# Generated by GNU Autoconf 2.63 for ypserv 2.24. +# Generated by GNU Autoconf 2.63 for ypserv 2.25. # # Report bugs to <[email protected]>. # @@ -596,8 +596,8 @@ # Identity of this package. PACKAGE_NAME='ypserv' PACKAGE_TARNAME='ypserv' -PACKAGE_VERSION='2.24' -PACKAGE_STRING='ypserv 2.24' +PACKAGE_VERSION='2.25' +PACKAGE_STRING='ypserv 2.25' PACKAGE_BUGREPORT='[email protected]' ac_unique_file="ypserv/ypserv.c" @@ -1315,7 +1315,7 @@ # Omit some internal or obsolete options to make the list less imposing. # This message is too long to be a string in the A/UX 3.1 sh. cat <<_ACEOF -\`configure' configures ypserv 2.24 to adapt to many kinds of systems. +\`configure' configures ypserv 2.25 to adapt to many kinds of systems. Usage: $0 [OPTION]... [VAR=VALUE]... @@ -1381,7 +1381,7 @@ if test -n "$ac_init_help"; then case $ac_init_help in - short | recursive ) echo "Configuration of ypserv 2.24:";; + short | recursive ) echo "Configuration of ypserv 2.25:";; esac cat <<\_ACEOF @@ -1481,7 +1481,7 @@ test -n "$ac_init_help" && exit $ac_status if $ac_init_version; then cat <<\_ACEOF -ypserv configure 2.24 +ypserv configure 2.25 generated by GNU Autoconf 2.63 Copyright (C) 1992, 1993, 1994, 1995, 1996, 1998, 1999, 2000, 2001, @@ -1495,7 +1495,7 @@ This file contains any messages produced by compilers while running configure, to aid debugging if configure makes a mistake. -It was created by ypserv $as_me 2.24, which was +It was created by ypserv $as_me 2.25, which was generated by GNU Autoconf 2.63. Invocation command line was $ $0 $@ @@ -2211,7 +2211,7 @@ # Define the identity of the package. PACKAGE='ypserv' - VERSION='2.24' + VERSION='2.25' cat >>confdefs.h <<_ACEOF @@ -10931,7 +10931,7 @@ # report actual input values of CONFIG_FILES etc. instead of their # values after options handling. ac_log=" -This file was extended by ypserv $as_me 2.24, which was +This file was extended by ypserv $as_me 2.25, which was generated by GNU Autoconf 2.63. Invocation command line was CONFIG_FILES = $CONFIG_FILES @@ -10994,7 +10994,7 @@ _ACEOF cat >>$CONFIG_STATUS <<_ACEOF || ac_write_fail=1 ac_cs_version="\\ -ypserv config.status 2.24 +ypserv config.status 2.25 configured by $0, generated by GNU Autoconf 2.63, with options \\"`$as_echo "$ac_configure_args" | sed 's/^ //; s/[\\""\`\$]/\\\\&/g'`\\" diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/ypserv-2.24/configure.in new/ypserv-2.25/configure.in --- old/ypserv-2.24/configure.in 2010-09-24 11:58:26.000000000 +0200 +++ new/ypserv-2.25/configure.in 2011-04-29 15:51:20.000000000 +0200 @@ -2,7 +2,7 @@ # Copyright (C) 1999-2009 Thorsten Kukuk <[email protected]> # dnl Process this file with autoconf to produce a configure script. -AC_INIT(ypserv, 2.24, [email protected]) +AC_INIT(ypserv, 2.25, [email protected]) AM_INIT_AUTOMAKE AC_CONFIG_SRCDIR([ypserv/ypserv.c]) AM_CONFIG_HEADER(config.h) diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/ypserv-2.24/lib/pidfile.c new/ypserv-2.25/lib/pidfile.c --- old/ypserv-2.24/lib/pidfile.c 2010-02-23 14:44:55.000000000 +0100 +++ new/ypserv-2.25/lib/pidfile.c 2011-04-15 16:49:41.000000000 +0200 @@ -1,4 +1,4 @@ -/* Copyright (c) 2009 Thorsten Kukuk +/* Copyright (c) 2009, 2011 Thorsten Kukuk Author: Thorsten Kukuk <[email protected]> The YP Server is free software; you can redistribute it and/or @@ -40,6 +40,7 @@ log_msg ("cannot create pidfile %s", filename); if (debug_flag) log_msg ("\n"); + exit (1); } lock.l_type = F_WRLCK; @@ -53,6 +54,7 @@ log_msg ("fcntl error"); if (debug_flag) log_msg ("\n"); + exit (1); } if (lock.l_type == F_UNLCK) pid = 0; /* false, region is not locked by another proc */ diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/ypserv-2.24/lib/yp_db.c new/ypserv-2.25/lib/yp_db.c --- old/ypserv-2.24/lib/yp_db.c 2009-04-02 13:35:16.000000000 +0200 +++ new/ypserv-2.25/lib/yp_db.c 2011-04-15 17:00:47.000000000 +0200 @@ -1,4 +1,4 @@ -/* Copyright (c) 2000, 2001, 2002, 2003, 2004, 2009 Thorsten Kukuk +/* Copyright (c) 2000, 2001, 2002, 2003, 2004, 2009, 2011 Thorsten Kukuk Author: Thorsten Kukuk <[email protected]> The YP Server is free software; you can redistribute it and/or @@ -56,6 +56,7 @@ dbp = gdbm_open (buf, 0, GDBM_READER, 0, NULL); + /* XXX dead code, gdbm_cache_value isn't implemented yet */ if (dbp && gdbm_cache_value >= 0) gdbm_setopt(dbp, GDBM_CACHESIZE, &gdbm_cache_value, sizeof(int)); diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/ypserv-2.24/lib/ypserv_conf.c new/ypserv-2.25/lib/ypserv_conf.c --- old/ypserv-2.24/lib/ypserv_conf.c 2008-04-15 15:04:47.000000000 +0200 +++ new/ypserv-2.25/lib/ypserv_conf.c 2011-04-15 17:03:15.000000000 +0200 @@ -1,4 +1,4 @@ -/* Copyright (c) 1996, 1997, 1998, 1999, 2000, 2001, 2003, 2004, 2006, 2008 Thorsten Kukuk +/* Copyright (c) 1996, 1997, 1998, 1999, 2000, 2001, 2003, 2004, 2006, 2008, 2011 Thorsten Kukuk Author: Thorsten Kukuk <[email protected]> The YP Server is free software; you can redistribute it and/or @@ -64,7 +64,7 @@ m = strtok (n, "/"); - sscanf (m, "%s", buf); + sscanf (m, "%19s", buf); for (i = 0; i < strlen (buf); i++) if ((buf[i] < '0' || buf[i] > '9') && buf[i] != '.') @@ -172,7 +172,7 @@ { FILE *in; char c, *cp; - char buf1[1025], buf2[1025], buf3[1025]; + char buf1[1025], buf2[1025] = "", buf3[1025]; long line = 0; conffile_t *ptr = NULL, *work = NULL; char *filename = alloca (strlen (path) + sizeof ("/ypserv.conf") + 1); diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/ypserv-2.24/makedbm/makedbm.c new/ypserv-2.25/makedbm/makedbm.c --- old/ypserv-2.24/makedbm/makedbm.c 2006-01-10 20:22:20.000000000 +0100 +++ new/ypserv-2.25/makedbm/makedbm.c 2011-04-15 17:05:31.000000000 +0200 @@ -1,4 +1,4 @@ -/* Copyright (c) 1996,1997, 1998, 1999, 2000, 2002, 2003, 2005, 2006 Thorsten Kukuk +/* Copyright (c) 1996-2006, 2011 Thorsten Kukuk Author: Thorsten Kukuk <[email protected]> The YP Server is free software; you can redistribute it and/or @@ -458,6 +458,9 @@ rename (filename, dbmName); #endif free (filename); + + if (strcmp (fileName, "-") != 0) + fclose (input); } static void diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/ypserv-2.24/revnetgroup/getnetgrent.c new/ypserv-2.25/revnetgroup/getnetgrent.c --- old/ypserv-2.24/revnetgroup/getnetgrent.c 2005-05-31 15:36:47.000000000 +0200 +++ new/ypserv-2.25/revnetgroup/getnetgrent.c 2011-04-15 17:08:24.000000000 +0200 @@ -243,6 +243,8 @@ list->list = malloc (10 * sizeof (struct netgrentry)); if (NULL != list->list) list->maxmembers = 10; + else + return; } if (list->members == list->maxmembers) diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/ypserv-2.24/rpc.yppasswdd/update.c new/ypserv-2.25/rpc.yppasswdd/update.c --- old/ypserv-2.24/rpc.yppasswdd/update.c 2010-09-24 11:44:20.000000000 +0200 +++ new/ypserv-2.25/rpc.yppasswdd/update.c 2011-04-15 17:11:22.000000000 +0200 @@ -1,4 +1,4 @@ -/* Copyright (c) 1999, 2000, 2001, 2005, 2006, 2010 Thorsten Kukuk +/* Copyright (c) 1999, 2000, 2001, 2005, 2006, 2010, 2011 Thorsten Kukuk Author: Thorsten Kukuk <[email protected]> The YP Server is free software; you can redistribute it and/or @@ -433,6 +433,7 @@ log_msg ("%s failed", logbuf); log_msg ("Can't stat %s: %m", path_shadow); fclose (oldpf); + fclose (newpf); fclose (oldsf); return 1; } @@ -741,6 +742,29 @@ * *===============================================================*/ +static char * +remove_password (char *str) +{ + char *ptr = strstr (str, " o:"); + + if (ptr != NULL) + { + ptr+=3; + while (*ptr && *ptr != ' ') + *ptr++ = 'X'; + } + + ptr = strstr (str, " p:"); + if (ptr != NULL) + { + ptr+=3; + while (*ptr && *ptr != ' ') + *ptr++ = 'X'; + } + + return ptr; +} + static int external_update_pipe (yppasswd *yppw, char *logbuf) { @@ -915,6 +939,9 @@ } fclose(fp); + if (!debug_flag) + parentmsg = remove_password (parentmsg); + if (strspn(childresponse, "OK") < 2) { log_msg ("%s failed. Change request: %s", logbuf, parentmsg); diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/ypserv-2.24/rpc.yppasswdd/yppasswdd.c new/ypserv-2.25/rpc.yppasswdd/yppasswdd.c --- old/ypserv-2.24/rpc.yppasswdd/yppasswdd.c 2010-02-23 14:48:11.000000000 +0100 +++ new/ypserv-2.25/rpc.yppasswdd/yppasswdd.c 2011-04-29 15:33:19.000000000 +0200 @@ -1,5 +1,5 @@ /* - Copyright (c) 1996-2006, 2010 Thorsten Kukuk, <[email protected]> + Copyright (c) 1996-2006, 2010, 2011 Thorsten Kukuk, <[email protected]> Copyright (c) 1994, 1995, 1996 Olaf Kirch, <[email protected]> This file is part of the NYS YP Server. @@ -372,12 +372,22 @@ } umask(0); i = open("/dev/null", O_RDWR); + if (i == -1) + { + int err = errno; + log_msg ("rpc.yppasswdd: open /dev/null failed: %s\n", + strerror (err)); + exit (err); + } + + /* two dups, we have stdin, stdout, stderr */ if (dup(i) == -1) { int err = errno; log_msg ("rpc.yppasswdd: dup failed: %s\n", strerror (err)); exit (err); } + if (dup(i) == -1) { int err = errno; diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/ypserv-2.24/yphelper/yphelper.c new/ypserv-2.25/yphelper/yphelper.c --- old/ypserv-2.24/yphelper/yphelper.c 2005-05-31 11:14:40.000000000 +0200 +++ new/ypserv-2.25/yphelper/yphelper.c 2011-04-29 15:36:00.000000000 +0200 @@ -1,4 +1,4 @@ -/* Copyright (c) 1999, 2001, 2002 Thorsten Kukuk +/* Copyright (c) 1999, 2001, 2002, 2011 Thorsten Kukuk Author: Thorsten Kukuk <[email protected]> The YP Server is free software; you can redistribute it and/or @@ -539,7 +539,7 @@ #if USE_FQDN struct hostent *hp = NULL; #endif - char *hostname, *domainname; + char *hostname, *domainname, *val; int ret; if (domain != NULL) @@ -580,7 +580,7 @@ #endif if (strcasecmp (hostname, - get_dbm_entry ("YP_MASTER_NAME", map, domainname)) == 0) + (val = get_dbm_entry ("YP_MASTER_NAME", map, domainname))) == 0) ret = 0; else ret = 1; diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/ypserv-2.24/ypserv/ypserv.c new/ypserv-2.25/ypserv/ypserv.c --- old/ypserv-2.24/ypserv/ypserv.c 2010-02-23 14:48:22.000000000 +0100 +++ new/ypserv-2.25/ypserv/ypserv.c 2011-04-29 15:37:21.000000000 +0200 @@ -1,4 +1,4 @@ -/* Copyright (c) 1996-2010 Thorsten Kukuk +/* Copyright (c) 1996-2011 Thorsten Kukuk Author: Thorsten Kukuk <[email protected]> The YP Server is free software; you can redistribute it and/or @@ -411,6 +411,12 @@ umask (0); i = open ("/dev/null", O_RDWR); + if (i == -1) + { + log_msg ("opening /dev/null failed: %s\n", strerror (errno)); + exit (1); + } + /* two dups: stdin, stdout, stderr */ if (dup (i) == -1) { log_msg ("dup failed: %s\n", strerror (errno)); diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/ypserv-2.24/ypxfr/ypxfr.c new/ypserv-2.25/ypxfr/ypxfr.c --- old/ypserv-2.24/ypxfr/ypxfr.c 2005-09-02 16:22:11.000000000 +0200 +++ new/ypserv-2.25/ypxfr/ypxfr.c 2011-04-29 15:46:48.000000000 +0200 @@ -1,4 +1,4 @@ -/* Copyright (c) 2000, 2001, 2002, 2003, 2004, 2005 Thorsten Kukuk +/* Copyright (c) 2000-2005, 2011 Thorsten Kukuk Author: Thorsten Kukuk <[email protected]> The YP Server is free software; you can redistribute it and/or @@ -836,7 +836,11 @@ if (target_domain == NULL) { - yp_get_default_domain (&target_domain); + if (yp_get_default_domain (&target_domain) != 0) + { + log_msg ("Cannot get default domain"); + exit (1); + } if (target_domain == NULL) { ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Remember to have fun... -- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
