Hello community, here is the log from the commit of package system-config-printer for openSUSE:11.4 checked in at Tue Jan 3 17:42:20 CET 2012.
-------- --- old-versions/11.4/UPDATES/all/system-config-printer/system-config-printer.changes 2011-12-08 11:05:38.000000000 +0100 +++ 11.4/system-config-printer/system-config-printer.changes 2012-01-03 09:32:06.000000000 +0100 @@ -1,0 +2,6 @@ +Tue Jan 3 08:25:01 UTC 2012 - [email protected] + +- Fix coding errors caught by Stephen Shaw <[email protected]> in + system-config-printer-subprocess-no-shell.patch. + +------------------------------------------------------------------- calling whatdependson for 11.4-i586 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Other differences: ------------------ ++++++ system-config-printer.spec ++++++ --- /var/tmp/diff_new_pack.pKQeoa/_old 2012-01-03 17:42:11.000000000 +0100 +++ /var/tmp/diff_new_pack.pKQeoa/_new 2012-01-03 17:42:11.000000000 +0100 @@ -1,7 +1,7 @@ # # spec file for package system-config-printer # -# Copyright (c) 2011 SUSE LINUX Products GmbH, Nuernberg, Germany. +# Copyright (c) 2012 SUSE LINUX Products GmbH, Nuernberg, Germany. # # All modifications and additions to the file contributed by third parties # remain the property of their copyright owners, unless otherwise agreed @@ -22,7 +22,7 @@ License: GPLv2+ Group: Hardware/Printing Version: 1.2.5 -Release: 5.<RELEASE8> +Release: 5.<RELEASE10> Summary: A printer administration tool Url: http://cyberelk.net/tim/software/system-config-printer/ Source0: http://cyberelk.net/tim/data/system-config-printer/1.0.x/system-config-printer-%{version}.tar.bz2 ++++++ system-config-printer-subprocess-no-shell.patch ++++++ --- /var/tmp/diff_new_pack.pKQeoa/_old 2012-01-03 17:42:11.000000000 +0100 +++ /var/tmp/diff_new_pack.pKQeoa/_new 2012-01-03 17:42:11.000000000 +0100 @@ -23,7 +23,7 @@ + new_environ['LC_ALL'] = "C" + new_environ['DISPLAY'] = "" + args = ["hp-info", "-x", "-i", "-d" + faxuri] -+ debugprint (faxuri + ": " + args) ++ debugprint (faxuri + ": " + str(args)) try: - p = subprocess.Popen (cmd, shell=True, close_fds=True, + p = subprocess.Popen (args, env=new_environ, close_fds=True, @@ -41,7 +41,7 @@ - cmd = 'hp-makeuri ' + mod + ' "${HOST}"' - debugprint (host + ": " + cmd) + args = ["hp-makeuri", mod, host] -+ debugprint (host + ": " + args) ++ debugprint (host + ": " + str(args)) uri = None try: - p = subprocess.Popen (cmd, shell=True, close_fds=True, @@ -57,7 +57,7 @@ - cmd = '/usr/lib/cups/backend/snmp "${HOST}"' - debugprint (host + ": " + cmd) + args = ["/usr/lib/cups/backend/snmp", host] -+ debugprint (host + ": " + args) ++ debugprint (host + ": " + str(args)) stdout = None try: - p = subprocess.Popen (cmd, shell=True, close_fds=True, @@ -104,7 +104,7 @@ p = TimedSubprocess (parent=parent, timeout=3000, - args='LC_ALL=C DISPLAY= hp-info -d"$URI"', -+ args=["hp-info", "-d" + uri, ++ args=["hp-info", "-d" + uri], close_fds=True, - shell=True, + env=new_environ, continue with "q"... Remember to have fun... -- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
