Hello community, here is the log from the commit of package perl-Test-Fatal for openSUSE:Factory checked in at 2012-02-20 16:16:36 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Comparing /work/SRC/openSUSE:Factory/perl-Test-Fatal (Old) and /work/SRC/openSUSE:Factory/.perl-Test-Fatal.new (New) ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Package is "perl-Test-Fatal", Maintainer is "" Changes: -------- --- /work/SRC/openSUSE:Factory/perl-Test-Fatal/perl-Test-Fatal.changes 2011-11-18 15:48:01.000000000 +0100 +++ /work/SRC/openSUSE:Factory/.perl-Test-Fatal.new/perl-Test-Fatal.changes 2012-02-20 16:16:39.000000000 +0100 @@ -1,0 +2,8 @@ +Mon Feb 20 08:38:05 UTC 2012 - [email protected] + +- updated to 0.010 + avoid tickling an overloading bug in perl 5.6 during testing (thanks, + Zefram) + advise against using isnt(exception{...},undef) + +------------------------------------------------------------------- Old: ---- Test-Fatal-0.008.tar.gz New: ---- Test-Fatal-0.010.tar.gz ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Other differences: ------------------ ++++++ perl-Test-Fatal.spec ++++++ --- /var/tmp/diff_new_pack.suA4NE/_old 2012-02-20 16:16:40.000000000 +0100 +++ /var/tmp/diff_new_pack.suA4NE/_new 2012-02-20 16:16:40.000000000 +0100 @@ -1,7 +1,7 @@ # # spec file for package perl-Test-Fatal # -# Copyright (c) 2011 SUSE LINUX Products GmbH, Nuernberg, Germany. +# Copyright (c) 2012 SUSE LINUX Products GmbH, Nuernberg, Germany. # # All modifications and additions to the file contributed by third parties # remain the property of their copyright owners, unless otherwise agreed @@ -15,43 +15,31 @@ # Please submit bugfixes or comments via http://bugs.opensuse.org/ # -# norootforbuild - Name: perl-Test-Fatal +Version: 0.010 +Release: 0 %define cpan_name Test-Fatal Summary: Incredibly simple helpers for testing code with exceptions -Version: 0.008 -Release: 1 -License: GPL-1.0+ or Artistic-1.0 +License: Artistic-1.0 or GPL-1.0+ Group: Development/Libraries/Perl Url: http://search.cpan.org/dist/Test-Fatal/ -Source: http://search.cpan.org/CPAN/authors/id/R/RJ/RJBS/Test-Fatal-%{version}.tar.gz +Source: http://www.cpan.org/authors/id/R/RJ/RJBS/%{cpan_name}-%{version}.tar.gz BuildArch: noarch BuildRoot: %{_tmppath}/%{name}-%{version}-build -%{perl_requires} BuildRequires: perl BuildRequires: perl-macros -BuildRequires: perl(Test::More) >= 0.96 -# -BuildRequires: perl(Carp) -BuildRequires: perl(Exporter) >= 5.59 -BuildRequires: perl(overload) BuildRequires: perl(Try::Tiny) >= 0.07 -# -Requires: perl(Carp) -Requires: perl(Exporter) >= 5.59 +#BuildRequires: perl(Test::Fatal) Requires: perl(Try::Tiny) >= 0.07 +%{perl_requires} %description -Test::Fatal is an alternative to the popular Test::Exception. It does much -less, but should allow greater flexibility in testing exception-throwing -code with about the same amount of typing. -It exports one routine by default: "exception". - -Authors: --------- - Ricardo Signes <[email protected]> +Test::Fatal is an alternative to the popular the Test::Exception manpage. +It does much less, but should allow greater flexibility in testing +exception-throwing code with about the same amount of typing. + +It exports one routine by default: 'exception'. %prep %setup -q -n %{cpan_name}-%{version} @@ -65,18 +53,11 @@ %install %perl_make_install -# do not perl_process_packlist (noarch) -# remove .packlist file -%{__rm} -rf $RPM_BUILD_ROOT%perl_vendorarch -# remove perllocal.pod file -%{__rm} -rf $RPM_BUILD_ROOT%perl_archlib +%perl_process_packlist %perl_gen_filelist -%clean -%{__rm} -rf $RPM_BUILD_ROOT - %files -f %{name}.files -%defattr(-,root,root,-) +%defattr(-,root,root,755) %doc Changes LICENSE README %changelog ++++++ Test-Fatal-0.008.tar.gz -> Test-Fatal-0.010.tar.gz ++++++ diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/Test-Fatal-0.008/Changes new/Test-Fatal-0.010/Changes --- old/Test-Fatal-0.008/Changes 2011-11-07 03:10:28.000000000 +0100 +++ new/Test-Fatal-0.010/Changes 2012-02-16 16:28:07.000000000 +0100 @@ -1,5 +1,12 @@ Revision history for Test-Fatal +0.010 2012-02-16 10:27:54 America/New_York + avoid tickling an overloading bug in perl 5.6 during testing (thanks, + Zefram) + +0.009 2012-02-09 15:26:11 America/New_York + advise against using isnt(exception{...},undef) + 0.008 2011-11-06 21:10:14 America/New_York no changes since 0.007 diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/Test-Fatal-0.008/META.json new/Test-Fatal-0.010/META.json --- old/Test-Fatal-0.008/META.json 2011-11-07 03:10:28.000000000 +0100 +++ new/Test-Fatal-0.010/META.json 2012-02-16 16:28:07.000000000 +0100 @@ -4,7 +4,7 @@ "Ricardo Signes <[email protected]>" ], "dynamic_config" : 0, - "generated_by" : "Dist::Zilla version 4.300003, CPAN::Meta::Converter version 2.112621", + "generated_by" : "Dist::Zilla version 4.300007, CPAN::Meta::Converter version 2.120351", "license" : [ "perl_5" ], @@ -21,19 +21,19 @@ }, "runtime" : { "requires" : { - "Carp" : 0, + "Carp" : "0", "Exporter" : "5.57", - "Test::Builder" : 0, + "Test::Builder" : "0", "Try::Tiny" : "0.07", - "strict" : 0, - "warnings" : 0 + "strict" : "0", + "warnings" : "0" } }, "test" : { "requires" : { - "Test::Builder::Tester" : 0, + "Test::Builder::Tester" : "0", "Test::More" : "0.47", - "overload" : 0 + "overload" : "0" } } }, @@ -46,118 +46,118 @@ "web" : "https://github.com/rjbs/test-fatal" } }, - "version" : "0.008", + "version" : "0.010", "x_Dist_Zilla" : { "plugins" : [ { "class" : "Dist::Zilla::Plugin::CheckPrereqsIndexed", "name" : "@RJBS/CheckPrereqsIndexed", - "version" : "0.005" + "version" : "0.007" }, { "class" : "Dist::Zilla::Plugin::GatherDir", "name" : "@RJBS/@Basic/GatherDir", - "version" : "4.300003" + "version" : "4.300007" }, { "class" : "Dist::Zilla::Plugin::PruneCruft", "name" : "@RJBS/@Basic/PruneCruft", - "version" : "4.300003" + "version" : "4.300007" }, { "class" : "Dist::Zilla::Plugin::ManifestSkip", "name" : "@RJBS/@Basic/ManifestSkip", - "version" : "4.300003" + "version" : "4.300007" }, { "class" : "Dist::Zilla::Plugin::MetaYAML", "name" : "@RJBS/@Basic/MetaYAML", - "version" : "4.300003" + "version" : "4.300007" }, { "class" : "Dist::Zilla::Plugin::License", "name" : "@RJBS/@Basic/License", - "version" : "4.300003" + "version" : "4.300007" }, { "class" : "Dist::Zilla::Plugin::Readme", "name" : "@RJBS/@Basic/Readme", - "version" : "4.300003" + "version" : "4.300007" }, { "class" : "Dist::Zilla::Plugin::ExtraTests", "name" : "@RJBS/@Basic/ExtraTests", - "version" : "4.300003" + "version" : "4.300007" }, { "class" : "Dist::Zilla::Plugin::ExecDir", "name" : "@RJBS/@Basic/ExecDir", - "version" : "4.300003" + "version" : "4.300007" }, { "class" : "Dist::Zilla::Plugin::ShareDir", "name" : "@RJBS/@Basic/ShareDir", - "version" : "4.300003" + "version" : "4.300007" }, { "class" : "Dist::Zilla::Plugin::MakeMaker", "name" : "@RJBS/@Basic/MakeMaker", - "version" : "4.300003" + "version" : "4.300007" }, { "class" : "Dist::Zilla::Plugin::Manifest", "name" : "@RJBS/@Basic/Manifest", - "version" : "4.300003" + "version" : "4.300007" }, { "class" : "Dist::Zilla::Plugin::TestRelease", "name" : "@RJBS/@Basic/TestRelease", - "version" : "4.300003" + "version" : "4.300007" }, { "class" : "Dist::Zilla::Plugin::ConfirmRelease", "name" : "@RJBS/@Basic/ConfirmRelease", - "version" : "4.300003" + "version" : "4.300007" }, { "class" : "Dist::Zilla::Plugin::UploadToCPAN", "name" : "@RJBS/@Basic/UploadToCPAN", - "version" : "4.300003" + "version" : "4.300007" }, { "class" : "Dist::Zilla::Plugin::AutoPrereqs", "name" : "@RJBS/AutoPrereqs", - "version" : "4.300003" + "version" : "4.300007" }, { "class" : "Dist::Zilla::Plugin::Git::NextVersion", "name" : "@RJBS/Git::NextVersion", - "version" : "1.112510" + "version" : "1.120370" }, { "class" : "Dist::Zilla::Plugin::PkgVersion", "name" : "@RJBS/PkgVersion", - "version" : "4.300003" + "version" : "4.300007" }, { "class" : "Dist::Zilla::Plugin::MetaConfig", "name" : "@RJBS/MetaConfig", - "version" : "4.300003" + "version" : "4.300007" }, { "class" : "Dist::Zilla::Plugin::MetaJSON", "name" : "@RJBS/MetaJSON", - "version" : "4.300003" + "version" : "4.300007" }, { "class" : "Dist::Zilla::Plugin::NextRelease", "name" : "@RJBS/NextRelease", - "version" : "4.300003" + "version" : "4.300007" }, { "class" : "Dist::Zilla::Plugin::PodSyntaxTests", "name" : "@RJBS/PodSyntaxTests", - "version" : "4.300003" + "version" : "4.300007" }, { "class" : "Dist::Zilla::Plugin::Repository", @@ -173,7 +173,7 @@ } }, "name" : "@RJBS/TestMoreWithSubtests", - "version" : "4.300003" + "version" : "4.300007" }, { "class" : "Dist::Zilla::Plugin::PodWeaver", @@ -183,27 +183,27 @@ { "class" : "Dist::Zilla::Plugin::GithubMeta", "name" : "@RJBS/GithubMeta", - "version" : "0.26" + "version" : "0.28" }, { "class" : "Dist::Zilla::Plugin::Git::Check", "name" : "@RJBS/@Git/Check", - "version" : "1.112510" + "version" : "1.120370" }, { "class" : "Dist::Zilla::Plugin::Git::Commit", "name" : "@RJBS/@Git/Commit", - "version" : "1.112510" + "version" : "1.120370" }, { "class" : "Dist::Zilla::Plugin::Git::Tag", "name" : "@RJBS/@Git/Tag", - "version" : "1.112510" + "version" : "1.120370" }, { "class" : "Dist::Zilla::Plugin::Git::Push", "name" : "@RJBS/@Git/Push", - "version" : "1.112510" + "version" : "1.120370" }, { "class" : "Dist::Zilla::Plugin::RemovePrereqs", @@ -215,7 +215,7 @@ } }, "name" : "RemovePrereqs", - "version" : "4.300003" + "version" : "4.300007" }, { "class" : "Dist::Zilla::Plugin::Prereqs", @@ -226,37 +226,37 @@ } }, "name" : "TestRequires", - "version" : "4.300003" + "version" : "4.300007" }, { "class" : "Dist::Zilla::Plugin::FinderCode", "name" : ":InstallModules", - "version" : "4.300003" + "version" : "4.300007" }, { "class" : "Dist::Zilla::Plugin::FinderCode", "name" : ":IncModules", - "version" : "4.300003" + "version" : "4.300007" }, { "class" : "Dist::Zilla::Plugin::FinderCode", "name" : ":TestFiles", - "version" : "4.300003" + "version" : "4.300007" }, { "class" : "Dist::Zilla::Plugin::FinderCode", "name" : ":ExecFiles", - "version" : "4.300003" + "version" : "4.300007" }, { "class" : "Dist::Zilla::Plugin::FinderCode", "name" : ":ShareFiles", - "version" : "4.300003" + "version" : "4.300007" }, { "class" : "Dist::Zilla::Plugin::FinderCode", "name" : ":MainModule", - "version" : "4.300003" + "version" : "4.300007" } ], "zilla" : { @@ -264,7 +264,7 @@ "config" : { "is_trial" : "0" }, - "version" : "4.300003" + "version" : "4.300007" } } } diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/Test-Fatal-0.008/META.yml new/Test-Fatal-0.010/META.yml --- old/Test-Fatal-0.008/META.yml 2011-11-07 03:10:28.000000000 +0100 +++ new/Test-Fatal-0.010/META.yml 2012-02-16 16:28:07.000000000 +0100 @@ -9,7 +9,7 @@ configure_requires: ExtUtils::MakeMaker: 6.30 dynamic_config: 0 -generated_by: 'Dist::Zilla version 4.300003, CPAN::Meta::Converter version 2.112621' +generated_by: 'Dist::Zilla version 4.300007, CPAN::Meta::Converter version 2.120351' license: perl meta-spec: url: http://module-build.sourceforge.net/META-spec-v1.4.html @@ -25,97 +25,97 @@ resources: homepage: https://github.com/rjbs/test-fatal repository: https://github.com/rjbs/test-fatal.git -version: 0.008 +version: 0.010 x_Dist_Zilla: plugins: - class: Dist::Zilla::Plugin::CheckPrereqsIndexed name: '@RJBS/CheckPrereqsIndexed' - version: 0.005 + version: 0.007 - class: Dist::Zilla::Plugin::GatherDir name: '@RJBS/@Basic/GatherDir' - version: 4.300003 + version: 4.300007 - class: Dist::Zilla::Plugin::PruneCruft name: '@RJBS/@Basic/PruneCruft' - version: 4.300003 + version: 4.300007 - class: Dist::Zilla::Plugin::ManifestSkip name: '@RJBS/@Basic/ManifestSkip' - version: 4.300003 + version: 4.300007 - class: Dist::Zilla::Plugin::MetaYAML name: '@RJBS/@Basic/MetaYAML' - version: 4.300003 + version: 4.300007 - class: Dist::Zilla::Plugin::License name: '@RJBS/@Basic/License' - version: 4.300003 + version: 4.300007 - class: Dist::Zilla::Plugin::Readme name: '@RJBS/@Basic/Readme' - version: 4.300003 + version: 4.300007 - class: Dist::Zilla::Plugin::ExtraTests name: '@RJBS/@Basic/ExtraTests' - version: 4.300003 + version: 4.300007 - class: Dist::Zilla::Plugin::ExecDir name: '@RJBS/@Basic/ExecDir' - version: 4.300003 + version: 4.300007 - class: Dist::Zilla::Plugin::ShareDir name: '@RJBS/@Basic/ShareDir' - version: 4.300003 + version: 4.300007 - class: Dist::Zilla::Plugin::MakeMaker name: '@RJBS/@Basic/MakeMaker' - version: 4.300003 + version: 4.300007 - class: Dist::Zilla::Plugin::Manifest name: '@RJBS/@Basic/Manifest' - version: 4.300003 + version: 4.300007 - class: Dist::Zilla::Plugin::TestRelease name: '@RJBS/@Basic/TestRelease' - version: 4.300003 + version: 4.300007 - class: Dist::Zilla::Plugin::ConfirmRelease name: '@RJBS/@Basic/ConfirmRelease' - version: 4.300003 + version: 4.300007 - class: Dist::Zilla::Plugin::UploadToCPAN name: '@RJBS/@Basic/UploadToCPAN' - version: 4.300003 + version: 4.300007 - class: Dist::Zilla::Plugin::AutoPrereqs name: '@RJBS/AutoPrereqs' - version: 4.300003 + version: 4.300007 - class: Dist::Zilla::Plugin::Git::NextVersion name: '@RJBS/Git::NextVersion' - version: 1.112510 + version: 1.120370 - class: Dist::Zilla::Plugin::PkgVersion name: '@RJBS/PkgVersion' - version: 4.300003 + version: 4.300007 - class: Dist::Zilla::Plugin::MetaConfig name: '@RJBS/MetaConfig' - version: 4.300003 + version: 4.300007 - class: Dist::Zilla::Plugin::MetaJSON name: '@RJBS/MetaJSON' - version: 4.300003 + version: 4.300007 - class: Dist::Zilla::Plugin::NextRelease name: '@RJBS/NextRelease' - version: 4.300003 + version: 4.300007 - class: Dist::Zilla::Plugin::PodSyntaxTests name: '@RJBS/PodSyntaxTests' - version: 4.300003 + version: 4.300007 - class: Dist::Zilla::Plugin::Repository name: '@RJBS/Repository' @@ -127,7 +127,7 @@ phase: test type: requires name: '@RJBS/TestMoreWithSubtests' - version: 4.300003 + version: 4.300007 - class: Dist::Zilla::Plugin::PodWeaver name: '@RJBS/PodWeaver' @@ -135,23 +135,23 @@ - class: Dist::Zilla::Plugin::GithubMeta name: '@RJBS/GithubMeta' - version: 0.26 + version: 0.28 - class: Dist::Zilla::Plugin::Git::Check name: '@RJBS/@Git/Check' - version: 1.112510 + version: 1.120370 - class: Dist::Zilla::Plugin::Git::Commit name: '@RJBS/@Git/Commit' - version: 1.112510 + version: 1.120370 - class: Dist::Zilla::Plugin::Git::Tag name: '@RJBS/@Git/Tag' - version: 1.112510 + version: 1.120370 - class: Dist::Zilla::Plugin::Git::Push name: '@RJBS/@Git/Push' - version: 1.112510 + version: 1.120370 - class: Dist::Zilla::Plugin::RemovePrereqs config: @@ -159,7 +159,7 @@ modules_to_remove: - Test::More name: RemovePrereqs - version: 4.300003 + version: 4.300007 - class: Dist::Zilla::Plugin::Prereqs config: @@ -167,33 +167,33 @@ phase: test type: requires name: TestRequires - version: 4.300003 + version: 4.300007 - class: Dist::Zilla::Plugin::FinderCode name: ':InstallModules' - version: 4.300003 + version: 4.300007 - class: Dist::Zilla::Plugin::FinderCode name: ':IncModules' - version: 4.300003 + version: 4.300007 - class: Dist::Zilla::Plugin::FinderCode name: ':TestFiles' - version: 4.300003 + version: 4.300007 - class: Dist::Zilla::Plugin::FinderCode name: ':ExecFiles' - version: 4.300003 + version: 4.300007 - class: Dist::Zilla::Plugin::FinderCode name: ':ShareFiles' - version: 4.300003 + version: 4.300007 - class: Dist::Zilla::Plugin::FinderCode name: ':MainModule' - version: 4.300003 + version: 4.300007 zilla: class: Dist::Zilla::Dist::Builder config: is_trial: 0 - version: 4.300003 + version: 4.300007 diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/Test-Fatal-0.008/Makefile.PL new/Test-Fatal-0.010/Makefile.PL --- old/Test-Fatal-0.008/Makefile.PL 2011-11-07 03:10:28.000000000 +0100 +++ new/Test-Fatal-0.010/Makefile.PL 2012-02-16 16:28:07.000000000 +0100 @@ -31,7 +31,7 @@ "strict" => 0, "warnings" => 0 }, - "VERSION" => "0.008", + "VERSION" => "0.010", "test" => { "TESTS" => "t/*.t" } diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/Test-Fatal-0.008/README new/Test-Fatal-0.010/README --- old/Test-Fatal-0.008/README 2011-11-07 03:10:28.000000000 +0100 +++ new/Test-Fatal-0.010/README 2012-02-16 16:28:07.000000000 +0100 @@ -1,7 +1,7 @@ This archive contains the distribution Test-Fatal, -version 0.008: +version 0.010: incredibly simple helpers for testing code with exceptions diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/Test-Fatal-0.008/lib/Test/Fatal.pm new/Test-Fatal-0.010/lib/Test/Fatal.pm --- old/Test-Fatal-0.008/lib/Test/Fatal.pm 2011-11-07 03:10:28.000000000 +0100 +++ new/Test-Fatal-0.010/lib/Test/Fatal.pm 2012-02-16 16:28:07.000000000 +0100 @@ -2,7 +2,7 @@ use warnings; package Test::Fatal; { - $Test::Fatal::VERSION = '0.008'; + $Test::Fatal::VERSION = '0.010'; } # ABSTRACT: incredibly simple helpers for testing code with exceptions @@ -78,7 +78,7 @@ =head1 VERSION -version 0.008 +version 0.010 =head1 SYNOPSIS @@ -93,10 +93,10 @@ "the code lived", ); - isnt( + like( exception { might_die; }, - undef, - "the code died", + qr/turns out it died/, + "the code died as expected", ); isa_ok( @@ -122,7 +122,7 @@ C<exception> takes a bare block of code and returns the exception thrown by that block. If no exception was thrown, it returns undef. -B<ACHTUNG!> If the block results in a I<false> exception, such as 0 or the +B<Achtung!> If the block results in a I<false> exception, such as 0 or the empty string, Test::Fatal itself will die. Since either of these cases indicates a serious problem with the system under testing, this behavior is considered a I<feature>. If you must test for these conditions, you should use @@ -151,6 +151,17 @@ my $exception = exception { ... }; like( $exception, qr/foo/, "foo appears in the exception" ); +B<Achtung>: One final bad idea: + + isnt( exception { ... }, undef, "my code died!"); + +It's true that this tests that your code died, but you should really test that +it died I<for the right reason>. For example, if you make an unrelated mistake +in the block, like using the wrong dereference, your test will pass even though +the code to be tested isn't really run at all. If you're expecting an +inspectable exception with an identifier or class, test that. If you're +expecting a string exception, consider using C<like>. + =head2 success try { @@ -177,8 +188,8 @@ These provide an easy upgrade path for replacing existing unit tests based on C<Test::Exception>. -RJBS does not using this except as a convenience while porting tests to use -Test::Fatal's C<exception> routine. +RJBS does not suggest using this except as a convenience while porting tests to +use Test::Fatal's C<exception> routine. use Test::More tests => 2; use Test::Fatal qw(dies_ok lives_ok); diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/Test-Fatal-0.008/t/basic.t new/Test-Fatal-0.010/t/basic.t --- old/Test-Fatal-0.008/t/basic.t 2011-11-07 03:10:28.000000000 +0100 +++ new/Test-Fatal-0.010/t/basic.t 2012-02-16 16:28:07.000000000 +0100 @@ -67,7 +67,7 @@ { package FalseObject; - use overload 'bool' => sub { return }; + use overload 'bool' => sub { 0 }; } like( -- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
