Hello community, here is the log from the commit of package crystalhd-libs for openSUSE:Factory checked in at 2012-03-12 08:53:28 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Comparing /work/SRC/openSUSE:Factory/crystalhd-libs (Old) and /work/SRC/openSUSE:Factory/.crystalhd-libs.new (New) ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Package is "crystalhd-libs", Maintainer is "[email protected]" Changes: -------- --- /work/SRC/openSUSE:Factory/crystalhd-libs/crystalhd-libs.changes 2011-09-23 01:54:32.000000000 +0200 +++ /work/SRC/openSUSE:Factory/.crystalhd-libs.new/crystalhd-libs.changes 2012-03-12 08:53:31.000000000 +0100 @@ -1,0 +2,15 @@ +Fri Mar 9 08:56:07 UTC 2012 - [email protected] + +- license update: SUSE-Firmware + Use SUSE-Firmware to describe firmware which can be freely distributed in + non-modifiable form. The SUSE- prefix should be used until SPDX.org + accept the license upstream + +------------------------------------------------------------------- +Sat Feb 25 04:23:07 UTC 2012 - [email protected] + +- Use rpmoptflags +- Fix buffer overflow (!) in strncat usage + This library needs a full security review, code stinks. + +------------------------------------------------------------------- ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Other differences: ------------------ ++++++ crystalhd-libs.spec ++++++ --- /var/tmp/diff_new_pack.7MBZoB/_old 2012-03-12 08:53:32.000000000 +0100 +++ /var/tmp/diff_new_pack.7MBZoB/_new 2012-03-12 08:53:32.000000000 +0100 @@ -1,7 +1,7 @@ # # spec file for package crystalhd-libs # -# Copyright (c) 2011 SUSE LINUX Products GmbH, Nuernberg, Germany. +# Copyright (c) 2012 SUSE LINUX Products GmbH, Nuernberg, Germany. # # All modifications and additions to the file contributed by third parties # remain the property of their copyright owners, unless otherwise agreed @@ -16,14 +16,13 @@ # - Name: crystalhd-libs BuildRequires: gcc-c++ Summary: Broadcom Crystal HD device interface library -Version: 3.6.5 -Release: 1 -License: LGPLv2.1+ +License: LGPL-2.1+ Group: System/Libraries +Version: 3.6.5 +Release: 0 Source0: crystalhd-libs_%{version}-1.tar.bz2 Source1: README Source2: LICENSE @@ -38,8 +37,8 @@ H.264 video stream with Broadcom Crystal HD chips. %package -n libcrystalhd3 -License: LGPLv2.1+ Summary: Broadcom Crystal HD device interface library +License: LGPL-2.1+ Group: System/Libraries %description -n libcrystalhd3 @@ -48,8 +47,8 @@ %package -n libcrystalhd-devel -License: LGPLv2.1+ Summary: Development package for libcrystalhd +License: LGPL-2.1+ Group: Development/Languages/C and C++ Requires: libcrystalhd3 = %{version}-%{release} @@ -58,7 +57,7 @@ %package -n crystalhd-firmware Summary: Firmware for the Broadcom Crystal HD video decoder -License: NON-OSI-COMPLIANT(no modification) +License: SUSE-Firmware Group: Hardware/Other %description -n crystalhd-firmware @@ -66,11 +65,12 @@ %prep %setup -q -n crystalhd-libs -%patch0 -p1 +%patch0 cp %{SOURCE1} . cp %{SOURCE2} . %build +export CXXFLAGS="%optflags" make %{?_smp_mflags} %install ++++++ crystalhd-libs-define-first.patch ++++++ --- /var/tmp/diff_new_pack.7MBZoB/_old 2012-03-12 08:53:32.000000000 +0100 +++ /var/tmp/diff_new_pack.7MBZoB/_new 2012-03-12 08:53:32.000000000 +0100 @@ -1,6 +1,5 @@ -diff -uNr crystalhd-libs/libcrystalhd_if.h new-crystalhd-libs//libcrystalhd_if.h ---- crystalhd-libs/libcrystalhd_if.h 2010-12-07 00:15:46.000000000 +0100 -+++ new-crystalhd-libs//libcrystalhd_if.h 2011-01-24 19:52:02.845076999 +0100 +--- libcrystalhd_if.h.orig ++++ libcrystalhd_if.h @@ -29,8 +29,8 @@ #ifndef _BCM_LDIL_IF_H_ #define _BCM_LDIL_IF_H_ @@ -11,3 +10,44 @@ #define FLEA_MAX_TRICK_MODE_SPEED 6 +--- Makefile.orig ++++ Makefile +@@ -16,13 +16,13 @@ BCGCC = g++ + INCLUDES = -I./ -I/usr/include + + +-CXXFLAGS = -D__LINUX_USER__ ++CXXFLAGS += -D__LINUX_USER__ + # -DLDIL_PRINTS_ON + # -D_USE_SHMEM_ + + CXXFLAGS += ${INCLUDES} +-CXXFLAGS += -O2 -Wall -fPIC -shared -fstrict-aliasing -msse2 +-LDFLAGS = -Wl,-soname,${BCLIB_SL} -pthread ++CXXFLAGS += -pthread -O2 -Wall -fPIC -DPIC -fvisibility-inlines-hidden -shared -fstrict-aliasing -msse2 ++LDFLAGS = -Wl,-soname,${BCLIB_SL} + + SRCFILES = libcrystalhd_if.cpp \ + libcrystalhd_int_if.cpp \ +--- libcrystalhd_fwdiag_if.cpp.orig ++++ libcrystalhd_fwdiag_if.cpp +@@ -168,7 +168,7 @@ DtsDownloadFWDIAGToLINK(HANDLE hDevice,c + } + + if(FwBinFile!=NULL){ +- strncat(fwfile,(const char*)FwBinFile,sizeof(fwfile)); ++ strncat(fwfile,(const char*)FwBinFile,sizeof(fwfile)-strlen(fwfile)-1); + DebugLog_Trace(LDIL_DBG,"1. fwfile is %s\n",FwBinFile); + }else{ + strncat(fwfile,"/",sizeof(fwfile)); +--- libcrystalhd_if.cpp.orig ++++ libcrystalhd_if.cpp +@@ -723,7 +723,7 @@ DtsGetFWVersionFromFile( + } + + if(fname){ +- strncat(fwfile,(const char*)fname,sizeof(fwfile)); ++ strncat(fwfile,(const char*)fname, sizeof(fwfile)-strlen(fwfile)-1); + }else{ + if(Ctx->DevId == BC_PCI_DEVID_FLEA) + strncat(fwfile,FWBINFILE_70015,sizeof(FWBINFILE_70015)); -- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
