Hello community, here is the log from the commit of package libmodplug for openSUSE:Factory checked in at 2012-03-19 10:07:43 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Comparing /work/SRC/openSUSE:Factory/libmodplug (Old) and /work/SRC/openSUSE:Factory/.libmodplug.new (New) ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Package is "libmodplug", Maintainer is "[email protected]" Changes: -------- --- /work/SRC/openSUSE:Factory/libmodplug/libmodplug.changes 2011-09-23 02:08:59.000000000 +0200 +++ /work/SRC/openSUSE:Factory/.libmodplug.new/libmodplug.changes 2012-03-19 10:08:07.000000000 +0100 @@ -1,0 +2,5 @@ +Thu Mar 15 13:10:41 UTC 2012 - [email protected] + +- Fix buffer overflow. + +------------------------------------------------------------------- New: ---- libmodplug-overflow.patch ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Other differences: ------------------ ++++++ libmodplug.spec ++++++ --- /var/tmp/diff_new_pack.bU18Uq/_old 2012-03-19 10:08:11.000000000 +0100 +++ /var/tmp/diff_new_pack.bU18Uq/_new 2012-03-19 10:08:11.000000000 +0100 @@ -1,7 +1,7 @@ # # spec file for package libmodplug # -# Copyright (c) 2011 SUSE LINUX Products GmbH, Nuernberg, Germany. +# Copyright (c) 2012 SUSE LINUX Products GmbH, Nuernberg, Germany. # # All modifications and additions to the file contributed by third parties # remain the property of their copyright owners, unless otherwise agreed @@ -29,6 +29,8 @@ Source1: baselibs.conf # PATCH-FIX-OPENSUSE libmodplug-timidity.patch -- set paths to openSUSE timidity package Patch1: libmodplug-timidity.patch +# PATCH-FIX-OPENSUSE Fix buffer overflow +Patch2: libmodplug-overflow.patch BuildRequires: dos2unix gcc-c++ pkg-config BuildRoot: %{_tmppath}/%{name}-%{version}-build @@ -40,7 +42,6 @@ %package -n libmodplug%{soname} - License: SUSE-Public-Domain Summary: Development files for libmodplug Group: Development/Libraries/C and C++ @@ -65,6 +66,7 @@ %prep %setup -q %patch1 +%patch2 -p1 # Fix eol encoding. dos2unix -o ChangeLog ++++++ libmodplug-overflow.patch ++++++ Index: libmodplug-0.8.8.4/src/load_amf.cpp =================================================================== --- libmodplug-0.8.8.4.orig/src/load_amf.cpp +++ libmodplug-0.8.8.4/src/load_amf.cpp @@ -371,7 +371,7 @@ BOOL CSoundFile::ReadAMF(LPCBYTE lpStrea } // Store tracks positions BYTE **pTrackData = new BYTE *[realtrackcnt]; - memset(pTrackData, 0, sizeof(pTrackData)); + memset(*pTrackData, 0, sizeof(pTrackData)); for (UINT iTrack=0; iTrack<realtrackcnt; iTrack++) if (dwMemPos <= dwMemLength - 3) { UINT nTrkSize = bswapLE16(*(USHORT *)(lpStream+dwMemPos)); ++++++ libmodplug-timidity.patch ++++++ --- /var/tmp/diff_new_pack.bU18Uq/_old 2012-03-19 10:08:11.000000000 +0100 +++ /var/tmp/diff_new_pack.bU18Uq/_new 2012-03-19 10:08:11.000000000 +0100 @@ -1,6 +1,8 @@ ---- src/load_pat.cpp +Index: src/load_pat.cpp +=================================================================== +--- src/load_pat.cpp.orig +++ src/load_pat.cpp -@@ -53,8 +53,8 @@ +@@ -59,8 +59,8 @@ typedef UWORD WORD; #define PATHFORPAT "C:\\TIMIDITY\\INSTRUMENTS" #else #define DIRDELIM '/' -- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
