Hello community, here is the log from the commit of package smb4k for openSUSE:Factory checked in at 2012-09-17 01:29:38 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Comparing /work/SRC/openSUSE:Factory/smb4k (Old) and /work/SRC/openSUSE:Factory/.smb4k.new (New) ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Package is "smb4k", Maintainer is "[email protected]" Changes: -------- --- /work/SRC/openSUSE:Factory/smb4k/smb4k.changes 2012-09-11 08:00:07.000000000 +0200 +++ /work/SRC/openSUSE:Factory/.smb4k.new/smb4k.changes 2012-09-17 01:29:39.000000000 +0200 @@ -1,0 +2,11 @@ +Sun Sep 16 20:28:19 UTC 2012 - [email protected] + +- Update to version 1.0.4: + * Fixed erroneously shown error notifications when searching. + * Make sure that "tdb_log" messages are not shown as error notifications + to the user. + * Wait until unmounting all shares on exit finished before closing down. + * Make sure that the mount prefix and all its subdirectories correctly + inherit their permissions. + +------------------------------------------------------------------- Old: ---- smb4k-1.0.3.tar.bz2 New: ---- smb4k-1.0.4.tar.bz2 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Other differences: ------------------ ++++++ smb4k.spec ++++++ --- /var/tmp/diff_new_pack.8jxEYv/_old 2012-09-17 01:29:41.000000000 +0200 +++ /var/tmp/diff_new_pack.8jxEYv/_new 2012-09-17 01:29:41.000000000 +0200 @@ -17,7 +17,7 @@ Name: smb4k -Version: 1.0.3 +Version: 1.0.4 Release: 0 Summary: Advanced Network Neighborhood Browser for KDE License: GPL-2.0+ ++++++ smb4k-1.0.3.tar.bz2 -> smb4k-1.0.4.tar.bz2 ++++++ diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/smb4k-1.0.3/CMakeLists.txt new/smb4k-1.0.4/CMakeLists.txt --- old/smb4k-1.0.3/CMakeLists.txt 2012-06-23 15:59:52.000000000 +0200 +++ new/smb4k-1.0.4/CMakeLists.txt 2012-08-19 11:00:02.000000000 +0200 @@ -1,9 +1,9 @@ project( smb4k ) -set( VERSION 1.0.3 ) +set( VERSION 1.0.4 ) set( VERSION_MAJOR 1 ) set( VERSION_MINOR 0 ) -set( VERSION_PATCH 3 ) +set( VERSION_PATCH 4 ) cmake_minimum_required( VERSION 2.6 ) diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/smb4k-1.0.3/ChangeLog new/smb4k-1.0.4/ChangeLog --- old/smb4k-1.0.3/ChangeLog 2012-06-23 15:59:52.000000000 +0200 +++ new/smb4k-1.0.4/ChangeLog 2012-08-19 11:00:02.000000000 +0200 @@ -1,7 +1,16 @@ +Smb4K 1.0.4 (2012-08-19): +- Fixed erroneously shown error notifications when searching. Thanks to + Alexander Willand for reporting this issue. +- Make sure that "tdb_log" messages are not shown as error notifications + to the user. +- Wait until unmounting all shares on exit finished before closing down. +- Make sure that the mount prefix and all its subdirectories correctly + inherit their permissions. + Smb4K 1.0.3 (2012-06-23): - Make sure that output from the mount and unmount process is trimmed, so that there are no false error messages. -- Fixed error notifications being shown although mounting and unmounting +- Fixed error notifications being shown although mounting and unmounting shares was successful. Smb4K 1.0.2 (2012-05-30): diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/smb4k-1.0.3/core/CMakeLists.txt new/smb4k-1.0.4/core/CMakeLists.txt --- old/smb4k-1.0.3/core/CMakeLists.txt 2012-06-23 15:59:52.000000000 +0200 +++ new/smb4k-1.0.4/core/CMakeLists.txt 2012-08-19 11:00:02.000000000 +0200 @@ -50,6 +50,7 @@ target_link_libraries( smb4kcore ${QT_QTCORE_LIBRARY} ${QT_QTGUI_LIBRARY} + ${QT_QTTEST_LIBRARY} ${KDE4_KDECORE_LIBS} ${KDE4_KDEUI_LIBS} ${KDE4_KIO_LIBS} diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/smb4k-1.0.3/core/smb4kmounter.cpp new/smb4k-1.0.4/core/smb4kmounter.cpp --- old/smb4k-1.0.3/core/smb4kmounter.cpp 2012-06-23 15:59:52.000000000 +0200 +++ new/smb4k-1.0.4/core/smb4kmounter.cpp 2012-08-19 11:00:02.000000000 +0200 @@ -31,6 +31,7 @@ #include <QDesktopWidget> #include <QTimer> #include <QFileInfo> +#include <QTest> // KDE includes #include <kapplication.h> @@ -1326,6 +1327,12 @@ if ( Smb4KSettings::unmountSharesOnExit() ) { unmountAllShares(); + + // Wait until done. + while ( hasSubjobs() ) + { + QTest::qWait( TIMEOUT ); + } } else { diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/smb4k-1.0.3/core/smb4kmounter_p.cpp new/smb4k-1.0.4/core/smb4kmounter_p.cpp --- old/smb4k-1.0.3/core/smb4kmounter_p.cpp 2012-06-23 15:59:52.000000000 +0200 +++ new/smb4k-1.0.4/core/smb4kmounter_p.cpp 2012-08-19 11:00:02.000000000 +0200 @@ -138,6 +138,26 @@ // Do nothing } + // Get the permissions that should be used for creating the + // mount prefix and all its subdirectories. + // Please note that the actual permissions of the mount points + // are determined by the mount utility. + QFile::Permissions permissions; + KUrl parentDirectory; + + if ( QFile::exists( Smb4KSettings::mountPrefix().path() ) ) + { + parentDirectory = Smb4KSettings::mountPrefix(); + } + else + { + KUrl u( Smb4KSettings::mountPrefix() ); + parentDirectory = u.upUrl(); + } + + QFile f( parentDirectory.path() ); + permissions = f.permissions(); + // Assemble the mount point and create it. QString mountpoint; mountpoint += Smb4KSettings::mountPrefix().path(); @@ -164,6 +184,14 @@ } else { + KUrl u( dir.path() ); + + while ( u != parentDirectory ) + { + QFile( u.path() ).setPermissions( permissions ); + u = u.upUrl(); + } + share->setPath( dir.path() ); } diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/smb4k-1.0.3/core/smb4kscanner_p.cpp new/smb4k-1.0.4/core/smb4kscanner_p.cpp --- old/smb4k-1.0.3/core/smb4kscanner_p.cpp 2012-06-23 15:59:52.000000000 +0200 +++ new/smb4k-1.0.4/core/smb4kscanner_p.cpp 2012-08-19 11:00:02.000000000 +0200 @@ -1674,7 +1674,8 @@ { emit authError( this ); } - else if ( stderr.contains( "tdb_transaction_recover:" ) ) + else if ( stderr.contains( "tdb_transaction_recover:" ) || + stderr.contains( "tdb_log" ) ) { // Suppress debug output/information sent to stderr qDebug() << stderr; diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/smb4k-1.0.3/core/smb4ksearch_p.cpp new/smb4k-1.0.4/core/smb4ksearch_p.cpp --- old/smb4k-1.0.3/core/smb4ksearch_p.cpp 2012-06-23 15:59:52.000000000 +0200 +++ new/smb4k-1.0.4/core/smb4ksearch_p.cpp 2012-08-19 11:00:02.000000000 +0200 @@ -337,11 +337,15 @@ m_proc->abort(); emit authError( this ); } - else + else if ( stderr.contains( "NT_STATUS" ) ) { Smb4KNotification *notification = new Smb4KNotification(); notification->searchingFailed( m_string, stderr ); } + else + { + // Do nothing + } } -- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
