Hello community,

here is the log from the commit of package libgnomecups for openSUSE:Factory 
checked in at 2013-03-26 12:04:19
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Comparing /work/SRC/openSUSE:Factory/libgnomecups (Old)
 and      /work/SRC/openSUSE:Factory/.libgnomecups.new (New)
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++

Package is "libgnomecups", Maintainer is "[email protected]"

Changes:
--------
--- /work/SRC/openSUSE:Factory/libgnomecups/libgnomecups.changes        
2012-02-16 16:18:05.000000000 +0100
+++ /work/SRC/openSUSE:Factory/.libgnomecups.new/libgnomecups.changes   
2013-03-26 12:04:20.000000000 +0100
@@ -1,0 +2,18 @@
+Sun Mar 24 13:16:22 UTC 2013 - [email protected]
+
+- Add libgnomecups-buildfixes.patch: Use g_error_new_literal
+  instead of g_error_new, which does not like non-literal strings
+  as format identifiers.
+
+-------------------------------------------------------------------
+Thu Mar 21 13:18:44 UTC 2013 - [email protected]
+
+- license update: LGPL-2.0
+  No evidence of GPL code
+
+-------------------------------------------------------------------
+Fri Mar  1 12:45:15 UTC 2013 - [email protected]
+
+- Spec-cleanup using format_spec_file service.
+
+-------------------------------------------------------------------

New:
----
  libgnomecups-buildfixes.patch

++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++

Other differences:
------------------
++++++ libgnomecups.spec ++++++
--- /var/tmp/diff_new_pack.Wei92e/_old  2013-03-26 12:04:22.000000000 +0100
+++ /var/tmp/diff_new_pack.Wei92e/_new  2013-03-26 12:04:22.000000000 +0100
@@ -1,7 +1,7 @@
 #
 # spec file for package libgnomecups
 #
-# Copyright (c) 2012 SUSE LINUX Products GmbH, Nuernberg, Germany.
+# Copyright (c) 2013 SUSE LINUX Products GmbH, Nuernberg, Germany.
 #
 # All modifications and additions to the file contributed by third parties
 # remain the property of their copyright owners, unless otherwise agreed
@@ -17,19 +17,12 @@
 
 
 Name:           libgnomecups
-BuildRequires:  cups-devel
-BuildRequires:  fdupes
-BuildRequires:  glib2-devel
-BuildRequires:  gnome-common
-BuildRequires:  intltool
-BuildRequires:  translation-update-upstream
-BuildRequires:  zlib-devel
 Version:        0.2.3
 Release:        0
-Url:            http://www.gnome.org/
 Summary:        GNOME CUPS Library
-License:        GPL-2.0+ ; LGPL-2.0
+License:        LGPL-2.0
 Group:          System/GUI/GNOME
+Url:            http://www.gnome.org/
 Source:         %{name}-%{version}.tar.gz
 Source99:       baselibs.conf
 # PATCH-FIX-UPSTREAM libgnomecups-callback-fix.patch
@@ -40,30 +33,34 @@
 Patch2:         libgnomecups-ignore-default-ipp-warning.patch
 # PATCH-FIX-UPSTREAM libgnomecups-glib.patch bgo#664930 [email protected] 
-- Fix build with glib 2.31: only glib.h can be included.
 Patch3:         libgnomecups-glib.patch
+# PATCH-FIX-UPSTREAM libgnomecups-buildfixes.patch [email protected] -- use 
g_error_new_literal to avoid explotability of literal strings.
+Patch4:         libgnomecups-buildfixes.patch
+BuildRequires:  cups-devel
+BuildRequires:  fdupes
+BuildRequires:  gnome-common
+BuildRequires:  intltool
+BuildRequires:  translation-update-upstream
+BuildRequires:  zlib-devel
+BuildRequires:  pkgconfig(glib-2.0)
 # bug437293
 %ifarch ppc64
 Obsoletes:      libgnomecups-64bit
 %endif
+Recommends:     %{name}-lang = %{version}
 #
 BuildRoot:      %{_tmppath}/%{name}-%{version}-build
-Recommends:     %{name}-lang = %{version}
 
 %description
 A gobject (GLib) wrapper for IPP printer management, which is used by
 CUPS.  Mainly used by the GNOME printing system.
 
-
-
-Authors:
---------
-    Dave Camp <[email protected]>
-    Michael Meeks <[email protected]>
-    Chris Lahey <[email protected]>
-
 %package devel
 Summary:        GNOME CUPS Library
 Group:          System/GUI/GNOME
-Requires:       %{name} = %{version} cups-devel glib2-devel zlib-devel
+Requires:       %{name} = %{version}
+Requires:       cups-devel
+Requires:       zlib-devel
+Requires:       pkgconfig(glib-2.0)
 # bug437293
 %ifarch ppc64
 Obsoletes:      libgnomecups-devel-64bit
@@ -74,14 +71,6 @@
 A gobject (GLib) wrapper for IPP printer management, which is used by
 CUPS.  Mainly used by the GNOME printing system.
 
-
-
-Authors:
---------
-    Dave Camp <[email protected]>
-    Michael Meeks <[email protected]>
-    Chris Lahey <[email protected]>
-
 %lang_package
 %prep
 %setup -q
@@ -90,22 +79,23 @@
 %patch1 -p1
 %patch2 -p1
 %patch3 -p1
+%patch4 -p1
 
 %build
 autoreconf -f -i
 %configure --with-pic\
        --disable-static
-make %{?jobs:-j%jobs}
+make %{?_smp_mflags}
 
 %install
-%makeinstall
-%{__rm} -f %{buildroot}%{_libdir}/*.la
+%make_install
+rm -f %{buildroot}%{_libdir}/*.la
 # Change sr@Latn to sr@latin
 mv %{buildroot}%{_datadir}/locale/sr@Latn 
%{buildroot}%{_datadir}/locale/sr@latin
 %find_lang %{name}
 
 %clean
-rm -rf $RPM_BUILD_ROOT
+rm -rf %{buildroot}
 
 %post -p /sbin/ldconfig
 
@@ -113,7 +103,7 @@
 
 %files
 %defattr (-, root, root)
-%doc AUTHORS COPYING COPYING.LIB ChangeLog NEWS README
+%doc AUTHORS COPYING COPYING.LIB ChangeLog NEWS
 %{_libdir}/*.so.*
 
 %files lang -f %{name}.lang

++++++ libgnomecups-buildfixes.patch ++++++
Index: libgnomecups-0.2.3/libgnomecups/gnome-cups-request.c
===================================================================
--- libgnomecups-0.2.3.orig/libgnomecups/gnome-cups-request.c
+++ libgnomecups-0.2.3/libgnomecups/gnome-cups-request.c
@@ -357,7 +357,7 @@ request_thread_main (GnomeCupsRequest *r
                        g_warning ("IPP request %s failed with status %d",
                         ippOpString 
(request->request->request.op.operation_id), status);
                        if (request->error != NULL)
-                               *(request->error) = g_error_new 
(GNOME_CUPS_ERROR, 
+                               *(request->error) = g_error_new_literal 
(GNOME_CUPS_ERROR, 
                                                                 status, 
ippErrorString (status));
                } else if (request->response && _gnome_cups_debug) {
                        g_print ("response = \n");
@@ -368,7 +368,7 @@ request_thread_main (GnomeCupsRequest *r
                        request->path, request->output_fd);
                request->response = NULL;
                if (HTTP_OK != status && request->error != NULL)
-                       *(request->error) = g_error_new (GNOME_CUPS_ERROR, 
+                       *(request->error) = g_error_new_literal 
(GNOME_CUPS_ERROR, 
                                                         status, httpStatus 
(status));
        } else {
                g_warning ("Neither request nor output_fd set");
@@ -471,7 +471,7 @@ gnome_cups_request_add_requested_attribu
        ippAddStrings (request, group,
                       IPP_TAG_NAME | IPP_TAG_COPY,
                       "requested-attributes",
-                      n_attributes, NULL, attributes);
+                      n_attributes, NULL, (const char* const*)attributes);
 }
 
 typedef struct
-- 
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to