Hello community, here is the log from the commit of package netcontrol for openSUSE:Factory checked in at 2013-04-02 12:32:34 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Comparing /work/SRC/openSUSE:Factory/netcontrol (Old) and /work/SRC/openSUSE:Factory/.netcontrol.new (New) ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Package is "netcontrol", Maintainer is "[email protected]" Changes: -------- --- /work/SRC/openSUSE:Factory/netcontrol/netcontrol.changes 2013-01-29 11:19:15.000000000 +0100 +++ /work/SRC/openSUSE:Factory/.netcontrol.new/netcontrol.changes 2013-04-02 12:32:36.000000000 +0200 @@ -1,0 +2,15 @@ +Tue Mar 26 15:01:02 UTC 2013 - [email protected] + +- version 0.2.8 +- Added ChangeLog.git to dist archive and to devel package docs. +- Fixed ncf_close to not close logger as ncf_init did not open any. + This caused SEGV's in libvirt, that redirects the global logger + to itself and is using multiple ncf instances (bnc#811002). +- Fixed pthreads detection and source enablement in configure, + added an explicit configure --enable-pthreads option to spec + file to cause a failure on detection problems (bnc#811002). +- Fixed SEGV at parsing not existing BRIDGE_PATHCOSTS and memory + leaks in in loop check, xml parsing and on backup file creation + failure while routes file rewrite (bnc#810381). + +------------------------------------------------------------------- Old: ---- netcontrol-0.2.7.tar.bz2 New: ---- netcontrol-0.2.8.tar.bz2 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Other differences: ------------------ ++++++ netcontrol.spec ++++++ --- /var/tmp/diff_new_pack.1iodXb/_old 2013-04-02 12:32:38.000000000 +0200 +++ /var/tmp/diff_new_pack.1iodXb/_new 2013-04-02 12:32:38.000000000 +0200 @@ -17,8 +17,8 @@ Name: netcontrol -Version: 0.2.7 -Release: 0 +Version: 0.2.8 +Release: 0.<RELEASE5> Summary: A network configuration library License: LGPL-2.1+ Group: Productivity/Networking/System @@ -56,6 +56,7 @@ Marius Tomaschewski <[email protected]> %package -n libnetcontrol0 + Summary: A network configuration library Group: Productivity/Networking/System @@ -73,6 +74,7 @@ Marius Tomaschewski <[email protected]> %package -n libnetcontrol-devel + Summary: Development header and library files Group: Development/Libraries/C and C++ Requires: libnetcontrol0 = %{version} @@ -100,6 +102,7 @@ %if 0%{?suse_version} >= 1230 --enable-network-service \ %endif + --enable-pthreads \ --disable-static make %{?_smp_mflags} @@ -119,7 +122,7 @@ %files -n libnetcontrol-devel %defattr(-,root,root,-) -%doc README COPYING.LGPL COPYING.GPL +%doc README COPYING.LGPL COPYING.GPL ChangeLog.git %{_libdir}/*.so %{_includedir}/* %{_datadir}/pkgconfig/netcontrol.pc ++++++ netcontrol-0.2.7.tar.bz2 -> netcontrol-0.2.8.tar.bz2 ++++++ diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/netcontrol-0.2.7/ChangeLog.git new/netcontrol-0.2.8/ChangeLog.git --- old/netcontrol-0.2.7/ChangeLog.git 1970-01-01 01:00:00.000000000 +0100 +++ new/netcontrol-0.2.8/ChangeLog.git 2013-03-26 16:35:47.000000000 +0100 @@ -0,0 +1,549 @@ +commit 21cf2bf79856f26f42dad05facbeb28fa25c5cdd +Author: Marius Tomaschewski <[email protected]> +Date: Tue Mar 26 16:10:38 2013 +0100 + + version 0.2.8, updated changes file + +commit 2adbf8c3bbbddd2c4969477736f6c5852203e3e3 +Author: Marius Tomaschewski <[email protected]> +Date: Tue Mar 26 15:27:47 2013 +0100 + + Updated copyright year in files touched in 2013 + +commit c567271a998b4b4d042bf692598228e2e603768d +Author: Marius Tomaschewski <[email protected]> +Date: Tue Mar 26 13:56:26 2013 +0100 + + Added ChangeLog.git to dist archive and devel docs + +commit cfaf753096a0b8fe094975723a94c765dd41d4a5 +Author: Marius Tomaschewski <[email protected]> +Date: Tue Mar 26 12:03:40 2013 +0100 + + Fixed ncf_close to not close logger (bnc#811002) + + Don't close logger in ncf_close, ncf_init did not open any. + This caused SEGV's in libvirt, using multiple ncf instances. + +commit 5d704cfadff97e0267bb91ad2e673032b4d578b3 +Author: Marius Tomaschewski <[email protected]> +Date: Tue Mar 26 10:18:51 2013 +0100 + + Fixed pthreads detection in configure (bnc#811002) + + - Fixed to not provide own action-if-found to pthreads + detection macro, so it defines HAVE_PTHREADS. + - Added a --disable/enable-pthreads configure option. + When configure is used with explicit --enable-pthreads, + it fails when it were unable to detect pthreas now. + - Use configure --enable-pthreads in spec file template + to fail on pthreas detection problems. + +commit 39fbe98f290bb7837fead68a9510ac31e20c1139 +Author: Marius Tomaschewski <[email protected]> +Date: Fri Mar 22 15:03:23 2013 +0100 + + Cleanup on backup creation error in routes rewrite + +commit 5a1045e040e9f16ce1e7e4a64b58971bf795881f +Author: Marius Tomaschewski <[email protected]> +Date: Fri Mar 22 15:01:15 2013 +0100 + + Fixed memleaks xml_from_route and _address_config + +commit d82ee3cf927d89d64f27fe63f9ac875c1f27abad +Author: Marius Tomaschewski <[email protected]> +Date: Fri Mar 22 15:00:31 2013 +0100 + + Fixed memory leak in check_interface_loop + +commit edd9312a5b0c06992387ee2cbbe37622cfde86c8 +Author: Marius Tomaschewski <[email protected]> +Date: Fri Mar 22 14:35:47 2013 +0100 + + Fixed SEGV at parsing not existing BRIDGE_PATHCOSTS + + Improper return code check allowing also the not-found code, + caused to pass NULL pointer to initial strtok_r (bnc#810381). + +commit aaa77eedd7ebb39a06353713d708eb9cb17d32ea +Author: Marius Tomaschewski <[email protected]> +Date: Fri Jan 25 10:44:35 2013 +0100 + + version 0.2.7, updated changes file + +commit 8a9bf426e09f3c19839605207e8ee2e308206e4f +Author: Marius Tomaschewski <[email protected]> +Date: Fri Jan 25 10:36:56 2013 +0100 + + Fixed bridge variable initialization in try_bridge + +commit cf3707b92e5432f879d302870382fb1cddca01b1 +Author: Marius Tomaschewski <[email protected]> +Date: Fri Jan 25 09:37:41 2013 +0100 + + Use --enable-network-service on openSUSE >= 12.3 + +commit 531e7c3592a248527316b69c1787cd1c9fd0ff02 +Author: Marius Tomaschewski <[email protected]> +Date: Fri Jan 25 09:37:28 2013 +0100 + + Check network.service alias when requested + + Check the network.service alias link instead of NETWORKMANAGER + variable in /etc/sysconfig/network/config, when requested by + the --enable-network-service configure option. + +commit a54c7dc49de719b5d1aad81424708f173328cae7 +Author: Marius Tomaschewski <[email protected]> +Date: Tue Jul 3 13:16:36 2012 +0200 + + version 0.2.6, updated netcontrol.changes + +commit 426ffee7c1619a424b8e24f8d20e30ea4899f0b7 +Author: Marius Tomaschewski <[email protected]> +Date: Tue Jul 3 13:13:15 2012 +0200 + + Fixed libnl-devel rpm build requires for 12.1 + +commit fa746dd8cb777fbaa318fe7c07f03d1a832f4126 +Author: Marius Tomaschewski <[email protected]> +Date: Tue Jul 3 13:03:42 2012 +0200 + + Updated FSF address in copyright statements + +commit bfb526bdf004005c68d1f684b5f402be515ae816 +Author: Marius Tomaschewski <[email protected]> +Date: Tue Jul 3 12:43:26 2012 +0200 + + Merged spec file changes from openSUSE:Factory + +commit 736a208e28177701204a98ac44bdec5c72709538 +Author: Marius Tomaschewski <[email protected]> +Date: Mon Jul 2 12:55:19 2012 +0200 + + version 0.2.5, updated netcontrol.changes + +commit 4c9c4cbfeb493f2e7ce7c918fc06807f05cacba5 +Author: Marius Tomaschewski <[email protected]> +Date: Mon Jul 2 12:54:44 2012 +0200 + + Reverted to require autoconf 2.63, no silent rules + +commit cedf37e215d0919a3a886e118b2900860188d229 +Author: Marius Tomaschewski <[email protected]> +Date: Mon Jul 2 12:51:07 2012 +0200 + + Enabled pkg-config in rpm build-requires + +commit 14e360fe87728810db70d937f1165e912f22b14f +Author: Marius Tomaschewski <[email protected]> +Date: Thu Jun 28 12:16:07 2012 +0200 + + Fetch ip addresses and routes in system refresh + +commit 4d845322026fed739c4ab225f65fb5af800e1a9c +Author: Marius Tomaschewski <[email protected]> +Date: Thu Jun 28 12:14:46 2012 +0200 + + Added netlink utilities to fetch ip addrs and routes + +commit 4201a8a7a3193d0b79fa88faaa49968995979f36 +Author: Marius Tomaschewski <[email protected]> +Date: Thu Jun 28 12:11:24 2012 +0200 + + Added libnl-1 to rpm build deps and configure check + +commit 4fb289b41066f3520d33cb12d62ccb7d5672618b +Author: Marius Tomaschewski <[email protected]> +Date: Thu Jun 14 12:09:18 2012 +0200 + + No -o rc for ifup or it fails when startmode=manual + +commit 5a97ea91cc0e52dfe35c4f2582eaa42d90d955da +Author: Marius Tomaschewski <[email protected]> +Date: Fri Jun 8 15:21:25 2012 +0200 + + Always call ifstatus in ncf_if_status + +commit 820f6ca08264134b2cff75e3a716ff31e376ba12 +Author: Marius Tomaschewski <[email protected]> +Date: Fri Jun 8 15:19:29 2012 +0200 + + Do not report error when interface does not exists any more + +commit a0fc39da23b26db83e3e8a0ea0435a2eba4f7c43 +Author: Marius Tomaschewski <[email protected]> +Date: Fri Jun 8 15:18:03 2012 +0200 + + No operstate check to better match ifstatus results + +commit 9ee5cecee144e0518d75b8a097c281b84b81959b +Author: Marius Tomaschewski <[email protected]> +Date: Fri Jun 8 15:27:35 2012 +0200 + + Improved error handling, report errors once + +commit 752fbacebbee1d4694bc1aae55aa4600e326459a +Author: Marius Tomaschewski <[email protected]> +Date: Wed Jun 6 14:03:57 2012 +0200 + + Check type while creating topology as well + +commit 169b83eeaa11edda4bbbcc86c0c1026da3f3cb04 +Author: Marius Tomaschewski <[email protected]> +Date: Wed Jun 6 13:28:45 2012 +0200 + + Call ifstatus to get authorative active status. + +commit bfaf73406ddbe9eba1fdf7f609087e32e169042d +Author: Marius Tomaschewski <[email protected]> +Date: Fri Jun 8 15:25:03 2012 +0200 + + Expose a lot of error details to the user + +commit 596aa93db50ac2762b4c889dd4072a16bc7acc2f +Author: Marius Tomaschewski <[email protected]> +Date: Mon Jun 4 15:02:27 2012 +0200 + + Adopted configure for complete interface trees + +commit 9d74e7c9455e80b6bb06effa7f4da5a02a6215af +Author: Marius Tomaschewski <[email protected]> +Date: Mon Jun 4 14:58:51 2012 +0200 + + Write complete interface trees in configure + +commit 8e6e9d9428e68bef880c43f7a5cc5dcaec2975e4 +Author: Marius Tomaschewski <[email protected]> +Date: Mon Jun 4 14:53:12 2012 +0200 + + Read startmode from config in system handle + +commit bb37f175a56f699d66d7222a9fabec8f25618565 +Author: Marius Tomaschewski <[email protected]> +Date: Mon Jun 4 14:50:21 2012 +0200 + + Save root dir in system handle when provided in init + +commit 6591c0fbf167b53b9e9c078eb08c9e61f3e68b57 +Author: Marius Tomaschewski <[email protected]> +Date: Mon Jun 4 14:42:48 2012 +0200 + + Fixed netxf xml to always include MAC address if any + +commit 87fdaab3e056c639b9abe90d57f943f24c8950b8 +Author: Marius Tomaschewski <[email protected]> +Date: Mon Jun 4 14:40:42 2012 +0200 + + Fixed arp ip target in netcf xml from interface + +commit c6dea4472dddaae2e9b438e093254efd63bbffab +Author: Marius Tomaschewski <[email protected]> +Date: Mon Jun 4 14:36:19 2012 +0200 + + Fixed to parse complete tree in netcf xml_to_interface + +commit 22e5870d1fee24b41df58cd82e914563e3a70460 +Author: Marius Tomaschewski <[email protected]> +Date: Mon Jun 4 13:44:31 2012 +0200 + + Fixed bond to write out arp_ip_target options + +commit 5a7d0b1c99ec10d77a6b7ea85cbcf7dae253266c +Author: Marius Tomaschewski <[email protected]> +Date: Mon Jun 4 13:37:21 2012 +0200 + + Cleaned up redundant words in debug output + +commit e7e1e7bf8654fb48aec3df14a9607584df3108d9 +Author: Marius Tomaschewski <[email protected]> +Date: Mon Jun 4 13:34:44 2012 +0200 + + Pass root directory also to the system handle + +commit adf779ad4b41b2add3709a771a74424f1f473e75 +Author: Marius Tomaschewski <[email protected]> +Date: Mon Jun 4 13:21:36 2012 +0200 + + Refresh config handle earlier, fixed a double free + +commit e9cf19c5a043ebfa8cd8fc099d72b0cddd7ac46c +Author: Marius Tomaschewski <[email protected]> +Date: Mon Jun 4 13:12:50 2012 +0200 + + Fetch mac address from system when not in the config + +commit 40985a91470462aa96643504c8a53e48e48bf2e0 +Author: Marius Tomaschewski <[email protected]> +Date: Mon Jun 4 09:12:56 2012 +0200 + + Lowered missed config messages to trace (debug) + +commit a15fa821932653c3a273bba1c5161623e0ae04b7 +Author: Marius Tomaschewski <[email protected]> +Date: Fri Jun 1 13:13:09 2012 +0200 + + Fixed to return errors in xml_node_print + +commit d47f1c7caec46ca79efaa9699b9a57e14619ed80 +Author: Marius Tomaschewski <[email protected]> +Date: Thu May 24 12:20:59 2012 +0200 + + Added a find function in interface array and handle + +commit 4b6265b7a1727a651f76f13ef7630f339ea2fb43 +Author: Marius Tomaschewski <[email protected]> +Date: Thu May 24 12:09:01 2012 +0200 + + Fixed nc_bonding_add_slave to expose errors + +commit 61e5d1a1d6e8cd4dee73a0f654aa2bad4fd29be8 +Author: Marius Tomaschewski <[email protected]> +Date: Thu May 24 12:07:33 2012 +0200 + + Fixed authors lines + +commit 833b2ab788ef8d51a43e999338ab81f3265e5ab8 +Author: Marius Tomaschewski <[email protected]> +Date: Mon May 7 16:07:32 2012 +0200 + + Removed senseless check that caused SEGV later + +commit 30dd5d12b35eeb89b091e585108dd8c6983f937b +Author: Marius Tomaschewski <[email protected]> +Date: Mon May 7 16:00:18 2012 +0200 + + Automatically start interfeces we depend on + + When starting a bridge/bond/vlan, start the slaves/ports/base + interfaces first (when not yet running) to make sure, virtual + base interfaces (e.g. bond used as bridge port) exist. + +commit 6be4a1a346da8797bc7b000b831c889c537b2a2e +Author: Marius Tomaschewski <[email protected]> +Date: Wed Dec 7 10:30:44 2011 +0100 + + Updated netcontrol.changes + +commit 85a05a63223484336752fe054094a5188fc9e214 +Author: Marius Tomaschewski <[email protected]> +Date: Wed Dec 7 10:30:44 2011 +0100 + + Lowered bad_reference log level to warning + +commit a95ca655dc098db769baee90f8b66a58aecb1603 +Author: Marius Tomaschewski <[email protected]> +Date: Tue Sep 27 13:20:06 2011 +0200 + + version 0.2.4, updated changes file + +commit 3461dddd03256d4bb42fc7d18286218abfbe15df +Author: Marius Tomaschewski <[email protected]> +Date: Tue Sep 27 13:04:31 2011 +0200 + + Generate complete interface chanins, no vlan type + +commit bf36260705b70df7e09c39ce52479ab00eab4f4f +Author: Marius Tomaschewski <[email protected]> +Date: Tue Sep 27 10:35:48 2011 +0200 + + Removed init of legacy variables + +commit e84725eb4a4df80a919502d8f1ad204b3c959ea5 +Author: Marius Tomaschewski <[email protected]> +Date: Tue Sep 27 09:49:01 2011 +0200 + + Fixed writing of bonding slaves into ifcfg file + +commit e325a5d3616970bbae1665164dce79e07e6acc58 +Author: Marius Tomaschewski <[email protected]> +Date: Tue Sep 13 18:44:03 2011 +0200 + + Fixed loop in autoconf bootstap script + +commit 22d5bc4861f00350e07e30091efcc9ffe1551f5a +Author: Marius Tomaschewski <[email protected]> +Date: Fri Sep 9 19:15:30 2011 +0200 + + Added interface array new and free helper functions + +commit 329370699a2c47f41f04e6f48ce80373b7543f31 +Author: Marius Tomaschewski <[email protected]> +Date: Fri Sep 9 14:06:12 2011 +0200 + + Fixed to check freopen return code and fail + +commit a84278676034a1a55ce09d3fdf26faa6b0f47eab +Author: Marius Tomaschewski <[email protected]> +Date: Fri Sep 9 11:17:11 2011 +0200 + + Fixed memory leak in netcf xml_from_interface + + Fixed netcf xml_from_interface to cleanup correctly when + construction of vlan,bond,bridge nodes fails and avoid + to append incomplete child nodes to the parent (if any). + +commit 19bda6e0a9d1b423a600660df42cadf3dbd43f70 +Author: Marius Tomaschewski <[email protected]> +Date: Fri Sep 9 10:58:12 2011 +0200 + + Added _node suffix to xml_node_replace_child + + Added a _node suffix to the xml_node_replace_child function name, + so it matches its arguments and another prototypes (detele,append). + +commit 4abac1803040502b643deac72ad7a20ea136193f +Author: Marius Tomaschewski <[email protected]> +Date: Fri Sep 9 10:57:18 2011 +0200 + + Added xml_node_append_child_node function + +commit c39b36f4694efe7229f8eb64acb334d4afa3bea6 +Author: Marius Tomaschewski <[email protected]> +Date: Thu Sep 8 19:07:28 2011 +0200 + + updated changes file + +commit d161f8e0b5e1729d644bf44367996bef5227e7ef +Author: Marius Tomaschewski <[email protected]> +Date: Thu Sep 8 19:06:34 2011 +0200 + + Include config.h to have _GNU_SOURCE defined + +commit 198963ba95a5d29d95777e40e18271a81ef9ab12 +Author: Marius Tomaschewski <[email protected]> +Date: Fri Aug 26 13:29:17 2011 +0200 + + updated changes file + +commit 18b9f198d39c66b78d54a21c82f7db929496f637 +Author: Marius Tomaschewski <[email protected]> +Date: Fri Aug 26 13:26:21 2011 +0200 + + increased version to 0.2.3, updated url + +commit 55dc5febf317489c0898e1fedc0d7e29c9eed1b2 +Author: Marius Tomaschewski <[email protected]> +Date: Fri Aug 26 13:25:02 2011 +0200 + + added baselibs.conf to git sources + +commit 154e455c9c0870e36d39d3ba84dc79ab5866b0f4 +Author: Marius Tomaschewski <[email protected]> +Date: Thu Aug 25 20:35:21 2011 +0200 + + Added GPL authorization note to spec file + + Added GPL authorization note to spec file + Added README and COPYING to libnetcontrol-devel doc file list + Removed obs <RELEASE0> placeholder, so a rpmbuild -ta works + +commit 5d0873ee61b90b4210e13d5969e6a5163df69b01 +Author: Marius Tomaschewski <[email protected]> +Date: Thu Aug 25 20:23:52 2011 +0200 + + added README and COPYING files + +commit d7e1751a38b72ab5f73537e157e42359aaea31fd +Author: Marius Tomaschewski <[email protected]> +Date: Thu Aug 25 20:21:18 2011 +0200 + + cleaned up copyrights and authorization notes + + Cleaned up copyright statements in source, header and other files, + added authorization notes about use of GPL code from wicked project + inside of the LGPL libnetcontrol library. + +commit ed073cd695440d0f7e62d70f4a935da0b32c5df4 +Author: Marius Tomaschewski <[email protected]> +Date: Tue Jul 12 11:44:48 2011 +0200 + + version 0.2.2, updated changes file + +commit 769265bbbf520b35c121197a18907d741e431290 +Author: Marius Tomaschewski <[email protected]> +Date: Tue Jul 12 11:41:18 2011 +0200 + + Use bus-id for bonding slave, vlan and infiniband fixes + +commit 4f5f3c179def8814720c475e811364ca1c6b6d1e +Author: Marius Tomaschewski <[email protected]> +Date: Tue Jul 12 11:41:03 2011 +0200 + + - Fixed / tweaked infiniband and vlan configuration + +commit b87b86c0a118738b00b944191330feee627606ef +Author: Marius Tomaschewski <[email protected]> +Date: Tue Jul 12 11:40:36 2011 +0200 + + Set close-on-exec flag on all files we open + +commit 11ce80b4772799a5230da3f0c2470f78bd98c4d1 +Author: Marius Tomaschewski <[email protected]> +Date: Tue Jul 12 11:39:52 2011 +0200 + + Set close-on-exec flag for all files we open + +commit fd00d02464a3e0dd49f293b97925abaf8f686308 +Author: Marius Tomaschewski <[email protected]> +Date: Tue Jul 12 11:38:51 2011 +0200 + + Utility to read interface bus-id from sysfs + +commit 8affcdf73c19eb6e56c4de1315b6d85d3b2e9f21 +Author: Marius Tomaschewski <[email protected]> +Date: Tue Jul 12 11:37:28 2011 +0200 + + Added bonding slave type flag + +commit d4f7132316bec86c1ebec304984f0bfd86c1836d +Author: Marius Tomaschewski <[email protected]> +Date: Tue Jul 12 11:36:30 2011 +0200 + + Added utility to rename file to a dot backup + +commit b25b4bbd332eb4d880076d17b4c57aa53c96b173 +Author: Marius Tomaschewski <[email protected]> +Date: Tue Jul 12 11:34:08 2011 +0200 + + Parse infiniband hwaddr, utility to compare hwaddrs + +commit db49330ca342f7df3f52f488f864cb824c1d6370 +Author: Marius Tomaschewski <[email protected]> +Date: Tue Jul 12 11:33:12 2011 +0200 + + Implemented udev rule hwaddr/bus-id update utils + +commit a97a56d118677aa2349360a80de5f34fc3a70c38 +Author: Marius Tomaschewski <[email protected]> +Date: Wed Jul 6 21:39:47 2011 +0200 + + version 0.2.1, fixing config modify actions + + fixed config modify (delete, configure) actions of depending + interfaces, implemented ifup and ifdown in backend, added + several checks and removed patch level from the API version. + +commit 51b2ef738e3401c27132613ad601e06abbfd4e1d +Author: Marius Tomaschewski <[email protected]> +Date: Mon Jul 4 09:28:42 2011 +0200 + + A first write-enabled version 0.2.0 + + Added a first, not yet complete implementation of ncf_define, + dummy hacks for ncf_undefine and if_up/if_down. + Added function to redirect log messages to a driver callback + allowing to redirected all logs e.g. to the libvirtd log. + +commit 45e6de3262f6cc65e11dcea29c89a73ac126e716 +Author: Marius Tomaschewski <[email protected]> +Date: Thu Jun 16 22:41:11 2011 +0200 + + - Initial import + +commit 27d01b0fb270a1f3f68cfe507fe42fbc250ee2de +Author: Marius Tomaschewski <[email protected]> +Date: Thu Jun 16 16:17:42 2011 +0200 + + Added .gitignore file diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/netcontrol-0.2.7/Makefile.am new/netcontrol-0.2.8/Makefile.am --- old/netcontrol-0.2.7/Makefile.am 2011-08-26 13:32:47.000000000 +0200 +++ new/netcontrol-0.2.8/Makefile.am 2013-03-26 15:12:45.000000000 +0100 @@ -14,3 +14,17 @@ EXTRA_DIST = netcontrol.changes netcontrol.spec baselibs.conf \ README COPYING.GPL COPYING.LGPL +dist-hook: $(distdir)/ChangeLog.git + +$(distdir)/ChangeLog.git: check-git-tool + @if [ -d $(top_srcdir)/.git ]; then \ + LANG=C git log -- $(top_srcdir) > $(distdir)/ChangeLog.git ; \ + fi + +check-git-tool: + @if ! git --version &>/dev/null ; then \ + echo 'ERROR: Unable to find the '\'git\'' version control client!'; \ + echo ' Please install git (git-core) and try again.' ; \ + exit 1 ; \ + fi >&2 + diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/netcontrol-0.2.7/Makefile.in new/netcontrol-0.2.8/Makefile.in --- old/netcontrol-0.2.7/Makefile.in 2013-01-25 10:45:47.000000000 +0100 +++ new/netcontrol-0.2.8/Makefile.in 2013-03-26 16:32:23.000000000 +0100 @@ -591,6 +591,9 @@ || exit 1; \ fi; \ done + $(MAKE) $(AM_MAKEFLAGS) \ + top_distdir="$(top_distdir)" distdir="$(distdir)" \ + dist-hook -test -n "$(am__skip_mode_fix)" \ || find "$(distdir)" -type d ! -perm -755 \ -exec chmod u+rwx,go+rx {} \; -o \ @@ -650,7 +653,7 @@ *.zip*) \ unzip $(distdir).zip ;;\ esac - chmod -R a-w $(distdir); chmod u+w $(distdir) + chmod -R a-w $(distdir); chmod a+w $(distdir) mkdir $(distdir)/_build mkdir $(distdir)/_inst chmod a-w $(distdir) @@ -833,8 +836,8 @@ all all-am am--refresh check check-am clean clean-cscope \ clean-generic clean-libtool cscope cscopelist \ cscopelist-recursive ctags ctags-recursive dist dist-all \ - dist-bzip2 dist-gzip dist-lzip dist-shar dist-tarZ dist-xz \ - dist-zip distcheck distclean distclean-generic \ + dist-bzip2 dist-gzip dist-hook dist-lzip dist-shar dist-tarZ \ + dist-xz dist-zip distcheck distclean distclean-generic \ distclean-libtool distclean-tags distcleancheck distdir \ distuninstallcheck dvi dvi-am html html-am info info-am \ install install-am install-data install-data-am install-dvi \ @@ -848,6 +851,20 @@ uninstall uninstall-am uninstall-pkgconfigDATA +dist-hook: $(distdir)/ChangeLog.git + +$(distdir)/ChangeLog.git: check-git-tool + @if [ -d $(top_srcdir)/.git ]; then \ + LANG=C git log -- $(top_srcdir) > $(distdir)/ChangeLog.git ; \ + fi + +check-git-tool: + @if ! git --version &>/dev/null ; then \ + echo 'ERROR: Unable to find the '\'git\'' version control client!'; \ + echo ' Please install git (git-core) and try again.' ; \ + exit 1 ; \ + fi >&2 + # Tell versions [3.59,3.63) of GNU make to not export all variables. # Otherwise a system limit (for SysV at least) may be exceeded. .NOEXPORT: diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/netcontrol-0.2.7/aclocal.m4 new/netcontrol-0.2.8/aclocal.m4 --- old/netcontrol-0.2.7/aclocal.m4 2013-01-25 10:45:45.000000000 +0100 +++ new/netcontrol-0.2.8/aclocal.m4 2013-03-26 16:32:21.000000000 +0100 @@ -8634,7 +8634,8 @@ # ---------------------------------- AC_DEFUN([PKG_PROG_PKG_CONFIG], [m4_pattern_forbid([^_?PKG_[A-Z_]+$]) -m4_pattern_allow([^PKG_CONFIG(_PATH)?$]) +m4_pattern_allow([^PKG_CONFIG(_(PATH|LIBDIR|SYSROOT_DIR|ALLOW_SYSTEM_(CFLAGS|LIBS)))?$]) +m4_pattern_allow([^PKG_CONFIG_(DISABLE_UNINSTALLED|TOP_BUILD_DIR|DEBUG_SPEW)$]) AC_ARG_VAR([PKG_CONFIG], [path to pkg-config utility]) AC_ARG_VAR([PKG_CONFIG_PATH], [directories to add to pkg-config's search path]) AC_ARG_VAR([PKG_CONFIG_LIBDIR], [path overriding pkg-config's built-in search path]) @@ -8680,7 +8681,8 @@ pkg_cv_[]$1="$$1" elif test -n "$PKG_CONFIG"; then PKG_CHECK_EXISTS([$3], - [pkg_cv_[]$1=`$PKG_CONFIG --[]$2 "$3" 2>/dev/null`], + [pkg_cv_[]$1=`$PKG_CONFIG --[]$2 "$3" 2>/dev/null` + test "x$?" != "x0" && pkg_failed=yes ], [pkg_failed=yes]) else pkg_failed=untried @@ -8728,9 +8730,9 @@ AC_MSG_RESULT([no]) _PKG_SHORT_ERRORS_SUPPORTED if test $_pkg_short_errors_supported = yes; then - $1[]_PKG_ERRORS=`$PKG_CONFIG --short-errors --print-errors "$2" 2>&1` + $1[]_PKG_ERRORS=`$PKG_CONFIG --short-errors --print-errors --cflags --libs "$2" 2>&1` else - $1[]_PKG_ERRORS=`$PKG_CONFIG --print-errors "$2" 2>&1` + $1[]_PKG_ERRORS=`$PKG_CONFIG --print-errors --cflags --libs "$2" 2>&1` fi # Put the nasty error message in config.log where it belongs echo "$$1[]_PKG_ERRORS" >&AS_MESSAGE_LOG_FD @@ -8764,6 +8766,46 @@ fi[]dnl ])# PKG_CHECK_MODULES + +# PKG_INSTALLDIR(DIRECTORY) +# ------------------------- +# Substitutes the variable pkgconfigdir as the location where a module +# should install pkg-config .pc files. By default the directory is +# $libdir/pkgconfig, but the default can be changed by passing +# DIRECTORY. The user can override through the --with-pkgconfigdir +# parameter. +AC_DEFUN([PKG_INSTALLDIR], +[m4_pushdef([pkg_default], [m4_default([$1], ['${libdir}/pkgconfig'])]) +m4_pushdef([pkg_description], + [pkg-config installation directory @<:@]pkg_default[@:>@]) +AC_ARG_WITH([pkgconfigdir], + [AS_HELP_STRING([--with-pkgconfigdir], pkg_description)],, + [with_pkgconfigdir=]pkg_default) +AC_SUBST([pkgconfigdir], [$with_pkgconfigdir]) +m4_popdef([pkg_default]) +m4_popdef([pkg_description]) +]) dnl PKG_INSTALLDIR + + +# PKG_NOARCH_INSTALLDIR(DIRECTORY) +# ------------------------- +# Substitutes the variable noarch_pkgconfigdir as the location where a +# module should install arch-independent pkg-config .pc files. By +# default the directory is $datadir/pkgconfig, but the default can be +# changed by passing DIRECTORY. The user can override through the +# --with-noarch-pkgconfigdir parameter. +AC_DEFUN([PKG_NOARCH_INSTALLDIR], +[m4_pushdef([pkg_default], [m4_default([$1], ['${datadir}/pkgconfig'])]) +m4_pushdef([pkg_description], + [pkg-config arch-independent installation directory @<:@]pkg_default[@:>@]) +AC_ARG_WITH([noarch-pkgconfigdir], + [AS_HELP_STRING([--with-noarch-pkgconfigdir], pkg_description)],, + [with_noarch_pkgconfigdir=]pkg_default) +AC_SUBST([noarch_pkgconfigdir], [$with_noarch_pkgconfigdir]) +m4_popdef([pkg_default]) +m4_popdef([pkg_description]) +]) dnl PKG_NOARCH_INSTALLDIR + # Copyright (C) 2002-2012 Free Software Foundation, Inc. # # This file is free software; the Free Software Foundation diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/netcontrol-0.2.7/configure new/netcontrol-0.2.8/configure --- old/netcontrol-0.2.7/configure 2013-01-25 10:45:46.000000000 +0100 +++ new/netcontrol-0.2.8/configure 2013-03-26 16:32:21.000000000 +0100 @@ -1,6 +1,6 @@ #! /bin/sh # Guess values for system-dependent variables and create Makefiles. -# Generated by GNU Autoconf 2.69 for netcontrol 0.2.7. +# Generated by GNU Autoconf 2.69 for netcontrol 0.2.8. # # Report bugs to <[email protected]>. # @@ -590,8 +590,8 @@ # Identity of this package. PACKAGE_NAME='netcontrol' PACKAGE_TARNAME='netcontrol' -PACKAGE_VERSION='0.2.7' -PACKAGE_STRING='netcontrol 0.2.7' +PACKAGE_VERSION='0.2.8' +PACKAGE_STRING='netcontrol 0.2.8' PACKAGE_BUGREPORT='[email protected]' PACKAGE_URL='http://www.suse.de/~mt/git/netcontrol.git/' @@ -768,6 +768,7 @@ with_gnu_ld with_sysroot enable_libtool_lock +enable_pthreads enable_network_service ' ac_precious_vars='build_alias @@ -1324,7 +1325,7 @@ # Omit some internal or obsolete options to make the list less imposing. # This message is too long to be a string in the A/UX 3.1 sh. cat <<_ACEOF -\`configure' configures netcontrol 0.2.7 to adapt to many kinds of systems. +\`configure' configures netcontrol 0.2.8 to adapt to many kinds of systems. Usage: $0 [OPTION]... [VAR=VALUE]... @@ -1394,7 +1395,7 @@ if test -n "$ac_init_help"; then case $ac_init_help in - short | recursive ) echo "Configuration of netcontrol 0.2.7:";; + short | recursive ) echo "Configuration of netcontrol 0.2.8:";; esac cat <<\_ACEOF @@ -1411,6 +1412,7 @@ --enable-fast-install[=PKGS] optimize for fast installation [default=yes] --disable-libtool-lock avoid locking (might break parallel builds) + --disable-pthreads Disable pthread detection and use [default=auto] --enable-network-service Check systemd network.service alias link @@ -1508,7 +1510,7 @@ test -n "$ac_init_help" && exit $ac_status if $ac_init_version; then cat <<\_ACEOF -netcontrol configure 0.2.7 +netcontrol configure 0.2.8 generated by GNU Autoconf 2.69 Copyright (C) 2012 Free Software Foundation, Inc. @@ -1931,7 +1933,7 @@ This file contains any messages produced by compilers while running configure, to aid debugging if configure makes a mistake. -It was created by netcontrol $as_me 0.2.7, which was +It was created by netcontrol $as_me 0.2.8, which was generated by GNU Autoconf 2.69. Invocation command line was $ $0 $@ @@ -2755,7 +2757,7 @@ # Define the identity of the package. PACKAGE='netcontrol' - VERSION='0.2.7' + VERSION='0.2.8' cat >>confdefs.h <<_ACEOF @@ -2803,7 +2805,7 @@ VERSION_API=${VERSION%.*} -LIBNETCONTROL_VERSION_INFO=2:7:2 +LIBNETCONTROL_VERSION_INFO=2:8:2 DEPDIR="${am__leading_dot}deps" @@ -12102,7 +12104,13 @@ -# Check for posix thread support. +# Check whether --enable-pthreads was given. +if test "${enable_pthreads+set}" = set; then : + enableval=$enable_pthreads; +fi + +if test "X$enable_pthreads" != "Xno" ; then + # Check for posix thread support. ac_ext=c @@ -12472,9 +12480,7 @@ # Finally, execute ACTION-IF-FOUND/ACTION-IF-NOT-FOUND: if test x"$ax_pthread_ok" = xyes; then - LIBS="${PTHREAD_LIBS}${LIBS:+ $LIBS}" - CFLAGS="${CFLAGS}${PTHREAD_CFLAGS:+ $PTHREAD_CFLAGS}" - if test "x${PTHREAD_CC}" != x; then CC="${PTHREAD_CC}" ; fi +$as_echo "#define HAVE_PTHREAD 1" >>confdefs.h : else @@ -12488,6 +12494,17 @@ ac_compiler_gnu=$ac_cv_c_compiler_gnu +fi +# Note: AX_PTHREAD action-if-found defines HAVE_PTHREAD, +# except we provide own action that overrides it. +if test "X$ax_pthread_ok" = "Xyes" ; then + LIBS="${PTHREAD_LIBS}${LIBS:+ $LIBS}" + CFLAGS="${CFLAGS}${PTHREAD_CFLAGS:+ $PTHREAD_CFLAGS}" + if test "x${PTHREAD_CC}" != x; then CC="${PTHREAD_CC}" ; fi +elif test "X$enable_pthreads" = "Xyes" ; then + as_fn_error $? "unable to detect pthread support" "$LINENO" 5 +fi + @@ -12622,6 +12639,7 @@ $as_echo "$as_me:${as_lineno-$LINENO}: \$? = $ac_status" >&5 test $ac_status = 0; }; then pkg_cv_LIBNL_CFLAGS=`$PKG_CONFIG --cflags "libnl-1" 2>/dev/null` + test "x$?" != "x0" && pkg_failed=yes else pkg_failed=yes fi @@ -12638,6 +12656,7 @@ $as_echo "$as_me:${as_lineno-$LINENO}: \$? = $ac_status" >&5 test $ac_status = 0; }; then pkg_cv_LIBNL_LIBS=`$PKG_CONFIG --libs "libnl-1" 2>/dev/null` + test "x$?" != "x0" && pkg_failed=yes else pkg_failed=yes fi @@ -12657,9 +12676,9 @@ _pkg_short_errors_supported=no fi if test $_pkg_short_errors_supported = yes; then - LIBNL_PKG_ERRORS=`$PKG_CONFIG --short-errors --print-errors "libnl-1" 2>&1` + LIBNL_PKG_ERRORS=`$PKG_CONFIG --short-errors --print-errors --cflags --libs "libnl-1" 2>&1` else - LIBNL_PKG_ERRORS=`$PKG_CONFIG --print-errors "libnl-1" 2>&1` + LIBNL_PKG_ERRORS=`$PKG_CONFIG --print-errors --cflags --libs "libnl-1" 2>&1` fi # Put the nasty error message in config.log where it belongs echo "$LIBNL_PKG_ERRORS" >&5 @@ -13724,7 +13743,7 @@ # report actual input values of CONFIG_FILES etc. instead of their # values after options handling. ac_log=" -This file was extended by netcontrol $as_me 0.2.7, which was +This file was extended by netcontrol $as_me 0.2.8, which was generated by GNU Autoconf 2.69. Invocation command line was CONFIG_FILES = $CONFIG_FILES @@ -13791,7 +13810,7 @@ cat >>$CONFIG_STATUS <<_ACEOF || ac_write_fail=1 ac_cs_config="`$as_echo "$ac_configure_args" | sed 's/^ //; s/[\\""\`\$]/\\\\&/g'`" ac_cs_version="\\ -netcontrol config.status 0.2.7 +netcontrol config.status 0.2.8 configured by $0, generated by GNU Autoconf 2.69, with options \\"\$ac_cs_config\\" diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/netcontrol-0.2.7/configure.ac new/netcontrol-0.2.8/configure.ac --- old/netcontrol-0.2.7/configure.ac 2013-01-25 10:44:59.000000000 +0100 +++ new/netcontrol-0.2.8/configure.ac 2013-03-26 16:00:26.000000000 +0100 @@ -2,7 +2,7 @@ # Process this file with autoconf to produce a configure script. AC_PREREQ([2.63]) -AC_INIT([netcontrol], [0.2.7], [[email protected]], [], +AC_INIT([netcontrol], [0.2.8], [[email protected]], [], [http://www.suse.de/~mt/git/netcontrol.git/]) AM_INIT_AUTOMAKE([foreign dist-bzip2 no-dist-gzip]) AC_CONFIG_SRCDIR([src/nctest.c]) @@ -10,7 +10,7 @@ AC_PREFIX_DEFAULT(/usr) AC_SUBST([VERSION_API], [${VERSION%.*}]) -AC_SUBST([LIBNETCONTROL_VERSION_INFO], [2:7:2]) +AC_SUBST([LIBNETCONTROL_VERSION_INFO], [2:8:2]) AC_USE_SYSTEM_EXTENSIONS @@ -21,12 +21,21 @@ AC_PROG_INSTALL AC_PROG_LIBTOOL -# Check for posix thread support. -AX_PTHREAD([ +AC_ARG_ENABLE([pthreads], [AS_HELP_STRING([--disable-pthreads], + [Disable pthread detection and use [default=auto]])]) +if test "X$enable_pthreads" != "Xno" ; then + # Check for posix thread support. + AX_PTHREAD +fi +# Note: AX_PTHREAD action-if-found defines HAVE_PTHREAD, +# except we provide own action that overrides it. +if test "X$ax_pthread_ok" = "Xyes" ; then LIBS="${PTHREAD_LIBS}${LIBS:+ $LIBS}" CFLAGS="${CFLAGS}${PTHREAD_CFLAGS:+ $PTHREAD_CFLAGS}" if test "x${PTHREAD_CC}" != x; then CC="${PTHREAD_CC}" ; fi -]) +elif test "X$enable_pthreads" = "Xyes" ; then + AC_MSG_ERROR([unable to detect pthread support]) +fi PKG_CHECK_MODULES([LIBNL], [libnl-1]) AC_ARG_ENABLE(network-service, diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/netcontrol-0.2.7/netcontrol.changes new/netcontrol-0.2.8/netcontrol.changes --- old/netcontrol-0.2.7/netcontrol.changes 2013-01-25 10:44:59.000000000 +0100 +++ new/netcontrol-0.2.8/netcontrol.changes 2013-03-26 16:01:12.000000000 +0100 @@ -1,4 +1,19 @@ ------------------------------------------------------------------- +Tue Mar 26 15:01:02 UTC 2013 - [email protected] + +- version 0.2.8 +- Added ChangeLog.git to dist archive and to devel package docs. +- Fixed ncf_close to not close logger as ncf_init did not open any. + This caused SEGV's in libvirt, that redirects the global logger + to itself and is using multiple ncf instances (bnc#811002). +- Fixed pthreads detection and source enablement in configure, + added an explicit configure --enable-pthreads option to spec + file to cause a failure on detection problems (bnc#811002). +- Fixed SEGV at parsing not existing BRIDGE_PATHCOSTS and memory + leaks in in loop check, xml parsing and on backup file creation + failure while routes file rewrite (bnc#810381). + +------------------------------------------------------------------- Fri Jan 25 09:39:55 UTC 2013 - [email protected] - version 0.2.7 diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/netcontrol-0.2.7/netcontrol.spec new/netcontrol-0.2.8/netcontrol.spec --- old/netcontrol-0.2.7/netcontrol.spec 2013-01-25 10:45:51.000000000 +0100 +++ new/netcontrol-0.2.8/netcontrol.spec 2013-03-26 16:32:26.000000000 +0100 @@ -1,7 +1,7 @@ # # spec file for package netcontrol # -# Copyright (c) 2011 SUSE LINUX Products GmbH, Nuernberg, Germany. +# Copyright (c) 2013 SUSE LINUX Products GmbH, Nuernberg, Germany. # # All modifications and additions to the file contributed by third parties # remain the property of their copyright owners, unless otherwise agreed @@ -16,7 +16,7 @@ # Name: netcontrol -Version: 0.2.7 +Version: 0.2.8 Release: 0 Summary: A network configuration library License: LGPL-2.1+ @@ -97,8 +97,9 @@ export CFLAGS="-W -Wall $RPM_OPT_FLAGS" %configure \ %if 0%{?suse_version} >= 1230 - --enable-network-service \ + --enable-network-service \ %endif + --enable-pthreads \ --disable-static make %{?_smp_mflags} @@ -118,7 +119,7 @@ %files -n libnetcontrol-devel %defattr(-,root,root,-) -%doc README COPYING.LGPL COPYING.GPL +%doc README COPYING.LGPL COPYING.GPL ChangeLog.git %{_libdir}/*.so %{_includedir}/* %{_datadir}/pkgconfig/netcontrol.pc diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/netcontrol-0.2.7/netcontrol.spec.in new/netcontrol-0.2.8/netcontrol.spec.in --- old/netcontrol-0.2.7/netcontrol.spec.in 2013-01-25 10:05:58.000000000 +0100 +++ new/netcontrol-0.2.8/netcontrol.spec.in 2013-03-26 15:33:51.000000000 +0100 @@ -1,7 +1,7 @@ # # spec file for package netcontrol # -# Copyright (c) 2011 SUSE LINUX Products GmbH, Nuernberg, Germany. +# Copyright (c) 2013 SUSE LINUX Products GmbH, Nuernberg, Germany. # # All modifications and additions to the file contributed by third parties # remain the property of their copyright owners, unless otherwise agreed @@ -97,8 +97,9 @@ export CFLAGS="-W -Wall $RPM_OPT_FLAGS" %configure \ %if 0%{?suse_version} >= 1230 - --enable-network-service \ + --enable-network-service \ %endif + --enable-pthreads \ --disable-static make %{?_smp_mflags} @@ -118,7 +119,7 @@ %files -n libnetcontrol-devel %defattr(-,root,root,-) -%doc README COPYING.LGPL COPYING.GPL +%doc README COPYING.LGPL COPYING.GPL ChangeLog.git %{_libdir}/*.so %{_includedir}/* %{_datadir}/pkgconfig/netcontrol.pc diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/netcontrol-0.2.7/src/backend-suse.c new/netcontrol-0.2.8/src/backend-suse.c --- old/netcontrol-0.2.7/src/backend-suse.c 2013-01-25 10:44:59.000000000 +0100 +++ new/netcontrol-0.2.8/src/backend-suse.c 2013-03-26 15:33:51.000000000 +0100 @@ -2,7 +2,7 @@ * Translation between internal representation and SUSE ifcfg files * * Copyright (C) 2009, 2010 Olaf Kirch <[email protected]> - * Copyright (C) 2011 SUSE LINUX Products GmbH, Nuernberg, Germany. + * Copyright (C) 2011-2013 SUSE LINUX Products GmbH, Nuernberg, Germany. * * This program is free software; you can redistribute it and/or modify * it under the terms of the GNU General Public License as published by @@ -1173,7 +1173,7 @@ } nc_string_free(&value); } - if (nc_sysconfig_get_string(sc, "BRIDGE_PATHCOSTS", &value) >= 0) { + if (nc_sysconfig_get_string(sc, "BRIDGE_PATHCOSTS", &value) == 0) { char *p = NULL; unsigned int i = 0; for (token = strtok_r(value, " \t", &p); @@ -3041,7 +3041,7 @@ (nc_make_dot_suffix(&old_path, file_name.string, dot_backup) < 0)) { nc_error("Unable to apply a backup suffix to filename: %s", file_name.string); - return -1; + goto failure; } fd = mkstemp(tmp_path.string); diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/netcontrol-0.2.7/src/netcf-xml.c new/netcontrol-0.2.8/src/netcf-xml.c --- old/netcontrol-0.2.7/src/netcf-xml.c 2012-07-03 12:59:29.000000000 +0200 +++ new/netcontrol-0.2.8/src/netcf-xml.c 2013-03-26 15:33:51.000000000 +0100 @@ -2,7 +2,7 @@ * Translation between internal representation and netcf XML * * Copyright (C) 2010 Olaf Kirch <[email protected]> - * Copyright (C) 2011 SUSE LINUX Products GmbH, Nuernberg, Germany. + * Copyright (C) 2011-2013 SUSE LINUX Products GmbH, Nuernberg, Germany. * * This program is free software; you can redistribute it and/or modify * it under the terms of the GNU General Public License as published by @@ -327,10 +327,12 @@ } if(nc_interface_array_index_by_name(guard, ifname) != -1) { nc_error("recursive loop in interface chain: %s", buf.string); + nc_stringbuf_destroy(&buf); return 1; } else { nc_debug_netcf("interface chain: %s", buf.string ? buf.string : ifname); + nc_stringbuf_destroy(&buf); return 0; } } @@ -714,6 +716,8 @@ xml_node_add_attr(routenode, "gateway", gway.string); } + nc_stringbuf_destroy(&dest); + nc_stringbuf_destroy(&gway); return 0; failure: nc_stringbuf_destroy(&dest); @@ -819,6 +823,8 @@ dest.string, rp->prefixlen, gway.string, (rp->nh.device ? "dev " : ""), (rp->nh.device ? rp->nh.device : "")); + nc_stringbuf_destroy(&dest); + nc_stringbuf_destroy(&gway); } #endif } diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/netcontrol-0.2.7/src/netcf.c new/netcontrol-0.2.8/src/netcf.c --- old/netcontrol-0.2.7/src/netcf.c 2012-07-03 12:59:20.000000000 +0200 +++ new/netcontrol-0.2.8/src/netcf.c 2013-03-26 15:33:51.000000000 +0100 @@ -2,7 +2,7 @@ * This file implements a netcf interface * * Copyright (C) 2010 Olaf Kirch <[email protected]> - * Copyright (C) 2011 SUSE LINUX Products GmbH, Nuernberg, Germany. + * Copyright (C) 2011-2013 SUSE LINUX Products GmbH, Nuernberg, Germany. * * This library is free software; you can redistribute it and/or * modify it under the terms of the GNU Lesser General Public @@ -158,7 +158,6 @@ memset(ncf, 0, sizeof(*ncf)); free(ncf); } - nc_logger_close(); return 0; } -- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
