Hello community, here is the log from the commit of package ddclient for openSUSE:Factory checked in at 2013-05-27 09:44:18 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Comparing /work/SRC/openSUSE:Factory/ddclient (Old) and /work/SRC/openSUSE:Factory/.ddclient.new (New) ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Package is "ddclient" Changes: -------- --- /work/SRC/openSUSE:Factory/ddclient/ddclient.changes 2013-05-16 09:49:20.000000000 +0200 +++ /work/SRC/openSUSE:Factory/.ddclient.new/ddclient.changes 2013-05-27 09:44:19.000000000 +0200 @@ -1,0 +2,9 @@ +Thu May 16 13:23:40 UTC 2013 - [email protected] + +- more init-script fixes: + - startproc now needs the pidfile parameter (or it woulld look + for "perl.pid". Sorry, should have run more tests. + - while I'm at it, get the pidfile from the config file in case + the user would have changed it + +------------------------------------------------------------------- ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Other differences: ------------------ ++++++ rc.ddclient ++++++ --- /var/tmp/diff_new_pack.sMD8zG/_old 2013-05-27 09:44:20.000000000 +0200 +++ /var/tmp/diff_new_pack.sMD8zG/_new 2013-05-27 09:44:20.000000000 +0200 @@ -42,6 +42,10 @@ else dd_use="-use=if -if ppp0" fi +# extract pid= from config, strip trailing comments and trailing whitespace... +pid_file=`sed -n '/^pid=/{s@#.*$@@;s@[[:space:]]*$@@;s@^pid=@@;p}' /etc/ddclient.conf` +# default is /var/run/ddclient.pid +[ -z "$pid_file" ] && pid_file=/var/run/ddclient.pid # Shell functions sourced from /etc/rc.status: # rc_check check and set local and overall rc status @@ -77,14 +81,14 @@ echo -n "Starting ddclient daemon :" # startproc does check the name of the binary, and this is "perl" in this case, # so better start it this way or systemd will not know it is running - /sbin/startproc /usr/bin/perl "$DDCLIENT_BIN" -daemon $dd_intervall "$dd_use" $DDCLIENT_OPTIONS -pid /var/run/ddclient.pid + /sbin/startproc -p $pid_file /usr/bin/perl "$DDCLIENT_BIN" -daemon $dd_intervall "$dd_use" $DDCLIENT_OPTIONS -pid $pid_file # remember status and be verbose rc_status -v ;; stop) echo -n "Shutting down ddclient daemon :" - /sbin/killproc -p /var/run/ddclient.pid -TERM /usr/bin/perl + /sbin/killproc -p $pid_file -TERM /usr/bin/perl # remember status and be verbose rc_status -v @@ -117,7 +121,7 @@ ;; status) echo -n "Checking for service ddclient :" - /sbin/checkproc -p /var/run/ddclient.pid /usr/bin/perl + /sbin/checkproc -p $pid_file /usr/bin/perl # remember status and be verbose rc_status -v -- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
