Hello community, here is the log from the commit of package taglib.1811 for openSUSE:12.3:Update checked in at 2013-07-03 11:24:20 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Comparing /work/SRC/openSUSE:12.3:Update/taglib.1811 (Old) and /work/SRC/openSUSE:12.3:Update/.taglib.1811.new (New) ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Package is "taglib.1811" Changes: -------- New Changes file: --- /dev/null 2013-07-02 09:26:14.908030755 +0200 +++ /work/SRC/openSUSE:12.3:Update/.taglib.1811.new/taglib.changes 2013-07-03 11:24:21.000000000 +0200 @@ -0,0 +1,437 @@ +------------------------------------------------------------------- +Mon Jun 24 17:41:56 UTC 2013 - [email protected] + +- Added-check-if-file-is-open-before-attempting-to-rea.patch: Added + check if file is open before attempting to read tags (bnc#826228) + +------------------------------------------------------------------- +Fri May 24 12:24:27 UTC 2013 - [email protected] + +- Added taglib-1.8-ds-rusxmms-r9.patch and deleted + taglib-1.8-ds-rusxmms-r8.patch to fix the reopened bnc#814814 + +------------------------------------------------------------------- +Fri Apr 26 17:19:29 UTC 2013 - [email protected] + +- Added taglib-1.8-ds-rusxmms-r8.patch which fixes bnc#814814 where + non russian text was corrupted in tags. +- Removed old taglib-1.8-ds-rusxmms-r2.patch +- Added built binary examples which manipulate tags from the + command line to enable easier testing of libtag. These are in the + taglib rpm. +- Created taglib-1.8-strip-rpath.patch to remove rpath from binaries. + +------------------------------------------------------------------- +Mon Feb 4 19:50:45 UTC 2013 - [email protected] + +- Replace taglib-1.6-ds-rusxmms.patch with + taglib-1.8-ds-rusxmms-r2.patch: Update rusxmms patch to also work + with non-Russian locale (bnc#780256). + +------------------------------------------------------------------- +Mon Feb 4 19:50:45 UTC 2013 - [email protected] + +- Update rusxmms patch to version taglib-1.8-ds-rusxmms-r2 in order to fix bnc#780256 + +------------------------------------------------------------------- +Fri Feb 1 18:54:07 UTC 2013 - [email protected] + +- update license to new format + +------------------------------------------------------------------- +Thu Nov 8 04:49:38 UTC 2012 - [email protected] + +- Add patch taglib-1.8-version_fix.patch: fix version defines + in taglib.h + +------------------------------------------------------------------- +Thu Sep 13 10:11:52 UTC 2012 - [email protected] + +- Update to 1.8 + * Added support for OWNE ID3 frames. + * Changed key validation in the new PropertyMap API. + * ID3v1::Tag::setStringHandler will no londer delete the previous handler, the caller is responsible for this. + * File objects will also no longer delete the passed IOStream objects. It should be done in the caller code after the File object is no longer used. + * Added ID3v2::Tag::setLatin1StringHandler for custom handling of latin1-encoded text in ID3v2 frames. + * Fixed validation of ID3v2 frame IDs (IDs with ‘0’ were ignored). + * New API for accessing tags by name. + * New abstract I/O stream layer to allow custom I/O handlers. + * Support for writing ID3v2.3 tags. + * Support for various module file formats (MOD, S3M, IT, XM). + * Support for MP4 and ASF is now enabled by default. + * Started using atomic int operations for reference counting. + * Added methods for checking if WMA and MP4 files are DRM-protected. + * Added taglib_free to the C bindings. + * New method to allow removing pictures from FLAC files. + * Support for reading audio properties from ALAC and Musepack SV8 files. + * Added replay-gain information to Musepack audio properties. + * Support for APEv2 binary tags. + * Many AudioProperties subclasses now provide information about the total number of samples. + * Various small bug fixes. +- Drop taglib-noansiflags.patch (no longer relevant) + +------------------------------------------------------------------- +Fri May 11 10:22:59 UTC 2012 - [email protected] + +-Update to 1.7.2: + * Fixed division by zero while parsing corrupted MP4 files (CVE-2012-2396). + * Fixed compilation on Haiku. + * Improved parsing of corrupted WMA, RIFF and OGG files. + * Fixed a memory leak in the WMA parser. + * Fixed a memory leak in the FLAC parser. + * Fixed a possible division by zero in the APE parser. + * Added detection of TTA2 files. + * Fixed saving of multiple identically named tags to Vorbis Comments. +-Fixed a build failure related to doxygen. + +------------------------------------------------------------------- +Thu May 10 01:51:54 UTC 2012 - [email protected] + +- Also, define GNU_SOURCE + +------------------------------------------------------------------- +Thu May 10 01:11:38 UTC 2012 - [email protected] + +- No dont use -ansi gcc flag. + +------------------------------------------------------------------- +Thu Mar 8 01:01:13 YEKT 2012 - [email protected] + +- Add rusxmms patch to be fixed https://features.opensuse.org/313273 + +------------------------------------------------------------------- +Sat May 28 07:03:00 UTC 2011 - [email protected] + +- Made taglib become a package again to satisfy the depencies of + packages that still require it. + +------------------------------------------------------------------- +Sat May 28 04:31:40 UTC 2011 - [email protected] + +- Conflict the last version of taglib that contained the libraries + from the library subpackages. +- Make sure the devel package obsoletes the last version of + taglib-devel where the main package contained the libraries. +- taglib is the name of the srcrpm, moved docs to devel subpackage. + +------------------------------------------------------------------- +Wed May 25 14:19:41 UTC 2011 - [email protected] + +- obsolete the right version of taglib + +------------------------------------------------------------------- +Sun May 22 22:29:07 UTC 2011 - [email protected] + +- make taglib become a package again, that has only one duty, to require + libtag1 and libtag_c0 for packages that still require taglib instead of + the new package names libtag1 and libtag_c0 + +------------------------------------------------------------------- +Tue May 17 20:55:51 UTC 2011 - [email protected] + +- Update to version 1.7: + * Fixed memory leaks in the FLAC file format parser. + * Fixed bitrate calculation for WAV files. + From 1.7 RC1 + * Support for reading/writing tags from Monkey's Audio files. (BUG:210404) + * Support for reading/writing embedded pictures from WMA files. + * Support for reading/writing embedded pictures from FLAC files (BUG:218696). + * Implemented APE::Tag::isEmpty() to check for all APE tags, not just the + basic ones. + * Added reading of WAV audio length. (BUG:116033) + * Exposed FLAC MD5 signature of the uncompressed audio stream via + FLAC::Properties::signature(). (BUG:160172) + * Added function ByteVector::toHex() for hex-encoding of byte vectors. + * WavPack reader now tries to get the audio length by finding the final + block, if the header doesn't have the information. (BUG:258016) + * Fixed a memory leak in the ID3v2.2 PIC frame parser. (BUG:257007) + * Fixed writing of RIFF files with even chunk sizes. (BUG:243954) + * Fixed compilation on MSVC 2010. + * Removed support for building using autoconf/automake. + * API docs can be now built using "make docs". +- Spec file updates: + * Changes based on openSUSE shared library packaging policy (added libtag1, + libtag_c0 and libtag-devel packages, removed taglib and taglib-devel + packages). + * Changes based on spec-cleaner run. + * Changed License: to LGPLv2.1+ ; MPLv1.1 .. + * Updates in Group, Summary and %description entries. + * Added libcppunit-devel and pkg-config in BuildRequires. + * Minor other updates. +- Updated taglib.desktop for susehelp to point to libtag-devel. + +------------------------------------------------------------------- +Sat Feb 26 14:24:48 UTC 2011 - [email protected] + +- update to version 1.6.3 + * Fixed definitions of the TAGLIB_WITH_MP4 and TAGLIB_WITH_ASF macros. + * Fixed upgrading of ID3v2.3 genre frame with ID3v1 code 0 (Blues). + * New method `int String::toInt(bool *ok)` which can return whether the conversion to a number was successful. + * Fixed parsing of incorrectly written lengths in ID3v2 (affects mainly compressed frames). + + +------------------------------------------------------------------- +Sun Apr 11 17:07:36 UTC 2010 - [email protected] + +- update to version 1.6.2 + * Read Vorbis Comments from the first FLAC metadata block, + if there are multipe ones. + * Fixed a memory leak in FileRef's OGA format detection. + * Fixed compilation with the Sun Studio compiler. + * Handle WM/TrackNumber attributes with DWORD content in WMA files. + * More strict check if something is a valid MP4 file. + * Correctly save MP4 int-pair atoms with flags set to 0. + * Fixed compilation of the test runner on Windows. + * Store ASF attributes larger than 64k in the metadata library object. + * Ignore trailing non-data atoms when parsing MP4 covr atoms. + * Don't upgrade ID3v2.2 frame TDA to TDRC. + +------------------------------------------------------------------- +Mon Feb 1 12:33:03 UTC 2010 - [email protected] + +- Package baselibs.conf + +------------------------------------------------------------------- +Tue Nov 3 23:21:25 UTC 2009 - [email protected] + +- Update to version 1.6.1 ++++ 240 more lines (skipped) ++++ between /dev/null ++++ and /work/SRC/openSUSE:12.3:Update/.taglib.1811.new/taglib.changes New: ---- Added-check-if-file-is-open-before-attempting-to-rea.patch baselibs.conf taglib-1.7.2-doxygen.patch taglib-1.8-ds-rusxmms-r9.patch taglib-1.8-strip-rpath.patch taglib-1.8-version_fix.patch taglib-1.8.tar.gz taglib.changes taglib.desktop taglib.spec ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Other differences: ------------------ ++++++ taglib.spec ++++++ # # spec file for package taglib # # Copyright (c) 2013 SUSE LINUX Products GmbH, Nuernberg, Germany. # # All modifications and additions to the file contributed by third parties # remain the property of their copyright owners, unless otherwise agreed # upon. The license for this file, and modifications and additions to the # file, is the same license as for the pristine package itself (unless the # license for the pristine package is not an Open Source License, in which # case the license is the MIT License). An "Open Source License" is a # license that conforms to the Open Source Definition (Version 1.9) # published by the Open Source Initiative. # Please submit bugfixes or comments via http://bugs.opensuse.org/ # Name: taglib Version: 1.8 Release: 0 Summary: Audio Meta-Data Library License: LGPL-2.1+ and MPL-1.1 Group: Productivity/Multimedia/Other Url: http://ktown.kde.org/~wheeler/taglib/ Source0: https://github.com/downloads/taglib/taglib/%{name}-%{version}.tar.gz Source1: %{name}.desktop Source100: baselibs.conf # This patch is to fix bnc#814814 and enables russian users to display Cryllics text correctly. Patch0: taglib-1.8-ds-rusxmms-r9.patch Patch1: taglib-1.7.2-doxygen.patch # PATCH-FIX-UPSTREAM taglib-1.8-version_fix.patch - fix version defines in taglib.h Patch2: taglib-1.8-version_fix.patch # Get example executables to build without rpath Patch3: taglib-1.8-strip-rpath.patch # PATCH-FIX-UPSTREAM Added-check-if-file-is-open-before-attempting-to-rea.patch Patch4: Added-check-if-file-is-open-before-attempting-to-rea.patch BuildRoot: %{_tmppath}/%{name}-%{version}-build BuildRequires: cmake BuildRequires: doxygen BuildRequires: fdupes BuildRequires: gcc-c++ BuildRequires: graphviz-gnome BuildRequires: libcppunit-devel BuildRequires: pkg-config %if 0%{?suse_version} BuildRequires: update-desktop-files %endif BuildRequires: librcc-devel BuildRequires: zlib-devel # NOTE: The tagreader and writer executables give different results when built with # an earlier taglib-1.8-ds-rusxmms patch. See bnc#814814 Requires: libtag1 = %{version}-%{release} Requires: libtag_c0 = %{version}-%{release} %description TagLib is a library for reading and editing the meta-data of several popular audio formats. Currently it supports both ID3v1 and ID3v2 for MP3 files, Ogg Vorbis comments and ID3 tags and Vorbis comments in FLAC, MPC, Speex, WavPack TrueAudio, WAV, AIFF, MP4 and ASF files. This package contains built examples which manipulate tags from the command line. %package -n libtag1 Summary: Audio Meta-Data Library License: LGPL-2.1+ Group: System/Libraries # Without this the old taglib package containing the libraries isn't removed when this package is installed. # The only alternative is for the libraries to Require: taglib version-release, badness 440 Conflicts: taglib <= 1.6.3 %description -n libtag1 TagLib is a library for reading and editing the meta-data of several popular audio formats. Currently it supports both ID3v1 and ID3v2 for MP3 files, Ogg Vorbis comments and ID3 tags and Vorbis comments in FLAC, MPC, Speex, WavPack TrueAudio, WAV, AIFF, MP4 and ASF files. %package -n libtag_c0 Summary: Audio Meta-Data Library License: LGPL-2.1+ Group: System/Libraries # Without this the old taglib package containing the libraries isn't removed when this package is installed. # The only alternative is for the libraries to Require: taglib version-release, badness 440 Conflicts: taglib <= 1.6.3 %description -n libtag_c0 TagLib is a library for reading and editing the meta-data of several popular audio formats. Currently it supports both ID3v1 and ID3v2 for MP3 files, Ogg Vorbis comments and ID3 tags and Vorbis comments in FLAC, MPC, Speex, WavPack TrueAudio, WAV, AIFF, MP4 and ASF files. %package -n libtag-devel Summary: Development files for taglib License: LGPL-2.1+ Group: Development/Libraries/C and C++ Requires: libstdc++-devel Requires: libtag1 = %{version}-%{release} Requires: libtag_c0 = %{version}-%{release} # taglib-devel was last used in openSUSE 11.4 (taglib-devel-1.6.2) # The last taglib-devel used was version 1.6.3 from multimedia:libs. Provides: taglib-devel = %{version} Obsoletes: taglib-devel <= 1.6.3 %description -n libtag-devel This package contains development files for taglib. %prep %setup -q %patch0 -p1 %patch1 -p1 %patch2 -p1 %patch3 %patch4 -p1 %build mkdir build cd build export CXXFLAGS="%{optflags} -D_GNU_SOURCE" export CFLAGS="%{optflags} -D_GNU_SOURCE" _libsuffix=$(echo %{_lib} | cut -b4-) cmake -DCMAKE_INSTALL_PREFIX=%{_prefix} \ -DBUILD_TESTS:BOOL=ON \ -DLIB_SUFFIX=$_libsuffix \ -DWITH_ASF:BOOL=ON \ -DWITH_MP4:BOOL=ON \ -DBUILD_EXAMPLES:BOOL=ON .. make %{?_smp_mflags} VERBOSE=1 cd .. doxygen -u doxygen %install pushd build make DESTDIR=%{buildroot} install popd # install susehelp file mkdir -p %{buildroot}%{_datadir}/susehelp/meta/Development/Libraries/ install -pm 0644 %{SOURCE1} %{buildroot}%{_datadir}/susehelp/meta/Development/Libraries/ %if 0%{?suse_version} %suse_update_desktop_file %{buildroot}%{_datadir}/susehelp/meta/Development/Libraries/%{name}.desktop %endif # Documentation mkdir -p %{buildroot}%{_defaultdocdir}/libtag-devel rm -f examples/CMake* cp -a AUTHORS COPYING.LGPL COPYING.MPL NEWS doc/html/ examples/ %{buildroot}%{_defaultdocdir}/libtag-devel/ %fdupes -s %{buildroot} # Add built examples to taglib package. mkdir -p %{buildroot}%{_bindir} for i in `find build/examples -maxdepth 1 ! -type d -executable`; do cp -v ${i} %{buildroot}%{_bindir}/; done %check # check the library #pushd tests #make check #popd %clean %{?buildroot:%__rm -rf "%{buildroot}"} %post -n libtag1 -p /sbin/ldconfig %postun -n libtag1 -p /sbin/ldconfig %post -n libtag_c0 -p /sbin/ldconfig %postun -n libtag_c0 -p /sbin/ldconfig %files -n libtag1 %defattr(-,root,root,-) %{_libdir}/libtag.so.1 %{_libdir}/libtag.so.1.* %files -n libtag_c0 %defattr(-,root,root,-) %{_libdir}/libtag_c.so.0 %{_libdir}/libtag_c.so.0.* %files -n libtag-devel %defattr(-,root,root,-) %doc %{_defaultdocdir}/libtag-devel %{_bindir}/taglib-config %{_includedir}/taglib/ %{_libdir}/libtag*.so %{_libdir}/pkgconfig/*.pc %{_datadir}/susehelp/ %files %defattr(-,root,root,-) %{_bindir}/* %exclude %{_bindir}/taglib-config %changelog ++++++ Added-check-if-file-is-open-before-attempting-to-rea.patch ++++++ From: gonemad <[email protected]> Date: Thu, 11 Oct 2012 21:20:03 -0400 Subject: Added check if file is open before attempting to read tags Patch-mainline: yes References: bnc#826228 Signed-off-by: Jiri Slaby <[email protected]> --- taglib/ape/apefile.cpp | 6 ++++-- taglib/asf/asffile.cpp | 6 ++++-- taglib/flac/flacfile.cpp | 9 ++++++--- taglib/it/itfile.cpp | 6 ++++-- taglib/mod/modfile.cpp | 6 ++++-- taglib/mp4/mp4file.cpp | 6 ++++-- taglib/mpc/mpcfile.cpp | 6 ++++-- taglib/ogg/flac/oggflacfile.cpp | 6 ++++-- taglib/ogg/speex/speexfile.cpp | 6 ++++-- taglib/ogg/vorbis/vorbisfile.cpp | 6 ++++-- taglib/s3m/s3mfile.cpp | 6 ++++-- taglib/wavpack/wavpackfile.cpp | 6 ++++-- taglib/xm/xmfile.cpp | 6 ++++-- 13 files changed, 54 insertions(+), 27 deletions(-) diff --git a/taglib/ape/apefile.cpp b/taglib/ape/apefile.cpp index cb65224..bf6491f 100644 --- a/taglib/ape/apefile.cpp +++ b/taglib/ape/apefile.cpp @@ -90,14 +90,16 @@ APE::File::File(FileName file, bool readProperties, Properties::ReadStyle propertiesStyle) : TagLib::File(file) { d = new FilePrivate; - read(readProperties, propertiesStyle); + if(isOpen()) + read(readProperties, propertiesStyle); } APE::File::File(IOStream *stream, bool readProperties, Properties::ReadStyle propertiesStyle) : TagLib::File(stream) { d = new FilePrivate; - read(readProperties, propertiesStyle); + if(isOpen()) + read(readProperties, propertiesStyle); } APE::File::~File() diff --git a/taglib/asf/asffile.cpp b/taglib/asf/asffile.cpp index 455631f..6a3155a 100644 --- a/taglib/asf/asffile.cpp +++ b/taglib/asf/asffile.cpp @@ -372,14 +372,16 @@ ASF::File::File(FileName file, bool readProperties, Properties::ReadStyle proper : TagLib::File(file) { d = new FilePrivate; - read(readProperties, propertiesStyle); + if(isOpen()) + read(readProperties, propertiesStyle); } ASF::File::File(IOStream *stream, bool readProperties, Properties::ReadStyle propertiesStyle) : TagLib::File(stream) { d = new FilePrivate; - read(readProperties, propertiesStyle); + if(isOpen()) + read(readProperties, propertiesStyle); } ASF::File::~File() diff --git a/taglib/flac/flacfile.cpp b/taglib/flac/flacfile.cpp index c85d959..291c42d 100644 --- a/taglib/flac/flacfile.cpp +++ b/taglib/flac/flacfile.cpp @@ -109,7 +109,8 @@ FLAC::File::File(FileName file, bool readProperties, TagLib::File(file) { d = new FilePrivate; - read(readProperties, propertiesStyle); + if(isOpen()) + read(readProperties, propertiesStyle); } FLAC::File::File(FileName file, ID3v2::FrameFactory *frameFactory, @@ -118,7 +119,8 @@ FLAC::File::File(FileName file, ID3v2::FrameFactory *frameFactory, { d = new FilePrivate; d->ID3v2FrameFactory = frameFactory; - read(readProperties, propertiesStyle); + if(isOpen()) + read(readProperties, propertiesStyle); } FLAC::File::File(IOStream *stream, ID3v2::FrameFactory *frameFactory, @@ -127,7 +129,8 @@ FLAC::File::File(IOStream *stream, ID3v2::FrameFactory *frameFactory, { d = new FilePrivate; d->ID3v2FrameFactory = frameFactory; - read(readProperties, propertiesStyle); + if(isOpen()) + read(readProperties, propertiesStyle); } FLAC::File::~File() diff --git a/taglib/it/itfile.cpp b/taglib/it/itfile.cpp index 4e04951..4807b9a 100644 --- a/taglib/it/itfile.cpp +++ b/taglib/it/itfile.cpp @@ -45,7 +45,8 @@ IT::File::File(FileName file, bool readProperties, Mod::FileBase(file), d(new FilePrivate(propertiesStyle)) { - read(readProperties); + if(isOpen()) + read(readProperties); } IT::File::File(IOStream *stream, bool readProperties, @@ -53,7 +54,8 @@ IT::File::File(IOStream *stream, bool readProperties, Mod::FileBase(stream), d(new FilePrivate(propertiesStyle)) { - read(readProperties); + if(isOpen()) + read(readProperties); } IT::File::~File() diff --git a/taglib/mod/modfile.cpp b/taglib/mod/modfile.cpp index 25fc871..8700ca7 100644 --- a/taglib/mod/modfile.cpp +++ b/taglib/mod/modfile.cpp @@ -45,7 +45,8 @@ Mod::File::File(FileName file, bool readProperties, Mod::FileBase(file), d(new FilePrivate(propertiesStyle)) { - read(readProperties); + if(isOpen()) + read(readProperties); } Mod::File::File(IOStream *stream, bool readProperties, @@ -53,7 +54,8 @@ Mod::File::File(IOStream *stream, bool readProperties, Mod::FileBase(stream), d(new FilePrivate(propertiesStyle)) { - read(readProperties); + if(isOpen()) + read(readProperties); } Mod::File::~File() diff --git a/taglib/mp4/mp4file.cpp b/taglib/mp4/mp4file.cpp index 0218557..6f7e48e 100644 --- a/taglib/mp4/mp4file.cpp +++ b/taglib/mp4/mp4file.cpp @@ -67,14 +67,16 @@ MP4::File::File(FileName file, bool readProperties, AudioProperties::ReadStyle a : TagLib::File(file) { d = new FilePrivate; - read(readProperties, audioPropertiesStyle); + if(isOpen()) + read(readProperties, audioPropertiesStyle); } MP4::File::File(IOStream *stream, bool readProperties, AudioProperties::ReadStyle audioPropertiesStyle) : TagLib::File(stream) { d = new FilePrivate; - read(readProperties, audioPropertiesStyle); + if(isOpen()) + read(readProperties, audioPropertiesStyle); } MP4::File::~File() diff --git a/taglib/mpc/mpcfile.cpp b/taglib/mpc/mpcfile.cpp index 519a046..7734eae 100644 --- a/taglib/mpc/mpcfile.cpp +++ b/taglib/mpc/mpcfile.cpp @@ -94,14 +94,16 @@ MPC::File::File(FileName file, bool readProperties, Properties::ReadStyle propertiesStyle) : TagLib::File(file) { d = new FilePrivate; - read(readProperties, propertiesStyle); + if(isOpen()) + read(readProperties, propertiesStyle); } MPC::File::File(IOStream *stream, bool readProperties, Properties::ReadStyle propertiesStyle) : TagLib::File(stream) { d = new FilePrivate; - read(readProperties, propertiesStyle); + if(isOpen()) + read(readProperties, propertiesStyle); } MPC::File::~File() diff --git a/taglib/ogg/flac/oggflacfile.cpp b/taglib/ogg/flac/oggflacfile.cpp index 9d9c303..e523f27 100644 --- a/taglib/ogg/flac/oggflacfile.cpp +++ b/taglib/ogg/flac/oggflacfile.cpp @@ -72,14 +72,16 @@ Ogg::FLAC::File::File(FileName file, bool readProperties, Properties::ReadStyle propertiesStyle) : Ogg::File(file) { d = new FilePrivate; - read(readProperties, propertiesStyle); + if(isOpen()) + read(readProperties, propertiesStyle); } Ogg::FLAC::File::File(IOStream *stream, bool readProperties, Properties::ReadStyle propertiesStyle) : Ogg::File(stream) { d = new FilePrivate; - read(readProperties, propertiesStyle); + if(isOpen()) + read(readProperties, propertiesStyle); } Ogg::FLAC::File::~File() diff --git a/taglib/ogg/speex/speexfile.cpp b/taglib/ogg/speex/speexfile.cpp index 3a4940a..58f6756 100644 --- a/taglib/ogg/speex/speexfile.cpp +++ b/taglib/ogg/speex/speexfile.cpp @@ -62,14 +62,16 @@ Speex::File::File(FileName file, bool readProperties, Properties::ReadStyle propertiesStyle) : Ogg::File(file) { d = new FilePrivate; - read(readProperties, propertiesStyle); + if(isOpen()) + read(readProperties, propertiesStyle); } Speex::File::File(IOStream *stream, bool readProperties, Properties::ReadStyle propertiesStyle) : Ogg::File(stream) { d = new FilePrivate; - read(readProperties, propertiesStyle); + if(isOpen()) + read(readProperties, propertiesStyle); } Speex::File::~File() diff --git a/taglib/ogg/vorbis/vorbisfile.cpp b/taglib/ogg/vorbis/vorbisfile.cpp index e2eed9e..a6753f5 100644 --- a/taglib/ogg/vorbis/vorbisfile.cpp +++ b/taglib/ogg/vorbis/vorbisfile.cpp @@ -67,14 +67,16 @@ Vorbis::File::File(FileName file, bool readProperties, Properties::ReadStyle propertiesStyle) : Ogg::File(file) { d = new FilePrivate; - read(readProperties, propertiesStyle); + if(isOpen()) + read(readProperties, propertiesStyle); } Vorbis::File::File(IOStream *stream, bool readProperties, Properties::ReadStyle propertiesStyle) : Ogg::File(stream) { d = new FilePrivate; - read(readProperties, propertiesStyle); + if(isOpen()) + read(readProperties, propertiesStyle); } Vorbis::File::~File() diff --git a/taglib/s3m/s3mfile.cpp b/taglib/s3m/s3mfile.cpp index 7ffdf91..1afe362 100644 --- a/taglib/s3m/s3mfile.cpp +++ b/taglib/s3m/s3mfile.cpp @@ -47,7 +47,8 @@ S3M::File::File(FileName file, bool readProperties, Mod::FileBase(file), d(new FilePrivate(propertiesStyle)) { - read(readProperties); + if(isOpen()) + read(readProperties); } S3M::File::File(IOStream *stream, bool readProperties, @@ -55,7 +56,8 @@ S3M::File::File(IOStream *stream, bool readProperties, Mod::FileBase(stream), d(new FilePrivate(propertiesStyle)) { - read(readProperties); + if(isOpen()) + read(readProperties); } S3M::File::~File() diff --git a/taglib/wavpack/wavpackfile.cpp b/taglib/wavpack/wavpackfile.cpp index 49f7923..ea5a8f8 100644 --- a/taglib/wavpack/wavpackfile.cpp +++ b/taglib/wavpack/wavpackfile.cpp @@ -86,14 +86,16 @@ WavPack::File::File(FileName file, bool readProperties, Properties::ReadStyle propertiesStyle) : TagLib::File(file) { d = new FilePrivate; - read(readProperties, propertiesStyle); + if(isOpen()) + read(readProperties, propertiesStyle); } WavPack::File::File(IOStream *stream, bool readProperties, Properties::ReadStyle propertiesStyle) : TagLib::File(stream) { d = new FilePrivate; - read(readProperties, propertiesStyle); + if(isOpen()) + read(readProperties, propertiesStyle); } WavPack::File::~File() diff --git a/taglib/xm/xmfile.cpp b/taglib/xm/xmfile.cpp index c311a06..a0890c8 100644 --- a/taglib/xm/xmfile.cpp +++ b/taglib/xm/xmfile.cpp @@ -359,7 +359,8 @@ XM::File::File(FileName file, bool readProperties, Mod::FileBase(file), d(new FilePrivate(propertiesStyle)) { - read(readProperties); + if(isOpen()) + read(readProperties); } XM::File::File(IOStream *stream, bool readProperties, @@ -367,7 +368,8 @@ XM::File::File(IOStream *stream, bool readProperties, Mod::FileBase(stream), d(new FilePrivate(propertiesStyle)) { - read(readProperties); + if(isOpen()) + read(readProperties); } XM::File::~File() -- 1.8.3.1 ++++++ baselibs.conf ++++++ libtag1 libtag_c0 ++++++ taglib-1.7.2-doxygen.patch ++++++ diff --git a/CMakeLists.txt b/CMakeLists.txt index 20a1141..0e9e884 100644 --- a/CMakeLists.txt +++ b/CMakeLists.txt @@ -94,7 +94,7 @@ if(BUILD_TESTS) endif(BUILD_TESTS) add_subdirectory(examples) -configure_file(${CMAKE_CURRENT_SOURCE_DIR}/Doxyfile.cmake ${CMAKE_CURRENT_BINARY_DIR}/Doxyfile) +configure_file(${CMAKE_CURRENT_SOURCE_DIR}/Doxyfile.cmake ${CMAKE_CURRENT_SOURCE_DIR}/Doxyfile) file(COPY doc/taglib.png DESTINATION doc) add_custom_target(docs doxygen) ++++++ taglib-1.8-ds-rusxmms-r9.patch ++++++ ++++ 609 lines (skipped) ++++++ taglib-1.8-strip-rpath.patch ++++++ Index: examples/CMakeLists.txt =================================================================== --- examples/CMakeLists.txt.orig 2012-09-06 20:03:15.000000000 +0200 +++ examples/CMakeLists.txt 2013-04-23 08:44:33.938480393 +0200 @@ -11,6 +11,8 @@ if(ENABLE_STATIC) add_definitions(-DTAGLIB_STATIC) endif(ENABLE_STATIC) +SET(CMAKE_SKIP_BUILD_RPATH TRUE) + ########### next target ############### ADD_EXECUTABLE(tagreader tagreader.cpp) @@ -45,6 +47,14 @@ ADD_EXECUTABLE(strip-id3v1 strip-id3v1.c TARGET_LINK_LIBRARIES(strip-id3v1 tag ) +#set_target_properties(examples PROPERTIES +# INSTALL_NAME_DIR ${BIN_INSTALL_DIR} +# LINK_INTERFACE_LIBRARIES "" +#) + +#install(TARGETS examples +# FRAMEWORK DESTINATION ${FRAMEWORK_INSTALL_DIR} +# RUNTIME DESTINATION ${BIN_INSTALL_DIR} +#) endif(BUILD_EXAMPLES) - ++++++ taglib-1.8-version_fix.patch ++++++ diff -ur taglib-1.8/taglib/toolkit/taglib.h taglib-1.8.nu/taglib/toolkit/taglib.h --- taglib-1.8/taglib/toolkit/taglib.h 2012-09-06 15:03:15.000000000 -0300 +++ taglib-1.8.nu/taglib/toolkit/taglib.h 2012-11-08 01:47:51.088000009 -0300 @@ -27,7 +27,7 @@ #define TAGLIB_H #define TAGLIB_MAJOR_VERSION 1 -#define TAGLIB_MINOR_VERSION 7 +#define TAGLIB_MINOR_VERSION 8 #define TAGLIB_PATCH_VERSION 0 #if defined(__GNUC__) && (__GNUC__ > 4 || (__GNUC__ == 4 && __GNUC_MINOR__ > 1)) ++++++ taglib.desktop ++++++ [Desktop Entry] Name=Taglib API reference Name[de]=Taglib API Referenz Name[hu]=Taglib API referencia DocPath=/usr/share/doc/packages/libtag-devel/html/index.html X-DOC-SearchMethod=htdig -- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
