Hello community, here is the log from the commit of package avogadro for openSUSE:Factory checked in at 2013-08-13 10:26:07 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Comparing /work/SRC/openSUSE:Factory/avogadro (Old) and /work/SRC/openSUSE:Factory/.avogadro.new (New) ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Package is "avogadro" Changes: -------- --- /work/SRC/openSUSE:Factory/avogadro/avogadro.changes 2013-03-14 16:52:57.000000000 +0100 +++ /work/SRC/openSUSE:Factory/.avogadro.new/avogadro.changes 2013-08-13 10:26:08.000000000 +0200 @@ -1,0 +2,7 @@ +Sun Aug 11 09:08:02 UTC 2013 - [email protected] + +- Compile with %{optflags} +- Use RelWithDebInfo build type not to strip binaries +- shlib-pic-flag.patch: Always use PIC in shlib objects + +------------------------------------------------------------------- New: ---- shlib-pic-flag.patch ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Other differences: ------------------ ++++++ avogadro.spec ++++++ --- /var/tmp/diff_new_pack.a1nlId/_old 2013-08-13 10:26:08.000000000 +0200 +++ /var/tmp/diff_new_pack.a1nlId/_new 2013-08-13 10:26:08.000000000 +0200 @@ -30,6 +30,8 @@ Patch0: avogadro-1.1.0-no-return-in-nonvoid-function.patch # PATCH-FIX-UPSTREAM avoid crash when loading aux - see https://github.com/cryos/avogadro/commit/a4050e8a3f70ddc2bcc75a5b00d26416964b7275.patch Patch1: MopacAuxReaderFix.patch +# PATCH-FIX-UPSTREAM always use -fPIC for shlib objects +Patch2: shlib-pic-flag.patch BuildRequires: boost-devel BuildRequires: cmake BuildRequires: docbook-utils @@ -106,6 +108,7 @@ %setup -q %patch0 -p1 %patch1 -p1 +%patch2 -p1 %build mkdir -p build @@ -120,6 +123,10 @@ -DENABLE_UPDATE_CHECKER=OFF \ -DENABLE_ZMATRIX_TOOL=ON \ -DENABLE_PYTHON=ON \ + -DCMAKE_VERBOSE_MAKEFILE=true \ + -DCMAKE_C_FLAGS="%{optflags}" \ + -DCMAKE_CXX_FLAGS="%{optflags}" \ + -DCMAKE_BUILD_TYPE=RelWithDebInfo \ .. make %{?_smp_mflags} ++++++ shlib-pic-flag.patch ++++++ Index: avogadro-1.1.0/libavogadro/src/extensions/crystallography/spglib/CMakeLists.txt =================================================================== --- avogadro-1.1.0.orig/libavogadro/src/extensions/crystallography/spglib/CMakeLists.txt +++ avogadro-1.1.0/libavogadro/src/extensions/crystallography/spglib/CMakeLists.txt @@ -19,7 +19,5 @@ add_library(spglib STATIC ${spglib_SRCS} # Suppress spglib warnings set_target_properties(spglib PROPERTIES COMPILE_FLAGS "-w") -# Set -fPIC on x86_64 -if("${CMAKE_SYSTEM_PROCESSOR}" STREQUAL "x86_64") - set(CMAKE_C_FLAGS "${CMAKE_C_FLAGS} -fPIC" ) -endif() +# Add -fPIC +set_target_properties(spglib PROPERTIES POSITION_INDEPENDENT_CODE TRUE) Index: avogadro-1.1.0/libavogadro/src/extensions/swcntbuilder/tubegen/CMakeLists.txt =================================================================== --- avogadro-1.1.0.orig/libavogadro/src/extensions/swcntbuilder/tubegen/CMakeLists.txt +++ avogadro-1.1.0/libavogadro/src/extensions/swcntbuilder/tubegen/CMakeLists.txt @@ -18,8 +18,5 @@ add_library(tubegen STATIC ${tubegen_SRC # Suppress warnings set_target_properties(tubegen PROPERTIES COMPILE_FLAGS "-w") -# Set -fPIC on x86_64 -if("${CMAKE_SYSTEM_PROCESSOR}" STREQUAL "x86_64") - set(CMAKE_C_FLAGS "${CMAKE_C_FLAGS} -fPIC" ) - set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -fPIC" ) -endif() +# Add -fPIC +set_target_properties(tubegen PROPERTIES POSITION_INDEPENDENT_CODE TRUE) -- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
