Hello community, here is the log from the commit of package xlsclients for openSUSE:Factory checked in at 2013-09-13 14:47:13 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Comparing /work/SRC/openSUSE:Factory/xlsclients (Old) and /work/SRC/openSUSE:Factory/.xlsclients.new (New) ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Package is "xlsclients" Changes: -------- --- /work/SRC/openSUSE:Factory/xlsclients/xlsclients.changes 2012-05-08 12:05:47.000000000 +0200 +++ /work/SRC/openSUSE:Factory/.xlsclients.new/xlsclients.changes 2013-09-13 14:47:14.000000000 +0200 @@ -1,0 +2,10 @@ +Thu Sep 12 19:47:11 UTC 2013 - [email protected] + +- Update to version 1.1.3: + + Fix deconstification warnings from gcc. + + Add -version flag to print version from PACKAGE_STRING. + + Give unique names to the two reply variables in child_info. + + configure.ac: regroup statements and comment. + + Add missing AC_CONFIG_SRCDIR([Makefile.am]). + +------------------------------------------------------------------- Old: ---- xlsclients-1.1.2.tar.bz2 New: ---- xlsclients-1.1.3.tar.bz2 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Other differences: ------------------ ++++++ xlsclients.spec ++++++ --- /var/tmp/diff_new_pack.WmBzQC/_old 2013-09-13 14:47:14.000000000 +0200 +++ /var/tmp/diff_new_pack.WmBzQC/_new 2013-09-13 14:47:14.000000000 +0200 @@ -1,7 +1,7 @@ # # spec file for package xlsclients # -# Copyright (c) 2012 SUSE LINUX Products GmbH, Nuernberg, Germany. +# Copyright (c) 2013 SUSE LINUX Products GmbH, Nuernberg, Germany. # # All modifications and additions to the file contributed by third parties # remain the property of their copyright owners, unless otherwise agreed @@ -15,13 +15,14 @@ # Please submit bugfixes or comments via http://bugs.opensuse.org/ # + Name: xlsclients -Version: 1.1.2 +Version: 1.1.3 Release: 0 -License: MIT Summary: Utility to list client applications running on a X11 server -Url: http://xorg.freedesktop.org/ +License: MIT Group: System/X11/Utilities +Url: http://xorg.freedesktop.org/ Source0: http://xorg.freedesktop.org/releases/individual/app/%{name}-%{version}.tar.bz2 BuildRequires: pkg-config BuildRequires: pkgconfig(xcb) >= 1.6 ++++++ xlsclients-1.1.2.tar.bz2 -> xlsclients-1.1.3.tar.bz2 ++++++ ++++ 17268 lines of diff (skipped) ++++ retrying with extended exclude list diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' --exclude Makefile.in --exclude configure --exclude config.guess --exclude '*.pot' --exclude mkinstalldirs --exclude aclocal.m4 --exclude config.sub --exclude depcomp --exclude install-sh --exclude ltmain.sh old/xlsclients-1.1.2/ChangeLog new/xlsclients-1.1.3/ChangeLog --- old/xlsclients-1.1.2/ChangeLog 2011-05-03 06:13:15.000000000 +0200 +++ new/xlsclients-1.1.3/ChangeLog 2013-09-08 18:57:17.000000000 +0200 @@ -1,3 +1,90 @@ +commit 1bdd68ccb6f107525d27a2963f01f7bc4830e643 +Author: Alan Coopersmith <[email protected]> +Date: Sun Sep 8 09:56:46 2013 -0700 + + xlsclients 1.1.3 + + Signed-off-by: Alan Coopersmith <[email protected]> + +commit c5de636fc500d5151ce4a4d0ceb0cbc152d73b49 +Author: Alan Coopersmith <[email protected]> +Date: Fri Jul 19 00:48:10 2013 -0700 + + Fix deconstification warnings from gcc + + Signed-off-by: Alan Coopersmith <[email protected]> + +commit a67a804a43ad75efb3040c9e9e067fc60cde1256 +Author: Alan Coopersmith <[email protected]> +Date: Fri Jul 19 00:45:13 2013 -0700 + + Add -version flag to print version from PACKAGE_STRING + + Signed-off-by: Alan Coopersmith <[email protected]> + +commit 81a64c9112b9d650106a01d8bcd246011d037bc2 +Author: Alan Coopersmith <[email protected]> +Date: Tue Jan 22 22:46:42 2013 -0800 + + Give unique names to the two reply variables in child_info + + Clears compiler warnings: + + xlsclients.c:253:28: warning: declaration shadows a local variable [-Wshadow] + xcb_get_property_reply_t *reply; + ^ + xlsclients.c:250:30: note: previous declaration is here + xcb_query_tree_reply_t **reply; + + Signed-off-by: Alan Coopersmith <[email protected]> + +commit 70c0bd30f0f77e70910d10f91ecca617d6b5acb7 +Author: Gaetan Nadon <[email protected]> +Date: Sun Jan 22 20:19:45 2012 -0500 + + configure.ac: regroup statements and comment + + Add missing AC_CONFIG_SRCDIR([Makefile.am]) + + Move AC_USE_SYSTEM_EXTENSIONS higher up in Autoconf init section + which must come before XORG_DEFAULT_OPTIONS + + Move XORG_DEFAULT_OPTIONS to its usual place with X.Org macros + Note that AC_FUNC_STRNLEN calls AC_REQUIRE(AC_USE_SYSTEM_EXTENSIONS) + + Comment the strnlen function replacement. + http://pubs.opengroup.org/onlinepubs/9699919799/functions/strlen.html + + No functional changes. Following the layout in + http://www.x.org/wiki/NewModuleGuidelines + + Signed-off-by: Gaetan Nadon <[email protected]> + +commit 395f3573fe0124991eb9a2f33473ea2ed2fd422c +Author: Gaetan Nadon <[email protected]> +Date: Fri Jan 20 19:57:48 2012 -0500 + + Revert "make: remove $(LIBOBJS) dead code" + + AC_FUNC_STRLEN is one of the functions that call AC_LIBOBJ + which sets $LIBOBJ. + + This reverts commit 789a5b42a716b14429c67161147151dd57dd5480. + +commit 789a5b42a716b14429c67161147151dd57dd5480 +Author: Gaetan Nadon <[email protected]> +Date: Fri Jan 20 15:19:26 2012 -0500 + + make: remove $(LIBOBJS) dead code + + Starting at Autoconf 2.53, the use of LIBOBJS is an error. + http://www.gnu.org/software/autoconf/manual/autoconf.html# + AC_005fLIBOBJ-vs-LIBOBJS + + There are no system functions to override in this module. + + Signed-off-by: Gaetan Nadon <[email protected]> + commit 5f064f70b183147578919166bedeca55cdb0af71 Author: Alan Coopersmith <[email protected]> Date: Mon May 2 21:12:31 2011 -0700 diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' --exclude Makefile.in --exclude configure --exclude config.guess --exclude '*.pot' --exclude mkinstalldirs --exclude aclocal.m4 --exclude config.sub --exclude depcomp --exclude install-sh --exclude ltmain.sh old/xlsclients-1.1.2/compile new/xlsclients-1.1.3/compile --- old/xlsclients-1.1.2/compile 1970-01-01 01:00:00.000000000 +0100 +++ new/xlsclients-1.1.3/compile 2013-09-08 18:57:01.000000000 +0200 @@ -0,0 +1,347 @@ +#! /bin/sh +# Wrapper for compilers which do not understand '-c -o'. + +scriptversion=2012-10-14.11; # UTC + +# Copyright (C) 1999-2013 Free Software Foundation, Inc. +# Written by Tom Tromey <[email protected]>. +# +# This program is free software; you can redistribute it and/or modify +# it under the terms of the GNU General Public License as published by +# the Free Software Foundation; either version 2, or (at your option) +# any later version. +# +# This program is distributed in the hope that it will be useful, +# but WITHOUT ANY WARRANTY; without even the implied warranty of +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the +# GNU General Public License for more details. +# +# You should have received a copy of the GNU General Public License +# along with this program. If not, see <http://www.gnu.org/licenses/>. + +# As a special exception to the GNU General Public License, if you +# distribute this file as part of a program that contains a +# configuration script generated by Autoconf, you may include it under +# the same distribution terms that you use for the rest of that program. + +# This file is maintained in Automake, please report +# bugs to <[email protected]> or send patches to +# <[email protected]>. + +nl=' +' + +# We need space, tab and new line, in precisely that order. Quoting is +# there to prevent tools from complaining about whitespace usage. +IFS=" "" $nl" + +file_conv= + +# func_file_conv build_file lazy +# Convert a $build file to $host form and store it in $file +# Currently only supports Windows hosts. If the determined conversion +# type is listed in (the comma separated) LAZY, no conversion will +# take place. +func_file_conv () +{ + file=$1 + case $file in + / | /[!/]*) # absolute file, and not a UNC file + if test -z "$file_conv"; then + # lazily determine how to convert abs files + case `uname -s` in + MINGW*) + file_conv=mingw + ;; + CYGWIN*) + file_conv=cygwin + ;; + *) + file_conv=wine + ;; + esac + fi + case $file_conv/,$2, in + *,$file_conv,*) + ;; + mingw/*) + file=`cmd //C echo "$file " | sed -e 's/"\(.*\) " *$/\1/'` + ;; + cygwin/*) + file=`cygpath -m "$file" || echo "$file"` + ;; + wine/*) + file=`winepath -w "$file" || echo "$file"` + ;; + esac + ;; + esac +} + +# func_cl_dashL linkdir +# Make cl look for libraries in LINKDIR +func_cl_dashL () +{ + func_file_conv "$1" + if test -z "$lib_path"; then + lib_path=$file + else + lib_path="$lib_path;$file" + fi + linker_opts="$linker_opts -LIBPATH:$file" +} + +# func_cl_dashl library +# Do a library search-path lookup for cl +func_cl_dashl () +{ + lib=$1 + found=no + save_IFS=$IFS + IFS=';' + for dir in $lib_path $LIB + do + IFS=$save_IFS + if $shared && test -f "$dir/$lib.dll.lib"; then + found=yes + lib=$dir/$lib.dll.lib + break + fi + if test -f "$dir/$lib.lib"; then + found=yes + lib=$dir/$lib.lib + break + fi + if test -f "$dir/lib$lib.a"; then + found=yes + lib=$dir/lib$lib.a + break + fi + done + IFS=$save_IFS + + if test "$found" != yes; then + lib=$lib.lib + fi +} + +# func_cl_wrapper cl arg... +# Adjust compile command to suit cl +func_cl_wrapper () +{ + # Assume a capable shell + lib_path= + shared=: + linker_opts= + for arg + do + if test -n "$eat"; then + eat= + else + case $1 in + -o) + # configure might choose to run compile as 'compile cc -o foo foo.c'. + eat=1 + case $2 in + *.o | *.[oO][bB][jJ]) + func_file_conv "$2" + set x "$@" -Fo"$file" + shift + ;; + *) + func_file_conv "$2" + set x "$@" -Fe"$file" + shift + ;; + esac + ;; + -I) + eat=1 + func_file_conv "$2" mingw + set x "$@" -I"$file" + shift + ;; + -I*) + func_file_conv "${1#-I}" mingw + set x "$@" -I"$file" + shift + ;; + -l) + eat=1 + func_cl_dashl "$2" + set x "$@" "$lib" + shift + ;; + -l*) + func_cl_dashl "${1#-l}" + set x "$@" "$lib" + shift + ;; + -L) + eat=1 + func_cl_dashL "$2" + ;; + -L*) + func_cl_dashL "${1#-L}" + ;; + -static) + shared=false + ;; + -Wl,*) + arg=${1#-Wl,} + save_ifs="$IFS"; IFS=',' + for flag in $arg; do + IFS="$save_ifs" + linker_opts="$linker_opts $flag" + done + IFS="$save_ifs" + ;; + -Xlinker) + eat=1 + linker_opts="$linker_opts $2" + ;; + -*) + set x "$@" "$1" + shift + ;; + *.cc | *.CC | *.cxx | *.CXX | *.[cC]++) + func_file_conv "$1" + set x "$@" -Tp"$file" + shift + ;; + *.c | *.cpp | *.CPP | *.lib | *.LIB | *.Lib | *.OBJ | *.obj | *.[oO]) + func_file_conv "$1" mingw + set x "$@" "$file" + shift + ;; + *) + set x "$@" "$1" + shift + ;; + esac + fi + shift + done + if test -n "$linker_opts"; then + linker_opts="-link$linker_opts" + fi + exec "$@" $linker_opts + exit 1 +} + +eat= + +case $1 in + '') + echo "$0: No command. Try '$0 --help' for more information." 1>&2 + exit 1; + ;; + -h | --h*) + cat <<\EOF +Usage: compile [--help] [--version] PROGRAM [ARGS] + +Wrapper for compilers which do not understand '-c -o'. +Remove '-o dest.o' from ARGS, run PROGRAM with the remaining +arguments, and rename the output as expected. + +If you are trying to build a whole package this is not the +right script to run: please start by reading the file 'INSTALL'. + +Report bugs to <[email protected]>. +EOF + exit $? + ;; + -v | --v*) + echo "compile $scriptversion" + exit $? + ;; + cl | *[/\\]cl | cl.exe | *[/\\]cl.exe ) + func_cl_wrapper "$@" # Doesn't return... + ;; +esac + +ofile= +cfile= + +for arg +do + if test -n "$eat"; then + eat= + else + case $1 in + -o) + # configure might choose to run compile as 'compile cc -o foo foo.c'. + # So we strip '-o arg' only if arg is an object. + eat=1 + case $2 in + *.o | *.obj) + ofile=$2 + ;; + *) + set x "$@" -o "$2" + shift + ;; + esac + ;; + *.c) + cfile=$1 + set x "$@" "$1" + shift + ;; + *) + set x "$@" "$1" + shift + ;; + esac + fi + shift +done + +if test -z "$ofile" || test -z "$cfile"; then + # If no '-o' option was seen then we might have been invoked from a + # pattern rule where we don't need one. That is ok -- this is a + # normal compilation that the losing compiler can handle. If no + # '.c' file was seen then we are probably linking. That is also + # ok. + exec "$@" +fi + +# Name of file we expect compiler to create. +cofile=`echo "$cfile" | sed 's|^.*[\\/]||; s|^[a-zA-Z]:||; s/\.c$/.o/'` + +# Create the lock directory. +# Note: use '[/\\:.-]' here to ensure that we don't use the same name +# that we are using for the .o file. Also, base the name on the expected +# object file name, since that is what matters with a parallel build. +lockdir=`echo "$cofile" | sed -e 's|[/\\:.-]|_|g'`.d +while true; do + if mkdir "$lockdir" >/dev/null 2>&1; then + break + fi + sleep 1 +done +# FIXME: race condition here if user kills between mkdir and trap. +trap "rmdir '$lockdir'; exit 1" 1 2 15 + +# Run the compile. +"$@" +ret=$? + +if test -f "$cofile"; then + test "$cofile" = "$ofile" || mv "$cofile" "$ofile" +elif test -f "${cofile}bj"; then + test "${cofile}bj" = "$ofile" || mv "${cofile}bj" "$ofile" +fi + +rmdir "$lockdir" +exit $ret + +# Local Variables: +# mode: shell-script +# sh-indentation: 2 +# eval: (add-hook 'write-file-hooks 'time-stamp) +# time-stamp-start: "scriptversion=" +# time-stamp-format: "%:y-%02m-%02d.%02H" +# time-stamp-time-zone: "UTC" +# time-stamp-end: "; # UTC" +# End: diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' --exclude Makefile.in --exclude configure --exclude config.guess --exclude '*.pot' --exclude mkinstalldirs --exclude aclocal.m4 --exclude config.sub --exclude depcomp --exclude install-sh --exclude ltmain.sh old/xlsclients-1.1.2/configure.ac new/xlsclients-1.1.3/configure.ac --- old/xlsclients-1.1.2/configure.ac 2011-05-03 06:11:30.000000000 +0200 +++ new/xlsclients-1.1.3/configure.ac 2013-09-08 18:56:56.000000000 +0200 @@ -21,10 +21,15 @@ dnl dnl Process this file with autoconf to create configure. +# Initialize Autoconf AC_PREREQ([2.60]) -AC_INIT([xlsclients], [1.1.2], - [https://bugs.freedesktop.org/enter_bug.cgi?product=xorg], - [xlsclients]) +AC_INIT([xlsclients], [1.1.3], + [https://bugs.freedesktop.org/enter_bug.cgi?product=xorg], [xlsclients]) +AC_CONFIG_SRCDIR([Makefile.am]) +AC_CONFIG_HEADERS([config.h]) +AC_USE_SYSTEM_EXTENSIONS + +# Initialize Automake AM_INIT_AUTOMAKE([foreign dist-bzip2]) AM_MAINTAINER_MODE @@ -32,19 +37,15 @@ m4_ifndef([XORG_MACROS_VERSION], [m4_fatal([must install xorg-macros 1.8 or later before running autoconf/autogen])]) XORG_MACROS_VERSION(1.8) +XORG_DEFAULT_OPTIONS -AC_CONFIG_HEADERS([config.h]) - -# Check for functional strnlen -AC_USE_SYSTEM_EXTENSIONS +# Use POSIX strnlen or the implementation supplied in this module AC_FUNC_STRNLEN if test "x$ac_cv_func_strnlen_working" = xyes; then AC_DEFINE(HAVE_STRNLEN, 1, [Define to 1 if you have a working strnlen function.]) fi -XORG_DEFAULT_OPTIONS - -# Checks for pkg-config packages +# Obtain compiler/linker options for xlsclients dependencies PKG_CHECK_MODULES(XLSCLIENTS, xcb >= 1.6) AC_CONFIG_FILES([ diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' --exclude Makefile.in --exclude configure --exclude config.guess --exclude '*.pot' --exclude mkinstalldirs --exclude aclocal.m4 --exclude config.sub --exclude depcomp --exclude install-sh --exclude ltmain.sh old/xlsclients-1.1.2/man/xlsclients.man new/xlsclients-1.1.3/man/xlsclients.man --- old/xlsclients-1.1.2/man/xlsclients.man 2011-01-21 08:27:34.000000000 +0100 +++ new/xlsclients-1.1.3/man/xlsclients.man 2013-09-08 18:56:56.000000000 +0200 @@ -27,7 +27,7 @@ xlsclients - list client applications running on a display .SH SYNOPSIS .B "xlsclients" -[-display \fIdisplayname\fP] [-a] [-l] [-m maxcmdlen] +[-display \fIdisplayname\fP] [-a] [-l] [-m maxcmdlen] [-version] .SH DESCRIPTION .PP .I Xlsclients @@ -51,6 +51,9 @@ .B \-m \fImaxcmdlen\fP This option specifies the maximum number of characters in a command to print out. The default is 10000. +.TP 8 +.B \-version +Print the program version and exit. .SH ENVIRONMENT .PP .TP 8 diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' --exclude Makefile.in --exclude configure --exclude config.guess --exclude '*.pot' --exclude mkinstalldirs --exclude aclocal.m4 --exclude config.sub --exclude depcomp --exclude install-sh --exclude ltmain.sh old/xlsclients-1.1.2/missing new/xlsclients-1.1.3/missing --- old/xlsclients-1.1.2/missing 2011-05-03 06:13:00.000000000 +0200 +++ new/xlsclients-1.1.3/missing 2013-09-08 18:57:01.000000000 +0200 @@ -1,11 +1,10 @@ #! /bin/sh -# Common stub for a few missing GNU programs while installing. +# Common wrapper for a few potentially missing GNU programs. -scriptversion=2009-04-28.21; # UTC +scriptversion=2012-06-26.16; # UTC -# Copyright (C) 1996, 1997, 1999, 2000, 2002, 2003, 2004, 2005, 2006, -# 2008, 2009 Free Software Foundation, Inc. -# Originally by Fran,cois Pinard <[email protected]>, 1996. +# Copyright (C) 1996-2013 Free Software Foundation, Inc. +# Originally written by Fran,cois Pinard <[email protected]>, 1996. # This program is free software; you can redistribute it and/or modify # it under the terms of the GNU General Public License as published by @@ -26,69 +25,40 @@ # the same distribution terms that you use for the rest of that program. if test $# -eq 0; then - echo 1>&2 "Try \`$0 --help' for more information" + echo 1>&2 "Try '$0 --help' for more information" exit 1 fi -run=: -sed_output='s/.* --output[ =]\([^ ]*\).*/\1/p' -sed_minuso='s/.* -o \([^ ]*\).*/\1/p' - -# In the cases where this matters, `missing' is being run in the -# srcdir already. -if test -f configure.ac; then - configure_ac=configure.ac -else - configure_ac=configure.in -fi +case $1 in -msg="missing on your system" + --is-lightweight) + # Used by our autoconf macros to check whether the available missing + # script is modern enough. + exit 0 + ;; -case $1 in ---run) - # Try to run requested program, and just exit if it succeeds. - run= - shift - "$@" && exit 0 - # Exit code 63 means version mismatch. This often happens - # when the user try to use an ancient version of a tool on - # a file that requires a minimum version. In this case we - # we should proceed has if the program had been absent, or - # if --run hadn't been passed. - if test $? = 63; then - run=: - msg="probably too old" - fi - ;; + --run) + # Back-compat with the calling convention used by older automake. + shift + ;; -h|--h|--he|--hel|--help) echo "\ $0 [OPTION]... PROGRAM [ARGUMENT]... -Handle \`PROGRAM [ARGUMENT]...' for when PROGRAM is missing, or return an -error status if there is no known handling for PROGRAM. +Run 'PROGRAM [ARGUMENT]...', returning a proper advice when this fails due +to PROGRAM being missing or too old. Options: -h, --help display this help and exit -v, --version output version information and exit - --run try to run the given command, and emulate it if it fails Supported PROGRAM values: - aclocal touch file \`aclocal.m4' - autoconf touch file \`configure' - autoheader touch file \`config.h.in' - autom4te touch the output file, or create a stub one - automake touch all \`Makefile.in' files - bison create \`y.tab.[ch]', if possible, from existing .[ch] - flex create \`lex.yy.c', if possible, from existing .c - help2man touch the output file - lex create \`lex.yy.c', if possible, from existing .c - makeinfo touch the output file - tar try tar, gnutar, gtar, then tar without non-portable flags - yacc create \`y.tab.[ch]', if possible, from existing .[ch] + aclocal autoconf autoheader autom4te automake makeinfo + bison yacc flex lex help2man -Version suffixes to PROGRAM as well as the prefixes \`gnu-', \`gnu', and -\`g' are ignored when checking the name. +Version suffixes to PROGRAM as well as the prefixes 'gnu-', 'gnu', and +'g' are ignored when checking the name. Send bug reports to <[email protected]>." exit $? @@ -100,272 +70,141 @@ ;; -*) - echo 1>&2 "$0: Unknown \`$1' option" - echo 1>&2 "Try \`$0 --help' for more information" + echo 1>&2 "$0: unknown '$1' option" + echo 1>&2 "Try '$0 --help' for more information" exit 1 ;; esac -# normalize program name to check for. -program=`echo "$1" | sed ' - s/^gnu-//; t - s/^gnu//; t - s/^g//; t'` - -# Now exit if we have it, but it failed. Also exit now if we -# don't have it and --version was passed (most likely to detect -# the program). This is about non-GNU programs, so use $1 not -# $program. -case $1 in - lex*|yacc*) - # Not GNU programs, they don't have --version. - ;; - - tar*) - if test -n "$run"; then - echo 1>&2 "ERROR: \`tar' requires --run" - exit 1 - elif test "x$2" = "x--version" || test "x$2" = "x--help"; then - exit 1 - fi - ;; +# Run the given program, remember its exit status. +"$@"; st=$? - *) - if test -z "$run" && ($1 --version) > /dev/null 2>&1; then - # We have it, but it failed. - exit 1 - elif test "x$2" = "x--version" || test "x$2" = "x--help"; then - # Could not run --version or --help. This is probably someone - # running `$TOOL --version' or `$TOOL --help' to check whether - # $TOOL exists and not knowing $TOOL uses missing. - exit 1 - fi - ;; -esac - -# If it does not exist, or fails to run (possibly an outdated version), -# try to emulate it. -case $program in - aclocal*) - echo 1>&2 "\ -WARNING: \`$1' is $msg. You should only need it if - you modified \`acinclude.m4' or \`${configure_ac}'. You might want - to install the \`Automake' and \`Perl' packages. Grab them from - any GNU archive site." - touch aclocal.m4 - ;; - - autoconf*) - echo 1>&2 "\ -WARNING: \`$1' is $msg. You should only need it if - you modified \`${configure_ac}'. You might want to install the - \`Autoconf' and \`GNU m4' packages. Grab them from any GNU - archive site." - touch configure - ;; - - autoheader*) - echo 1>&2 "\ -WARNING: \`$1' is $msg. You should only need it if - you modified \`acconfig.h' or \`${configure_ac}'. You might want - to install the \`Autoconf' and \`GNU m4' packages. Grab them - from any GNU archive site." - files=`sed -n 's/^[ ]*A[CM]_CONFIG_HEADER(\([^)]*\)).*/\1/p' ${configure_ac}` - test -z "$files" && files="config.h" - touch_files= - for f in $files; do - case $f in - *:*) touch_files="$touch_files "`echo "$f" | - sed -e 's/^[^:]*://' -e 's/:.*//'`;; - *) touch_files="$touch_files $f.in";; - esac - done - touch $touch_files - ;; - - automake*) - echo 1>&2 "\ -WARNING: \`$1' is $msg. You should only need it if - you modified \`Makefile.am', \`acinclude.m4' or \`${configure_ac}'. - You might want to install the \`Automake' and \`Perl' packages. - Grab them from any GNU archive site." - find . -type f -name Makefile.am -print | - sed 's/\.am$/.in/' | - while read f; do touch "$f"; done - ;; +# If it succeeded, we are done. +test $st -eq 0 && exit 0 - autom4te*) - echo 1>&2 "\ -WARNING: \`$1' is needed, but is $msg. - You might have modified some files without having the - proper tools for further handling them. - You can get \`$1' as part of \`Autoconf' from any GNU - archive site." - - file=`echo "$*" | sed -n "$sed_output"` - test -z "$file" && file=`echo "$*" | sed -n "$sed_minuso"` - if test -f "$file"; then - touch $file - else - test -z "$file" || exec >$file - echo "#! /bin/sh" - echo "# Created by GNU Automake missing as a replacement of" - echo "# $ $@" - echo "exit 0" - chmod +x $file - exit 1 - fi - ;; - - bison*|yacc*) - echo 1>&2 "\ -WARNING: \`$1' $msg. You should only need it if - you modified a \`.y' file. You may need the \`Bison' package - in order for those modifications to take effect. You can get - \`Bison' from any GNU archive site." - rm -f y.tab.c y.tab.h - if test $# -ne 1; then - eval LASTARG="\${$#}" - case $LASTARG in - *.y) - SRCFILE=`echo "$LASTARG" | sed 's/y$/c/'` - if test -f "$SRCFILE"; then - cp "$SRCFILE" y.tab.c - fi - SRCFILE=`echo "$LASTARG" | sed 's/y$/h/'` - if test -f "$SRCFILE"; then - cp "$SRCFILE" y.tab.h - fi - ;; - esac - fi - if test ! -f y.tab.h; then - echo >y.tab.h - fi - if test ! -f y.tab.c; then - echo 'main() { return 0; }' >y.tab.c - fi - ;; - - lex*|flex*) - echo 1>&2 "\ -WARNING: \`$1' is $msg. You should only need it if - you modified a \`.l' file. You may need the \`Flex' package - in order for those modifications to take effect. You can get - \`Flex' from any GNU archive site." - rm -f lex.yy.c - if test $# -ne 1; then - eval LASTARG="\${$#}" - case $LASTARG in - *.l) - SRCFILE=`echo "$LASTARG" | sed 's/l$/c/'` - if test -f "$SRCFILE"; then - cp "$SRCFILE" lex.yy.c - fi - ;; - esac - fi - if test ! -f lex.yy.c; then - echo 'main() { return 0; }' >lex.yy.c - fi - ;; - - help2man*) - echo 1>&2 "\ -WARNING: \`$1' is $msg. You should only need it if - you modified a dependency of a manual page. You may need the - \`Help2man' package in order for those modifications to take - effect. You can get \`Help2man' from any GNU archive site." - - file=`echo "$*" | sed -n "$sed_output"` - test -z "$file" && file=`echo "$*" | sed -n "$sed_minuso"` - if test -f "$file"; then - touch $file - else - test -z "$file" || exec >$file - echo ".ab help2man is required to generate this page" - exit $? - fi - ;; - - makeinfo*) - echo 1>&2 "\ -WARNING: \`$1' is $msg. You should only need it if - you modified a \`.texi' or \`.texinfo' file, or any other file - indirectly affecting the aspect of the manual. The spurious - call might also be the consequence of using a buggy \`make' (AIX, - DU, IRIX). You might want to install the \`Texinfo' package or - the \`GNU make' package. Grab either from any GNU archive site." - # The file to touch is that specified with -o ... - file=`echo "$*" | sed -n "$sed_output"` - test -z "$file" && file=`echo "$*" | sed -n "$sed_minuso"` - if test -z "$file"; then - # ... or it is the one specified with @setfilename ... - infile=`echo "$*" | sed 's/.* \([^ ]*\) *$/\1/'` - file=`sed -n ' - /^@setfilename/{ - s/.* \([^ ]*\) *$/\1/ - p - q - }' $infile` - # ... or it is derived from the source name (dir/f.texi becomes f.info) - test -z "$file" && file=`echo "$infile" | sed 's,.*/,,;s,.[^.]*$,,'`.info - fi - # If the file does not exist, the user really needs makeinfo; - # let's fail without touching anything. - test -f $file || exit 1 - touch $file - ;; - - tar*) - shift - - # We have already tried tar in the generic part. - # Look for gnutar/gtar before invocation to avoid ugly error - # messages. - if (gnutar --version > /dev/null 2>&1); then - gnutar "$@" && exit 0 - fi - if (gtar --version > /dev/null 2>&1); then - gtar "$@" && exit 0 - fi - firstarg="$1" - if shift; then - case $firstarg in - *o*) - firstarg=`echo "$firstarg" | sed s/o//` - tar "$firstarg" "$@" && exit 0 - ;; - esac - case $firstarg in - *h*) - firstarg=`echo "$firstarg" | sed s/h//` - tar "$firstarg" "$@" && exit 0 - ;; - esac - fi - - echo 1>&2 "\ -WARNING: I can't seem to be able to run \`tar' with the given arguments. - You may want to install GNU tar or Free paxutils, or check the - command line arguments." - exit 1 - ;; - - *) - echo 1>&2 "\ -WARNING: \`$1' is needed, and is $msg. - You might have modified some files without having the - proper tools for further handling them. Check the \`README' file, - it often tells you about the needed prerequisites for installing - this package. You may also peek at any GNU archive site, in case - some other package would contain this missing \`$1' program." - exit 1 - ;; -esac +# Also exit now if we it failed (or wasn't found), and '--version' was +# passed; such an option is passed most likely to detect whether the +# program is present and works. +case $2 in --version|--help) exit $st;; esac + +# Exit code 63 means version mismatch. This often happens when the user +# tries to use an ancient version of a tool on a file that requires a +# minimum version. +if test $st -eq 63; then + msg="probably too old" +elif test $st -eq 127; then + # Program was missing. + msg="missing on your system" +else + # Program was found and executed, but failed. Give up. + exit $st +fi -exit 0 +perl_URL=http://www.perl.org/ +flex_URL=http://flex.sourceforge.net/ +gnu_software_URL=http://www.gnu.org/software + +program_details () +{ + case $1 in + aclocal|automake) + echo "The '$1' program is part of the GNU Automake package:" + echo "<$gnu_software_URL/automake>" + echo "It also requires GNU Autoconf, GNU m4 and Perl in order to run:" + echo "<$gnu_software_URL/autoconf>" + echo "<$gnu_software_URL/m4/>" + echo "<$perl_URL>" + ;; + autoconf|autom4te|autoheader) + echo "The '$1' program is part of the GNU Autoconf package:" + echo "<$gnu_software_URL/autoconf/>" + echo "It also requires GNU m4 and Perl in order to run:" + echo "<$gnu_software_URL/m4/>" + echo "<$perl_URL>" + ;; + esac +} + +give_advice () +{ + # Normalize program name to check for. + normalized_program=`echo "$1" | sed ' + s/^gnu-//; t + s/^gnu//; t + s/^g//; t'` + + printf '%s\n' "'$1' is $msg." + + configure_deps="'configure.ac' or m4 files included by 'configure.ac'" + case $normalized_program in + autoconf*) + echo "You should only need it if you modified 'configure.ac'," + echo "or m4 files included by it." + program_details 'autoconf' + ;; + autoheader*) + echo "You should only need it if you modified 'acconfig.h' or" + echo "$configure_deps." + program_details 'autoheader' + ;; + automake*) + echo "You should only need it if you modified 'Makefile.am' or" + echo "$configure_deps." + program_details 'automake' + ;; + aclocal*) + echo "You should only need it if you modified 'acinclude.m4' or" + echo "$configure_deps." + program_details 'aclocal' + ;; + autom4te*) + echo "You might have modified some maintainer files that require" + echo "the 'automa4te' program to be rebuilt." + program_details 'autom4te' + ;; + bison*|yacc*) + echo "You should only need it if you modified a '.y' file." + echo "You may want to install the GNU Bison package:" + echo "<$gnu_software_URL/bison/>" + ;; + lex*|flex*) + echo "You should only need it if you modified a '.l' file." + echo "You may want to install the Fast Lexical Analyzer package:" + echo "<$flex_URL>" + ;; + help2man*) + echo "You should only need it if you modified a dependency" \ + "of a man page." + echo "You may want to install the GNU Help2man package:" + echo "<$gnu_software_URL/help2man/>" + ;; + makeinfo*) + echo "You should only need it if you modified a '.texi' file, or" + echo "any other file indirectly affecting the aspect of the manual." + echo "You might want to install the Texinfo package:" + echo "<$gnu_software_URL/texinfo/>" + echo "The spurious makeinfo call might also be the consequence of" + echo "using a buggy 'make' (AIX, DU, IRIX), in which case you might" + echo "want to install GNU make:" + echo "<$gnu_software_URL/make/>" + ;; + *) + echo "You might have modified some files without having the proper" + echo "tools for further handling them. Check the 'README' file, it" + echo "often tells you about the needed prerequisites for installing" + echo "this package. You may also peek at any GNU archive site, in" + echo "case some other package contains this missing '$1' program." + ;; + esac +} + +give_advice "$1" | sed -e '1s/^/WARNING: /' \ + -e '2,$s/^/ /' >&2 + +# Propagate the correct exit status (expected to be 127 for a program +# not found, 63 for a program that failed due to version mismatch). +exit $st # Local variables: # eval: (add-hook 'write-file-hooks 'time-stamp) diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' --exclude Makefile.in --exclude configure --exclude config.guess --exclude '*.pot' --exclude mkinstalldirs --exclude aclocal.m4 --exclude config.sub --exclude depcomp --exclude install-sh --exclude ltmain.sh old/xlsclients-1.1.2/xlsclients.c new/xlsclients-1.1.3/xlsclients.c --- old/xlsclients-1.1.2/xlsclients.c 2011-03-19 03:12:45.000000000 +0100 +++ new/xlsclients-1.1.3/xlsclients.c 2013-09-08 18:56:56.000000000 +0200 @@ -55,7 +55,7 @@ static void lookat (xcb_connection_t *dpy, xcb_window_t root, int verbose, int maxcmdlen); static void print_client_properties (xcb_connection_t *dpy, xcb_window_t w, int verbose, int maxcmdlen ); -static void print_text_field (xcb_connection_t *dpy, char *s, xcb_get_property_reply_t *tp ); +static void print_text_field (xcb_connection_t *dpy, const char *s, xcb_get_property_reply_t *tp ); static int print_quoted_word (char *s, int maxlen); static void unknown (xcb_connection_t *dpy, xcb_atom_t actual_type, int actual_format ); @@ -68,7 +68,8 @@ usage(void) { fprintf (stderr, - "usage: %s [-display dpy] [-m len] [-[a][l]]\n", ProgramName); + "usage: %s [-display dpy] [-m len] [-[a][l]] [-version]\n", + ProgramName); exit (1); } @@ -168,6 +169,9 @@ if (++i >= argc) usage (); maxcmdlen = atoi (argv[i]); continue; + case 'v': /* -version */ + printf("%s\n", PACKAGE_STRING); + exit(0); } for (cp = &arg[1]; *cp; cp++) { @@ -189,7 +193,7 @@ dpy = xcb_connect(displayname, &screen_number); if (xcb_connection_has_error(dpy)) { - char *name = displayname; + const char *name = displayname; if (!name) name = getenv("DISPLAY"); if (!name) @@ -247,23 +251,23 @@ int i, j; int child_count, num_rep; - xcb_query_tree_reply_t **reply; + xcb_query_tree_reply_t **qt_reply; for (i = 0; i < cs->list_length; i++) { - xcb_get_property_reply_t *reply; - reply = xcb_get_property_reply(c, cs->prop_cookie[i], NULL); - if (reply) { - if (reply->type) { + xcb_get_property_reply_t *gp_reply; + gp_reply = xcb_get_property_reply(c, cs->prop_cookie[i], NULL); + if (gp_reply) { + if (gp_reply->type) { /* Show information for this window */ print_client_properties(c, cs->win[i], cs->verbose, cs->maxcmdlen); - free(reply); + free(gp_reply); /* drain stale replies */ for (j = i+1; j < cs->list_length; j++) { - reply = xcb_get_property_reply(c, cs->prop_cookie[j], NULL); - if (reply) - free(reply); + gp_reply = xcb_get_property_reply(c, cs->prop_cookie[j], NULL); + if (gp_reply) + free(gp_reply); } for (j = 0; j < cs->list_length; j++) { xcb_query_tree_reply_t *rep; @@ -273,25 +277,25 @@ } goto done; } - free(reply); + free(gp_reply); } } /* WM_STATE not found. Recurse into children: */ num_rep = 0; - reply = malloc(sizeof(*reply) * cs->list_length); - if (!reply) + qt_reply = malloc(sizeof(*qt_reply) * cs->list_length); + if (!qt_reply) goto done; /* TODO: print OOM message, drain reply queue */ for (i = 0; i < cs->list_length; i++) { - reply[num_rep] = xcb_query_tree_reply(c, cs->tree_cookie[i], NULL); - if (reply[num_rep]) + qt_reply[num_rep] = xcb_query_tree_reply(c, cs->tree_cookie[i], NULL); + if (qt_reply[num_rep]) num_rep++; } child_count = 0; for (i = 0; i < num_rep; i++) - child_count += reply[i]->children_len; + child_count += qt_reply[i]->children_len; if (!child_count) { /* No children have CS_STATE; try the parent window */ @@ -314,8 +318,8 @@ child_count = 0; for (i = 0; i < num_rep; i++) { - xcb_window_t *child = xcb_query_tree_children(reply[i]); - for (j = 0; j < reply[i]->children_len; j++) { + xcb_window_t *child = xcb_query_tree_children(qt_reply[i]); + for (j = 0; j < qt_reply[i]->children_len; j++) { cs->win[child_count] = child[j]; cs->prop_cookie[child_count] = xcb_get_property(c, 0, child[j], WM_STATE, XCB_GET_PROPERTY_TYPE_ANY, @@ -329,8 +333,8 @@ reply_done: for (i = 0; i < num_rep; i++) - free(reply[i]); - free(reply); + free(qt_reply[i]); + free(qt_reply); done: free(closure); @@ -404,7 +408,7 @@ enqueue(root_list, rl); } -static char *Nil = "(nil)"; +static const char *Nil = "(nil)"; typedef struct { xcb_connection_t *c; @@ -487,7 +491,7 @@ */ if (cs->verbose) { if (wm_class && wm_class->type) { - char *res_name, *res_class; + const char *res_name, *res_class; int name_len, class_len; res_name = xcb_get_property_value(wm_class); name_len = strnlen(res_name, wm_class->value_len) + 1; @@ -560,7 +564,7 @@ } static void -print_text_field(xcb_connection_t *dpy, char *s, xcb_get_property_reply_t *tp) +print_text_field(xcb_connection_t *dpy, const char *s, xcb_get_property_reply_t *tp) { if (tp->type == XCB_NONE || tp->format == 0) { /* Or XCB_ATOM_NONE after libxcb 1.5 */ printf ("''"); -- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
