Hello community,

here is the log from the commit of package pam for openSUSE:Factory checked in 
at 2013-09-14 12:54:12
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Comparing /work/SRC/openSUSE:Factory/pam (Old)
 and      /work/SRC/openSUSE:Factory/.pam.new (New)
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++

Package is "pam"

Changes:
--------
--- /work/SRC/openSUSE:Factory/pam/pam.changes  2013-08-13 11:06:16.000000000 
+0200
+++ /work/SRC/openSUSE:Factory/.pam.new/pam.changes     2013-09-14 
12:54:15.000000000 +0200
@@ -1,0 +2,12 @@
+Thu Sep 12 10:05:53 CEST 2013 - [email protected]
+
+- Remove pam_unix-login.defs.diff, not needed anymore 
+
+-------------------------------------------------------------------
+Thu Sep 12 09:47:52 CEST 2013 - [email protected]
+
+- Update to version 1.1.7 (bugfix release)
+  - Drop missing-DESTDIR.diff and pam-fix-includes.patch
+  - fix-compiler-warnings.diff: fix unchecked setuid return code
+
+-------------------------------------------------------------------

Old:
----
  Linux-PAM-1.1.6-docs.tar.bz2
  Linux-PAM-1.1.6.tar.bz2
  missing-DESTDIR.diff
  pam-fix-includes.patch
  pam_unix-login.defs.diff

New:
----
  Linux-PAM-1.1.7-docs.tar.bz2
  Linux-PAM-1.1.7.tar.bz2
  fix-compiler-warnings.diff

++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++

Other differences:
------------------
++++++ pam.spec ++++++
--- /var/tmp/diff_new_pack.drX7IF/_old  2013-09-14 12:54:16.000000000 +0200
+++ /var/tmp/diff_new_pack.drX7IF/_new  2013-09-14 12:54:16.000000000 +0200
@@ -30,14 +30,11 @@
 %if %{enable_selinux}
 BuildRequires:  libselinux-devel
 %endif
-BuildRequires:  autoconf
-BuildRequires:  automake
-BuildRequires:  libtool
 %define libpam_so_version 0.83.1
 %define libpam_misc_so_version 0.82.0
 %define libpamc_so_version 0.82.1
-
-Version:        1.1.6
+#
+Version:        1.1.7
 Release:        0
 Summary:        A Security Tool that Provides Authentication for Applications
 License:        GPL-2.0+ or BSD-3-Clause
@@ -56,9 +53,7 @@
 Source8:        etc.environment
 Source9:        baselibs.conf
 Patch0:         pam_tally-deprecated.diff
-Patch1:         pam-fix-includes.patch
-Patch2:         missing-DESTDIR.diff
-Patch3:         pam_unix-login.defs.diff
+Patch1:         fix-compiler-warnings.diff
 BuildRoot:      %{_tmppath}/%{name}-%{version}-build
 
 %description
@@ -104,11 +99,8 @@
 %setup -q -n Linux-PAM-%{version} -b 1
 %patch0 -p0
 %patch1 -p0
-%patch2 -p1
-%patch3 -p1
 
 %build
-autoreconf -i
 export CFLAGS="%optflags -DNDEBUG"
 %configure \
        --sbindir=/sbin \

++++++ Linux-PAM-1.1.6-docs.tar.bz2 -> Linux-PAM-1.1.7-docs.tar.bz2 ++++++
++++ 4582 lines of diff (skipped)

++++++ Linux-PAM-1.1.6-docs.tar.bz2 -> Linux-PAM-1.1.7.tar.bz2 ++++++
++++ 263325 lines of diff (skipped)

++++++ fix-compiler-warnings.diff ++++++
--- modules/pam_unix/pam_unix_acct.c
+++ modules/pam_unix/pam_unix_acct.c    2013/09/12 07:19:05
@@ -121,7 +121,12 @@
     if (geteuid() == 0) {
       /* must set the real uid to 0 so the helper will not error
          out if pam is called from setuid binary (su, sudo...) */
-      setuid(0);
+      if (setuid(0) == -1) {
+          pam_syslog(pamh, LOG_ERR, "setuid failed: %m");
+          printf("-1\n");
+          fflush(stdout);
+          _exit(PAM_AUTHINFO_UNAVAIL);
+      }
     }
 
     /* exec binary helper */
--- modules/pam_unix/pam_unix_passwd.c
+++ modules/pam_unix/pam_unix_passwd.c  2013/09/12 07:24:40
@@ -255,7 +255,7 @@
        close(fds[0]);       /* close here to avoid possible SIGPIPE above */
        close(fds[1]);
        /* wait for helper to complete: */
-       while ((rc=waitpid(child, &retval, 0) < 0 && errno == EINTR);
+       while ((rc=waitpid(child, &retval, 0) < 0) && errno == EINTR);
        if (rc<0) {
          pam_syslog(pamh, LOG_ERR, "unix_update waitpid failed: %m");
          retval = PAM_AUTHTOK_ERR;
--- modules/pam_unix/support.c
+++ modules/pam_unix/support.c  2013/09/12 07:20:51
@@ -586,7 +586,10 @@
        if (geteuid() == 0) {
           /* must set the real uid to 0 so the helper will not error
             out if pam is called from setuid binary (su, sudo...) */
-         setuid(0);
+         if (setuid(0) == -1) {
+             D(("setuid failed"));
+            _exit(PAM_AUTHINFO_UNAVAIL);
+          }
        }
 
        /* exec binary helper */
-- 
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to