Hello community, here is the log from the commit of package perl-Test-Deep for openSUSE:Factory checked in at 2013-12-12 11:22:04 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Comparing /work/SRC/openSUSE:Factory/perl-Test-Deep (Old) and /work/SRC/openSUSE:Factory/.perl-Test-Deep.new (New) ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Package is "perl-Test-Deep" Changes: -------- --- /work/SRC/openSUSE:Factory/perl-Test-Deep/perl-Test-Deep.changes 2013-06-06 13:31:24.000000000 +0200 +++ /work/SRC/openSUSE:Factory/.perl-Test-Deep.new/perl-Test-Deep.changes 2013-12-12 11:22:05.000000000 +0100 @@ -1,0 +2,21 @@ +Mon Dec 9 11:17:46 UTC 2013 - [email protected] + +- updated to 0.112 + - rebuild MANIFEST, adding two forgotten files + + - When printing diagnostics, differentiate the type of a blessed object + from the name of the class itself (RT#78288, caused by changes to how + blessed objects are treated in 0.109) (thanks, Karen Etheridge) + + - Typo fixes (thanks, David Steinbrunner) + + - Fixes to clarity and accuracy of documentation (thanks, Michael Hamlin) + + - Add metadata links to repo and issue tracker + + - Added obj_isa for testing ->isa without falling back to ref($x) + + - Added the *experimental* ":v1" export group to skip importing + Isa, isa, and blessed + +------------------------------------------------------------------- Old: ---- Test-Deep-0.110.tar.gz New: ---- Test-Deep-0.112.tar.gz ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Other differences: ------------------ ++++++ perl-Test-Deep.spec ++++++ --- /var/tmp/diff_new_pack.XJXRmc/_old 2013-12-12 11:22:05.000000000 +0100 +++ /var/tmp/diff_new_pack.XJXRmc/_new 2013-12-12 11:22:05.000000000 +0100 @@ -17,7 +17,7 @@ Name: perl-Test-Deep -Version: 0.110 +Version: 0.112 Release: 0 %define cpan_name Test-Deep Summary: Extremely flexible deep comparison @@ -92,6 +92,6 @@ %files -f %{name}.files %defattr(-,root,root,755) -%doc CHANGES README TODO +%doc Changes README TODO %changelog ++++++ Test-Deep-0.110.tar.gz -> Test-Deep-0.112.tar.gz ++++++ diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/Test-Deep-0.110/CHANGES new/Test-Deep-0.112/CHANGES --- old/Test-Deep-0.110/CHANGES 2012-06-16 17:43:48.000000000 +0200 +++ new/Test-Deep-0.112/CHANGES 1970-01-01 01:00:00.000000000 +0100 @@ -1,323 +0,0 @@ -Revision history for Test-Deep - -0.110 2012-06-16 - - Allow methods() and listmethods() to work again on class methods - (RT#77804) (thanks, Ricardo Signes!) - -0.109 2012-02-16 - - UNIVERSAL::isa and UNIVERAL::can are no longer called as functions: - this was deprecated in UNIVERSAL 1.03. (RT#74760, Karen Etheridge) - - the code that builds the exporter configuration is cleaned up; more - documentation of how it may change (for the better, without breaking - stuff) should appear in the near future - -0.108 2010-10-15 - - simple (stringwise) comparison should now be much faster (thanks, - NCLEATON) - -0.107 2009-10-28 - - New maintainer: Ricardo Signes (rjbs) - - On 5.10.0 and newer perl, install to the "site" directory, not the - core perl directory in @INC. (Prior to 5.10.0, @INC ordering was - unfortunate, and fixing the install target would make upgrading - difficult.) - - cope with new stringification of qr{} objects in 5.13.x+ (thanks, - ANDK) - - fix Pod escaping errors (thanks, FWIE) - -0.106 - - Release after dev. - -0.105-dev - - Fix for perl 5.010.1 - the code to check the version and act - correctly on regexp refs treated .1 as behaving like 5.011. - -0.104 - - Document behaviour of cmp_bag when a non ARRAY-ref argument is passed - to it. Explicity test for this a die with a useful message. - - Document and export cmp_details and deep_diag, thanks to Tom Hukins - for the patch. - -0.103 - - Detect whether isa() is being called with 1 or 2 arguments and - dispatch to the correct function. This is hacky but fixes the problem - of clashing with UNIVERSAL::isa(). - -0.102 - - Behave well when a code comparator doesn't give diagnostics. Thanks - to Alex Kapranoff. - -0.101 - - Fix an overloading problem with All and Any. Thanks to Kostas - Chatzikokolakis for reporting the bug and especially for explaining - how to fix it :) - - Added a nasty hack to smooth over a problem in Test::Tester. - -0.100 - - Apply patch from Andreas Koenig (ANDK) to cope with Perl 5.11's new - REGEXP objects. - -0.099 - - Don't explode on perl's that don't have weakrefs. If they're not - available, just don't weaken the refs. It means refs can be cached - for longer than desirable but it's better than explodiing. - - This doesn't fix all of te problems with perl 5.005 but I'm pushing - it out because the previous version number upsets CPAN.pm. - -0.098 - - Cleaned up Test::Deep::NoTest by making it call Test::Deep's import, - that way it will always be in sync for exports. Also added some POD - docs. - - Added notest_extra.t to check that things are correctly exported and - working. - - Add cmp_details but left it undocumented. It manages localising the - stack etc. Factored eq_deeply and cmp_deeply through that. This meant - adding an icky hack into deep_diag. I should clean that whole thing - up. - - Remove $name from params of eq_deeply, in code and docs, it was - unused. - -0.097 - - Fixed doc typo for re(). - - Fix diagnostics for code(), it was always printing undef instead of - the got value. - -0.096 - - %WrapCache was keeping references to external data. It's now - local()ised at the start of a comparison just like the other caches - (why I didn't do that when I added it, I don't know). Thanks to - Matthijs Bomhoff for reporting the problem. - -0.095 - - Docs and code didn't match, useclass was actually requireclass, - available as both now - -0.094 - - Changed Set and Bag to no longer issue warnings when undefs are - present. Needed to make the sort and the diagnotics - undef-aware. Thanks to Colin Kuskie for pointing this out. - - Added tests for this. - -0.093 - - Fixed inifinte recursion when adding comparators into bags. That - whole area is unpleasant - conceptually as well as - implementation-wise. Comparators no longer inherit a compare method, - so we only call the specialised compare if it exists, otherwise we - just do normal deep comparison. - - Removed a debugging print. - -0.092 - - Got the if backwards for loading Test::Builder (again for NoTest - - simples changes...). No ill effects for most people as they load it - via something else any but ApacheSession for example doesn't. - - Now tetsing for lack of testing framework. - -0.091 - - Forgot to export lots of stuff via NoTest - -0.090 - - Added Test::Builder::NoTest so that eq_deeply can be use entirely - without Test::Builder. - -0.089 - - Wasn't corrrectly setting $Test::Builder::Level in cmp_bag, cmp_set - and cmp_methods, this caused test error messages to include the wrong - line/file. - - Whitespace changes. - -0.088 - - Slight twiddle to silence warnings from the new Test::Tester thanks to - SSORICHE - -0.087 - - cmp_methods, cmp_bag and cmp_set weren't passing on the test name. - Thanks to Alex Kapranoff for the patch. - -0.086 - - Add $tolerance to Number so now you can check that 2 numbers are - equal, give or take a little bit. - - Autogenerating most of the convenience constructor routines, deleted - nearly 200 lines of boilerplate. Why didn't I think of that before? - - Almost every test script had the same lines at the beginning. These - are now in t/std.pm, another 200 lines of code (well 50% whitespace) - gone. Happy. - - Added use warnings to the test scripts, didn't make a difference. - - Added inspection of strings captured from a regex and fixed up some - re() doc errors. - -0.085 - - When a hash or array value or amethod does not exist and the expected - value was a reference, the diagnostics were wrong because it headed - into Reftype tests. Now Test::Deep::descend catches "Does not exist" - early on. - - Added listmethods() - -0.084 - - Added subhashof and superhashof, restructured various Hash modules to - handle sub and super. - - Got rid of unexported hash_elements from Test::Deep. - - Fixed a problem with circular set comparisons. - -0.083 - - The cache is more efficient, using a single layer and weak refs, also - previously it could be fooled by reused addresses for objects (this - is not just theoretical). - - Now Test::Deep::descend is responsible for pushing onto the stack as - well as pulling, this means most tests don't need to think about the - stack at all - - For the stack stuff, had to create lots of "only" modules these are - tests that should never be called on their own as they make - assumptions about the validity of the data, they are used as subtests - inside others - - cleaned up lots of copy and paste Data::Dumper and confess and - various other bits and pieces - - Test::Deep::Cmp (and it's descendants) autopush themselves onto the - stack of any Test::Deep::* that uses them. Cuts even more cruft. - - Now everything uses the compare in Test::Deep::Cmp which just does a - deep comparison. This is not perfect for All and Set but it's as good - as what was happeneing before now. - - Wrapping unknown reftypes as shallow - -0.082 - - Got rid of silly use lib in the tests, shouldn't have been in public - - Added dependency on Test::More - - Moved from type =>, vals => to exp =>, got => in stack entries - - Individual descend()s no longer pop their data from the stack, that's - taken care of by Test::Deep::descend. This made things simpler in all - the comparisons. - - Added support for sub/super se/bag comparisons, thanks to Boris - Sukholitko <[email protected]> - - Added scalarref.t - -0.081 - - Got rid of struct mode for num() - - Large internal changes, now using a stack object rather than just an - array. This handles rendering the stack. - - The comparisons handle rendering the got and expected values now. - - num() and str() numify/stringify before comparing, this makes - overload of == or eq irrelevant. This also prevents problems with the - diag when something stringifies differently to it's numificiation or - differently each time you look. - - fixed diag of overloaded refs to display the ref value, not the - overloaded value - - nicer diags for booleans - -0.08 - - Slight doc fix - - Added coderef calling as a test - -0.07 - - Fixed number.t to skip strict test when if Scalar::Util is not right - - Major improvement of docs. No longer reads like it was written by a - drunken badger. - -0.06 - - Overhaul of Test::Deep::descend, native types are now wrapped up in a - Test::Deep:Cmp object, moves lots of logic out of descend - - Added ArrayLength, HashKeys, RefType, and Blessed comparisons - - All tests now use Test::NoWarnings - - Broke out descend tests into hash.t, array, regexpref.t, probably - should break out more - - Updated version of Scalar::Util dependency, thanks to Steve Purkis - -0.05 - - No longer using overload::StrVal() for looking behind overloads as - it's broken for Regexp refs in some versions of Perl. - -0.04 - - Documented bool and included the files!! - -0.03 - - cmp_deeply(undef, \"") calls overload::StrVal(undef) - - added bool test - - using Scalar::Util to get reftype and blessed class - -0.02 - - Added prereq to Makefile.PL - -0.01 - - First release diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/Test-Deep-0.110/Changes new/Test-Deep-0.112/Changes --- old/Test-Deep-0.110/Changes 1970-01-01 01:00:00.000000000 +0100 +++ new/Test-Deep-0.112/Changes 2013-11-30 20:05:44.000000000 +0100 @@ -0,0 +1,343 @@ +Revision history for Test-Deep + +0.112 2013-11-30 + - rebuild MANIFEST, adding two forgotten files + +0.111 2013-11-30 + + - When printing diagnostics, differentiate the type of a blessed object + from the name of the class itself (RT#78288, caused by changes to how + blessed objects are treated in 0.109) (thanks, Karen Etheridge) + + - Typo fixes (thanks, David Steinbrunner) + + - Fixes to clarity and accuracy of documentation (thanks, Michael Hamlin) + + - Add metadata links to repo and issue tracker + + - Added obj_isa for testing ->isa without falling back to ref($x) + + - Added the *experimental* ":v1" export group to skip importing + Isa, isa, and blessed + +0.110 2012-06-16 + + Allow methods() and listmethods() to work again on class methods + (RT#77804) (thanks, Ricardo Signes!) + +0.109 2012-02-16 + + UNIVERSAL::isa and UNIVERAL::can are no longer called as functions: + this was deprecated in UNIVERSAL 1.03. (RT#74760, Karen Etheridge) + + the code that builds the exporter configuration is cleaned up; more + documentation of how it may change (for the better, without breaking + stuff) should appear in the near future + +0.108 2010-10-15 + + simple (stringwise) comparison should now be much faster (thanks, + NCLEATON) + +0.107 2009-10-28 + + New maintainer: Ricardo Signes (rjbs) + + On 5.10.0 and newer perl, install to the "site" directory, not the + core perl directory in @INC. (Prior to 5.10.0, @INC ordering was + unfortunate, and fixing the install target would make upgrading + difficult.) + + cope with new stringification of qr{} objects in 5.13.x+ (thanks, + ANDK) + + fix Pod escaping errors (thanks, FWIE) + +0.106 + + Release after dev. + +0.105-dev + + Fix for perl 5.010.1 - the code to check the version and act + correctly on regexp refs treated .1 as behaving like 5.011. + +0.104 + + Document behaviour of cmp_bag when a non ARRAY-ref argument is passed + to it. Explicity test for this a die with a useful message. + + Document and export cmp_details and deep_diag, thanks to Tom Hukins + for the patch. + +0.103 + + Detect whether isa() is being called with 1 or 2 arguments and + dispatch to the correct function. This is hacky but fixes the problem + of clashing with UNIVERSAL::isa(). + +0.102 + + Behave well when a code comparator doesn't give diagnostics. Thanks + to Alex Kapranoff. + +0.101 + + Fix an overloading problem with All and Any. Thanks to Kostas + Chatzikokolakis for reporting the bug and especially for explaining + how to fix it :) + + Added a nasty hack to smooth over a problem in Test::Tester. + +0.100 + + Apply patch from Andreas Koenig (ANDK) to cope with Perl 5.11's new + REGEXP objects. + +0.099 + + Don't explode on perl's that don't have weakrefs. If they're not + available, just don't weaken the refs. It means refs can be cached + for longer than desirable but it's better than explodiing. + + This doesn't fix all of te problems with perl 5.005 but I'm pushing + it out because the previous version number upsets CPAN.pm. + +0.098 + + Cleaned up Test::Deep::NoTest by making it call Test::Deep's import, + that way it will always be in sync for exports. Also added some POD + docs. + + Added notest_extra.t to check that things are correctly exported and + working. + + Add cmp_details but left it undocumented. It manages localising the + stack etc. Factored eq_deeply and cmp_deeply through that. This meant + adding an icky hack into deep_diag. I should clean that whole thing + up. + + Remove $name from params of eq_deeply, in code and docs, it was + unused. + +0.097 + + Fixed doc typo for re(). + + Fix diagnostics for code(), it was always printing undef instead of + the got value. + +0.096 + + %WrapCache was keeping references to external data. It's now + local()ised at the start of a comparison just like the other caches + (why I didn't do that when I added it, I don't know). Thanks to + Matthijs Bomhoff for reporting the problem. + +0.095 + + Docs and code didn't match, useclass was actually requireclass, + available as both now + +0.094 + + Changed Set and Bag to no longer issue warnings when undefs are + present. Needed to make the sort and the diagnotics + undef-aware. Thanks to Colin Kuskie for pointing this out. + + Added tests for this. + +0.093 + + Fixed inifinte recursion when adding comparators into bags. That + whole area is unpleasant - conceptually as well as + implementation-wise. Comparators no longer inherit a compare method, + so we only call the specialised compare if it exists, otherwise we + just do normal deep comparison. + + Removed a debugging print. + +0.092 + + Got the if backwards for loading Test::Builder (again for NoTest - + simples changes...). No ill effects for most people as they load it + via something else any but ApacheSession for example doesn't. + + Now tetsing for lack of testing framework. + +0.091 + + Forgot to export lots of stuff via NoTest + +0.090 + + Added Test::Builder::NoTest so that eq_deeply can be use entirely + without Test::Builder. + +0.089 + + Wasn't corrrectly setting $Test::Builder::Level in cmp_bag, cmp_set + and cmp_methods, this caused test error messages to include the wrong + line/file. + + Whitespace changes. + +0.088 + + Slight twiddle to silence warnings from the new Test::Tester thanks to + SSORICHE + +0.087 + + cmp_methods, cmp_bag and cmp_set weren't passing on the test name. + Thanks to Alex Kapranoff for the patch. + +0.086 + + Add $tolerance to Number so now you can check that 2 numbers are + equal, give or take a little bit. + + Autogenerating most of the convenience constructor routines, deleted + nearly 200 lines of boilerplate. Why didn't I think of that before? + + Almost every test script had the same lines at the beginning. These + are now in t/std.pm, another 200 lines of code (well 50% whitespace) + gone. Happy. + + Added use warnings to the test scripts, didn't make a difference. + + Added inspection of strings captured from a regex and fixed up some + re() doc errors. + +0.085 + + When a hash or array value or amethod does not exist and the expected + value was a reference, the diagnostics were wrong because it headed + into Reftype tests. Now Test::Deep::descend catches "Does not exist" + early on. + + Added listmethods() + +0.084 + + Added subhashof and superhashof, restructured various Hash modules to + handle sub and super. + + Got rid of unexported hash_elements from Test::Deep. + + Fixed a problem with circular set comparisons. + +0.083 + + The cache is more efficient, using a single layer and weak refs, also + previously it could be fooled by reused addresses for objects (this + is not just theoretical). + + Now Test::Deep::descend is responsible for pushing onto the stack as + well as pulling, this means most tests don't need to think about the + stack at all + + For the stack stuff, had to create lots of "only" modules these are + tests that should never be called on their own as they make + assumptions about the validity of the data, they are used as subtests + inside others + + cleaned up lots of copy and paste Data::Dumper and confess and + various other bits and pieces + + Test::Deep::Cmp (and it's descendants) autopush themselves onto the + stack of any Test::Deep::* that uses them. Cuts even more cruft. + + Now everything uses the compare in Test::Deep::Cmp which just does a + deep comparison. This is not perfect for All and Set but it's as good + as what was happeneing before now. + + Wrapping unknown reftypes as shallow + +0.082 + + Got rid of silly use lib in the tests, shouldn't have been in public + + Added dependency on Test::More + + Moved from type =>, vals => to exp =>, got => in stack entries + + Individual descend()s no longer pop their data from the stack, that's + taken care of by Test::Deep::descend. This made things simpler in all + the comparisons. + + Added support for sub/super se/bag comparisons, thanks to Boris + Sukholitko <[email protected]> + + Added scalarref.t + +0.081 + + Got rid of struct mode for num() + + Large internal changes, now using a stack object rather than just an + array. This handles rendering the stack. + + The comparisons handle rendering the got and expected values now. + + num() and str() numify/stringify before comparing, this makes + overload of == or eq irrelevant. This also prevents problems with the + diag when something stringifies differently to it's numificiation or + differently each time you look. + + fixed diag of overloaded refs to display the ref value, not the + overloaded value + + nicer diags for booleans + +0.08 + + Slight doc fix + + Added coderef calling as a test + +0.07 + + Fixed number.t to skip strict test when if Scalar::Util is not right + + Major improvement of docs. No longer reads like it was written by a + drunken badger. + +0.06 + + Overhaul of Test::Deep::descend, native types are now wrapped up in a + Test::Deep:Cmp object, moves lots of logic out of descend + + Added ArrayLength, HashKeys, RefType, and Blessed comparisons + + All tests now use Test::NoWarnings + + Broke out descend tests into hash.t, array, regexpref.t, probably + should break out more + + Updated version of Scalar::Util dependency, thanks to Steve Purkis + +0.05 + + No longer using overload::StrVal() for looking behind overloads as + it's broken for Regexp refs in some versions of Perl. + +0.04 + + Documented bool and included the files!! + +0.03 + + cmp_deeply(undef, \"") calls overload::StrVal(undef) + + added bool test + + using Scalar::Util to get reftype and blessed class + +0.02 + + Added prereq to Makefile.PL + +0.01 + + First release diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/Test-Deep-0.110/MANIFEST new/Test-Deep-0.112/MANIFEST --- old/Test-Deep-0.110/MANIFEST 2012-06-16 17:44:48.000000000 +0200 +++ new/Test-Deep-0.112/MANIFEST 2013-11-30 20:06:08.000000000 +0100 @@ -1,4 +1,4 @@ -CHANGES +Changes lib/Test/Deep.pm lib/Test/Deep/All.pm lib/Test/Deep/Any.pm @@ -26,6 +26,7 @@ lib/Test/Deep/MM.pm lib/Test/Deep/NoTest.pm lib/Test/Deep/Number.pm +lib/Test/Deep/Obj.pm lib/Test/Deep/Ref.pm lib/Test/Deep/RefType.pm lib/Test/Deep/Regexp.pm @@ -75,6 +76,7 @@ t/regexp.t t/regexp.t.orig t/regexpref.t +t/rt78288_blessed_object.t t/scalar.t t/scalarref.t t/set.t diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/Test-Deep-0.110/META.json new/Test-Deep-0.112/META.json --- old/Test-Deep-0.110/META.json 2012-06-16 17:44:48.000000000 +0200 +++ new/Test-Deep-0.112/META.json 2013-11-30 20:06:08.000000000 +0100 @@ -4,7 +4,7 @@ "Fergal Daly <[email protected]>" ], "dynamic_config" : 1, - "generated_by" : "ExtUtils::MakeMaker version 6.6302, CPAN::Meta::Converter version 2.120921", + "generated_by" : "ExtUtils::MakeMaker version 6.82, CPAN::Meta::Converter version 2.132830", "license" : [ "unknown" ], @@ -41,5 +41,18 @@ } }, "release_status" : "stable", - "version" : "0.110" + "resources" : { + "bugtracker" : { + "web" : "http://github.com/rjbs/Test-Deep/issues/"; + }, + "homepage" : "http://github.com/rjbs/Test-Deep/";, + "license" : [ + "http://dev.perl.org/licenses/"; + ], + "repository" : { + "url" : "http://github.com/rjbs/Test-Deep/"; + }, + "x_MailingList" : "http://lists.perl.org/list/perl-qa.html"; + }, + "version" : "0.112" } diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/Test-Deep-0.110/META.yml new/Test-Deep-0.112/META.yml --- old/Test-Deep-0.110/META.yml 2012-06-16 17:44:47.000000000 +0200 +++ new/Test-Deep-0.112/META.yml 2013-11-30 20:06:08.000000000 +0100 @@ -7,7 +7,7 @@ configure_requires: ExtUtils::MakeMaker: 0 dynamic_config: 1 -generated_by: 'ExtUtils::MakeMaker version 6.6302, CPAN::Meta::Converter version 2.120921' +generated_by: 'ExtUtils::MakeMaker version 6.82, CPAN::Meta::Converter version 2.132830' license: unknown meta-spec: url: http://module-build.sourceforge.net/META-spec-v1.4.html @@ -23,4 +23,10 @@ Test::More: 0 Test::NoWarnings: 0.02 Test::Tester: 0.04 -version: 0.110 +resources: + MailingList: http://lists.perl.org/list/perl-qa.html + bugtracker: http://github.com/rjbs/Test-Deep/issues/ + homepage: http://github.com/rjbs/Test-Deep/ + license: http://dev.perl.org/licenses/ + repository: http://github.com/rjbs/Test-Deep/ +version: 0.112 diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/Test-Deep-0.110/Makefile.PL new/Test-Deep-0.112/Makefile.PL --- old/Test-Deep-0.110/Makefile.PL 2010-10-16 04:28:22.000000000 +0200 +++ new/Test-Deep-0.112/Makefile.PL 2013-11-30 15:57:59.000000000 +0100 @@ -17,6 +17,8 @@ $tt_prereq = "0.107"; } +my $mm_ver = ExtUtils::MakeMaker->VERSION; + WriteMakefile( AUTHOR => 'Fergal Daly <[email protected]>', NAME => 'Test::Deep', @@ -31,5 +33,20 @@ 'List::Util' => '1.09', }, + # This is a dumb mistake. Why did it get done? I'm the one who did it and I + # don't know. It only affects perl 5.8, and stopping doing it now would be a + # problem, because upgrades wouldn't actually upgrade. I'll just leave it + # here until 5.8 is really and truly dead enough. -- rjbs, 2013-11-30 ($] < 5.010 ? (INSTALLDIRS => 'perl') : ()), + + ($mm_ver < 6.46 ? () : (META_MERGE => { + resources => { + license => 'http://dev.perl.org/licenses/', + homepage => 'http://github.com/rjbs/Test-Deep/', + bugtracker => 'http://github.com/rjbs/Test-Deep/issues/', + repository => 'http://github.com/rjbs/Test-Deep/', + MailingList => 'http://lists.perl.org/list/perl-qa.html', + }, + })), + ); diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/Test-Deep-0.110/lib/Test/Deep/Isa.pm new/Test-Deep-0.112/lib/Test/Deep/Isa.pm --- old/Test-Deep-0.110/lib/Test/Deep/Isa.pm 2012-02-10 23:56:24.000000000 +0100 +++ new/Test-Deep-0.112/lib/Test/Deep/Isa.pm 2013-11-30 16:11:24.000000000 +0100 @@ -33,4 +33,11 @@ return "Checking class of $where with isa()"; } +sub renderExp +{ + my $self = shift; + + return "blessed into or ref of type '$self->{val}'"; +} + 1; diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/Test-Deep-0.110/lib/Test/Deep/NoTest.pm new/Test-Deep-0.112/lib/Test/Deep/NoTest.pm --- old/Test-Deep-0.110/lib/Test/Deep/NoTest.pm 2012-02-11 03:31:22.000000000 +0100 +++ new/Test-Deep-0.112/lib/Test/Deep/NoTest.pm 2013-04-13 16:51:30.000000000 +0200 @@ -31,9 +31,9 @@ use Test::Deep::NoTest; - if eq_deeply($a, $b) { + if (eq_deeply($a, $b)) { print "they were deeply equal\n"; - }; + } =head1 DESCRIPTION diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/Test-Deep-0.110/lib/Test/Deep/Obj.pm new/Test-Deep-0.112/lib/Test/Deep/Obj.pm --- old/Test-Deep-0.110/lib/Test/Deep/Obj.pm 1970-01-01 01:00:00.000000000 +0100 +++ new/Test-Deep-0.112/lib/Test/Deep/Obj.pm 2013-11-30 16:16:14.000000000 +0100 @@ -0,0 +1,42 @@ +use strict; +use warnings; + +package Test::Deep::Obj; + +use Test::Deep::Cmp; +use Scalar::Util; + +sub init +{ + my $self = shift; + + my $val = shift; + $self->{val} = $val; +} + +sub descend +{ + my $self = shift; + my $got = shift; + + return Scalar::Util::blessed($got) + && $got->isa($self->{val}); +} + +sub diag_message +{ + my $self = shift; + + my $where = shift; + + return "Checking class of $where with isa()"; +} + +sub renderExp +{ + my $self = shift; + + return "blessed into '$self->{val}' or subclass of '$self->{val}'"; +} + +1; diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/Test-Deep-0.110/lib/Test/Deep/Set.pm new/Test-Deep-0.112/lib/Test/Deep/Set.pm --- old/Test-Deep-0.110/lib/Test/Deep/Set.pm 2010-09-25 21:32:52.000000000 +0200 +++ new/Test-Deep-0.112/lib/Test/Deep/Set.pm 2013-11-30 15:42:59.000000000 +0100 @@ -177,7 +177,7 @@ return 0 if $self->{IgnoreDupes} != $other->{IgnoreDupes}; - # this works (kind of) because the the arrays are sorted + # this works (kind of) because the arrays are sorted return Test::Deep::descend($self->{val}, $other->{val}); } diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/Test-Deep-0.110/lib/Test/Deep.pm new/Test-Deep-0.112/lib/Test/Deep.pm --- old/Test-Deep-0.110/lib/Test/Deep.pm 2012-06-16 17:43:54.000000000 +0200 +++ new/Test-Deep-0.112/lib/Test/Deep.pm 2013-11-30 20:05:50.000000000 +0100 @@ -21,7 +21,7 @@ our ($Stack, %Compared, $CompareCache, %WrapCache, $Shallow); -our $VERSION = '0.110'; +our $VERSION = '0.112'; $VERSION = eval $VERSION; require Exporter; @@ -34,7 +34,7 @@ our $DNE_ADDR = Scalar::Util::refaddr($DNE); # if no sub name is supplied then we use the package name in lower case -my %constructors = ( +my @constructors = ( All => "", Any => "", Array => "", @@ -54,6 +54,7 @@ ListMethods => "", Methods => "", Number => "num", + Obj => "obj_isa", RefType => "", Regexp => "re", RegexpMatches => "", @@ -66,9 +67,9 @@ String => "str", ); -our @CONSTRUCTORS_FROM_CLASSES; +my @CONSTRUCTORS_FROM_CLASSES; -while (my ($pkg, $name) = each %constructors) +while (my ($pkg, $name) = splice @constructors, 0, 2) { $name = lc($pkg) unless $name; my $full_pkg = "Test::Deep::$pkg"; @@ -93,9 +94,11 @@ $EXPORT_TAGS{v0} = [ qw( Isa + blessed + obj_isa all any array array_each arrayelementsonly arraylength arraylengthonly - bag blessed bool cmp_bag cmp_deeply cmp_methods cmp_set code eq_deeply + bag bool cmp_bag cmp_deeply cmp_methods cmp_set code eq_deeply hash hash_each hashkeys hashkeysonly ignore isa listmethods methods noclass num re reftype regexpmatches regexponly regexpref regexprefonly scalarrefonly scalref set shallow str subbagof subhashof subsetof @@ -103,6 +106,19 @@ ) ]; + $EXPORT_TAGS{v1} = [ + qw( + obj_isa + + all any array array_each arrayelementsonly arraylength arraylengthonly + bag bool cmp_bag cmp_deeply cmp_methods cmp_set code eq_deeply + hash hash_each hashkeys hashkeysonly ignore listmethods methods + noclass num re reftype regexpmatches regexponly regexpref regexprefonly + scalarrefonly scalref set shallow str subbagof subhashof subsetof + superbagof superhashof supersetof useclass + ) + ]; + our @EXPORT = @{ $EXPORT_TAGS{ v0 } }; $EXPORT_TAGS{all} = [ @EXPORT, @EXPORT_OK ]; @@ -275,7 +291,7 @@ if (! $Expects and Scalar::Util::blessed($d1) and $d1->isa("Test::Deep::Cmp")) { my $where = $Stack->render('$data'); - confess "Found a special comparison in $where\nYou can only the specials in the expects structure"; + confess "Found a special comparison in $where\nYou can only use specials in the expects structure"; } if (ref $d1 and ref $d2) @@ -320,7 +336,7 @@ if (ref($d1) and (Scalar::Util::refaddr($d1) == $DNE_ADDR)) { - # whatever it was suposed to be, it didn't exist and so it's an + # whatever it was supposed to be, it didn't exist and so it's an # automatic fail return 0; } @@ -432,7 +448,7 @@ return Test::Deep::Class->new(1, $val); } -# docs and export say this is call useclass, doh! +# docs and export say this is called useclass, doh! *useclass = \&requireclass; @@ -742,7 +758,7 @@ # note no mention of Children here }; - $person_cmp->{Children} = each_array($person_cmp); + $person_cmp->{Children} = array_each($person_cmp); cmp_deeply($person, $person_cmp, "person ok"); @@ -961,7 +977,7 @@ This can be useful when you want to check that objects have been constructed correctly but you don't want to write lots of -C<bless>es. If \@people is an array of Person objects then +C<bless>es. If @people is an array of Person objects then cmp_deeply(\@people, noclass([ bless {name => 'John', phone => '555-5555'}, "Person", @@ -979,7 +995,7 @@ blessed correctly. You could use a map to bless all those hashes or you could do a second test like - cmp_deeply($people, array_each(isa("Person")); + cmp_deeply(\@people, array_each(isa("Person")); =head3 useclass($thing) @@ -1121,10 +1137,10 @@ The object returned by set() has an add() method. - my $set = set(1, 2, 3); - $set->add(4, 5, 6); + my $set = set(1, 2); + $set->add(1, 3, 1); -will result in a set containing 1, 2, 3, 4, 5, 5. +will result in a set containing 1, 2, 3. C<NOTE> See the NOTE on the bag() comparison for some dangers in using special comparisons inside set() @@ -1139,9 +1155,9 @@ checks that @$data contains at most 2 "1"s, 1 "3" and 1 "4" and - cmp_deeply($data, supersetof(1, 4)); + cmp_deeply($data, supersetof(1, 1, 1, 4)); -check that @$data contains at least 1 "1" and 1 "4". +will check that @$data has at least one "1" and at least one "4". These are just special cases of the Set and Bag comparisons so they also give you an add() method and they also have the same limitations when using @@ -1168,13 +1184,13 @@ Thanks to the magic of overloading, you can write - all(isa("Person"), methods(name => 'John'), re("^wi")) + any( re("^wi"), all(isa("Person"), methods(name => 'John')) ) as - isa("Person") & methods(name => 'John') | re("^wi") + re("^wi") | isa("Person") & methods(name => 'John') -Note B<single> | not double as || cannot be overloaded. This will only work +Note B<single> | not double, as || cannot be overloaded. This will only work when there is a special comparison involved. If you write "john" | "anne" | "robert" @@ -1315,7 +1331,7 @@ } } - cmp_deeply("Brian", \&check_name); + cmp_deeply("Brian", code(\&check_name)); =head1 DIAGNOSTIC FUNCTIONS diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/Test-Deep-0.110/t/error.t new/Test-Deep-0.112/t/error.t --- old/Test-Deep-0.110/t/error.t 2010-09-25 21:32:52.000000000 +0200 +++ new/Test-Deep-0.112/t/error.t 2013-11-30 16:03:48.000000000 +0100 @@ -12,6 +12,6 @@ ); }; - like($@, qr/^Found a special comparison in \$data->\[0\]\nYou can only the specials in the expects structure/, + like($@, qr/^Found a special comparison in \$data->\[0\]\nYou can only use specials in the expects structure/, "bad special"); } diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/Test-Deep-0.110/t/isa.t new/Test-Deep-0.112/t/isa.t --- old/Test-Deep-0.110/t/isa.t 2012-02-10 23:56:56.000000000 +0100 +++ new/Test-Deep-0.112/t/isa.t 2013-11-30 16:15:57.000000000 +0100 @@ -16,6 +16,21 @@ }, "isa eq" ); + + check_test( + sub { + cmp_deeply($a, obj_isa("HASH")); + }, + { + actual_ok => 0, + diag => <<EOM, +Checking class of \$data with isa() + got : $a +expect : blessed into 'HASH' or subclass of 'HASH' +EOM + }, + "obj_isa eq" + ); } { @@ -32,6 +47,17 @@ "isa eq" ); + check_test( + sub { + cmp_deeply($b, obj_isa("B")); + }, + { + actual_ok => 1, + diag => "", + }, + "isa eq" + ); + check_test( sub { @@ -42,12 +68,28 @@ diag => <<EOM, Checking class of \$data with isa() got : $b -expect : 'A' +expect : blessed into or ref of type 'A' EOM }, "isa eq" ); + check_test( + sub { + cmp_deeply($b, obj_isa("A")); + }, + { + actual_ok => 0, + diag => <<EOM, +Checking class of \$data with isa() + got : $b +expect : blessed into 'A' or subclass of 'A' +EOM + }, + "isa eq" + ); + + @A::ISA = (); @B::ISA = ("A"); @@ -57,6 +99,17 @@ }, { actual_ok => 1, + diag => "", + }, + "isa eq" + ); + + check_test( + sub { + cmp_deeply($b, obj_isa("A")); + }, + { + actual_ok => 1, diag => "", }, "isa eq" diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/Test-Deep-0.110/t/rt78288_blessed_object.t new/Test-Deep-0.112/t/rt78288_blessed_object.t --- old/Test-Deep-0.110/t/rt78288_blessed_object.t 1970-01-01 01:00:00.000000000 +0100 +++ new/Test-Deep-0.112/t/rt78288_blessed_object.t 2013-11-30 16:12:28.000000000 +0100 @@ -0,0 +1,20 @@ +use strict; +use warnings FATAL => 'all'; + +use t::std; + +check_test( + sub { cmp_deeply('Foo', isa('Foo')) }, + { + actual_ok => 0, + diag => <<EOM, +Checking class of \$data with isa() + got : 'Foo' +expect : blessed into or ref of type 'Foo' +EOM + }, + 'isa on a string' +); + + + -- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
