Hello community, here is the log from the commit of package OpenIPMI for openSUSE:Factory checked in at 2014-01-17 11:05:00 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Comparing /work/SRC/openSUSE:Factory/OpenIPMI (Old) and /work/SRC/openSUSE:Factory/.OpenIPMI.new (New) ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Package is "OpenIPMI" Changes: -------- --- /work/SRC/openSUSE:Factory/OpenIPMI/OpenIPMI.changes 2013-10-11 12:53:58.000000000 +0200 +++ /work/SRC/openSUSE:Factory/.OpenIPMI.new/OpenIPMI.changes 2014-01-23 15:39:17.000000000 +0100 @@ -1,0 +2,9 @@ +Thu Jan 9 15:03:26 UTC 2014 - [email protected] + +- Cleanup patches: + Drop: fix-devel-deps.patch + Add changelog to most of the patches and submitted them mainline. + Add: bug-854693_segv_sol.patch + bnc#854693 + +------------------------------------------------------------------- Old: ---- fix-devel-deps.patch New: ---- bug-854693_segv_sol.patch ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Other differences: ------------------ ++++++ OpenIPMI.spec ++++++ --- /var/tmp/diff_new_pack.wukeDx/_old 2014-01-23 15:39:17.000000000 +0100 +++ /var/tmp/diff_new_pack.wukeDx/_new 2014-01-23 15:39:17.000000000 +0100 @@ -1,7 +1,7 @@ # # spec file for package OpenIPMI # -# Copyright (c) 2013 SUSE LINUX Products GmbH, Nuernberg, Germany. +# Copyright (c) 2014 SUSE LINUX Products GmbH, Nuernberg, Germany. # # All modifications and additions to the file contributed by third parties # remain the property of their copyright owners, unless otherwise agreed @@ -48,16 +48,16 @@ Source1: sysconfig.ipmi Source2: openipmi.initscript Patch0: OpenIPMI-prefer_perl_vendor.patch -Patch2: new-names-for-new-variables -Patch3: OpenIPMI-libtool.patch +Patch1: tcl-includes-moved.patch +Patch2: OpenIPMI-libtool.patch +Patch3: new-names-for-new-variables Patch4: OpenIPMI-popt.patch Patch5: OpenIPMI-2.0.16-larger-ipmibuf.patch -Patch6: fix-devel-deps.patch # upstream ID 3587484 -Patch7: do-fclose.patch -Patch8: fix-conversions.patch +Patch6: do-fclose.patch +Patch7: fix-conversions.patch # location of tcl.h moved from include/tcl to include, [email protected] -Patch9: tcl-includes-moved.patch +Patch8: bug-854693_segv_sol.patch Source99: OpenIPMI-rpmlintrc Url: http://openipmi.sourceforge.net Provides: ipmi_ui @@ -112,14 +112,14 @@ %prep %setup -n %{name}-%{pkgversion} %patch0 -p1 -%patch2 -p1 +%patch1 -p1 +%patch2 %patch3 -%patch4 +%patch4 -p1 %patch5 -p1 %patch6 -p1 %patch7 -p1 %patch8 -p1 -%patch9 -p1 %build autoreconf --install --force ++++++ OpenIPMI-2.0.16-larger-ipmibuf.patch ++++++ --- /var/tmp/diff_new_pack.wukeDx/_old 2014-01-23 15:39:18.000000000 +0100 +++ /var/tmp/diff_new_pack.wukeDx/_new 2014-01-23 15:39:18.000000000 +0100 @@ -1,3 +1,10 @@ +Use 256 byte max message length instead of 80 + +I could not find any reference to this one, but it looks like for specific +hardware this necessary. + +Signed-off-by: Thomas Renninger <[email protected]> + diff -wruN -x '*~' -x '*.o' -x '*.a' -x '*.so' -x '*.so.[0-9]' -x autom4te.cache -x .deps -x .libs ../orig-OpenIPMI-2.0.20-rc3/include/linux/ipmi_msgdefs.h ./include/linux/ipmi_msgdefs.h --- ../orig-OpenIPMI-2.0.20-rc3/include/linux/ipmi_msgdefs.h 2012-07-22 00:01:45.000000000 +0200 +++ ./include/linux/ipmi_msgdefs.h 2013-10-04 09:41:31.801884531 +0200 ++++++ OpenIPMI-popt.patch ++++++ --- /var/tmp/diff_new_pack.wukeDx/_old 2014-01-23 15:39:18.000000000 +0100 +++ /var/tmp/diff_new_pack.wukeDx/_new 2014-01-23 15:39:18.000000000 +0100 @@ -1,3 +1,15 @@ +Check for the used poptGetContext instead of an unused variable + +grep poptHelpOptions * -r +reveals that this variable/function is not used in the code at all. +nm -D /usr/lib64/libpopt.so.0 |less +reveals that poptHelpOptions is a variable only. + +Check for the used (lanserv/lanserv.c and lanserv/ipmi_sim.c) poptGetContext +function instead whether the popt library functions are available. + +Signed-off-by: Thomas Renninger <[email protected]> + diff -wruN -x '*~' -x '*.o' -x '*.a' -x '*.so' -x '*.so.[0-9]' -x autom4te.cache -x .deps -x .libs ../orig-OpenIPMI-2.0.20-rc3/configure.in ./configure.in --- ../orig-OpenIPMI-2.0.20-rc3/configure.in 2013-10-04 09:38:40.754850007 +0200 +++ ./configure.in 2013-10-04 09:40:32.959464727 +0200 ++++++ bug-854693_segv_sol.patch ++++++ From: William Preston <[email protected]> Fix segfault if a message comes in before hand shaking is successfully finished Signed-off-by: Thomas Renninger <[email protected]> --- OpenIPMI-2.0.16/lib/ipmi_sol.c +++ OpenIPMI-2.0.16/lib/ipmi_sol.c @@ -3532,7 +3532,8 @@ sol_handle_recv_async(ipmi_con_t *ipm dump_hex(packet, data_len); #endif - if (conn->state == ipmi_sol_state_closed) { + if ((conn->state != ipmi_sol_state_connected) + && (conn->state != ipmi_sol_state_connected_ctu)) { ipmi_log(IPMI_LOG_WARNING, "ipmi_sol.c(sol_handle_recv_async): " "Dropped incoming SoL packet: connection closed."); ++++++ do-fclose.patch ++++++ --- /var/tmp/diff_new_pack.wukeDx/_old 2014-01-23 15:39:18.000000000 +0100 +++ /var/tmp/diff_new_pack.wukeDx/_new 2014-01-23 15:39:18.000000000 +0100 @@ -1,3 +1,7 @@ +Fix file descriptor leaks and a memory leak in error case + +Signed-off-by: Thomas Renninger <[email protected]> + diff -wruN -x '*~' -x '*.o' -x '*.a' -x '*.so' -x '*.so.[0-9]' -x autom4te.cache -x .deps -x .libs ../orig-OpenIPMI-2.0.20-rc3/lanserv/config.c ./lanserv/config.c --- ../orig-OpenIPMI-2.0.20-rc3/lanserv/config.c 2013-01-21 18:24:13.000000000 +0100 +++ ./lanserv/config.c 2013-10-04 09:46:41.322610344 +0200 ++++++ fix-conversions.patch ++++++ --- /var/tmp/diff_new_pack.wukeDx/_old 2014-01-23 15:39:18.000000000 +0100 +++ /var/tmp/diff_new_pack.wukeDx/_new 2014-01-23 15:39:18.000000000 +0100 @@ -1,3 +1,6 @@ +Not sure for what exactly this could be + + diff -wruN -x '*~' -x '*.o' -x '*.a' -x '*.so' -x '*.so.[0-9]' -x autom4te.cache -x .deps -x .libs ../orig-OpenIPMI-2.0.20-rc3/swig/OpenIPMI.i ./swig/OpenIPMI.i --- ../orig-OpenIPMI-2.0.20-rc3/swig/OpenIPMI.i 2013-08-28 17:02:23.000000000 +0200 +++ ./swig/OpenIPMI.i 2013-10-04 09:50:14.951385925 +0200 ++++++ new-names-for-new-variables ++++++ --- /var/tmp/diff_new_pack.wukeDx/_old 2014-01-23 15:39:18.000000000 +0100 +++ /var/tmp/diff_new_pack.wukeDx/_new 2014-01-23 15:39:18.000000000 +0100 @@ -1,3 +1,7 @@ +Rename variable from addr to rmcpp_addr + +Signed-off-by: Thomas Renninger <[email protected]> + diff -wruN -x '*~' -x '*.o' -x '*.a' -x '*.so' -x '*.so.[0-9]' -x autom4te.cache -x .deps -x .libs ../orig-OpenIPMI-2.0.20-rc3/lib/ipmi_lan.c ./lib/ipmi_lan.c --- ../orig-OpenIPMI-2.0.20-rc3/lib/ipmi_lan.c 2013-08-28 14:57:28.000000000 +0200 +++ ./lib/ipmi_lan.c 2013-10-04 09:38:55.847470769 +0200 -- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
