Hello community, here is the log from the commit of package yast2-storage for openSUSE:Factory checked in at 2014-08-01 14:34:11 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Comparing /work/SRC/openSUSE:Factory/yast2-storage (Old) and /work/SRC/openSUSE:Factory/.yast2-storage.new (New) ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Package is "yast2-storage" Changes: -------- --- /work/SRC/openSUSE:Factory/yast2-storage/yast2-storage.changes 2014-07-25 12:37:16.000000000 +0200 +++ /work/SRC/openSUSE:Factory/.yast2-storage.new/yast2-storage.changes 2014-08-01 14:34:12.000000000 +0200 @@ -1,0 +2,6 @@ +Thu Jul 31 11:18:58 CEST 2014 - [email protected] + +- disable snapshots if the root filesystem is small (bnc#888549) +- version 3.1.40 + +------------------------------------------------------------------- Old: ---- yast2-storage-3.1.39.tar.bz2 New: ---- yast2-storage-3.1.40.tar.bz2 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Other differences: ------------------ ++++++ yast2-storage.spec ++++++ --- /var/tmp/diff_new_pack.bREqFj/_old 2014-08-01 14:34:13.000000000 +0200 +++ /var/tmp/diff_new_pack.bREqFj/_new 2014-08-01 14:34:13.000000000 +0200 @@ -17,7 +17,7 @@ Name: yast2-storage -Version: 3.1.39 +Version: 3.1.40 Release: 0 BuildRoot: %{_tmppath}/%{name}-%{version}-build ++++++ yast2-storage-3.1.39.tar.bz2 -> yast2-storage-3.1.40.tar.bz2 ++++++ diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/yast2-storage-3.1.39/package/yast2-storage.changes new/yast2-storage-3.1.40/package/yast2-storage.changes --- old/yast2-storage-3.1.39/package/yast2-storage.changes 2014-07-24 15:14:15.000000000 +0200 +++ new/yast2-storage-3.1.40/package/yast2-storage.changes 2014-07-31 14:09:43.000000000 +0200 @@ -1,4 +1,10 @@ ------------------------------------------------------------------- +Thu Jul 31 11:18:58 CEST 2014 - [email protected] + +- disable snapshots if the root filesystem is small (bnc#888549) +- version 3.1.40 + +------------------------------------------------------------------- Tue Jul 22 10:23:00 CEST 2014 - [email protected] - disable btrfs quota again (see bnc#887046) diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/yast2-storage-3.1.39/package/yast2-storage.spec new/yast2-storage-3.1.40/package/yast2-storage.spec --- old/yast2-storage-3.1.39/package/yast2-storage.spec 2014-07-24 15:14:15.000000000 +0200 +++ new/yast2-storage-3.1.40/package/yast2-storage.spec 2014-07-31 14:09:43.000000000 +0200 @@ -17,7 +17,7 @@ Name: yast2-storage -Version: 3.1.39 +Version: 3.1.40 Release: 0 BuildRoot: %{_tmppath}/%{name}-%{version}-build diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/yast2-storage-3.1.39/src/clients/inst_disk_proposal.rb new/yast2-storage-3.1.40/src/clients/inst_disk_proposal.rb --- old/yast2-storage-3.1.39/src/clients/inst_disk_proposal.rb 2014-07-24 15:14:15.000000000 +0200 +++ new/yast2-storage-3.1.40/src/clients/inst_disk_proposal.rb 2014-07-31 14:09:43.000000000 +0200 @@ -88,14 +88,20 @@ Builtins.y2milestone("prop ok:%1", Ops.get_boolean(@prop, "ok", false)) if Ops.get_boolean(@prop, "ok", false) - if CouldNotDoSeparateHome(Ops.get_map(@prop, "target", {})) + @targetMap = Ops.get_map(@prop, "target", {}) + if StorageProposal.CouldNotDoSnapshots(@targetMap) + StorageProposal.SetProposalSnapshots(false) + if UI.WidgetExists(Id(:snapshots)) + UI.ChangeWidget(Id(:snapshots), :Value, false) + end + end + if StorageProposal.CouldNotDoSeparateHome(@targetMap) StorageProposal.SetProposalHome(false) if UI.WidgetExists(Id(:home)) UI.ChangeWidget(Id(:home), :Value, false) end end - Storage.SetTargetMap(Ops.get_map(@prop, "target", {})) - @targetMap = Ops.get_map(@prop, "target", {}) + Storage.SetTargetMap(@targetMap) Storage.SetPartProposalMode("accept") @changes = Storage.ChangeText Storage.HandleProposalPackages @@ -226,14 +232,19 @@ Popup.Error(_("Impossible to create the requested proposal.")) Storage.SetPartProposalMode("impossible") else - if CouldNotDoSeparateHome(Ops.get_map(@prop, "target", {})) - @reason = _( - "Not enough space available to propose separate /home." - ) + @targetMap = Ops.get_map(@prop, "target", {}) + if StorageProposal.CouldNotDoSnapshots(@targetMap) + # TRANSLATORS: popup error message + @reason = _("Not enough space available to propose snapshots for root volume.") + Popup.Error(@reason) + StorageProposal.SetProposalSnapshots(false) + end + if StorageProposal.CouldNotDoSeparateHome(@targetMap) + # TRANSLATORS: popup error message + @reason = _("Not enough space available to propose separate /home.") Popup.Error(@reason) StorageProposal.SetProposalHome(false) end - @targetMap = Ops.get_map(@prop, "target", {}) Storage.SetPartProposalMode("accept") Storage.SetPartProposalActive(true) end @@ -273,36 +284,6 @@ @ret end - def CouldNotDoSeparateHome(prop) - prop = deep_copy(prop) - ret = false - if StorageProposal.GetProposalHome - ls = [] - Builtins.foreach(prop) do |k, d| - ls = Convert.convert( - Builtins.union( - ls, - Builtins.filter(Ops.get_list(d, "partitions", [])) do |p| - !Ops.get_boolean(p, "delete", false) && - Ops.greater_than( - Builtins.size(Ops.get_string(p, "mount", "")), - 0 - ) - end - ), - :from => "list", - :to => "list <map>" - ) - end - ret = Builtins.size(Builtins.filter(ls) do |p| - Ops.get_string(p, "mount", "") == "/home" - end) == 0 - Builtins.y2milestone("CouldNotDoSeparateHome ls:%1", ls) - end - Builtins.y2milestone("CouldNotDoSeparateHome ret:%1", ret) - ret - end - def AskOverwriteChanges ret = true diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/yast2-storage-3.1.39/src/modules/StorageProposal.rb new/yast2-storage-3.1.40/src/modules/StorageProposal.rb --- old/yast2-storage-3.1.39/src/modules/StorageProposal.rb 2014-07-24 15:14:15.000000000 +0200 +++ new/yast2-storage-3.1.40/src/modules/StorageProposal.rb 2014-07-31 14:09:43.000000000 +0200 @@ -4473,7 +4473,9 @@ # enable snapshots for root volume if desired if StorageProposal.PropDefaultFs() == :btrfs && StorageProposal.GetProposalSnapshots() - if volume["mount"] == "/" + opts = StorageProposal.GetControlCfg() + size_limit_k = 1024 * opts["root_base"] + if volume["mount"] == "/" && volume["size_k"] >= size_limit_k volume["userdata"] = { "/" => "snapshots" } end end @@ -6496,6 +6498,56 @@ end + def CouldNotDoSnapshots(prop_target_map) + ret = false + if GetProposalSnapshots() + prop_target_map.each do |device, container| + log.info("haha #{device}") + container["partitions"].each do |volume| + if !volume.fetch("delete", false) + if volume.fetch("used_fs", :none) == :btrfs && volume.fetch("mount", "") == "/" + userdata = volume.fetch("userdata", {}) + ret = userdata.fetch("/", "") != "snapshots" + end + end + end + end + end + log.info("CouldNotDoSnapshots ret:#{ret}") + return ret + end + + + def CouldNotDoSeparateHome(prop_target_map) + ret = false + if GetProposalHome() + ls = [] + prop_target_map.each do |k, d| + ls = Convert.convert( + Builtins.union( + ls, + Builtins.filter(Ops.get_list(d, "partitions", [])) do |p| + !Ops.get_boolean(p, "delete", false) && + Ops.greater_than( + Builtins.size(Ops.get_string(p, "mount", "")), + 0 + ) + end + ), + :from => "list", + :to => "list <map>" + ) + end + ret = Builtins.size(Builtins.filter(ls) do |p| + Ops.get_string(p, "mount", "") == "/home" + end) == 0 + Builtins.y2milestone("CouldNotDoSeparateHome ls:%1", ls) + end + log.info("CouldNotDoSeparateHome ret:#{ret}") + return ret + end + + publish :function => :SetCreateVg, :type => "void (boolean)" publish :function => :GetProposalHome, :type => "boolean ()" publish :function => :SetProposalHome, :type => "void (boolean)" @@ -6523,6 +6575,8 @@ publish :function => :get_inst_prop, :type => "map <string, any> (map <string, map>)" publish :function => :SaveHeight, :type => "boolean ()" publish :function => :CommonWidgetsPopup, :type => "boolean ()" + publish :function => :CouldNotDoSnapshots, :type => "boolean (map <string, map>)" + publish :function => :CouldNotDoSeparateHome, :type => "boolean (map <string, map>)" end StorageProposal = StorageProposalClass.new diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/yast2-storage-3.1.39/testsuite/tests/empty-big-ppc64le1.out new/yast2-storage-3.1.40/testsuite/tests/empty-big-ppc64le1.out --- old/yast2-storage-3.1.39/testsuite/tests/empty-big-ppc64le1.out 2014-07-24 15:14:15.000000000 +0200 +++ new/yast2-storage-3.1.40/testsuite/tests/empty-big-ppc64le1.out 2014-07-31 14:09:43.000000000 +0200 @@ -22,3 +22,5 @@ Dump device:/dev/sda1 fsid:0x108 Dump device:/dev/sda2 fsid:0x82 Dump device:/dev/sda3 fsid:0x83 userdata:{"/"=>"snapshots"} +Dump +Dump Proposal Feedback: diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/yast2-storage-3.1.39/testsuite/tests/empty-big-ppc64le2.out new/yast2-storage-3.1.40/testsuite/tests/empty-big-ppc64le2.out --- old/yast2-storage-3.1.39/testsuite/tests/empty-big-ppc64le2.out 2014-07-24 15:14:15.000000000 +0200 +++ new/yast2-storage-3.1.40/testsuite/tests/empty-big-ppc64le2.out 2014-07-31 14:09:43.000000000 +0200 @@ -23,6 +23,9 @@ Dump device:/dev/sda label:gpt Dump device:/dev/sda1 fsid:0x108 Dump device:/dev/sda2 fsid:0x8e -Dump device:/dev/system/root userdata:{"/"=>"snapshots"} +Dump device:/dev/system/root Dump device:/dev/system/swap Dump device:/dev/system/home +Dump +Dump Proposal Feedback: +Dump Cound not do snapshots. diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/yast2-storage-3.1.39/testsuite/tests/empty-big1.out new/yast2-storage-3.1.40/testsuite/tests/empty-big1.out --- old/yast2-storage-3.1.39/testsuite/tests/empty-big1.out 2014-07-24 15:14:15.000000000 +0200 +++ new/yast2-storage-3.1.40/testsuite/tests/empty-big1.out 2014-07-31 14:09:43.000000000 +0200 @@ -22,3 +22,5 @@ Dump device:/dev/sda1 fsid:0x107 Dump device:/dev/sda2 fsid:0x82 Dump device:/dev/sda3 fsid:0x83 +Dump +Dump Proposal Feedback: diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/yast2-storage-3.1.39/testsuite/tests/empty-efi1.out new/yast2-storage-3.1.40/testsuite/tests/empty-efi1.out --- old/yast2-storage-3.1.39/testsuite/tests/empty-efi1.out 2014-07-24 15:14:15.000000000 +0200 +++ new/yast2-storage-3.1.40/testsuite/tests/empty-efi1.out 2014-07-31 14:09:43.000000000 +0200 @@ -23,3 +23,5 @@ Dump device:/dev/sda1 fsid:0x103 Dump device:/dev/sda2 fsid:0x82 Dump device:/dev/sda3 fsid:0x83 +Dump +Dump Proposal Feedback: diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/yast2-storage-3.1.39/testsuite/tests/empty-efi2.out new/yast2-storage-3.1.40/testsuite/tests/empty-efi2.out --- old/yast2-storage-3.1.39/testsuite/tests/empty-efi2.out 2014-07-24 15:14:15.000000000 +0200 +++ new/yast2-storage-3.1.40/testsuite/tests/empty-efi2.out 2014-07-31 14:09:43.000000000 +0200 @@ -24,3 +24,5 @@ Dump device:/dev/sda2 fsid:0x82 Dump device:/dev/sda3 fsid:0x83 Dump device:/dev/sda4 fsid:0x83 +Dump +Dump Proposal Feedback: diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/yast2-storage-3.1.39/testsuite/tests/empty-ppc64le1.out new/yast2-storage-3.1.40/testsuite/tests/empty-ppc64le1.out --- old/yast2-storage-3.1.39/testsuite/tests/empty-ppc64le1.out 2014-07-24 15:14:15.000000000 +0200 +++ new/yast2-storage-3.1.40/testsuite/tests/empty-ppc64le1.out 2014-07-31 14:09:43.000000000 +0200 @@ -22,3 +22,5 @@ Dump device:/dev/sda1 fsid:0x41 Dump device:/dev/sda2 fsid:0x82 Dump device:/dev/sda3 fsid:0x83 userdata:{"/"=>"snapshots"} +Dump +Dump Proposal Feedback: diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/yast2-storage-3.1.39/testsuite/tests/empty-ppc64le2.out new/yast2-storage-3.1.40/testsuite/tests/empty-ppc64le2.out --- old/yast2-storage-3.1.39/testsuite/tests/empty-ppc64le2.out 2014-07-24 15:14:15.000000000 +0200 +++ new/yast2-storage-3.1.40/testsuite/tests/empty-ppc64le2.out 2014-07-31 14:09:43.000000000 +0200 @@ -23,3 +23,5 @@ Dump device:/dev/sda2 fsid:0x82 Dump device:/dev/sda3 fsid:0x83 userdata:{"/"=>"snapshots"} Dump device:/dev/sda4 fsid:0x83 +Dump +Dump Proposal Feedback: diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/yast2-storage-3.1.39/testsuite/tests/empty-ppc64le3.out new/yast2-storage-3.1.40/testsuite/tests/empty-ppc64le3.out --- old/yast2-storage-3.1.39/testsuite/tests/empty-ppc64le3.out 2014-07-24 15:14:15.000000000 +0200 +++ new/yast2-storage-3.1.40/testsuite/tests/empty-ppc64le3.out 2014-07-31 14:09:43.000000000 +0200 @@ -23,6 +23,9 @@ Dump device:/dev/sda label:msdos Dump device:/dev/sda1 fsid:0x41 Dump device:/dev/sda2 fsid:0x8e -Dump device:/dev/system/root userdata:{"/"=>"snapshots"} +Dump device:/dev/system/root Dump device:/dev/system/swap Dump device:/dev/system/home +Dump +Dump Proposal Feedback: +Dump Cound not do snapshots. diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/yast2-storage-3.1.39/testsuite/tests/empty-s390x1.out new/yast2-storage-3.1.40/testsuite/tests/empty-s390x1.out --- old/yast2-storage-3.1.39/testsuite/tests/empty-s390x1.out 2014-07-24 15:14:15.000000000 +0200 +++ new/yast2-storage-3.1.40/testsuite/tests/empty-s390x1.out 2014-07-31 14:09:43.000000000 +0200 @@ -22,3 +22,5 @@ Dump device:/dev/sda1 fsid:0x83 Dump device:/dev/sda2 fsid:0x82 Dump device:/dev/sda3 fsid:0x83 userdata:{"/"=>"snapshots"} +Dump +Dump Proposal Feedback: diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/yast2-storage-3.1.39/testsuite/tests/empty-small1.out new/yast2-storage-3.1.40/testsuite/tests/empty-small1.out --- old/yast2-storage-3.1.39/testsuite/tests/empty-small1.out 2014-07-24 15:14:15.000000000 +0200 +++ new/yast2-storage-3.1.40/testsuite/tests/empty-small1.out 2014-07-31 14:09:43.000000000 +0200 @@ -19,4 +19,8 @@ Dump Target Map Excerpt: Dump device:/dev/sda label:msdos Dump device:/dev/sda1 fsid:0x82 -Dump device:/dev/sda2 fsid:0x83 userdata:{"/"=>"snapshots"} +Dump device:/dev/sda2 fsid:0x83 +Dump +Dump Proposal Feedback: +Dump Cound not do snapshots. +Dump Cound not do separate home. diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/yast2-storage-3.1.39/testsuite/tests/empty1.out new/yast2-storage-3.1.40/testsuite/tests/empty1.out --- old/yast2-storage-3.1.39/testsuite/tests/empty1.out 2014-07-24 15:14:15.000000000 +0200 +++ new/yast2-storage-3.1.40/testsuite/tests/empty1.out 2014-07-31 14:09:43.000000000 +0200 @@ -20,3 +20,5 @@ Dump device:/dev/sda label:msdos Dump device:/dev/sda1 fsid:0x82 Dump device:/dev/sda2 fsid:0x83 +Dump +Dump Proposal Feedback: diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/yast2-storage-3.1.39/testsuite/tests/empty2.out new/yast2-storage-3.1.40/testsuite/tests/empty2.out --- old/yast2-storage-3.1.39/testsuite/tests/empty2.out 2014-07-24 15:14:15.000000000 +0200 +++ new/yast2-storage-3.1.40/testsuite/tests/empty2.out 2014-07-31 14:09:43.000000000 +0200 @@ -21,3 +21,5 @@ Dump device:/dev/sda1 fsid:0x82 Dump device:/dev/sda2 fsid:0x83 userdata:{"/"=>"snapshots"} Dump device:/dev/sda3 fsid:0x83 +Dump +Dump Proposal Feedback: diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/yast2-storage-3.1.39/testsuite/tests/empty3.out new/yast2-storage-3.1.40/testsuite/tests/empty3.out --- old/yast2-storage-3.1.39/testsuite/tests/empty3.out 2014-07-24 15:14:15.000000000 +0200 +++ new/yast2-storage-3.1.40/testsuite/tests/empty3.out 2014-07-31 14:09:43.000000000 +0200 @@ -24,3 +24,5 @@ Dump device:/dev/sda2 fsid:0x8e Dump device:/dev/system/root Dump device:/dev/system/swap +Dump +Dump Proposal Feedback: diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/yast2-storage-3.1.39/testsuite/tests/empty4.out new/yast2-storage-3.1.40/testsuite/tests/empty4.out --- old/yast2-storage-3.1.39/testsuite/tests/empty4.out 2014-07-24 15:14:15.000000000 +0200 +++ new/yast2-storage-3.1.40/testsuite/tests/empty4.out 2014-07-31 14:09:43.000000000 +0200 @@ -25,3 +25,5 @@ Dump device:/dev/system/root Dump device:/dev/system/swap Dump device:/dev/system/home +Dump +Dump Proposal Feedback: diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/yast2-storage-3.1.39/testsuite/tests/empty5.out new/yast2-storage-3.1.40/testsuite/tests/empty5.out --- old/yast2-storage-3.1.39/testsuite/tests/empty5.out 2014-07-24 15:14:15.000000000 +0200 +++ new/yast2-storage-3.1.40/testsuite/tests/empty5.out 2014-07-31 14:09:43.000000000 +0200 @@ -24,3 +24,5 @@ Dump device:/dev/sda2 fsid:0x8e Dump device:/dev/system/root Dump device:/dev/system/swap +Dump +Dump Proposal Feedback: diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/yast2-storage-3.1.39/testsuite/tests/empty6.out new/yast2-storage-3.1.40/testsuite/tests/empty6.out --- old/yast2-storage-3.1.39/testsuite/tests/empty6.out 2014-07-24 15:14:15.000000000 +0200 +++ new/yast2-storage-3.1.40/testsuite/tests/empty6.out 2014-07-31 14:09:43.000000000 +0200 @@ -25,3 +25,5 @@ Dump device:/dev/system/root Dump device:/dev/system/swap Dump device:/dev/system/home +Dump +Dump Proposal Feedback: diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/yast2-storage-3.1.39/testsuite/tests/empty7.out new/yast2-storage-3.1.40/testsuite/tests/empty7.out --- old/yast2-storage-3.1.39/testsuite/tests/empty7.out 2014-07-24 15:14:15.000000000 +0200 +++ new/yast2-storage-3.1.40/testsuite/tests/empty7.out 2014-07-31 14:09:43.000000000 +0200 @@ -21,3 +21,5 @@ Dump device:/dev/sda1 fsid:0x82 Dump device:/dev/sda2 fsid:0x83 userdata:{"/"=>"snapshots"} Dump device:/dev/sda3 fsid:0x83 +Dump +Dump Proposal Feedback: diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/yast2-storage-3.1.39/testsuite/tests/empty8.out new/yast2-storage-3.1.40/testsuite/tests/empty8.out --- old/yast2-storage-3.1.39/testsuite/tests/empty8.out 2014-07-24 15:14:15.000000000 +0200 +++ new/yast2-storage-3.1.40/testsuite/tests/empty8.out 2014-07-31 14:09:43.000000000 +0200 @@ -21,3 +21,5 @@ Dump device:/dev/sda1 fsid:0x82 Dump device:/dev/sda2 fsid:0x83 userdata:{"/"=>"snapshots"} Dump device:/dev/sda3 fsid:0x83 +Dump +Dump Proposal Feedback: diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/yast2-storage-3.1.39/testsuite/tests/empty9.out new/yast2-storage-3.1.40/testsuite/tests/empty9.out --- old/yast2-storage-3.1.39/testsuite/tests/empty9.out 2014-07-24 15:14:15.000000000 +0200 +++ new/yast2-storage-3.1.40/testsuite/tests/empty9.out 2014-07-31 14:09:43.000000000 +0200 @@ -25,3 +25,5 @@ Dump device:/dev/system/root Dump device:/dev/system/swap Dump device:/dev/system/home +Dump +Dump Proposal Feedback: diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/yast2-storage-3.1.39/testsuite/tests/flex-info-empty-big-ppc64le1.out new/yast2-storage-3.1.40/testsuite/tests/flex-info-empty-big-ppc64le1.out --- old/yast2-storage-3.1.39/testsuite/tests/flex-info-empty-big-ppc64le1.out 2014-07-24 15:14:15.000000000 +0200 +++ new/yast2-storage-3.1.40/testsuite/tests/flex-info-empty-big-ppc64le1.out 2014-07-31 14:09:43.000000000 +0200 @@ -24,3 +24,6 @@ Dump device:/dev/sda2 fsid:0x82 Dump device:/dev/sda3 fsid:0x83 Dump device:/dev/sda4 fsid:0x83 +Dump +Dump Proposal Feedback: +Dump Cound not do snapshots. diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/yast2-storage-3.1.39/testsuite/tests/flex-info-empty-efi1.out new/yast2-storage-3.1.40/testsuite/tests/flex-info-empty-efi1.out --- old/yast2-storage-3.1.39/testsuite/tests/flex-info-empty-efi1.out 2014-07-24 15:14:15.000000000 +0200 +++ new/yast2-storage-3.1.40/testsuite/tests/flex-info-empty-efi1.out 2014-07-31 14:09:43.000000000 +0200 @@ -25,3 +25,6 @@ Dump device:/dev/sda2 fsid:0x82 Dump device:/dev/sda3 fsid:0x83 Dump device:/dev/sda4 fsid:0x83 +Dump +Dump Proposal Feedback: +Dump Cound not do snapshots. diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/yast2-storage-3.1.39/testsuite/tests/flex-info-empty-efi2.out new/yast2-storage-3.1.40/testsuite/tests/flex-info-empty-efi2.out --- old/yast2-storage-3.1.39/testsuite/tests/flex-info-empty-efi2.out 2014-07-24 15:14:15.000000000 +0200 +++ new/yast2-storage-3.1.40/testsuite/tests/flex-info-empty-efi2.out 2014-07-31 14:09:43.000000000 +0200 @@ -25,3 +25,6 @@ Dump device:/dev/sda2 fsid:0x82 Dump device:/dev/sda3 fsid:0x83 Dump device:/dev/sda4 fsid:0x83 +Dump +Dump Proposal Feedback: +Dump Cound not do snapshots. diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/yast2-storage-3.1.39/testsuite/tests/flex-info-empty-ppc64le1.out new/yast2-storage-3.1.40/testsuite/tests/flex-info-empty-ppc64le1.out --- old/yast2-storage-3.1.39/testsuite/tests/flex-info-empty-ppc64le1.out 2014-07-24 15:14:15.000000000 +0200 +++ new/yast2-storage-3.1.40/testsuite/tests/flex-info-empty-ppc64le1.out 2014-07-31 14:09:43.000000000 +0200 @@ -24,3 +24,6 @@ Dump device:/dev/sda2 fsid:0x82 Dump device:/dev/sda3 fsid:0x83 Dump device:/dev/sda4 fsid:0x83 +Dump +Dump Proposal Feedback: +Dump Cound not do snapshots. diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/yast2-storage-3.1.39/testsuite/tests/flex-info-empty-ppc64le2.out new/yast2-storage-3.1.40/testsuite/tests/flex-info-empty-ppc64le2.out --- old/yast2-storage-3.1.39/testsuite/tests/flex-info-empty-ppc64le2.out 2014-07-24 15:14:15.000000000 +0200 +++ new/yast2-storage-3.1.40/testsuite/tests/flex-info-empty-ppc64le2.out 2014-07-31 14:09:43.000000000 +0200 @@ -24,3 +24,6 @@ Dump device:/dev/sda2 fsid:0x82 Dump device:/dev/sda3 fsid:0x83 Dump device:/dev/sda4 fsid:0x83 +Dump +Dump Proposal Feedback: +Dump Cound not do snapshots. diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/yast2-storage-3.1.39/testsuite/tests/flex-info-empty1.out new/yast2-storage-3.1.40/testsuite/tests/flex-info-empty1.out --- old/yast2-storage-3.1.39/testsuite/tests/flex-info-empty1.out 2014-07-24 15:14:15.000000000 +0200 +++ new/yast2-storage-3.1.40/testsuite/tests/flex-info-empty1.out 2014-07-31 14:09:43.000000000 +0200 @@ -22,3 +22,6 @@ Dump device:/dev/sda1 fsid:0x82 Dump device:/dev/sda2 fsid:0x83 Dump device:/dev/sda3 fsid:0x83 +Dump +Dump Proposal Feedback: +Dump Cound not do snapshots. diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/yast2-storage-3.1.39/testsuite/tests/flex-info-empty2.out new/yast2-storage-3.1.40/testsuite/tests/flex-info-empty2.out --- old/yast2-storage-3.1.39/testsuite/tests/flex-info-empty2.out 2014-07-24 15:14:15.000000000 +0200 +++ new/yast2-storage-3.1.40/testsuite/tests/flex-info-empty2.out 2014-07-31 14:09:43.000000000 +0200 @@ -26,3 +26,6 @@ Dump device:/dev/sda6 fsid:0x82 Dump device:/dev/sda7 fsid:0x83 Dump device:/dev/sda8 fsid:0x83 +Dump +Dump Proposal Feedback: +Dump Cound not do snapshots. diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/yast2-storage-3.1.39/testsuite/tests/flex-xml-empty-efi1.out new/yast2-storage-3.1.40/testsuite/tests/flex-xml-empty-efi1.out --- old/yast2-storage-3.1.39/testsuite/tests/flex-xml-empty-efi1.out 2014-07-24 15:14:15.000000000 +0200 +++ new/yast2-storage-3.1.40/testsuite/tests/flex-xml-empty-efi1.out 2014-07-31 14:09:43.000000000 +0200 @@ -25,3 +25,6 @@ Dump device:/dev/sda2 fsid:0x82 Dump device:/dev/sda3 fsid:0x83 Dump device:/dev/sda4 fsid:0x83 +Dump +Dump Proposal Feedback: +Dump Cound not do snapshots. diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/yast2-storage-3.1.39/testsuite/tests/flex-xml-empty-ppc64le1.out new/yast2-storage-3.1.40/testsuite/tests/flex-xml-empty-ppc64le1.out --- old/yast2-storage-3.1.39/testsuite/tests/flex-xml-empty-ppc64le1.out 2014-07-24 15:14:15.000000000 +0200 +++ new/yast2-storage-3.1.40/testsuite/tests/flex-xml-empty-ppc64le1.out 2014-07-31 14:09:43.000000000 +0200 @@ -24,3 +24,6 @@ Dump device:/dev/sda2 fsid:0x82 Dump device:/dev/sda3 fsid:0x83 Dump device:/dev/sda4 fsid:0x83 +Dump +Dump Proposal Feedback: +Dump Cound not do snapshots. diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/yast2-storage-3.1.39/testsuite/tests/flex-xml-empty1.out new/yast2-storage-3.1.40/testsuite/tests/flex-xml-empty1.out --- old/yast2-storage-3.1.39/testsuite/tests/flex-xml-empty1.out 2014-07-24 15:14:15.000000000 +0200 +++ new/yast2-storage-3.1.40/testsuite/tests/flex-xml-empty1.out 2014-07-31 14:09:43.000000000 +0200 @@ -22,3 +22,6 @@ Dump device:/dev/sda1 fsid:0x82 Dump device:/dev/sda2 fsid:0x83 Dump device:/dev/sda3 fsid:0x83 +Dump +Dump Proposal Feedback: +Dump Cound not do snapshots. diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/yast2-storage-3.1.39/testsuite/tests/half-empty1.out new/yast2-storage-3.1.40/testsuite/tests/half-empty1.out --- old/yast2-storage-3.1.39/testsuite/tests/half-empty1.out 2014-07-24 15:14:15.000000000 +0200 +++ new/yast2-storage-3.1.40/testsuite/tests/half-empty1.out 2014-07-31 14:09:43.000000000 +0200 @@ -25,3 +25,5 @@ Dump device:/dev/sda5 fsid:0x82 Dump device:/dev/sda6 fsid:0x83 Dump device:/dev/sda7 fsid:0x83 +Dump +Dump Proposal Feedback: diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/yast2-storage-3.1.39/testsuite/tests/helper.rb new/yast2-storage-3.1.40/testsuite/tests/helper.rb --- old/yast2-storage-3.1.39/testsuite/tests/helper.rb 2014-07-24 15:14:15.000000000 +0200 +++ new/yast2-storage-3.1.40/testsuite/tests/helper.rb 2014-07-31 14:09:43.000000000 +0200 @@ -136,6 +136,17 @@ end + Testsuite.Dump("") + + Testsuite.Dump("Proposal Feedback:") + if StorageProposal.CouldNotDoSnapshots(prop["target"]) + Testsuite.Dump("Cound not do snapshots.") + end + + if StorageProposal.CouldNotDoSeparateHome(prop["target"]) + Testsuite.Dump("Cound not do separate home.") + end + else Testsuite.Dump("No proposal.") end diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/yast2-storage-3.1.39/testsuite/tests/reuse-home1.out new/yast2-storage-3.1.40/testsuite/tests/reuse-home1.out --- old/yast2-storage-3.1.39/testsuite/tests/reuse-home1.out 2014-07-24 15:14:15.000000000 +0200 +++ new/yast2-storage-3.1.40/testsuite/tests/reuse-home1.out 2014-07-31 14:09:43.000000000 +0200 @@ -21,3 +21,5 @@ Dump device:/dev/sda1 fsid:0x82 Dump device:/dev/sda2 fsid:0x83 Dump device:/dev/sda3 fsid:0x83 +Dump +Dump Proposal Feedback: diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/yast2-storage-3.1.39/testsuite/tests/windows-only-efi1.out new/yast2-storage-3.1.40/testsuite/tests/windows-only-efi1.out --- old/yast2-storage-3.1.39/testsuite/tests/windows-only-efi1.out 2014-07-24 15:14:15.000000000 +0200 +++ new/yast2-storage-3.1.40/testsuite/tests/windows-only-efi1.out 2014-07-31 14:09:43.000000000 +0200 @@ -25,3 +25,6 @@ Dump device:/dev/sda2 fsid:0x7 Dump device:/dev/sda3 fsid:0x82 Dump device:/dev/sda4 fsid:0x83 +Dump +Dump Proposal Feedback: +Dump Cound not do separate home. diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/yast2-storage-3.1.39/testsuite/tests/windows-only1.out new/yast2-storage-3.1.40/testsuite/tests/windows-only1.out --- old/yast2-storage-3.1.39/testsuite/tests/windows-only1.out 2014-07-24 15:14:15.000000000 +0200 +++ new/yast2-storage-3.1.40/testsuite/tests/windows-only1.out 2014-07-31 14:09:43.000000000 +0200 @@ -25,3 +25,5 @@ Dump device:/dev/sda5 fsid:0x82 Dump device:/dev/sda6 fsid:0x83 Dump device:/dev/sda7 fsid:0x83 +Dump +Dump Proposal Feedback: diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/yast2-storage-3.1.39/testsuite/tests/windows1.out new/yast2-storage-3.1.40/testsuite/tests/windows1.out --- old/yast2-storage-3.1.39/testsuite/tests/windows1.out 2014-07-24 15:14:15.000000000 +0200 +++ new/yast2-storage-3.1.40/testsuite/tests/windows1.out 2014-07-31 14:09:43.000000000 +0200 @@ -24,3 +24,5 @@ Dump device:/dev/sda5 fsid:0x82 Dump device:/dev/sda6 fsid:0x83 Dump device:/dev/sda7 fsid:0x83 +Dump +Dump Proposal Feedback: -- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
