Hello community,

here is the log from the commit of package monitoring-plugins-diskio for 
openSUSE:Factory checked in at 2014-08-13 08:49:03
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Comparing /work/SRC/openSUSE:Factory/monitoring-plugins-diskio (Old)
 and      /work/SRC/openSUSE:Factory/.monitoring-plugins-diskio.new (New)
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++

Package is "monitoring-plugins-diskio"

Changes:
--------
--- 
/work/SRC/openSUSE:Factory/monitoring-plugins-diskio/monitoring-plugins-diskio.changes
      2014-08-01 14:34:43.000000000 +0200
+++ 
/work/SRC/openSUSE:Factory/.monitoring-plugins-diskio.new/monitoring-plugins-diskio.changes
 2014-08-13 08:49:09.000000000 +0200
@@ -2 +2 @@
-Wed Jul 30 15:11:25 UTC 2014 - [email protected]
+Wed Jul 30 23:18:58 UTC 2014 - [email protected]
@@ -4,5 +4 @@
-- rename package to monitoring-plugins-diskio
-- update to 3.2.6:
-  + fixed a bug when calling the plugin in periods shorter than 1 second
-  + empty temporary files are re-written
-  + fixed a minor issue in the option parsing and output
+- renamed package to monitoring-plugins-diskio

Old:
----
  check_diskio-3.2.6.tar.gz

New:
----
  check_diskio-3.2.4.tar.gz

++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++

Other differences:
------------------
++++++ monitoring-plugins-diskio.spec ++++++
--- /var/tmp/diff_new_pack.FwTK52/_old  2014-08-13 08:49:10.000000000 +0200
+++ /var/tmp/diff_new_pack.FwTK52/_new  2014-08-13 08:49:10.000000000 +0200
@@ -1,7 +1,7 @@
 #
 # spec file for package monitoring-plugins-diskio
 #
-# Copyright (c) 2013-2014 SUSE LINUX Products GmbH, Nuernberg, Germany.
+# Copyright (c) 2013 SUSE LINUX Products GmbH, Nuernberg, Germany.
 #
 # All modifications and additions to the file contributed by third parties
 # remain the property of their copyright owners, unless otherwise agreed
@@ -16,7 +16,7 @@
 #
 
 Name:           monitoring-plugins-diskio
-Version:        3.2.6
+Version:        3.2.4
 Release:        1
 License:        GPL-3.0+
 %define         realname check_diskio
@@ -34,7 +34,7 @@
 BuildRequires:  %perl_arch
 BuildRequires:  nagios-rpm-macros
 Provides:       nagios-plugins-diskio = %{version}-%{release}
-Obsoletes:      nagios-plugins-diskio < 3.2.5
+Obsoletes:      nagios-plugins-diskio < %{version}-%{release}
 Requires:       %perl_arch
 Requires:       perl(Array::Unique)
 Requires:       perl(English)
@@ -49,8 +49,8 @@
 BuildArch:      noarch
 
 %description
-A monitoring plugin to monitor the amount of disk I/O in sectors on Linux
-systems.
+check_diskio is a Nagios plugin to monitor the amount of disk I/O in sectors
+on Linux 2.6 and 2.4 systems
 
 %prep
 %setup -q -n %{realname}-%{version}

++++++ check_diskio-3.2.6.tar.gz -> check_diskio-3.2.4.tar.gz ++++++
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' 
'--exclude=.svnignore' old/check_diskio-3.2.6/AUTHORS 
new/check_diskio-3.2.4/AUTHORS
--- old/check_diskio-3.2.6/AUTHORS      2013-02-25 22:57:38.000000000 +0100
+++ new/check_diskio-3.2.4/AUTHORS      2010-12-29 12:08:28.000000000 +0100
@@ -8,4 +8,3 @@
 * Nikolaus Filus for the UOM enhancements
 * Vitaliy Zhhuta for the help with /proc/diskstats formatting issues
 * Greg Maples for helping in the partition stripping of LVM volumes
-* Anonymous reporter for the temporary file check fix
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' 
'--exclude=.svnignore' old/check_diskio-3.2.6/COPYRIGHT 
new/check_diskio-3.2.4/COPYRIGHT
--- old/check_diskio-3.2.6/COPYRIGHT    2013-02-26 07:07:45.000000000 +0100
+++ new/check_diskio-3.2.4/COPYRIGHT    2010-12-29 12:08:28.000000000 +0100
@@ -1,4 +1,4 @@
-Copyright (c) 2007-2013 Matteo Corti, ETH Zurich
+Copyright (c) 2009 Matteo Corti
 
 This program is free software; you can redistribute it and/or modify
 it under the terms of the GNU General Public License as published by
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' 
'--exclude=.svnignore' old/check_diskio-3.2.6/Changes 
new/check_diskio-3.2.4/Changes
--- old/check_diskio-3.2.6/Changes      2014-01-31 07:48:00.000000000 +0100
+++ new/check_diskio-3.2.4/Changes      2011-11-09 20:23:31.000000000 +0100
@@ -1,14 +1,3 @@
-2014-01-30  Matteo Corti  <[email protected]>
-
-       * check_diskio: fixed a bug when calling the plugin in periods shorter 
than 1 second
-
-2013-02-26  Matteo Corti  <[email protected]>
-        * check_diskio: empty temporary files are re-written
-
-2012-04-14  Matteo Corti  <[email protected]>
-
-       * check_diskio: fixed a minor issue in the option parsing and output
-
 2011-11-09  Matteo Corti  <[email protected]>
 
        * check_diskio: support for 3.x kernels
@@ -129,7 +118,7 @@
        * Initial release
 
 
-# $Id: Changes 1351 2014-01-31 06:47:38Z corti $
-# $Revision: 1351 $
+# $Id: Changes 1275 2011-11-09 15:24:34Z corti $
+# $Revision: 1275 $
 # $HeadURL: https://svn.id.ethz.ch/nagios_plugins/check_diskio/Changes $
-# $Date: 2014-01-31 07:47:38 +0100 (Fri, 31 Jan 2014) $
+# $Date: 2011-11-09 16:24:34 +0100 (Wed, 09 Nov 2011) $
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' 
'--exclude=.svnignore' old/check_diskio-3.2.6/INSTALL 
new/check_diskio-3.2.4/INSTALL
--- old/check_diskio-3.2.6/INSTALL      2012-12-23 12:06:00.000000000 +0100
+++ new/check_diskio-3.2.4/INSTALL      2010-02-21 10:03:58.000000000 +0100
@@ -1,34 +1,5 @@
 Build and install check_diskio
 
-Dependences
-===========
-
-check_diskio depends on several Perl modules:
-
- * Array::Unique
- * English
- * File::Slurp
- * List::MoreUtils
- * Nagios::Plugin
- * Nagios::Plugin::Getopt
- * Nagios::Plugin::Threshold
- * Number::Format
- * POSIX
- * Readonly
- * version
-
-Perl modules can be found on the "Comprehensive Perl Archive Network"
-(CPAN). The "How to install CPAN modules" guide summarizes how these
-can be installed
-
-        http://www.cpan.org/modules/INSTALL.html
-
-On many systems Perl modules are also available as installation
-packages (refer to your system documentation on how to install them).
-
-The 'perl Makefile.PL' command (see below) will list the missing
-packages the you will need to install.
-
 Install to /usr/lib/nagios/plugins/contrib
 ==========================================
 
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' 
'--exclude=.svnignore' old/check_diskio-3.2.6/META.yml 
new/check_diskio-3.2.4/META.yml
--- old/check_diskio-3.2.6/META.yml     2014-01-31 07:48:00.000000000 +0100
+++ new/check_diskio-3.2.4/META.yml     2011-11-09 20:23:31.000000000 +0100
@@ -1,5 +1,5 @@
 ---
-abstract: unknown
+abstract: ~
 author:
   - 'Matteo Corti <[email protected]>'
 build_requires:
@@ -7,18 +7,18 @@
   File::Spec: 0
   Test::More: 0
 configure_requires:
-  ExtUtils::MakeMaker: 0
-dynamic_config: 0
-generated_by: 'ExtUtils::MakeMaker version 6.72, CPAN::Meta::Converter version 
2.132140'
-license: open_source
+  ExtUtils::MakeMaker: 6.42
+distribution_type: module
+generated_by: 'Module::Install version 1.01'
+license: gpl
 meta-spec:
   url: http://module-build.sourceforge.net/META-spec-v1.4.html
   version: 1.4
 name: check_diskio
 no_index:
   directory:
-    - t
     - inc
+    - t
 requires:
   Array::Unique: 0
   English: 0
@@ -30,5 +30,7 @@
   Number::Format: 0
   POSIX: 0
   Readonly: 0
-  perl: 5.00800
-version: v3.2.6
+  perl: 5.8.0
+resources:
+  license: http://opensource.org/licenses/gpl-license.php
+version: 3.2.4
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' 
'--exclude=.svnignore' old/check_diskio-3.2.6/NEWS new/check_diskio-3.2.4/NEWS
--- old/check_diskio-3.2.6/NEWS 2014-01-31 07:48:00.000000000 +0100
+++ new/check_diskio-3.2.4/NEWS 2011-11-09 20:23:31.000000000 +0100
@@ -1,7 +1,3 @@
-2014-01-31 3.2.6: fixed a bug when calling the plugin in periods shorter than
-                  1 second
-2013-02-26 3.2.5: handles empty temporary files and fixes a minor bug in option
-                  parsing
 2011-11-09 3.2.4: supports 3.X kernels
 2010-10-20 3.2.3: fixes a bug in the parsing of the statistics file
 2010-07-06 3.2.2: fixes a bug which ignored devices specified with -d /dev
@@ -31,7 +27,7 @@
 2007-02-23 1.1:   removed the max interval check
 2007-02-19 1.0:   initial release
 
-# $Id: NEWS 1351 2014-01-31 06:47:38Z corti $
-# $Revision: 1351 $
+# $Id: NEWS 1275 2011-11-09 15:24:34Z corti $
+# $Revision: 1275 $
 # $HeadURL: https://svn.id.ethz.ch/nagios_plugins/check_diskio/NEWS $
-# $Date: 2014-01-31 07:47:38 +0100 (Fri, 31 Jan 2014) $
+# $Date: 2011-11-09 16:24:34 +0100 (Wed, 09 Nov 2011) $
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' 
'--exclude=.svnignore' old/check_diskio-3.2.6/check_diskio 
new/check_diskio-3.2.4/check_diskio
--- old/check_diskio-3.2.6/check_diskio 2014-01-31 07:48:00.000000000 +0100
+++ new/check_diskio-3.2.4/check_diskio 2011-11-09 20:23:31.000000000 +0100
@@ -3,11 +3,11 @@
 package main;
 
 # check_diskio is a Nagios plugin to monitor the amount of disk
-# I/O in sectors on Linux
+# I/O in sectors on Linux 2.6 and 2.4 systems
 #
 # See  the INSTALL file for installation instructions
 #
-# Copyright (c) 2007-2013 ETH Zurich.
+# Copyright (c) 2007,2008 ETH Zurich.
 #
 # This module is free software; you can redistribute it and/or modify it
 # under the terms of GNU general public license (gpl) version 3.
@@ -17,17 +17,17 @@
 # enable substitution with:
 #   $ svn propset svn:keywords "Id Revision HeadURL Source Date"
 #
-#   $Id: check_diskio 1351 2014-01-31 06:47:38Z corti $
-#   $Revision: 1351 $
+#   $Id: check_diskio 1277 2011-11-09 17:25:43Z corti $
+#   $Revision: 1277 $
 #   $HeadURL: https://svn.id.ethz.ch/nagios_plugins/check_diskio/check_diskio $
-#   $Date: 2014-01-31 07:47:38 +0100 (Fri, 31 Jan 2014) $
+#   $Date: 2011-11-09 18:25:43 +0100 (Wed, 09 Nov 2011) $
 
 use 5.00800;
 
 use strict;
 use warnings;
 
-our $VERSION = '3.2.6';
+our $VERSION = '3.2.4';
 
 use Array::Unique;
 use English qw(-no_match_vars);
@@ -186,8 +186,7 @@
       . "\n", 1;
 
     ## no critic (InputOutput::RequireBriefOpen)
-    open $TMP_FH, q{>},
-      $tmp
+    open $TMP_FH, q{>}, $tmp
       or $plugin->nagios_exit( UNKNOWN,
         "Cannot initialize timer ($tmp): $OS_ERROR" );
 
@@ -208,11 +207,10 @@
 }
 
 ##############################################################################
-# Usage     : ($time, $in, $out) = read_timer( $temporary_file )
+# Usage     : ($time, $in, $out) = read_timer()
 # Purpose   : reads the time and I/O data from the temporary file
 # Returns   : ($time, $in, $out) time difference, input and output data
-# Arguments : $temporary_file : name of the temporary file holding the timer
-#             data
+# Arguments : n/a
 # Throws    : n/a
 # Comments  : n/a
 # See also  : n/a
@@ -220,11 +218,6 @@
 
     my $tmp = shift;
 
-    if ( !defined $tmp ) {
-        $plugin->nagios_exit( UNKNOWN,
-            'Internal error: read_timer called without parameters' );
-    }
-
     my $TMP_FH;
     my $time;
     my $in;
@@ -394,7 +387,7 @@
 
     }
 
-    $plugin->nagios_exit( UNKNOWN, "Device '$device' not found" );
+    $plugin->nagios_exit( UNKNOWN, "Device $device not found" );
 
     return
 
@@ -762,8 +755,7 @@
             undef $device;
 
             ## no critic (InputOutput::RequireBriefOpen)
-            open $MTAB_FH, q{<},
-              '/etc/mtab'
+            open $MTAB_FH, q{<}, '/etc/mtab'
               or $plugin->nagios_exit( UNKNOWN,
                 "Cannot open /etc/mtab: $OS_ERROR" );
             while (<$MTAB_FH>) {
@@ -892,7 +884,7 @@
 
     verbose "Checking: @unique_devices\n";
 
-    #####
+#####
     # UOM
 
     my $multiplier;
@@ -905,7 +897,7 @@
     # according to the guidelines only [TGMK]B (Bytes) are valid UOM
     #   http://nagiosplug.sourceforge.net/developer-guidelines.html#AEN201
     my $perfdata_uom = 'B';
-    if ( $format eq 's' || $format =~ /^sectors?$/mxs ) {
+    if ( $format eq 's' || $format =~ /^sector[s]$/mxs ) {
 
         #sectors
         $multiplier   = 1;
@@ -913,7 +905,7 @@
         $perfdata_uom = q{};
 
     }
-    elsif ( $format eq 'b' || $format =~ /^bits?$/mxs ) {
+    elsif ( $format eq 'b' || $format =~ /^bit[s]$/mxs ) {
 
         # bits
         $multiplier   = $options->ssize() * $BITS_PER_BYTE;
@@ -921,7 +913,7 @@
         $perfdata_uom = q{};
 
     }
-    elsif ( $format eq 'B' || $format =~ /^bytes?$/mxs ) {
+    elsif ( $format eq 'B' || $format =~ /^byte[s]$/mxs ) {
 
         # bytes
         $multiplier = $options->ssize();
@@ -993,7 +985,7 @@
 
     }
 
-    ########################
+########################
     # Check the proc entry
 
     my $diff;
@@ -1024,8 +1016,7 @@
           . format_number( $s_write, 0, 0 )
           . "\n", 1;
 
-        # check if the temporary file exists and has some content
-        if ( !-s $tmp_files{$device} ) {
+        if ( !-f $tmp_files{$device} ) {
             verbose "temporary file not available resetting and waiting\n";
             write_timer( $tmp_files{$device}, $s_write, $s_read );
             sleep 1;
@@ -1043,7 +1034,7 @@
 
             # wait a little bit
             sleep 1;
-            ( $diff, $in, $out ) = read_timer( $tmp_files{$device} );
+            ( $diff, $in, $out ) = read_timer();
 
         }
 
@@ -1128,7 +1119,7 @@
     }
 
     if ( $options->silent() ) {
-        $plugin->nagios_exit( OK, ( join ', ', @unique_devices ) . ' OK' );
+        $plugin->nagios_exit( OK, ( join ', ', @unique_devices ) . 'OK' );
     }
     else {
         $plugin->nagios_exit( $status, join ', ', @status_lines, );
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' 
'--exclude=.svnignore' old/check_diskio-3.2.6/check_diskio.pod 
new/check_diskio-3.2.4/check_diskio.pod
--- old/check_diskio-3.2.6/check_diskio.pod     2014-01-31 07:48:00.000000000 
+0100
+++ new/check_diskio-3.2.4/check_diskio.pod     2011-11-09 20:23:31.000000000 
+0100
@@ -14,7 +14,7 @@
 
 =head1 VERSION
 
-Version 3.2.6
+Version 3.2.4
 
 =head1 SYNOPSIS
 
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' 
'--exclude=.svnignore' old/check_diskio-3.2.6/check_diskio.spec 
new/check_diskio-3.2.4/check_diskio.spec
--- old/check_diskio-3.2.6/check_diskio.spec    2014-01-31 07:48:00.000000000 
+0100
+++ new/check_diskio-3.2.4/check_diskio.spec    2011-11-09 20:23:31.000000000 
+0100
@@ -1,12 +1,12 @@
 
################################################################################
 # File version information:
-# $Id: check_diskio.spec 1351 2014-01-31 06:47:38Z corti $
-# $Revision: 1351 $
+# $Id: check_diskio.spec 1278 2011-11-09 18:44:34Z corti $
+# $Revision: 1278 $
 # $HeadURL: 
https://svn.id.ethz.ch/nagios_plugins/check_diskio/check_diskio.spec $
-# $Date: 2014-01-31 07:47:38 +0100 (Fri, 31 Jan 2014) $
+# $Date: 2011-11-09 19:44:34 +0100 (Wed, 09 Nov 2011) $
 
################################################################################
 
-%define version          3.2.6
+%define version          3.2.4
 %define release          0
 %define sourcename       check_diskio
 %define packagename      nagios-plugins-check-diskio
@@ -75,9 +75,6 @@
 %{_mandir}/man1/%{sourcename}.1*
 
 %changelog
-* Thu Jan 30 2014 Matteo Corti <[email protected]> - 3.2.6-0
-- Updated to 3.2.6 (bug fix)
-
 * Wed Nov  9 2011 Matteo Corti <[email protected]> - 3.2.4-0
 - 3.X kernel support
 
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' 
'--exclude=.svnignore' old/check_diskio-3.2.6/inc/Module/Install/Base.pm 
new/check_diskio-3.2.4/inc/Module/Install/Base.pm
--- old/check_diskio-3.2.6/inc/Module/Install/Base.pm   2011-11-09 
17:54:44.000000000 +0100
+++ new/check_diskio-3.2.4/inc/Module/Install/Base.pm   2010-05-17 
21:08:29.000000000 +0200
@@ -4,7 +4,7 @@
 use strict 'vars';
 use vars qw{$VERSION};
 BEGIN {
-       $VERSION = '1.01';
+       $VERSION = '0.95';
 }
 
 # Suspend handler for "redefined" warnings
@@ -51,18 +51,13 @@
 #line 106
 
 sub is_admin {
-       ! $_[0]->admin->isa('Module::Install::Base::FakeAdmin');
+       $_[0]->admin->VERSION;
 }
 
 sub DESTROY {}
 
 package Module::Install::Base::FakeAdmin;
 
-use vars qw{$VERSION};
-BEGIN {
-       $VERSION = $Module::Install::Base::VERSION;
-}
-
 my $fake;
 
 sub new {
@@ -80,4 +75,4 @@
 
 1;
 
-#line 159
+#line 154
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' 
'--exclude=.svnignore' old/check_diskio-3.2.6/inc/Module/Install/Include.pm 
new/check_diskio-3.2.4/inc/Module/Install/Include.pm
--- old/check_diskio-3.2.6/inc/Module/Install/Include.pm        2011-11-09 
17:54:44.000000000 +0100
+++ new/check_diskio-3.2.4/inc/Module/Install/Include.pm        2010-05-17 
21:08:29.000000000 +0200
@@ -6,7 +6,7 @@
 
 use vars qw{$VERSION @ISA $ISCORE};
 BEGIN {
-       $VERSION = '1.01';
+       $VERSION = '0.95';
        @ISA     = 'Module::Install::Base';
        $ISCORE  = 1;
 }
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' 
'--exclude=.svnignore' old/check_diskio-3.2.6/inc/Module/Install/MakeMaker.pm 
new/check_diskio-3.2.4/inc/Module/Install/MakeMaker.pm
--- old/check_diskio-3.2.6/inc/Module/Install/MakeMaker.pm      2011-11-09 
17:54:44.000000000 +0100
+++ new/check_diskio-3.2.4/inc/Module/Install/MakeMaker.pm      2010-05-17 
21:08:29.000000000 +0200
@@ -7,7 +7,7 @@
 
 use vars qw{$VERSION @ISA $ISCORE};
 BEGIN {
-       $VERSION = '1.01';
+       $VERSION = '0.95';
        @ISA     = 'Module::Install::Base';
        $ISCORE  = 1;
 }
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' 
'--exclude=.svnignore' old/check_diskio-3.2.6/inc/Module/Install/Makefile.pm 
new/check_diskio-3.2.4/inc/Module/Install/Makefile.pm
--- old/check_diskio-3.2.6/inc/Module/Install/Makefile.pm       2011-11-09 
17:54:44.000000000 +0100
+++ new/check_diskio-3.2.4/inc/Module/Install/Makefile.pm       2010-05-17 
21:08:29.000000000 +0200
@@ -4,11 +4,10 @@
 use strict 'vars';
 use ExtUtils::MakeMaker   ();
 use Module::Install::Base ();
-use Fcntl qw/:flock :seek/;
 
 use vars qw{$VERSION @ISA $ISCORE};
 BEGIN {
-       $VERSION = '1.01';
+       $VERSION = '0.95';
        @ISA     = 'Module::Install::Base';
        $ISCORE  = 1;
 }
@@ -102,27 +101,25 @@
        my ($self, %new_args) = @_;
        my $args = ( $self->{makemaker_args} ||= {} );
        foreach my $key (keys %new_args) {
-               if ($makemaker_argtype{$key}) {
-                       if ($makemaker_argtype{$key} eq 'ARRAY') {
-                               $args->{$key} = [] unless defined $args->{$key};
-                               unless (ref $args->{$key} eq 'ARRAY') {
-                                       $args->{$key} = [$args->{$key}]
-                               }
-                               push @{$args->{$key}},
-                                       ref $new_args{$key} eq 'ARRAY'
-                                               ? @{$new_args{$key}}
-                                               : $new_args{$key};
+               if ($makemaker_argtype{$key} eq 'ARRAY') {
+                       $args->{$key} = [] unless defined $args->{$key};
+                       unless (ref $args->{$key} eq 'ARRAY') {
+                               $args->{$key} = [$args->{$key}]
                        }
-                       elsif ($makemaker_argtype{$key} eq 'HASH') {
-                               $args->{$key} = {} unless defined $args->{$key};
-                               foreach my $skey (keys %{ $new_args{$key} }) {
-                                       $args->{$key}{$skey} = 
$new_args{$key}{$skey};
-                               }
-                       }
-                       elsif ($makemaker_argtype{$key} eq 'APPENDABLE') {
-                               $self->makemaker_append($key => 
$new_args{$key});
+                       push @{$args->{$key}},
+                               ref $new_args{$key} eq 'ARRAY'
+                                       ? @{$new_args{$key}}
+                                       : $new_args{$key};
+               }
+               elsif ($makemaker_argtype{$key} eq 'HASH') {
+                       $args->{$key} = {} unless defined $args->{$key};
+                       foreach my $skey (keys %{ $new_args{$key} }) {
+                               $args->{$key}{$skey} = $new_args{$key}{$skey};
                        }
                }
+               elsif ($makemaker_argtype{$key} eq 'APPENDABLE') {
+                       $self->makemaker_append($key => $new_args{$key});
+               }
                else {
                        if (defined $args->{$key}) {
                                warn qq{MakeMaker attribute "$key" is 
overriden; use "makemaker_append" to append values\n};
@@ -181,22 +178,28 @@
        $self->makemaker_args( INC => shift );
 }
 
+my %test_dir = ();
+
 sub _wanted_t {
+       /\.t$/ and -f $_ and $test_dir{$File::Find::dir} = 1;
 }
 
 sub tests_recursive {
        my $self = shift;
+       if ( $self->tests ) {
+               die "tests_recursive will not work if tests are already 
defined";
+       }
        my $dir = shift || 't';
        unless ( -d $dir ) {
                die "tests_recursive dir '$dir' does not exist";
        }
-       my %tests = map { $_ => 1 } split / /, ($self->tests || '');
+       %test_dir = ();
        require File::Find;
-       File::Find::find(
-        sub { /\.t$/ and -f $_ and $tests{"$File::Find::dir/*.t"} = 1 },
-        $dir
-    );
-       $self->tests( join ' ', sort keys %tests );
+       File::Find::find( \&_wanted_t, $dir );
+       if ( -d 'xt' and ($Module::Install::AUTHOR or $ENV{RELEASE_TESTING}) ) {
+               File::Find::find( \&_wanted_t, 'xt' );
+       }
+       $self->tests( join ' ', map { "$_/*.t" } sort keys %test_dir );
 }
 
 sub write {
@@ -248,9 +251,6 @@
                $args->{test} = {
                        TESTS => (join ' ', grep {!$seen{$_}++} @tests),
                };
-    } elsif ( $Module::Install::ExtraTests::use_extratests ) {
-        # Module::Install::ExtraTests doesn't set $self->tests and does its 
own tests via harness.
-        # So, just ignore our xt tests here.
        } elsif ( -d 'xt' and ($Module::Install::AUTHOR or 
$ENV{RELEASE_TESTING}) ) {
                $args->{test} = {
                        TESTS => join( ' ', map { "$_/*.t" } grep { -d $_ } qw{ 
t xt } ),
@@ -297,22 +297,13 @@
        # Remove any reference to perl, BUILD_REQUIRES doesn't support it
        delete $args->{BUILD_REQUIRES}->{perl};
 
-       # Delete bundled dists from prereq_pm, add it to Makefile DIR
-       my $subdirs = ($args->{DIR} || []);
+       # Delete bundled dists from prereq_pm
+       my $subdirs = ($args->{DIR} ||= []);
        if ($self->bundles) {
-               my %processed;
                foreach my $bundle (@{ $self->bundles }) {
-                       my ($mod_name, $dist_dir) = @$bundle;
-                       delete $prereq->{$mod_name};
-                       $dist_dir = File::Basename::basename($dist_dir); # dir 
for building this module
-                       if (not exists $processed{$dist_dir}) {
-                               if (-d $dist_dir) {
-                                       # List as sub-directory to be processed 
by make
-                                       push @$subdirs, $dist_dir;
-                               }
-                               # Else do nothing: the module is already 
present on the system
-                               $processed{$dist_dir} = undef;
-                       }
+                       my ($file, $dir) = @$bundle;
+                       push @$subdirs, $dir if -d $dir;
+                       delete $build_prereq->{$file}; #Delete from build 
prereqs only
                }
        }
 
@@ -365,9 +356,9 @@
                . ($self->postamble || '');
 
        local *MAKEFILE;
-       open MAKEFILE, "+< $makefile_name" or die "fix_up_makefile: Couldn't 
open $makefile_name: $!";
-       eval { flock MAKEFILE, LOCK_EX };
+       open MAKEFILE, "< $makefile_name" or die "fix_up_makefile: Couldn't 
open $makefile_name: $!";
        my $makefile = do { local $/; <MAKEFILE> };
+       close MAKEFILE or die $!;
 
        $makefile =~ s/\b(test_harness\(\$\(TEST_VERBOSE\), )/$1'inc', /;
        $makefile =~ s/( -I\$\(INST_ARCHLIB\))/ -Iinc$1/g;
@@ -387,8 +378,7 @@
        # XXX - This is currently unused; not sure if it breaks other MM-users
        # $makefile =~ s/^pm_to_blib\s+:\s+/pm_to_blib :: /mg;
 
-       seek MAKEFILE, 0, SEEK_SET;
-       truncate MAKEFILE, 0;
+       open  MAKEFILE, "> $makefile_name" or die "fix_up_makefile: Couldn't 
open $makefile_name: $!";
        print MAKEFILE  "$preamble$makefile$postamble" or die $!;
        close MAKEFILE  or die $!;
 
@@ -412,4 +402,4 @@
 
 __END__
 
-#line 541
+#line 531
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' 
'--exclude=.svnignore' old/check_diskio-3.2.6/inc/Module/Install/Metadata.pm 
new/check_diskio-3.2.4/inc/Module/Install/Metadata.pm
--- old/check_diskio-3.2.6/inc/Module/Install/Metadata.pm       2011-11-09 
17:54:44.000000000 +0100
+++ new/check_diskio-3.2.4/inc/Module/Install/Metadata.pm       2010-05-17 
21:08:29.000000000 +0200
@@ -6,7 +6,7 @@
 
 use vars qw{$VERSION @ISA $ISCORE};
 BEGIN {
-       $VERSION = '1.01';
+       $VERSION = '0.95';
        @ISA     = 'Module::Install::Base';
        $ISCORE  = 1;
 }
@@ -178,6 +178,43 @@
        $self->{values}->{perl_version} = $version;
 }
 
+#Stolen from M::B
+my %license_urls = (
+    perl         => 'http://dev.perl.org/licenses/',
+    apache       => 'http://apache.org/licenses/LICENSE-2.0',
+    artistic     => 'http://opensource.org/licenses/artistic-license.php',
+    artistic_2   => 'http://opensource.org/licenses/artistic-license-2.0.php',
+    lgpl         => 'http://opensource.org/licenses/lgpl-license.php',
+    lgpl2        => 'http://opensource.org/licenses/lgpl-2.1.php',
+    lgpl3        => 'http://opensource.org/licenses/lgpl-3.0.html',
+    bsd          => 'http://opensource.org/licenses/bsd-license.php',
+    gpl          => 'http://opensource.org/licenses/gpl-license.php',
+    gpl2         => 'http://opensource.org/licenses/gpl-2.0.php',
+    gpl3         => 'http://opensource.org/licenses/gpl-3.0.html',
+    mit          => 'http://opensource.org/licenses/mit-license.php',
+    mozilla      => 'http://opensource.org/licenses/mozilla1.1.php',
+    open_source  => undef,
+    unrestricted => undef,
+    restrictive  => undef,
+    unknown      => undef,
+);
+
+sub license {
+       my $self = shift;
+       return $self->{values}->{license} unless @_;
+       my $license = shift or die(
+               'Did not provide a value to license()'
+       );
+       $self->{values}->{license} = $license;
+
+       # Automatically fill in license URLs
+       if ( $license_urls{$license} ) {
+               $self->resources( license => $license_urls{$license} );
+       }
+
+       return 1;
+}
+
 sub all_from {
        my ( $self, $file ) = @_;
 
@@ -317,9 +354,6 @@
        require ExtUtils::MM_Unix;
        my ( $self, $file ) = @_;
        $self->version( ExtUtils::MM_Unix->parse_version($file) );
-
-       # for version integrity check
-       $self->makemaker_args( VERSION_FROM => $file );
 }
 
 sub abstract_from {
@@ -330,7 +364,7 @@
                        { DISTNAME => $self->name },
                        'ExtUtils::MM_Unix'
                )->parse_abstract($file)
-       );
+        );
 }
 
 # Add both distribution and module name
@@ -445,90 +479,42 @@
        }
 }
 
-#Stolen from M::B
-my %license_urls = (
-    perl         => 'http://dev.perl.org/licenses/',
-    apache       => 'http://apache.org/licenses/LICENSE-2.0',
-    apache_1_1   => 'http://apache.org/licenses/LICENSE-1.1',
-    artistic     => 'http://opensource.org/licenses/artistic-license.php',
-    artistic_2   => 'http://opensource.org/licenses/artistic-license-2.0.php',
-    lgpl         => 'http://opensource.org/licenses/lgpl-license.php',
-    lgpl2        => 'http://opensource.org/licenses/lgpl-2.1.php',
-    lgpl3        => 'http://opensource.org/licenses/lgpl-3.0.html',
-    bsd          => 'http://opensource.org/licenses/bsd-license.php',
-    gpl          => 'http://opensource.org/licenses/gpl-license.php',
-    gpl2         => 'http://opensource.org/licenses/gpl-2.0.php',
-    gpl3         => 'http://opensource.org/licenses/gpl-3.0.html',
-    mit          => 'http://opensource.org/licenses/mit-license.php',
-    mozilla      => 'http://opensource.org/licenses/mozilla1.1.php',
-    open_source  => undef,
-    unrestricted => undef,
-    restrictive  => undef,
-    unknown      => undef,
-);
-
-sub license {
-       my $self = shift;
-       return $self->{values}->{license} unless @_;
-       my $license = shift or die(
-               'Did not provide a value to license()'
-       );
-       $license = __extract_license($license) || lc $license;
-       $self->{values}->{license} = $license;
-
-       # Automatically fill in license URLs
-       if ( $license_urls{$license} ) {
-               $self->resources( license => $license_urls{$license} );
-       }
-
-       return 1;
-}
-
 sub _extract_license {
        my $pod = shift;
        my $matched;
        return __extract_license(
                ($matched) = $pod =~ m/
-                       (=head \d \s+ L(?i:ICEN[CS]E|ICENSING)\b.*?)
+                       (=head \d \s+ (?:licen[cs]e|licensing)\b.*?)
                        (=head \d.*|=cut.*|)\z
-               /xms
+               /ixms
        ) || __extract_license(
                ($matched) = $pod =~ m/
-                       (=head \d \s+ (?:C(?i:OPYRIGHTS?)|L(?i:EGAL))\b.*?)
+                       (=head \d \s+ (?:copyrights?|legal)\b.*?)
                        (=head \d.*|=cut.*|)\z
-               /xms
+               /ixms
        );
 }
 
 sub __extract_license {
        my $license_text = shift or return;
        my @phrases      = (
-               '(?:under )?the same (?:terms|license) as (?:perl|the perl 
(?:\d )?programming language)' => 'perl', 1,
-               '(?:under )?the terms of (?:perl|the perl programming language) 
itself' => 'perl', 1,
-               'Artistic and GPL'                   => 'perl',         1,
-               'GNU general public license'         => 'gpl',          1,
-               'GNU public license'                 => 'gpl',          1,
-               'GNU lesser general public license'  => 'lgpl',         1,
-               'GNU lesser public license'          => 'lgpl',         1,
-               'GNU library general public license' => 'lgpl',         1,
-               'GNU library public license'         => 'lgpl',         1,
-               'GNU Free Documentation license'     => 'unrestricted', 1,
-               'GNU Affero General Public License'  => 'open_source',  1,
-               '(?:Free)?BSD license'               => 'bsd',          1,
-               'Artistic license 2\.0'              => 'artistic_2',   1,
-               'Artistic license'                   => 'artistic',     1,
-               'Apache (?:Software )?license'       => 'apache',       1,
-               'GPL'                                => 'gpl',          1,
-               'LGPL'                               => 'lgpl',         1,
-               'BSD'                                => 'bsd',          1,
-               'Artistic'                           => 'artistic',     1,
-               'MIT'                                => 'mit',          1,
-               'Mozilla Public License'             => 'mozilla',      1,
-               'Q Public License'                   => 'open_source',  1,
-               'OpenSSL License'                    => 'unrestricted', 1,
-               'SSLeay License'                     => 'unrestricted', 1,
-               'zlib License'                       => 'open_source',  1,
-               'proprietary'                        => 'proprietary',  0,
+               'under the same (?:terms|license) as (?:perl|the perl 
programming language)' => 'perl', 1,
+               'under the terms of (?:perl|the perl programming language) 
itself' => 'perl', 1,
+               'Artistic and GPL'                   => 'perl',        1,
+               'GNU general public license'         => 'gpl',         1,
+               'GNU public license'                 => 'gpl',         1,
+               'GNU lesser general public license'  => 'lgpl',        1,
+               'GNU lesser public license'          => 'lgpl',        1,
+               'GNU library general public license' => 'lgpl',        1,
+               'GNU library public license'         => 'lgpl',        1,
+               'BSD license'                        => 'bsd',         1,
+               'Artistic license'                   => 'artistic',    1,
+               'GPL'                                => 'gpl',         1,
+               'LGPL'                               => 'lgpl',        1,
+               'BSD'                                => 'bsd',         1,
+               'Artistic'                           => 'artistic',    1,
+               'MIT'                                => 'mit',         1,
+               'proprietary'                        => 'proprietary', 0,
        );
        while ( my ($pattern, $license, $osi) = splice(@phrases, 0, 3) ) {
                $pattern =~ s#\s+#\\s+#gs;
@@ -536,7 +522,6 @@
                        return $license;
                }
        }
-       return '';
 }
 
 sub license_from {
@@ -551,9 +536,9 @@
 
 sub _extract_bugtracker {
        my @links   = $_[0] =~ m#L<(
-        https?\Q://rt.cpan.org/\E[^>]+|
-        https?\Q://github.com/\E[\w_]+/[\w_]+/issues|
-        https?\Q://code.google.com/p/\E[\w_\-]+/issues/list
+        \Qhttp://rt.cpan.org/\E[^>]+|
+        \Qhttp://github.com/\E[\w_]+/[\w_]+/issues|
+        \Qhttp://code.google.com/p/\E[\w_\-]+/issues/list
         )>#gx;
        my %links;
        @links{@links}=();
@@ -617,15 +602,8 @@
        return $v;
 }
 
-sub add_metadata {
-    my $self = shift;
-    my %hash = @_;
-    for my $key (keys %hash) {
-        warn "add_metadata: $key is not prefixed with 'x_'.\n" .
-             "Use appopriate function to add non-private metadata.\n" unless 
$key =~ /^x_/;
-        $self->{values}->{$key} = $hash{$key};
-    }
-}
+
+
 
 
 ######################################################################
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' 
'--exclude=.svnignore' old/check_diskio-3.2.6/inc/Module/Install/Scripts.pm 
new/check_diskio-3.2.4/inc/Module/Install/Scripts.pm
--- old/check_diskio-3.2.6/inc/Module/Install/Scripts.pm        2011-11-09 
17:54:44.000000000 +0100
+++ new/check_diskio-3.2.4/inc/Module/Install/Scripts.pm        2010-05-17 
21:08:29.000000000 +0200
@@ -6,7 +6,7 @@
 
 use vars qw{$VERSION @ISA $ISCORE};
 BEGIN {
-       $VERSION = '1.01';
+       $VERSION = '0.95';
        @ISA     = 'Module::Install::Base';
        $ISCORE  = 1;
 }
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' 
'--exclude=.svnignore' old/check_diskio-3.2.6/inc/Module/Install.pm 
new/check_diskio-3.2.4/inc/Module/Install.pm
--- old/check_diskio-3.2.6/inc/Module/Install.pm        2011-11-09 
17:54:44.000000000 +0100
+++ new/check_diskio-3.2.4/inc/Module/Install.pm        2010-05-17 
21:08:29.000000000 +0200
@@ -22,6 +22,7 @@
 use Cwd        ();
 use File::Find ();
 use File::Path ();
+use FindBin;
 
 use vars qw{$VERSION $MAIN};
 BEGIN {
@@ -31,7 +32,7 @@
        # This is not enforced yet, but will be some time in the next few
        # releases once we can make sure it won't clash with custom
        # Module::Install extensions.
-       $VERSION = '1.01';
+       $VERSION = '0.95';
 
        # Storage for the pseudo-singleton
        $MAIN    = undef;
@@ -126,11 +127,6 @@
        #-------------------------------------------------------------
 
        unless ( -f $self->{file} ) {
-               foreach my $key (keys %INC) {
-                       delete $INC{$key} if $key =~ /Module\/Install/;
-               }
-
-               local $^W;
                require "$self->{path}/$self->{dispatch}.pm";
                File::Path::mkpath("$self->{prefix}/$self->{author}");
                $self->{admin} = "$self->{name}::$self->{dispatch}"->new( _top 
=> $self );
@@ -139,13 +135,12 @@
                goto &{"$self->{name}::import"};
        }
 
-       local $^W;
        *{"${who}::AUTOLOAD"} = $self->autoload;
        $self->preload;
 
        # Unregister loader and worker packages so subdirs can use them again
-       delete $INC{'inc/Module/Install.pm'};
-       delete $INC{'Module/Install.pm'};
+       delete $INC{"$self->{file}"};
+       delete $INC{"$self->{path}.pm"};
 
        # Save to the singleton
        $MAIN = $self;
@@ -164,21 +159,7 @@
                        # Delegate back to parent dirs
                        goto &$code unless $cwd eq $pwd;
                }
-               unless ($$sym =~ s/([^:]+)$//) {
-                       # XXX: it looks like we can't retrieve the missing 
function
-                       # via $$sym (usually $main::AUTOLOAD) in this case.
-                       # I'm still wondering if we should slurp Makefile.PL to
-                       # get some context or not ...
-                       my ($package, $file, $line) = caller;
-                       die <<"EOT";
-Unknown function is found at $file line $line.
-Execution of $file aborted due to runtime errors.
-
-If you're a contributor to a project, you may need to install
-some Module::Install extensions from CPAN (or other repository).
-If you're a user of a module, please contact the author.
-EOT
-               }
+               $$sym =~ /([^:]+)$/ or die "Cannot autoload $who - $sym";
                my $method = $1;
                if ( uc($method) eq $method ) {
                        # Do nothing
@@ -219,7 +200,6 @@
 
        my $who = $self->_caller;
        foreach my $name ( sort keys %seen ) {
-               local $^W;
                *{"${who}::$name"} = sub {
                        ${"${who}::AUTOLOAD"} = "${who}::$name";
                        goto &{"${who}::AUTOLOAD"};
@@ -230,18 +210,12 @@
 sub new {
        my ($class, %args) = @_;
 
-       delete $INC{'FindBin.pm'};
-       {
-               # to suppress the redefine warning
-               local $SIG{__WARN__} = sub {};
-               require FindBin;
-       }
-
        # ignore the prefix on extension modules built from top level.
        my $base_path = Cwd::abs_path($FindBin::Bin);
        unless ( Cwd::abs_path(Cwd::cwd()) eq $base_path ) {
                delete $args{prefix};
        }
+
        return $args{_self} if $args{_self};
 
        $args{dispatch} ||= 'Admin';
@@ -294,10 +268,8 @@
 sub load_extensions {
        my ($self, $path, $top) = @_;
 
-       my $should_reload = 0;
        unless ( grep { ! ref $_ and lc $_ eq lc $self->{prefix} } @INC ) {
                unshift @INC, $self->{prefix};
-               $should_reload = 1;
        }
 
        foreach my $rv ( $self->find_extensions($path) ) {
@@ -305,13 +277,12 @@
                next if $self->{pathnames}{$pkg};
 
                local $@;
-               my $new = eval { local $^W; require $file; $pkg->can('new') };
+               my $new = eval { require $file; $pkg->can('new') };
                unless ( $new ) {
                        warn $@ if $@;
                        next;
                }
-               $self->{pathnames}{$pkg} =
-                       $should_reload ? delete $INC{$file} : $INC{$file};
+               $self->{pathnames}{$pkg} = delete $INC{$file};
                push @{$self->{extensions}}, &{$new}($pkg, _top => $top );
        }
 
@@ -467,4 +438,4 @@
 
 1;
 
-# Copyright 2008 - 2011 Adam Kennedy.
+# Copyright 2008 - 2010 Adam Kennedy.
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' 
'--exclude=.svnignore' old/check_diskio-3.2.6/inc/version.pm 
new/check_diskio-3.2.4/inc/version.pm
--- old/check_diskio-3.2.6/inc/version.pm       2011-11-09 17:54:44.000000000 
+0100
+++ new/check_diskio-3.2.4/inc/version.pm       2010-05-17 21:08:29.000000000 
+0200
@@ -7,7 +7,7 @@
 
 use vars qw(@ISA $VERSION $CLASS $STRICT $LAX *declare *qv);
 
-$VERSION = 0.88;
+$VERSION = 0.82;
 
 $CLASS = 'version';
 
@@ -124,7 +124,13 @@
     *version::qv = \&version::vpp::qv;
     *version::declare = \&version::vpp::declare;
     *version::_VERSION = \&version::vpp::_VERSION;
-    if ($] >= 5.009000 && $] < 5.011004) {
+    if ($] > 5.009001 && $] < 5.010000) {
+       no strict 'refs';
+       *version::stringify = \&version::vpp::stringify;
+       *{'version::(""'} = \&version::vpp::stringify;
+       *version::new = \&version::vpp::new;
+    }
+    elsif ($] == 5.010000 || $] == 5.010001) {
        no strict 'refs';
        *version::stringify = \&version::vpp::stringify;
        *{'version::(""'} = \&version::vpp::stringify;
@@ -138,8 +144,12 @@
     *version::declare = \&version::vxs::declare;
     *version::qv = \&version::vxs::qv;
     *version::_VERSION = \&version::vxs::_VERSION;
-    *version::vcmp = \&version::vxs::VCMP;
-    if ($] >= 5.009000 && $] < 5.011004) {
+    if ($] > 5.009001 && $] < 5.010000) {
+       no strict 'refs';
+       *version::stringify = \&version::vxs::stringify;
+       *{'version::(""'} = \&version::vxs::stringify;
+    }
+    elsif ($] == 5.010000 || $] == 5.010001) {
        no strict 'refs';
        *version::stringify = \&version::vxs::stringify;
        *{'version::(""'} = \&version::vxs::stringify;
@@ -198,12 +208,14 @@
     }
 
     if (exists($args{'is_strict'})) {
-       *{$callpkg.'::is_strict'} = \&version::is_strict
+       *{$callpkg.'::is_strict'} = 
+           sub {return $class->is_strict(shift)}
          unless defined(&{$callpkg.'::is_strict'});
     }
 
     if (exists($args{'is_lax'})) {
-       *{$callpkg.'::is_lax'} = \&version::is_lax
+       *{$callpkg.'::is_lax'} = 
+           sub {return $class->is_lax(shift)}
          unless defined(&{$callpkg.'::is_lax'});
     }
 }

-- 
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to