Hello community, here is the log from the commit of package samba for openSUSE:Factory checked in at 2014-11-07 09:05:19 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Comparing /work/SRC/openSUSE:Factory/samba (Old) and /work/SRC/openSUSE:Factory/.samba.new (New) ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Package is "samba" Changes: -------- --- /work/SRC/openSUSE:Factory/samba/samba.changes 2014-10-31 12:31:50.000000000 +0100 +++ /work/SRC/openSUSE:Factory/.samba.new/samba.changes 2014-11-07 09:05:20.000000000 +0100 @@ -1,0 +2,17 @@ +Thu Nov 6 13:41:46 UTC 2014 - [email protected] + +- Use the upstream tar ball, as signature verification is now able to handle + compressed archives. + +------------------------------------------------------------------- +Wed Nov 5 13:02:57 CET 2014 - [email protected] + +- Fix leak when closing file descriptor returned from dirfd; (bso#10918). + +------------------------------------------------------------------- +Tue Oct 28 16:13:45 UTC 2014 - [email protected] + +- Remove dependency on gpg-offline as signature checking is implemented in the + source validator. + +------------------------------------------------------------------- Old: ---- samba-pubkey_6568B7EA.asc New: ---- samba.keyring ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Other differences: ------------------ ++++++ samba.spec ++++++ --- /var/tmp/diff_new_pack.LYbtAn/_old 2014-11-07 09:05:22.000000000 +0100 +++ /var/tmp/diff_new_pack.LYbtAn/_new 2014-11-07 09:05:22.000000000 +0100 @@ -118,7 +118,6 @@ BuildRequires: libxslt-tools %endif %if 0%{?suse_version} > 1220 -BuildRequires: gpg-offline BuildRequires: systemd BuildRequires: systemd-devel %endif @@ -146,7 +145,7 @@ %else %define build_make_smp_mflags %{?jobs:-j%jobs} %endif -%define SOURCE_TIMESTAMP 3312 +%define SOURCE_TIMESTAMP 3327 %define BRANCH %{version} %global with_mitkrb5 1 %global with_dc 0 @@ -165,7 +164,7 @@ Group: Productivity/Networking/Samba Source: %{samba_source_location} Source5: %{samba_source_signature_location} -Source6: http://www.samba.org/samba/ftp/samba-pubkey_6568B7EA.asc +Source6: samba.keyring Source1: vendor-files.tar.bz2 Source2: patches.tar.bz2 Source4: baselibs.conf @@ -1105,11 +1104,6 @@ %prep -%if 0%{?suse_version} > 1220 -gzip -dc %{SOURCE0} >${RPM_SOURCE_DIR}/%{name}-%{samba_ver_full}.tar -%{?gpg_verify: %gpg_verify --keyring %{SOURCE6} %{SOURCE5}} -rm ${RPM_SOURCE_DIR}/%{name}-%{samba_ver_full}.tar -%endif %setup -n samba-%{samba_ver_full} -q # patches %setup -T -D -a 2 -n samba-%{samba_ver_full} -q ++++++ patches.tar.bz2 ++++++ diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/patches/samba.org/6faef4d213e76077bdbaf83cf07f0261c11dc757 new/patches/samba.org/6faef4d213e76077bdbaf83cf07f0261c11dc757 --- old/patches/samba.org/6faef4d213e76077bdbaf83cf07f0261c11dc757 1970-01-01 01:00:00.000000000 +0100 +++ new/patches/samba.org/6faef4d213e76077bdbaf83cf07f0261c11dc757 2014-11-05 19:20:59.000000000 +0100 @@ -0,0 +1,74 @@ +From 6faef4d213e76077bdbaf83cf07f0261c11dc757 Mon Sep 17 00:00:00 2001 +From: Noel Power <[email protected]> +Date: Tue, 4 Nov 2014 16:52:49 +0100 +Subject: [PATCH] btrfs: don't leak opened directory handle + +Closing a directory handle file descriptor via close() is undefined, +according to: +http://pubs.opengroup.org/onlinepubs/9699919799/functions/dirfd.html + +Signed-off-by: Noel Power <[email protected]> +Reviewed-by: David Disseldorp <[email protected]> +Reviewed-by: Jeremy Allison <[email protected]> + +Autobuild-User(master): David Disseldorp <[email protected]> +Autobuild-Date(master): Tue Nov 4 20:51:02 CET 2014 on sn-devel-104 +--- + source3/modules/vfs_btrfs.c | 22 ++++++++++++++++------ + 1 file changed, 16 insertions(+), 6 deletions(-) + +diff --git source3/modules/vfs_btrfs.c source3/modules/vfs_btrfs.c +index c1e17b3..5144239 100644 +--- source3/modules/vfs_btrfs.c ++++ source3/modules/vfs_btrfs.c +@@ -245,23 +245,29 @@ static NTSTATUS btrfs_get_compression(struct vfs_handle_struct *handle, + int fd; + bool opened = false; + NTSTATUS status; ++ DIR *dir = NULL; + + if ((fsp != NULL) && (fsp->fh->fd != -1)) { + fd = fsp->fh->fd; + } else if (smb_fname != NULL) { + if (S_ISDIR(smb_fname->st.st_ex_mode)) { +- DIR *dir = opendir(smb_fname->base_name); ++ dir = opendir(smb_fname->base_name); + if (dir == NULL) { + return NT_STATUS_UNSUCCESSFUL; + } ++ opened = true; + fd = dirfd(dir); ++ if (fd < 0) { ++ status = NT_STATUS_UNSUCCESSFUL; ++ goto err_close; ++ } + } else { + fd = open(smb_fname->base_name, O_RDONLY); ++ if (fd < 0) { ++ return NT_STATUS_UNSUCCESSFUL; ++ } ++ opened = true; + } +- if (fd < 0) { +- return NT_STATUS_UNSUCCESSFUL; +- } +- opened = true; + } else { + return NT_STATUS_INVALID_PARAMETER; + } +@@ -281,7 +287,11 @@ static NTSTATUS btrfs_get_compression(struct vfs_handle_struct *handle, + status = NT_STATUS_OK; + err_close: + if (opened) { +- close(fd); ++ if (dir != NULL) { ++ closedir(dir); ++ } else { ++ close(fd); ++ } + } + + return status; +-- +1.8.4.5 + diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/patches/series new/patches/series --- old/patches/series 2014-10-26 14:56:35.000000000 +0100 +++ new/patches/series 2014-11-05 19:20:59.000000000 +0100 @@ -81,6 +81,7 @@ samba.org/98426ad467fa64975bd9e6aa32530a2dde719035 -p0 # bnc 890008 samba.org/0751495b1327d002b79482632b7c590cae6e3f9d -p0 # bso 10787, bnc 893774 samba.org/7f59711f076e98ece099f6b38ff6da8c80fa6d5e -p0 # bso 10824, bnc 897969 +samba.org/6faef4d213e76077bdbaf83cf07f0261c11dc757 -p0 # bso 10918 samba.org/fix_pc_dependencies.diff -p0 # SuSE specific changes ++++++ samba.keyring ++++++ pub 1024D/6568B7EA 2007-02-04 [expires: 2016-01-17] uid Samba Distribution Verification Key <[email protected]> sub 2048g/DA6DFB44 2007-02-04 [expires: 2016-01-17] -----BEGIN PGP PUBLIC KEY BLOCK----- Version: GnuPG v1.4.11 (GNU/Linux) mQGiBEXGOUcRBACooMht/2pmNT3bKZn1WEFQa+sXe6nxi3G6lH5bIBUKp85SDM57 4qTcBIJXhwfGABeSvyUdZJbBxJDD5bNiO4k+Y5j3t8t9hb2FKgJ1bXL2aO5BbFnJ UlkWw8UnHE3A3mmq2hYjfu+0J7mdMxyH5kajbtGfgt0rbPn/K00AgoBCqwCgyNR7 1kaKzs1os6BiBhu0sTxTkN8EAJC1u1+z9mput/IWo9bQ85KRPfTXXRxv07jK++Yf tPGMerJFxdpdVI+O+LQB9J7L6WUHF8TzmMEGHHStjnKiZB3PCDcAYpR8pVB3085f fEpF32ic7mQzK+K+P0KARadywX1JLYSYP2YQ1BeYteC7hUtp/U0i0c12JDG4Bmil JMZABACis5ms470DH3OwU7b32lDDLFWlwGEQX+OKQealhYgz3hdIzO+cm6Gz0/z1 YGl8oV0dc1tG2EfsndDx7QRwrBoxahfsgClN4K8HLtbBy1Ox9kZn+hr1yNEaPdko +W5bC96Wo2RqnSP09qJ5/tp6rXXCLIgF/+PeCJtP31MaMP0Jo7Q6U2FtYmEgRGlz dHJpYnV0aW9uIFZlcmlmaWNhdGlvbiBLZXkgPHNhbWJhLWJ1Z3NAc2FtYmEub3Jn PohmBBMRAgAmAhsDBgsJCAcDAgQVAggDBBYCAwECHgECF4AFAk9Ki3oFCQ1GuTMA CgkQbzORW2Vot+oKMQCgxTZ6Gvo6cJsVdVLzUiJPcHD9tW4AnjiOTF6F0G60oPK0 IxKOjGvVQ+4riEYEEBECAAYFAkXGOXUACgkQXNXaBxV7yV6oTwCgnSEFCs2pAwW5 LU22AfVDwh9e5AkAn2k0dRoGj2UL/Js4qvf3sBqEw4rriEYEEBECAAYFAkXGOcYA CgkQIR7qMdg1EfZyDACgyvRXAmV0XUhH1vbNMEG9+sFXaCwAoOQTsk19i3Luy3Pw +1gDaUeCzeLdiEYEEBECAAYFAkXIMMUACgkQ3L4Y/6A1U7wMMACgg4+AVtovhtY6 y1qip9uZ8qwbnkkAni269FhHSPKfGGEnfkrN/Q2/3EY7iEYEEBECAAYFAkYNcugA CgkQp6cLM3ld2XFzGwCffyD/eMhEKCN6j5FCSbb3rhkyR/kAn0PlFtYrTNkrc1dO ezhvaZZCPBHWiEYEEBECAAYFAkZQmboACgkQVVCoNUmKuAcl1wCdEzFgS3DIgIhY y6Id5a9EqUjArLkAnArdjXskM952gLuyJjgictCiHdIeiEYEEBECAAYFAkZdvkMA CgkQw1Ohknblb7ZN8gCgjD/SWG0qBCBD7w19I5kVTijU9j4AmwbPf4wU7hY942tn 1NxUyKwF+edxiEYEEBECAAYFAkXIC4MACgkQi9gubzC5S1zMJgCgqQOcgVsXQ7IT BsUTEFPiGPwUis8An1sb+UQfnsoRVoiwxiczw55ACi1BiEYEEBECAAYFAkku3m0A CgkQSOk3aI7hFogLEgCeKMOoyGUtcp5FqhmspG2VwkKBuQkAnRloBsefS7AdUfiF b+R878ikkKbliEYEEBECAAYFAkoebcIACgkQXox4WnRne2nv5gCdEiyazjMYBfqr 9a0pJQDN/iCIxacAoJOyzJp+JuItm7lmKZcRYmcPZqmsiEYEEBECAAYFAkoebdoA CgkQFJEptQgNy8JooQCgmdL/Gea2PmDrU2ZvopA3aYp+uUYAn1plmv07PAuVjieN MiUdhCpUU21KiF4EEBEIAAYFAlI1FtQACgkQEXiFBUEonDt+tgD/Zho5K93GblMx Jz+0SQV/xqOAq3eC3RZ9XrxsBsyTaE4A/2B8LbPeW1dg2Kn3mOwQeD8WJm7Yakt1 k6AZTcStB2TKiGYEExECACYCGwMGCwkIBwMCBBUCCAMEFgIDAQIeAQIXgAUCR81n qQUJA+hh4gAKCRBvM5FbZWi36vi9AJ4mVG9nQnBvew0UM4d+/wi+9Lb31ACfSriq m7CdG27eSY4+631lFdRV9meIZgQTEQIAJgIbAwYLCQgHAwIEFQIIAwQWAgMBAh4B AheABQJJtjjzBQkHsmasAAoJEG8zkVtlaLfqxAQAoI0BuXAfJd6e36a/2rt4zVFO 3EmeAKCrWxRIFlIWArnqOfG2peNa9+tnQohmBBMRAgAmAhsDBgsJCAcDAgQVAggD BBYCAwECHgECF4AFAk1jjnEFCQl+iKoACgkQbzORW2Vot+o+KQCgkMVKNdbKjF9s F7k97c0qd/xMyy8AnR6EnNmLXPZNxQlcp9ZWYcPl+IUiiGYEExECACYCGwMGCwkI BwMCBBUCCAMEFgIDAQIeAQIXgAUCUtjwHQUJENUd0gAKCRBvM5FbZWi36rskAJ46 KBD19wYQIVj/7wV/ztpr80cbCgCgqAmyho6JTtwE696dgGKjobV8wJ+IZgQTEQIA JgUCRcY5RwIbAwUJAeEzgAYLCQgHAwIEFQIIAwQWAgMBAh4BAheAAAoJEG8zkVtl aLfqFfkAn1T7m5GZcOgn7+vv4pWL1iRgVfH8AJ9UZyFrbR5MuvzGY3XNNC0YM6Nq ebkCDQRFxjlhEAgAyDleE6VRurQ11O2A9VYyd/cXbqJolk4PeHSDg4NW2Ry78FGu SNV+87I2JoIWeUGulsTZJ20csFp2j9DzjF0jLKVVp6gUE2ZJ8XQKTGzEBJKNKTyU i8HUw9/tMuYbeHnX9PGrFnUgU+cr7uTmpODv0mtz+ZTSHvEN0o36kWIkl9drloKn oftibEAudC6/a58/QDIyqmRMdr+1ypwpMaGhctV8DqT4ybSLjxWkiOTrpzbLoV2H hkL+zKqgNkTbrpaJ6B4JfSemM0QY3ZgwdvC5viSl8iaZxw61JCunOdOBLsVV10Cj ryzT8KHd1PPTgmd4BWVP83hEkHaVsVzIkL1KjwAECwgAp259HGGl4Zd1J50IMj2F VCVddv7AI4ZYAEKtPEj4EyaeBhPycfQtijEu3ZVmB+LYw0m3jvkSy3dup6XYYsvA p/VL7Cbw7O9f/uUtj06Vdenh+UM0GZLyfz15JEV0NSJaL5L7eayonhwseJ+kGW+b XfQLgHkWae+VFxETu6Vyhv+e6P0s7MKw/7UhCkaQSkBA+Hh7D6IS8N3TCg1huoS0 X+BkfL/sSixYr6l697bRC2/cUu2cmas+hUhbnEAKel2P8Y50dwhc3yqvaRzuD8L4 VOd7kHiPbLgB0j3nMX1CHEH6wmjeiupLRDGPisXkyVIKgexZ7JKspwqH9DDdjgON PohPBBgRAgAPAhsMBQJPSovmBQkNRrmFAAoJEG8zkVtlaLfqaCQAnjMe3EosdMt8 yIE7wCLctOrYZTjFAJ9YWXXjLQJFo2in7vC1pP7pgXrTyIhPBBgRAgAPAhsMBQJS 2PADBQkQ1R2SAAoJEG8zkVtlaLfqWU0AniUMsF8RV9nmW1GHMHS8wqZrPHDbAJ9A 9GHh4cjTsKMmRsY6FDkDm8mExQ== =nU8K -----END PGP PUBLIC KEY BLOCK----- ++++++ vendor-files.tar.bz2 ++++++ diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/vendor-files/tools/package-data new/vendor-files/tools/package-data --- old/vendor-files/tools/package-data 2014-10-26 16:36:17.000000000 +0100 +++ new/vendor-files/tools/package-data 2014-11-06 14:57:44.000000000 +0100 @@ -1,2 +1,2 @@ # This is an autogenrated file. -SAMBA_PACKAGE_SVN_VERSION="3312" +SAMBA_PACKAGE_SVN_VERSION="3327" -- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
