Hello community,
here is the log from the commit of package perl-Class-Accessor-Grouped for
openSUSE:Factory checked in at 2014-11-13 09:17:55
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Comparing /work/SRC/openSUSE:Factory/perl-Class-Accessor-Grouped (Old)
and /work/SRC/openSUSE:Factory/.perl-Class-Accessor-Grouped.new (New)
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Package is "perl-Class-Accessor-Grouped"
Changes:
--------
---
/work/SRC/openSUSE:Factory/perl-Class-Accessor-Grouped/perl-Class-Accessor-Grouped.changes
2013-06-05 17:48:08.000000000 +0200
+++
/work/SRC/openSUSE:Factory/.perl-Class-Accessor-Grouped.new/perl-Class-Accessor-Grouped.changes
2014-11-13 09:18:14.000000000 +0100
@@ -1,0 +2,8 @@
+Wed Nov 12 09:35:01 UTC 2014 - [email protected]
+
+- updated to 0.10012
+ - Fix tests tickling deficient threads on perl 5.10.0
+ - Soft-depend on newer (bugfixed and *simpler*) Class::XSAccessor 1.19
+ - More robust threading tests
+
+-------------------------------------------------------------------
Old:
----
Class-Accessor-Grouped-0.10010.tar.gz
New:
----
Class-Accessor-Grouped-0.10012.tar.gz
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Other differences:
------------------
++++++ perl-Class-Accessor-Grouped.spec ++++++
--- /var/tmp/diff_new_pack.jNYme0/_old 2014-11-13 09:18:15.000000000 +0100
+++ /var/tmp/diff_new_pack.jNYme0/_new 2014-11-13 09:18:15.000000000 +0100
@@ -1,7 +1,7 @@
#
# spec file for package perl-Class-Accessor-Grouped
#
-# Copyright (c) 2013 SUSE LINUX Products GmbH, Nuernberg, Germany.
+# Copyright (c) 2014 SUSE LINUX Products GmbH, Nuernberg, Germany.
#
# All modifications and additions to the file contributed by third parties
# remain the property of their copyright owners, unless otherwise agreed
@@ -17,7 +17,7 @@
Name: perl-Class-Accessor-Grouped
-Version: 0.10010
+Version: 0.10012
Release: 0
%define cpan_name Class-Accessor-Grouped
Summary: Lets you build groups of accessors
@@ -34,34 +34,8 @@
BuildRequires: perl(Module::Runtime) >= 0.012
BuildRequires: perl(Test::Exception) >= 0.31
BuildRequires: perl(Test::More) >= 0.88
-#BuildRequires: perl(AccessorGroups)
-#BuildRequires: perl(AccessorGroupsComp)
-#BuildRequires: perl(AccessorGroupsParent)
-#BuildRequires: perl(AccessorGroupsRO)
-#BuildRequires: perl(AccessorGroupsSubclass)
-#BuildRequires: perl(AccessorGroupsWO)
-#BuildRequires: perl(BaseInheritedGroups)
-#BuildRequires: perl(Class::Accessor::Grouped)
-#BuildRequires: perl(Class::XSAccessor)
-#BuildRequires: perl(CPANPLUS::Backend)
-#BuildRequires: perl(Devel::Hide)
-#BuildRequires: perl(ExtraInheritedGroups)
-#BuildRequires: perl(inc::Module::Install) >= 1.06
-#BuildRequires: perl(JSON)
-#BuildRequires: perl(LWP::Simple)
-#BuildRequires: perl(Module::AutoInstall)
-#BuildRequires: perl(Module::Build)
-#BuildRequires: perl(Module::Install::Base)
-#BuildRequires: perl(mro)
-#BuildRequires: perl(MRO::Compat)
-#BuildRequires: perl(NotHashBased)
-#BuildRequires: perl(Package::Stash)
-#BuildRequires: perl(Parse::CPAN::Meta)
-#BuildRequires: perl(Sub::Name)
-#BuildRequires: perl(SuperInheritedGroups)
-#BuildRequires: perl(YAML::Tiny)
Requires: perl(Module::Runtime) >= 0.012
-Recommends: perl(Class::XSAccessor) >= 1.15
+Recommends: perl(Class::XSAccessor) >= 1.19
Recommends: perl(Sub::Name) >= 0.05
%{perl_requires}
++++++ Class-Accessor-Grouped-0.10010.tar.gz ->
Class-Accessor-Grouped-0.10012.tar.gz ++++++
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore' old/Class-Accessor-Grouped-0.10010/Changes
new/Class-Accessor-Grouped-0.10012/Changes
--- old/Class-Accessor-Grouped-0.10010/Changes 2013-04-24 04:53:43.000000000
+0200
+++ new/Class-Accessor-Grouped-0.10012/Changes 2014-10-05 23:20:29.000000000
+0200
@@ -1,5 +1,12 @@
Revision history for Class::Accessor::Grouped.
+0.10012 2014-10-05 21:22 (UTC)
+ - Fix tests tickling deficient threads on perl 5.10.0
+
+0.10011 2014-09-26 11:24 (UTC)
+ - Soft-depend on newer (bugfixed and *simpler*) Class::XSAccessor 1.19
+ - More robust threading tests
+
0.10010 2013-04-24 02:58 (UTC)
- Fix bug with identically-named 'simple' accessors in different
classes set to access *differently named fields* getting their
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore' old/Class-Accessor-Grouped-0.10010/META.yml
new/Class-Accessor-Grouped-0.10012/META.yml
--- old/Class-Accessor-Grouped-0.10010/META.yml 2013-04-24 04:58:18.000000000
+0200
+++ new/Class-Accessor-Grouped-0.10012/META.yml 2014-10-05 23:21:41.000000000
+0200
@@ -22,7 +22,7 @@
- inc
- t
recommends:
- Class::XSAccessor: 1.15
+ Class::XSAccessor: 1.19
Sub::Name: 0.05
requires:
Carp: 0
@@ -32,4 +32,4 @@
resources:
license: http://dev.perl.org/licenses/
repository: git://git.shadowcat.co.uk/p5sagit/Class-Accessor-Grouped.git
-version: 0.10010
+version: 0.10012
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore' old/Class-Accessor-Grouped-0.10010/Makefile.PL
new/Class-Accessor-Grouped-0.10012/Makefile.PL
--- old/Class-Accessor-Grouped-0.10010/Makefile.PL 2013-03-27
01:52:02.000000000 +0100
+++ new/Class-Accessor-Grouped-0.10012/Makefile.PL 2014-09-26
12:47:10.000000000 +0200
@@ -15,7 +15,7 @@
my $recommends = {
'Sub::Name' => '0.05',
# when changing CXSA version don't forget to adjust
lib/Class/Accessor/Grouped.pm as well
- 'Class::XSAccessor' => '1.15',
+ 'Class::XSAccessor' => '1.19',
};
recommends( $_ => $recommends->{$_} )
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore'
old/Class-Accessor-Grouped-0.10010/lib/Class/Accessor/Grouped.pm
new/Class-Accessor-Grouped-0.10012/lib/Class/Accessor/Grouped.pm
--- old/Class-Accessor-Grouped-0.10010/lib/Class/Accessor/Grouped.pm
2013-04-24 04:52:13.000000000 +0200
+++ new/Class-Accessor-Grouped-0.10012/lib/Class/Accessor/Grouped.pm
2014-10-05 23:20:02.000000000 +0200
@@ -15,12 +15,12 @@
}
}
-our $VERSION = '0.10010';
+our $VERSION = '0.10012';
$VERSION = eval $VERSION if $VERSION =~ /_/; # numify for warning-free dev
releases
# when changing minimum version don't forget to adjust Makefile.PL as well
our $__minimum_xsa_version;
-BEGIN { $__minimum_xsa_version = '1.15' }
+BEGIN { $__minimum_xsa_version = '1.19' }
our $USE_XS;
# the unless defined is here so that we can override the value
@@ -68,16 +68,10 @@
constant->import( TRACK_UNDEFER_FAIL => (
$INC{'Test/Builder.pm'} || $INC{'Test/Builder2.pm'}
and
- $0 =~ m|^ x?t / .+ \.t $|x
+ $0 =~ m{ ^ (?: \. \/ )? x?t / .+ \.t $}x
) ? 1 : 0 );
- require B;
- # a perl 5.6 kludge
- unless (B->can('perlstring')) {
- require Data::Dumper;
- my $d =
Data::Dumper->new([])->Indent(0)->Purity(0)->Pad('')->Useqq(1)->Terse(1)->Freezer('')->Toaster('');
- *B::perlstring = sub { $d->Values([shift])->Dump };
- }
+ sub perlstring ($) { q{"}. quotemeta( shift ). q{"} };
}
# Yes this method is undocumented
@@ -105,7 +99,7 @@
if ($name =~ /\0/) {
Carp::croak(sprintf
"Illegal accessor name %s - nulls should never appear in stash keys",
- B::perlstring($name),
+ __CAG_ENV__::perlstring($name),
);
}
elsif (! $ENV{CAG_ILLEGAL_ACCESSOR_NAME_OK} ) {
@@ -126,7 +120,7 @@
# idiot, there is now a ton of DBIC code out there that attempts
# to create column accessors with illegal names. In the interest
# of not cluttering the logs of unsuspecting victims (unsuspecting
- # because these accessors are unusuable anyway) we provide an
+ # because these accessors are unusable anyway) we provide an
# explicit "do not warn at all" escape, until all such code is
# fixed (this will be a loooooong time >:(
$ENV{CAG_ILLEGAL_ACCESSOR_NAME_OK} ne 'DO_NOT_WARN'
@@ -703,7 +697,7 @@
cxsa_call => 'accessors',
pp_generator => sub {
# my ($group, $fieldname) = @_;
- my $quoted_fieldname = B::perlstring($_[1]);
+ my $quoted_fieldname = __CAG_ENV__::perlstring($_[1]);
sprintf <<'EOS', ($_[0], $quoted_fieldname) x 2;
@_ > 1
@@ -717,7 +711,7 @@
cxsa_call => 'getters',
pp_generator => sub {
# my ($group, $fieldname) = @_;
- my $quoted_fieldname = B::perlstring($_[1]);
+ my $quoted_fieldname = __CAG_ENV__::perlstring($_[1]);
sprintf <<'EOS', $_[0], $quoted_fieldname;
@_ > 1
@@ -737,7 +731,7 @@
cxsa_call => 'setters',
pp_generator => sub {
# my ($group, $fieldname) = @_;
- my $quoted_fieldname = B::perlstring($_[1]);
+ my $quoted_fieldname = __CAG_ENV__::perlstring($_[1]);
sprintf <<'EOS', $_[0], $quoted_fieldname;
@_ > 1
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore' old/Class-Accessor-Grouped-0.10010/t/accessors_pp.t
new/Class-Accessor-Grouped-0.10012/t/accessors_pp.t
--- old/Class-Accessor-Grouped-0.10010/t/accessors_pp.t 2013-03-27
01:52:02.000000000 +0100
+++ new/Class-Accessor-Grouped-0.10012/t/accessors_pp.t 2014-09-28
20:03:56.000000000 +0200
@@ -40,28 +40,60 @@
my $todo = sub {
note "\nTesting $tname without Sub::Name (pass @{[ $pass ++ ]})\n\n";
- my $tfn = catfile($Bin, $tname);
+ my ($tfn) = catfile($Bin, $tname) =~ /(.+)/;
- delete $INC{$_} for (
- qw/AccessorGroups.pm AccessorGroupsRO.pm AccessorGroupsSubclass.pm
AccessorGroupsParent.pm AccessorGroupsWO.pm/,
+ for (
+ qw|AccessorGroups.pm AccessorGroups/BeenThereDoneThat.pm
AccessorGroupsRO.pm AccessorGroupsSubclass.pm AccessorGroupsParent.pm
AccessorGroupsWO.pm|,
File::Spec::Unix->catfile ($tfn),
- );
+ ) {
+ delete $INC{$_};
+ no strict 'refs';
+ if (my ($mod) = $_ =~ /(.+)\.pm$/ ) {
+ %{"${mod}::"} = ();
+ }
+ }
local $SIG{__WARN__} = sub { warn @_ unless $_[0] =~ /subroutine .+
redefined/i };
do($tfn);
+
+ 666;
};
if ($has_threads) {
- threads->create(sub {
- threads->create(sub {
- $todo->() for (1,2) }
- )->join;
- $todo->() for (1,2);
- })->join for (1,2)
+ for (1,2) {
+ is (
+ threads->create(sub {
+
+ # nested threading of this sort badly blows up on 5.10.0 (fixed with
5.10.1)
+ unless ($] > 5.009 and $] < 5.010001) {
+ is (
+
+ threads->create(sub {
+ $todo->();
+ })->join,
+
+ 666,
+
+ 'Innner thread joined ok',
+ );
+
+ is ($todo->(), 666, "Intermediate result ok");
+ }
+
+ return 777;
+ })->join,
+
+ 777,
+
+ 'Outer thread joined ok',
+ );
+
+ is ($todo->(), 666, "Unthreaded run ok") for (1,2);
+ }
}
else {
- $todo->() for (1, 2);
+ is ($todo->(), 666, "Unthreaded run ok") for (1,2);
}
}
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore' old/Class-Accessor-Grouped-0.10010/t/accessors_ro.t
new/Class-Accessor-Grouped-0.10012/t/accessors_ro.t
--- old/Class-Accessor-Grouped-0.10010/t/accessors_ro.t 2013-03-27
01:52:02.000000000 +0100
+++ new/Class-Accessor-Grouped-0.10012/t/accessors_ro.t 2014-09-26
12:46:53.000000000 +0200
@@ -3,7 +3,6 @@
use strict;
use warnings;
no warnings 'once';
-use Config;
use lib 't/lib';
# we test the pure-perl versions only, but allow overrides
@@ -84,15 +83,12 @@
: qr/$name(:?_accessor)?\Q' cannot alter its value (read-only attribute of
class AccessorGroupsRO)/
;
- {
- local $TODO = "Class::XSAccessor emits broken error messages on 5.10 or
-DDEBUGGING 5.8"
- if (
- $test_accessors->{$name}{is_xs}
- and
- $] < '5.011'
- and
- ( $] > '5.009' or $Config{config_args} =~ /DEBUGGING/ )
- );
+ SKIP: {
+ skip "Class::XSAccessor emits broken error messages on 5.10 and earlier",
1 if (
+ $test_accessors->{$name}{is_xs}
+ and
+ $] < '5.011'
+ );
# die on set via name/alias
throws_ok {
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore' old/Class-Accessor-Grouped-0.10010/t/accessors_wo.t
new/Class-Accessor-Grouped-0.10012/t/accessors_wo.t
--- old/Class-Accessor-Grouped-0.10010/t/accessors_wo.t 2013-03-27
01:52:02.000000000 +0100
+++ new/Class-Accessor-Grouped-0.10012/t/accessors_wo.t 2014-09-26
12:46:53.000000000 +0200
@@ -3,7 +3,6 @@
use strict;
use warnings;
no warnings 'once';
-use Config;
use lib 't/lib';
# we test the pure-perl versions only, but allow overrides
@@ -82,15 +81,12 @@
;
# die on get via name/alias
- {
- local $TODO = "Class::XSAccessor emits broken error messages on 5.10 or
-DDEBUGGING 5.8"
- if (
- $test_accessors->{$name}{is_xs}
- and
- $] < '5.011'
- and
- ( $] > '5.009' or $Config{config_args} =~ /DEBUGGING/ )
- );
+ SKIP: {
+ skip "Class::XSAccessor emits broken error messages on 5.10 and earlier",
1 if (
+ $test_accessors->{$name}{is_xs}
+ and
+ $] < '5.011'
+ );
throws_ok {
$obj->$name;
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore' old/Class-Accessor-Grouped-0.10010/t/accessors_xs.t
new/Class-Accessor-Grouped-0.10012/t/accessors_xs.t
--- old/Class-Accessor-Grouped-0.10010/t/accessors_xs.t 2013-04-10
05:47:55.000000000 +0200
+++ new/Class-Accessor-Grouped-0.10012/t/accessors_xs.t 2014-09-28
20:43:02.000000000 +0200
@@ -1,6 +1,6 @@
my $has_threads;
BEGIN { eval '
- use 5.008001;
+ use 5.008005; # older perls segfault on threading under CXSA
use threads;
use threads::shared;
$has_threads = 1;
@@ -42,7 +42,7 @@
my $todo = sub {
note "\nTesting $tname with USE_XS (pass @{[ $pass++ ]})\n\n";
- my $tfn = catfile($Bin, $tname);
+ my ($tfn) = catfile($Bin, $tname) =~ /(.+)/;
for (
qw|AccessorGroups.pm AccessorGroups/BeenThereDoneThat.pm
AccessorGroupsRO.pm AccessorGroupsSubclass.pm AccessorGroupsParent.pm
AccessorGroupsWO.pm|,
@@ -58,18 +58,44 @@
local $SIG{__WARN__} = sub { warn @_ unless $_[0] =~ /subroutine .+
redefined/i };
do($tfn);
+
+ 666;
};
if ($has_threads) {
- threads->create(sub {
- threads->create(sub {
- $todo->() for (1,2) }
- )->join;
- $todo->() for (1,2);
- })->join for (1,2)
+ for (1,2) {
+ is (
+ threads->create(sub {
+
+ # nested threading of this sort badly blows up on 5.10.0 (fixed with
5.10.1)
+ unless ($] > 5.009 and $] < 5.010001) {
+ is (
+
+ threads->create(sub {
+ $todo->();
+ })->join,
+
+ 666,
+
+ 'Innner thread joined ok',
+ );
+
+ is ($todo->(), 666, "Intermediate result ok");
+ }
+
+ return 777;
+ })->join,
+
+ 777,
+
+ 'Outer thread joined ok',
+ );
+
+ is ($todo->(), 666, "Unthreaded run ok") for (1,2);
+ }
}
else {
- $todo->() for (1, 2);
+ is ($todo->(), 666, "Unthreaded run ok") for (1,2);
}
}
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore'
old/Class-Accessor-Grouped-0.10010/t/accessors_xs_cachedwarn.t
new/Class-Accessor-Grouped-0.10012/t/accessors_xs_cachedwarn.t
--- old/Class-Accessor-Grouped-0.10010/t/accessors_xs_cachedwarn.t
2013-03-27 01:52:02.000000000 +0100
+++ new/Class-Accessor-Grouped-0.10012/t/accessors_xs_cachedwarn.t
2014-09-27 12:16:42.000000000 +0200
@@ -1,6 +1,6 @@
my $has_threads;
BEGIN { eval '
- use 5.008004; # older perls get confused by $SIG fiddling
+ use 5.008005; # older perls get confused by $SIG fiddling under CXSA
use threads;
use threads::shared;
$has_threads = 1;
@@ -45,9 +45,15 @@
is ($obj->singlefield, 2, 'Normal get');
is ($obj2->singlefield, undef, 'Normal get on unrelated object');
+
+ 42;
};
- $has_threads ? threads->create( $todo )->join : $todo->();
+ is (
+ ($has_threads ? threads->create( $todo )->join : $todo->()),
+ 42,
+ "Correct result after do-er",
+ )
}
is (@w, 3, '3 warnings total');
--
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
