Hello community,
here is the log from the commit of package gnome-online-miners for
openSUSE:Factory checked in at 2014-12-17 19:19:36
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Comparing /work/SRC/openSUSE:Factory/gnome-online-miners (Old)
and /work/SRC/openSUSE:Factory/.gnome-online-miners.new (New)
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Package is "gnome-online-miners"
Changes:
--------
--- /work/SRC/openSUSE:Factory/gnome-online-miners/gnome-online-miners.changes
2014-09-30 19:39:44.000000000 +0200
+++
/work/SRC/openSUSE:Factory/.gnome-online-miners.new/gnome-online-miners.changes
2014-12-17 19:18:32.000000000 +0100
@@ -1,0 +2,8 @@
+Mon Dec 15 17:57:59 UTC 2014 - [email protected]
+
+- Update to version 3.14.1:
+ + Wrong author shown for Google albums (bgo#740423).
+ + facebook: Don't use the time as a fallback for the title
+ (bgo#740869).
+
+-------------------------------------------------------------------
Old:
----
gnome-online-miners-3.14.0.tar.xz
New:
----
gnome-online-miners-3.14.1.tar.xz
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Other differences:
------------------
++++++ gnome-online-miners.spec ++++++
--- /var/tmp/diff_new_pack.xzzIdn/_old 2014-12-17 19:18:33.000000000 +0100
+++ /var/tmp/diff_new_pack.xzzIdn/_new 2014-12-17 19:18:33.000000000 +0100
@@ -18,7 +18,7 @@
Name: gnome-online-miners
-Version: 3.14.0
+Version: 3.14.1
Release: 0
Summary: Crawls through your online content
License: GPL-2.0+
++++++ gnome-online-miners-3.14.0.tar.xz -> gnome-online-miners-3.14.1.tar.xz
++++++
++++ 1996 lines of diff (skipped)
++++ retrying with extended exclude list
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore' --exclude Makefile.in --exclude configure --exclude
config.guess --exclude '*.pot' --exclude mkinstalldirs --exclude aclocal.m4
--exclude config.sub --exclude depcomp --exclude install-sh --exclude ltmain.sh
old/gnome-online-miners-3.14.0/INSTALL new/gnome-online-miners-3.14.1/INSTALL
--- old/gnome-online-miners-3.14.0/INSTALL 2014-09-24 10:08:10.000000000
+0200
+++ new/gnome-online-miners-3.14.1/INSTALL 2014-12-15 18:48:58.000000000
+0100
@@ -12,8 +12,8 @@
Basic Installation
==================
- Briefly, the shell commands `./configure; make; make install' should
-configure, build, and install this package. The following
+ Briefly, the shell command `./configure && make && make install'
+should configure, build, and install this package. The following
more-detailed instructions are generic; see the `README' file for
instructions specific to this package. Some packages provide this
`INSTALL' file but do not implement all of the features documented
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore' --exclude Makefile.in --exclude configure --exclude
config.guess --exclude '*.pot' --exclude mkinstalldirs --exclude aclocal.m4
--exclude config.sub --exclude depcomp --exclude install-sh --exclude ltmain.sh
old/gnome-online-miners-3.14.0/NEWS new/gnome-online-miners-3.14.1/NEWS
--- old/gnome-online-miners-3.14.0/NEWS 2014-09-24 10:06:26.000000000 +0200
+++ new/gnome-online-miners-3.14.1/NEWS 2014-12-15 18:48:13.000000000 +0100
@@ -1,3 +1,11 @@
+Overview of changes in 3.14.1
+=============================
+
+* Bugs fixed:
+ 740423 Wrong author shown for Google albums
+ 740869 facebook: Don't use the time as a fallback for the title
+
+
Overview of changes in 3.14.0
=============================
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore' --exclude Makefile.in --exclude configure --exclude
config.guess --exclude '*.pot' --exclude mkinstalldirs --exclude aclocal.m4
--exclude config.sub --exclude depcomp --exclude install-sh --exclude ltmain.sh
old/gnome-online-miners-3.14.0/config/compile
new/gnome-online-miners-3.14.1/config/compile
--- old/gnome-online-miners-3.14.0/config/compile 1970-01-01
01:00:00.000000000 +0100
+++ new/gnome-online-miners-3.14.1/config/compile 2014-12-15
18:48:58.000000000 +0100
@@ -0,0 +1,347 @@
+#! /bin/sh
+# Wrapper for compilers which do not understand '-c -o'.
+
+scriptversion=2012-10-14.11; # UTC
+
+# Copyright (C) 1999-2013 Free Software Foundation, Inc.
+# Written by Tom Tromey <[email protected]>.
+#
+# This program is free software; you can redistribute it and/or modify
+# it under the terms of the GNU General Public License as published by
+# the Free Software Foundation; either version 2, or (at your option)
+# any later version.
+#
+# This program is distributed in the hope that it will be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+# GNU General Public License for more details.
+#
+# You should have received a copy of the GNU General Public License
+# along with this program. If not, see <http://www.gnu.org/licenses/>.
+
+# As a special exception to the GNU General Public License, if you
+# distribute this file as part of a program that contains a
+# configuration script generated by Autoconf, you may include it under
+# the same distribution terms that you use for the rest of that program.
+
+# This file is maintained in Automake, please report
+# bugs to <[email protected]> or send patches to
+# <[email protected]>.
+
+nl='
+'
+
+# We need space, tab and new line, in precisely that order. Quoting is
+# there to prevent tools from complaining about whitespace usage.
+IFS=" "" $nl"
+
+file_conv=
+
+# func_file_conv build_file lazy
+# Convert a $build file to $host form and store it in $file
+# Currently only supports Windows hosts. If the determined conversion
+# type is listed in (the comma separated) LAZY, no conversion will
+# take place.
+func_file_conv ()
+{
+ file=$1
+ case $file in
+ / | /[!/]*) # absolute file, and not a UNC file
+ if test -z "$file_conv"; then
+ # lazily determine how to convert abs files
+ case `uname -s` in
+ MINGW*)
+ file_conv=mingw
+ ;;
+ CYGWIN*)
+ file_conv=cygwin
+ ;;
+ *)
+ file_conv=wine
+ ;;
+ esac
+ fi
+ case $file_conv/,$2, in
+ *,$file_conv,*)
+ ;;
+ mingw/*)
+ file=`cmd //C echo "$file " | sed -e 's/"\(.*\) " *$/\1/'`
+ ;;
+ cygwin/*)
+ file=`cygpath -m "$file" || echo "$file"`
+ ;;
+ wine/*)
+ file=`winepath -w "$file" || echo "$file"`
+ ;;
+ esac
+ ;;
+ esac
+}
+
+# func_cl_dashL linkdir
+# Make cl look for libraries in LINKDIR
+func_cl_dashL ()
+{
+ func_file_conv "$1"
+ if test -z "$lib_path"; then
+ lib_path=$file
+ else
+ lib_path="$lib_path;$file"
+ fi
+ linker_opts="$linker_opts -LIBPATH:$file"
+}
+
+# func_cl_dashl library
+# Do a library search-path lookup for cl
+func_cl_dashl ()
+{
+ lib=$1
+ found=no
+ save_IFS=$IFS
+ IFS=';'
+ for dir in $lib_path $LIB
+ do
+ IFS=$save_IFS
+ if $shared && test -f "$dir/$lib.dll.lib"; then
+ found=yes
+ lib=$dir/$lib.dll.lib
+ break
+ fi
+ if test -f "$dir/$lib.lib"; then
+ found=yes
+ lib=$dir/$lib.lib
+ break
+ fi
+ if test -f "$dir/lib$lib.a"; then
+ found=yes
+ lib=$dir/lib$lib.a
+ break
+ fi
+ done
+ IFS=$save_IFS
+
+ if test "$found" != yes; then
+ lib=$lib.lib
+ fi
+}
+
+# func_cl_wrapper cl arg...
+# Adjust compile command to suit cl
+func_cl_wrapper ()
+{
+ # Assume a capable shell
+ lib_path=
+ shared=:
+ linker_opts=
+ for arg
+ do
+ if test -n "$eat"; then
+ eat=
+ else
+ case $1 in
+ -o)
+ # configure might choose to run compile as 'compile cc -o foo foo.c'.
+ eat=1
+ case $2 in
+ *.o | *.[oO][bB][jJ])
+ func_file_conv "$2"
+ set x "$@" -Fo"$file"
+ shift
+ ;;
+ *)
+ func_file_conv "$2"
+ set x "$@" -Fe"$file"
+ shift
+ ;;
+ esac
+ ;;
+ -I)
+ eat=1
+ func_file_conv "$2" mingw
+ set x "$@" -I"$file"
+ shift
+ ;;
+ -I*)
+ func_file_conv "${1#-I}" mingw
+ set x "$@" -I"$file"
+ shift
+ ;;
+ -l)
+ eat=1
+ func_cl_dashl "$2"
+ set x "$@" "$lib"
+ shift
+ ;;
+ -l*)
+ func_cl_dashl "${1#-l}"
+ set x "$@" "$lib"
+ shift
+ ;;
+ -L)
+ eat=1
+ func_cl_dashL "$2"
+ ;;
+ -L*)
+ func_cl_dashL "${1#-L}"
+ ;;
+ -static)
+ shared=false
+ ;;
+ -Wl,*)
+ arg=${1#-Wl,}
+ save_ifs="$IFS"; IFS=','
+ for flag in $arg; do
+ IFS="$save_ifs"
+ linker_opts="$linker_opts $flag"
+ done
+ IFS="$save_ifs"
+ ;;
+ -Xlinker)
+ eat=1
+ linker_opts="$linker_opts $2"
+ ;;
+ -*)
+ set x "$@" "$1"
+ shift
+ ;;
+ *.cc | *.CC | *.cxx | *.CXX | *.[cC]++)
+ func_file_conv "$1"
+ set x "$@" -Tp"$file"
+ shift
+ ;;
+ *.c | *.cpp | *.CPP | *.lib | *.LIB | *.Lib | *.OBJ | *.obj | *.[oO])
+ func_file_conv "$1" mingw
+ set x "$@" "$file"
+ shift
+ ;;
+ *)
+ set x "$@" "$1"
+ shift
+ ;;
+ esac
+ fi
+ shift
+ done
+ if test -n "$linker_opts"; then
+ linker_opts="-link$linker_opts"
+ fi
+ exec "$@" $linker_opts
+ exit 1
+}
+
+eat=
+
+case $1 in
+ '')
+ echo "$0: No command. Try '$0 --help' for more information." 1>&2
+ exit 1;
+ ;;
+ -h | --h*)
+ cat <<\EOF
+Usage: compile [--help] [--version] PROGRAM [ARGS]
+
+Wrapper for compilers which do not understand '-c -o'.
+Remove '-o dest.o' from ARGS, run PROGRAM with the remaining
+arguments, and rename the output as expected.
+
+If you are trying to build a whole package this is not the
+right script to run: please start by reading the file 'INSTALL'.
+
+Report bugs to <[email protected]>.
+EOF
+ exit $?
+ ;;
+ -v | --v*)
+ echo "compile $scriptversion"
+ exit $?
+ ;;
+ cl | *[/\\]cl | cl.exe | *[/\\]cl.exe )
+ func_cl_wrapper "$@" # Doesn't return...
+ ;;
+esac
+
+ofile=
+cfile=
+
+for arg
+do
+ if test -n "$eat"; then
+ eat=
+ else
+ case $1 in
+ -o)
+ # configure might choose to run compile as 'compile cc -o foo foo.c'.
+ # So we strip '-o arg' only if arg is an object.
+ eat=1
+ case $2 in
+ *.o | *.obj)
+ ofile=$2
+ ;;
+ *)
+ set x "$@" -o "$2"
+ shift
+ ;;
+ esac
+ ;;
+ *.c)
+ cfile=$1
+ set x "$@" "$1"
+ shift
+ ;;
+ *)
+ set x "$@" "$1"
+ shift
+ ;;
+ esac
+ fi
+ shift
+done
+
+if test -z "$ofile" || test -z "$cfile"; then
+ # If no '-o' option was seen then we might have been invoked from a
+ # pattern rule where we don't need one. That is ok -- this is a
+ # normal compilation that the losing compiler can handle. If no
+ # '.c' file was seen then we are probably linking. That is also
+ # ok.
+ exec "$@"
+fi
+
+# Name of file we expect compiler to create.
+cofile=`echo "$cfile" | sed 's|^.*[\\/]||; s|^[a-zA-Z]:||; s/\.c$/.o/'`
+
+# Create the lock directory.
+# Note: use '[/\\:.-]' here to ensure that we don't use the same name
+# that we are using for the .o file. Also, base the name on the expected
+# object file name, since that is what matters with a parallel build.
+lockdir=`echo "$cofile" | sed -e 's|[/\\:.-]|_|g'`.d
+while true; do
+ if mkdir "$lockdir" >/dev/null 2>&1; then
+ break
+ fi
+ sleep 1
+done
+# FIXME: race condition here if user kills between mkdir and trap.
+trap "rmdir '$lockdir'; exit 1" 1 2 15
+
+# Run the compile.
+"$@"
+ret=$?
+
+if test -f "$cofile"; then
+ test "$cofile" = "$ofile" || mv "$cofile" "$ofile"
+elif test -f "${cofile}bj"; then
+ test "${cofile}bj" = "$ofile" || mv "${cofile}bj" "$ofile"
+fi
+
+rmdir "$lockdir"
+exit $ret
+
+# Local Variables:
+# mode: shell-script
+# sh-indentation: 2
+# eval: (add-hook 'write-file-hooks 'time-stamp)
+# time-stamp-start: "scriptversion="
+# time-stamp-format: "%:y-%02m-%02d.%02H"
+# time-stamp-time-zone: "UTC"
+# time-stamp-end: "; # UTC"
+# End:
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore' --exclude Makefile.in --exclude configure --exclude
config.guess --exclude '*.pot' --exclude mkinstalldirs --exclude aclocal.m4
--exclude config.sub --exclude depcomp --exclude install-sh --exclude ltmain.sh
old/gnome-online-miners-3.14.0/config/missing
new/gnome-online-miners-3.14.1/config/missing
--- old/gnome-online-miners-3.14.0/config/missing 2014-09-24
10:08:10.000000000 +0200
+++ new/gnome-online-miners-3.14.1/config/missing 2014-12-15
18:48:58.000000000 +0100
@@ -1,7 +1,7 @@
#! /bin/sh
# Common wrapper for a few potentially missing GNU programs.
-scriptversion=2012-06-26.16; # UTC
+scriptversion=2013-10-28.13; # UTC
# Copyright (C) 1996-2013 Free Software Foundation, Inc.
# Originally written by Fran,cois Pinard <[email protected]>, 1996.
@@ -160,7 +160,7 @@
;;
autom4te*)
echo "You might have modified some maintainer files that require"
- echo "the 'automa4te' program to be rebuilt."
+ echo "the 'autom4te' program to be rebuilt."
program_details 'autom4te'
;;
bison*|yacc*)
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore' --exclude Makefile.in --exclude configure --exclude
config.guess --exclude '*.pot' --exclude mkinstalldirs --exclude aclocal.m4
--exclude config.sub --exclude depcomp --exclude install-sh --exclude ltmain.sh
old/gnome-online-miners-3.14.0/config.h.in
new/gnome-online-miners-3.14.1/config.h.in
--- old/gnome-online-miners-3.14.0/config.h.in 2014-09-24 10:08:09.000000000
+0200
+++ new/gnome-online-miners-3.14.1/config.h.in 2014-12-15 18:48:58.000000000
+0100
@@ -1,6 +1,6 @@
/* config.h.in. Generated from configure.ac by autoheader. */
-/* Enable additional debugging at the expense of performance and size */
+/* Define if debugging is enabled */
#undef GNOME_ENABLE_DEBUG
/* We are aware that GOA's API can change */
@@ -40,6 +40,9 @@
*/
#undef LT_OBJDIR
+/* Define if debugging is disabled */
+#undef NDEBUG
+
/* Define to 1 if your C compiler doesn't accept -c and -o together. */
#undef NO_MINUS_C_MINUS_O
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore' --exclude Makefile.in --exclude configure --exclude
config.guess --exclude '*.pot' --exclude mkinstalldirs --exclude aclocal.m4
--exclude config.sub --exclude depcomp --exclude install-sh --exclude ltmain.sh
old/gnome-online-miners-3.14.0/configure.ac
new/gnome-online-miners-3.14.1/configure.ac
--- old/gnome-online-miners-3.14.0/configure.ac 2014-09-24 10:06:38.000000000
+0200
+++ new/gnome-online-miners-3.14.1/configure.ac 2014-12-15 18:48:23.000000000
+0100
@@ -1,5 +1,5 @@
AC_INIT([GNOME Online Miners],
- [3.14.0],
+ [3.14.1],
[https://bugzilla.gnome.org/enter_bug.cgi?product=gnome-online-miners],
[gnome-online-miners],
[https://wiki.gnome.org/Projects/GnomeOnlineMiners])
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore' --exclude Makefile.in --exclude configure --exclude
config.guess --exclude '*.pot' --exclude mkinstalldirs --exclude aclocal.m4
--exclude config.sub --exclude depcomp --exclude install-sh --exclude ltmain.sh
old/gnome-online-miners-3.14.0/src/gom-facebook-miner.c
new/gnome-online-miners-3.14.1/src/gom-facebook-miner.c
--- old/gnome-online-miners-3.14.0/src/gom-facebook-miner.c 2014-06-25
13:04:30.000000000 +0200
+++ new/gnome-online-miners-3.14.1/src/gom-facebook-miner.c 2014-11-28
17:19:16.000000000 +0100
@@ -56,8 +56,6 @@
photo_link = gfbgraph_node_get_link (GFBGRAPH_NODE (photo));
photo_created_time = gfbgraph_node_get_created_time (GFBGRAPH_NODE (photo));
photo_name = gfbgraph_photo_get_name (photo);
- if (photo_name == NULL)
- photo_name = photo_created_time;
identifier = g_strdup_printf ("facebook:%s", photo_id);
@@ -202,7 +200,6 @@
album_created_time = gfbgraph_node_get_created_time (GFBGRAPH_NODE (album));
album_name = gfbgraph_album_get_name (album);
album_description = gfbgraph_album_get_description (album);
- g_message ("%s", album_created_time);
identifier = g_strdup_printf ("photos:collection:facebook:%s", album_id);
@@ -416,7 +413,7 @@
miner_class->goa_provider_type = "facebook";
miner_class->miner_identifier = MINER_IDENTIFIER;
- miner_class->version = 1;
+ miner_class->version = 2;
miner_class->create_services = create_services;
miner_class->query = query_facebook;
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore' --exclude Makefile.in --exclude configure --exclude
config.guess --exclude '*.pot' --exclude mkinstalldirs --exclude aclocal.m4
--exclude config.sub --exclude depcomp --exclude install-sh --exclude ltmain.sh
old/gnome-online-miners-3.14.0/src/gom-gdata-miner.c
new/gnome-online-miners-3.14.1/src/gom-gdata-miner.c
--- old/gnome-online-miners-3.14.0/src/gom-gdata-miner.c 2014-08-05
16:44:28.000000000 +0200
+++ new/gnome-online-miners-3.14.1/src/gom-gdata-miner.c 2014-12-15
18:37:38.000000000 +0100
@@ -1,6 +1,6 @@
/*
* GNOME Online Miners - crawls through your online content
- * Copyright (c) 2011, 2012, 2013 Red Hat, Inc.
+ * Copyright (c) 2011, 2012, 2013, 2014 Red Hat, Inc.
*
* This program is free software; you can redistribute it and/or
* modify it under the terms of the GNU General Public License
@@ -34,6 +34,21 @@
G_DEFINE_TYPE (GomGDataMiner, gom_gdata_miner, GOM_TYPE_MINER)
+static gchar *
+generate_fake_email_from_fullname (const gchar *fullname)
+{
+ GChecksum *checksum;
+ const gchar *digest;
+ gchar *retval;
+
+ checksum = g_checksum_new (G_CHECKSUM_MD5);
+ g_checksum_update (checksum, fullname, -1);
+ digest = g_checksum_get_string (checksum);
+ retval = g_strdup (digest);
+ g_checksum_free (checksum);
+ return retval;
+}
+
static gboolean
account_miner_job_process_entry (GomAccountMinerJob *job,
GDataDocumentsService *service,
@@ -331,6 +346,7 @@
const gchar *summary;
const gchar *mime;
+ gchar *email;
gchar *exposure;
gchar *focal_length;
gchar *fstop;
@@ -433,10 +449,12 @@
goto out;
credit = gdata_picasaweb_file_get_credit (photo);
+ email = generate_fake_email_from_fullname (credit);
contact_resource = gom_tracker_utils_ensure_contact_resource
(job->connection,
job->cancellable, error,
- job->datasource_urn, credit);
+ email, credit);
+ g_free (email);
if (*error != NULL)
goto out;
@@ -602,16 +620,18 @@
GDataFeed *feed = NULL;
GDataPicasaWebQuery *query;
gchar *resource = NULL;
- gchar *date, *identifier;
+ gchar *contact_resource, *date, *identifier;
+ gchar *email;
gboolean resource_exists, mtime_changed;
gint64 new_mtime;
gint64 timestamp;
const gchar *album_id;
+ const gchar *nickname;
const gchar *title;
const gchar *summary;
- GList *l, *authors, *photos = NULL;
+ GList *l, *photos = NULL;
GDataLink *alternate;
const gchar *alternate_uri;
@@ -690,31 +710,26 @@
if (*error != NULL)
goto out;
- authors = gdata_entry_get_authors (GDATA_ENTRY (album));
- for (l = authors; l != NULL; l = l->next)
- {
- GDataAuthor *author = GDATA_AUTHOR (l->data);
- gchar *contact_resource;
-
- contact_resource = gom_tracker_utils_ensure_contact_resource
(job->connection,
-
job->cancellable, error,
-
gdata_author_get_email_address (author),
-
gdata_author_get_name (author));
-
- if (*error != NULL)
- goto out;
+ nickname = gdata_picasaweb_album_get_nickname (album);
+ email = generate_fake_email_from_fullname (nickname);
+ contact_resource = gom_tracker_utils_ensure_contact_resource
+ (job->connection,
+ job->cancellable, error,
+ email, nickname);
+ g_free (email);
- gom_tracker_sparql_connection_insert_or_replace_triple
- (job->connection,
- job->cancellable, error,
- job->datasource_urn, resource,
- "nco:creator", contact_resource);
+ if (*error != NULL)
+ goto out;
- if (*error != NULL)
- goto out;
+ gom_tracker_sparql_connection_insert_or_replace_triple
+ (job->connection,
+ job->cancellable, error,
+ job->datasource_urn, resource,
+ "nco:creator", contact_resource);
+ g_free (contact_resource);
- g_free (contact_resource);
- }
+ if (*error != NULL)
+ goto out;
timestamp = gdata_picasaweb_album_get_timestamp (album);
date = gom_iso8601_from_timestamp (timestamp / 1000);
@@ -895,7 +910,7 @@
miner_class->goa_provider_type = "google";
miner_class->miner_identifier = MINER_IDENTIFIER;
- miner_class->version = 3;
+ miner_class->version = 4;
miner_class->create_services = create_services;
miner_class->query = query_gdata;
--
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]