Hello community, here is the log from the commit of package perl-strictures for openSUSE:Factory checked in at 2015-04-15 16:26:52 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Comparing /work/SRC/openSUSE:Factory/perl-strictures (Old) and /work/SRC/openSUSE:Factory/.perl-strictures.new (New) ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Package is "perl-strictures" Changes: -------- --- /work/SRC/openSUSE:Factory/perl-strictures/perl-strictures.changes 2015-02-10 20:22:52.000000000 +0100 +++ /work/SRC/openSUSE:Factory/.perl-strictures.new/perl-strictures.changes 2015-04-15 16:26:53.000000000 +0200 @@ -1,0 +2,14 @@ +Tue Apr 14 21:13:03 UTC 2015 - [email protected] + +- updated to 2.000000 + see /usr/share/doc/packages/perl-strictures/Changes + + 2.000000 - 2015-02-26 + * Incompatible Changes + - strictures 2 fatalizes only a subset of warnings. Some warning + categories are not safe to catch, or just inappropriate to have fatal. + Existing code looking like 'use strictures 1;' will continue to get the + old behavior of fatalizing all errors. The new behavior will take effect + when no version or version 2 is specified. + +------------------------------------------------------------------- Old: ---- strictures-1.005006.tar.gz New: ---- strictures-2.000000.tar.gz ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Other differences: ------------------ ++++++ perl-strictures.spec ++++++ --- /var/tmp/diff_new_pack.9DPEKk/_old 2015-04-15 16:26:53.000000000 +0200 +++ /var/tmp/diff_new_pack.9DPEKk/_new 2015-04-15 16:26:53.000000000 +0200 @@ -17,10 +17,10 @@ Name: perl-strictures -Version: 1.005006 +Version: 2.000000 Release: 0 %define cpan_name strictures -Summary: Turn on strict and make all warnings fatal +Summary: turn on strict and make all warnings fatal License: Artistic-1.0 or GPL-1.0+ Group: Development/Libraries/Perl Url: http://search.cpan.org/dist/strictures/ @@ -70,15 +70,6 @@ only to the mechanism of this code will result in a sub-version increase (e.g. 1.000000 to 1.000001 (1.0.1)). -If the behaviour of 'use strictures' in normal mode changes in any way, -that will constitute a major version increase -- and the code already -checks when its version is tested to ensure that - - use strictures 1; - -will continue to only introduce the current set of strictures even if 2.0 -is installed. - %prep %setup -q -n %{cpan_name}-%{version} ++++++ strictures-1.005006.tar.gz -> strictures-2.000000.tar.gz ++++++ diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/strictures-1.005006/Changes new/strictures-2.000000/Changes --- old/strictures-1.005006/Changes 2015-01-30 14:01:25.000000000 +0100 +++ new/strictures-2.000000/Changes 2015-02-26 10:32:12.000000000 +0100 @@ -1,5 +1,13 @@ Release history for strictures +2.000000 - 2015-02-26 + * Incompatible Changes + - strictures 2 fatalizes only a subset of warnings. Some warning + categories are not safe to catch, or just inappropriate to have fatal. + Existing code looking like 'use strictures 1;' will continue to get the + old behavior of fatalizing all errors. The new behavior will take effect + when no version or version 2 is specified. + 1.005006 - 2015-01-30 - fix extra checks triggering on paths starting with t, xt, lib, or blib, rather than only triggering on those directories. diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/strictures-1.005006/MANIFEST new/strictures-2.000000/MANIFEST --- old/strictures-1.005006/MANIFEST 2015-01-30 14:01:44.000000000 +0100 +++ new/strictures-2.000000/MANIFEST 2015-02-26 10:32:27.000000000 +0100 @@ -1,11 +1,13 @@ Changes lib/strictures.pm +lib/strictures/extra.pm maint/Makefile.PL.include Makefile.PL MANIFEST This list of files t/crash.t t/extras.t t/strictures.t +xt/all-categories.t xt/pod.t META.yml Module YAML meta-data (added by MakeMaker) META.json Module JSON meta-data (added by MakeMaker) diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/strictures-1.005006/META.json new/strictures-2.000000/META.json --- old/strictures-1.005006/META.json 2015-01-30 14:01:44.000000000 +0100 +++ new/strictures-2.000000/META.json 2015-02-26 10:32:27.000000000 +0100 @@ -4,7 +4,7 @@ "mst - Matt S. Trout (cpan:MSTROUT) <[email protected]>" ], "dynamic_config" : 1, - "generated_by" : "ExtUtils::MakeMaker version 7.04, CPAN::Meta::Converter version 2.142690", + "generated_by" : "ExtUtils::MakeMaker version 7.04, CPAN::Meta::Converter version 2.143240", "license" : [ "perl_5" ], @@ -67,5 +67,5 @@ "web" : "http://git.shadowcat.co.uk/gitweb/gitweb.cgi?p=p5sagit/strictures.git"; } }, - "version" : "1.005006" + "version" : "2.000000" } diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/strictures-1.005006/META.yml new/strictures-2.000000/META.yml --- old/strictures-1.005006/META.yml 2015-01-30 14:01:44.000000000 +0100 +++ new/strictures-2.000000/META.yml 2015-02-26 10:32:27.000000000 +0100 @@ -6,7 +6,7 @@ Test::More: '0' configure_requires: {} dynamic_config: 1 -generated_by: 'ExtUtils::MakeMaker version 7.04, CPAN::Meta::Converter version 2.142690' +generated_by: 'ExtUtils::MakeMaker version 7.04, CPAN::Meta::Converter version 2.143240' license: perl meta-spec: url: http://module-build.sourceforge.net/META-spec-v1.4.html @@ -26,4 +26,4 @@ bugtracker: https://rt.cpan.org/Public/Dist/Display.html?Name=strictures license: http://dev.perl.org/licenses/ repository: git://git.shadowcat.co.uk/p5sagit/strictures.git -version: '1.005006' +version: '2.000000' diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/strictures-1.005006/README new/strictures-2.000000/README --- old/strictures-1.005006/README 2015-01-30 14:01:44.000000000 +0100 +++ new/strictures-2.000000/README 2015-02-26 10:32:27.000000000 +0100 @@ -2,12 +2,23 @@ strictures - turn on strict and make all warnings fatal SYNOPSIS - use strictures 1; + use strictures 2; is equivalent to use strict; use warnings FATAL => 'all'; + use warnings NONFATAL => qw( + exec + recursion + internal + malloc + newline + experimental + deprecated + portable + ); + no warnings 'once'; except when called from a file which matches: @@ -18,14 +29,9 @@ side) -- or when ".git", ".svn", or ".hg" is present two directories up along with "dist.ini" (which would indicate we are in a "dzil test" operation, via Dist::Zilla) -- or when the "PERL_STRICTURES_EXTRA" - environment variable is set, in which case + environment variable is set, in which case it also does the equivalent + of - use strictures 1; - - is equivalent to - - use strict; - use warnings FATAL => 'all'; no indirect 'fatal'; no multidimensional; no bareword::filehandles; @@ -68,18 +74,94 @@ Any fixes only to the mechanism of this code will result in a sub-version increase (e.g. 1.000000 to 1.000001 (1.0.1)). - If the behaviour of "use strictures" in normal mode changes in any way, - that will constitute a major version increase -- and the code already - checks when its version is tested to ensure that +CATEGORY SELECTIONS + strictures does not enable fatal warnings for all categories. + + exec + Includes a warning that can cause your program to continue running + unintentionally after an internal fork. Not safe to fatalize. + + recursion + Infinite recursion will end up overflowing the stack eventually + anyway. + + internal + Triggers deep within perl, in places that are not safe to trap. + + malloc + Triggers deep within perl, in places that are not safe to trap. + + newline + Includes a warning for using stat on a valid but suspect filename, + ending in a newline. + + experimental + Experimental features are used intentionally. + + deprecated + Deprecations will inherently be added to in the future in unexpected + ways, so making them fatal won't be reliable. + + portable + Doesn't indicate an actual problem with the program, only that it + may not behave properly if run on a different machine. + + once + Can't be fatalized. Also triggers very inconsistently, so we just + disable it. + +VERSIONS + Depending on the version of strictures requested, different warnings + will be enabled. If no specific version is requested, the current + version's behavior will be used. Versions can be requested using perl's + standard mechanism: + + use strictures 2; - use strictures 1; + Or, by passing in a "version" option: - will continue to only introduce the current set of strictures even if - 2.0 is installed. + use strictures version => 2; + + VERSION 2 + Equivalent to: + + use strict; + use warnings FATAL => 'all'; + use warnings NONFATAL => qw( + exec + recursion + internal + malloc + newline + experimental + deprecated + portable + ); + no warnings 'once'; + + # and if in dev mode: + no indirect 'fatal'; + no multidimensional; + no bareword::filehandles; + + Additionally, any warnings created by modules using warnings::register + or "warnings::register_categories()" will not be fatalized. + + VERSION 1 + Equivalent to: + + use strict; + use warnings FATAL => 'all'; + # and if in dev mode: + no indirect 'fatal'; + no multidimensional; + no bareword::filehandles; METHODS import - This method does the setup work described above in "DESCRIPTION" + This method does the setup work described above in "DESCRIPTION". + Optionally accepts a "version" option to request a specific version's + behavior. VERSION This method traps the "strictures->VERSION(1)" call produced by a use diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/strictures-1.005006/lib/strictures/extra.pm new/strictures-2.000000/lib/strictures/extra.pm --- old/strictures-1.005006/lib/strictures/extra.pm 1970-01-01 01:00:00.000000000 +0100 +++ new/strictures-2.000000/lib/strictures/extra.pm 2015-02-01 21:32:15.000000000 +0100 @@ -0,0 +1,41 @@ +package strictures::extra; +use strict; +use warnings FATAL => 'all'; + +sub import { + $ENV{PERL_STRICTURES_EXTRA} = 1; +} + +sub unimport { + $ENV{PERL_STRICTURES_EXTRA} = 0; +} + +1; + +__END__ +=head1 NAME + +strictures::extra - enable or disable strictures additional checks + +=head1 SYNOPSIS + + no strictures::extra; + # will not enable indirect, multidimensional, or bareword filehandle checks + use strictures; + +=head1 DESCRIPTION + +Enable or disable strictures additional checks, preventing checks for C<.git> +or other VCS directories. + +Equivalent to setting the C<PERL_STRICTURES_EXTRA> environment variable. + +=head1 AUTHORS + +See L<strictures> for authors. + +=head1 COPYRIGHT AND LICENSE + +See L<strictures> for the copyright and license. + +=cut diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/strictures-1.005006/lib/strictures.pm new/strictures-2.000000/lib/strictures.pm --- old/strictures-1.005006/lib/strictures.pm 2015-01-30 13:58:20.000000000 +0100 +++ new/strictures-2.000000/lib/strictures.pm 2015-02-26 00:04:21.000000000 +0100 @@ -5,69 +5,225 @@ BEGIN { *_PERL_LT_5_8_4 = ($] < 5.008004) ? sub(){1} : sub(){0}; + *_CAN_GOTO_VERSION = ($] >= 5.008000) ? sub(){1} : sub(){0}; } -our $VERSION = '1.005006'; +our $VERSION = '2.000000'; $VERSION = eval $VERSION; +our @WARNING_CATEGORIES = grep { exists $warnings::Offsets{$_} } qw( + closure + chmod + deprecated + exiting + experimental + experimental::autoderef + experimental::const_attr + experimental::lexical_subs + experimental::lexical_topic + experimental::postderef + experimental::re_strict + experimental::refaliasing + experimental::regex_sets + experimental::signatures + experimental::smartmatch + experimental::win32_perlio + glob + imprecision + io + closed + exec + layer + newline + pipe + syscalls + unopened + locale + misc + missing + numeric + once + overflow + pack + portable + recursion + redefine + redundant + regexp + severe + debugging + inplace + internal + malloc + signal + substr + syntax + ambiguous + bareword + digit + illegalproto + parenthesis + precedence + printf + prototype + qw + reserved + semicolon + taint + threads + uninitialized + umask + unpack + untie + utf8 + non_unicode + nonchar + surrogate + void + void_unusual + y2k +); + sub VERSION { - my ($class, $version) = @_; - for ($version) { - last unless defined && !ref && int != 1; - die "Major version specified as $_ - this is strictures version 1"; - } - # passing undef here may either warn or die depending on the version of perl. - # we can't match the caller's warning state in this case, so just disable the - # warning. - no warnings 'uninitialized'; - shift->SUPER::VERSION(@_); + { + no warnings; + local $@; + if (defined $_[1] && eval { &UNIVERSAL::VERSION; 1}) { + $^H |= 0x20000 + unless _PERL_LT_5_8_4; + $^H{strictures_enable} = int $_[1]; + } + } + _CAN_GOTO_VERSION ? goto &UNIVERSAL::VERSION : &UNIVERSAL::VERSION; } -our $extra_load_states; +our %extra_load_states; our $Smells_Like_VCS; sub import { + my $class = shift; + my %opts = ref $_[0] ? %{$_[0]} : @_; + if (!exists $opts{version}) { + $opts{version} + = exists $^H{strictures_enable} ? delete $^H{strictures_enable} + : int $VERSION; + } + $opts{file} = (caller)[1]; + $class->_enable(\%opts); +} + +sub _enable { + my ($class, $opts) = @_; + my $version = $opts->{version}; + $version = 'undef' + if !defined $version; + my $method = "_enable_$version"; + if (!$class->can($method)) { + require Carp; + Carp::croak("Major version specified as $version - not supported!"); + } + $class->$method($opts); +} + +sub _enable_1 { + my ($class, $opts) = @_; strict->import; warnings->import(FATAL => 'all'); - my $extra_tests = do { - if (exists $ENV{PERL_STRICTURES_EXTRA}) { - if (_PERL_LT_5_8_4 and $ENV{PERL_STRICTURES_EXTRA}) { - die 'PERL_STRICTURES_EXTRA checks are not available on perls older than 5.8.4: ' - . "please unset \$ENV{PERL_STRICTURES_EXTRA}\n"; - } - $ENV{PERL_STRICTURES_EXTRA}; - } elsif (! _PERL_LT_5_8_4) { - (caller)[1] =~ /^(?:t|xt|lib|blib)[\\\/]/ - and defined $Smells_Like_VCS ? $Smells_Like_VCS - : ( $Smells_Like_VCS = !!( - -e '.git' || -e '.svn' || -e '.hg' - || (-e '../../dist.ini' - && (-e '../../.git' || -e '../../.svn' || -e '../../.hg' )) - )) + if (_want_extra($opts->{file})) { + _load_extras(qw(indirect multidimensional bareword::filehandles)); + indirect->unimport(':fatal') + if $extra_load_states{indirect}; + multidimensional->unimport + if $extra_load_states{multidimensional}; + bareword::filehandles->unimport + if $extra_load_states{'bareword::filehandles'}; + } +} + +our @V2_NONFATAL = grep { exists $warnings::Offsets{$_} } ( + 'exec', # not safe to catch + 'recursion', # will be caught by other mechanisms + 'internal', # not safe to catch + 'malloc', # not safe to catch + 'newline', # stat on nonexistent file with a newline in it + 'experimental', # no reason for these to be fatal + 'deprecated', # unfortunately can't make these fatal + 'portable', # everything worked fine here, just may not elsewhere +); +our @V2_DISABLE = grep { exists $warnings::Offsets{$_} } ( + 'once' # triggers inconsistently, can't be fatalized +); + +sub _enable_2 { + my ($class, $opts) = @_; + strict->import; + warnings->import; + warnings->import(FATAL => @WARNING_CATEGORIES); + warnings->unimport(FATAL => @V2_NONFATAL); + warnings->import(@V2_NONFATAL); + warnings->unimport(@V2_DISABLE); + + if (_want_extra($opts->{file})) { + _load_extras(qw(indirect multidimensional bareword::filehandles)); + indirect->unimport(':fatal') + if $extra_load_states{indirect}; + multidimensional->unimport + if $extra_load_states{multidimensional}; + bareword::filehandles->unimport + if $extra_load_states{'bareword::filehandles'}; + } +} + +sub _want_extra_env { + if (exists $ENV{PERL_STRICTURES_EXTRA}) { + if (_PERL_LT_5_8_4 and $ENV{PERL_STRICTURES_EXTRA}) { + die 'PERL_STRICTURES_EXTRA checks are not available on perls older' + . "than 5.8.4: please unset \$ENV{PERL_STRICTURES_EXTRA}\n"; } - }; - if ($extra_tests) { - $extra_load_states ||= do { - - my (%rv, @failed); - foreach my $mod (qw(indirect multidimensional bareword::filehandles)) { - eval "require $mod; \$rv{'$mod'} = 1;" or do { - push @failed, $mod; - - # courtesy of the 5.8 require bug - # (we do a copy because 5.16.2 at least uses the same read-only - # scalars for the qw() list and it doesn't seem worth a $^V check) - - (my $file = $mod) =~ s|::|/|g; - delete $INC{"${file}.pm"}; - }; - } - - if (@failed) { - my $failed = join ' ', @failed; - print STDERR <<EOE; + return $ENV{PERL_STRICTURES_EXTRA} ? 1 : 0; + } + return undef; +} + +sub _want_extra { + my $file = shift; + my $want_env = _want_extra_env(); + return $want_env + if defined $want_env; + return ( + !_PERL_LT_5_8_4 + and $file =~ /^(?:t|xt|lib|blib)[\\\/]/ + and defined $Smells_Like_VCS ? $Smells_Like_VCS + : ( $Smells_Like_VCS = !!( + -e '.git' || -e '.svn' || -e '.hg' + || (-e '../../dist.ini' + && (-e '../../.git' || -e '../../.svn' || -e '../../.hg' )) + )) + ); +} + +sub _load_extras { + my @extras = @_; + my @failed; + foreach my $mod (@extras) { + next + if exists $extra_load_states{$mod}; + + $extra_load_states{$mod} = eval "require $mod; 1;" or do { + push @failed, $mod; + + #work around 5.8 require bug + (my $file = $mod) =~ s|::|/|g; + delete $INC{"${file}.pm"}; + }; + } + + if (@failed) { + my $failed = join ' ', @failed; + my $extras = join ' ', @extras; + print STDERR <<EOE; strictures.pm extra testing active but couldn't load all modules. Missing were: $failed @@ -75,18 +231,10 @@ Extra testing is auto-enabled in checkouts only, so if you're the author of a strictures-using module you need to run: - cpan indirect multidimensional bareword::filehandles + cpan $extras but these modules are not required by your users. EOE - } - - \%rv; - }; - - indirect->unimport(':fatal') if $extra_load_states->{indirect}; - multidimensional->unimport if $extra_load_states->{multidimensional}; - bareword::filehandles->unimport if $extra_load_states->{'bareword::filehandles'}; } } @@ -99,36 +247,42 @@ =head1 SYNOPSIS - use strictures 1; + use strictures 2; is equivalent to use strict; use warnings FATAL => 'all'; + use warnings NONFATAL => qw( + exec + recursion + internal + malloc + newline + experimental + deprecated + portable + ); + no warnings 'once'; except when called from a file which matches: (caller)[1] =~ /^(?:t|xt|lib|blib)[\\\/]/ -and when either C<.git>, C<.svn>, or C<.hg> is present in the current directory (with -the intention of only forcing extra tests on the author side) -- or when C<.git>, -C<.svn>, or C<.hg> is present two directories up along with C<dist.ini> (which would -indicate we are in a C<dzil test> operation, via L<Dist::Zilla>) -- -or when the C<PERL_STRICTURES_EXTRA> environment variable is set, in which case - - use strictures 1; +and when either C<.git>, C<.svn>, or C<.hg> is present in the current directory +(with the intention of only forcing extra tests on the author side) -- or when +C<.git>, C<.svn>, or C<.hg> is present two directories up along with +C<dist.ini> (which would indicate we are in a C<dzil test> operation, via +L<Dist::Zilla>) -- or when the C<PERL_STRICTURES_EXTRA> environment variable is +set, in which case it also does the equivalent of -is equivalent to - - use strict; - use warnings FATAL => 'all'; no indirect 'fatal'; no multidimensional; no bareword::filehandles; -Note that C<PERL_STRICTURES_EXTRA> may at some point add even more tests, with only a minor -version increase, but any changes to the effect of C<use strictures> in -normal mode will involve a major version bump. +Note that C<PERL_STRICTURES_EXTRA> may at some point add even more tests, with +only a minor version increase, but any changes to the effect of C<use +strictures> in normal mode will involve a major version bump. If any of the extra testing modules are not present, L<strictures> will complain loudly, once, via C<warn()>, and then shut up. But you really @@ -159,25 +313,114 @@ C<PERL_STRICTURES_EXTRA> environment variable. If additional useful author side checks come to mind, I'll add them to the -C<PERL_STRICTURES_EXTRA> code path only -- this will result in a minor version increase (e.g. -1.000000 to 1.001000 (1.1.0) or similar). Any fixes only to the mechanism of -this code will result in a sub-version increase (e.g. 1.000000 to 1.000001 -(1.0.1)). - -If the behaviour of C<use strictures> in normal mode changes in any way, that -will constitute a major version increase -- and the code already checks -when its version is tested to ensure that +C<PERL_STRICTURES_EXTRA> code path only -- this will result in a minor version +increase (e.g. 1.000000 to 1.001000 (1.1.0) or similar). Any fixes only to the +mechanism of this code will result in a sub-version increase (e.g. 1.000000 to +1.000001 (1.0.1)). + +=head1 CATEGORY SELECTIONS + +strictures does not enable fatal warnings for all categories. + +=over 4 + +=item exec + +Includes a warning that can cause your program to continue running +unintentionally after an internal fork. Not safe to fatalize. - use strictures 1; +=item recursion -will continue to only introduce the current set of strictures even if 2.0 is -installed. +Infinite recursion will end up overflowing the stack eventually anyway. + +=item internal + +Triggers deep within perl, in places that are not safe to trap. + +=item malloc + +Triggers deep within perl, in places that are not safe to trap. + +=item newline + +Includes a warning for using stat on a valid but suspect filename, ending in a +newline. + +=item experimental + +Experimental features are used intentionally. + +=item deprecated + +Deprecations will inherently be added to in the future in unexpected ways, +so making them fatal won't be reliable. + +=item portable + +Doesn't indicate an actual problem with the program, only that it may not +behave properly if run on a different machine. + +=item once + +Can't be fatalized. Also triggers very inconsistently, so we just disable it. + +=back + +=head1 VERSIONS + +Depending on the version of strictures requested, different warnings will be +enabled. If no specific version is requested, the current version's behavior +will be used. Versions can be requested using perl's standard mechanism: + + use strictures 2; + +Or, by passing in a C<version> option: + + use strictures version => 2; + +=head2 VERSION 2 + +Equivalent to: + + use strict; + use warnings FATAL => 'all'; + use warnings NONFATAL => qw( + exec + recursion + internal + malloc + newline + experimental + deprecated + portable + ); + no warnings 'once'; + + # and if in dev mode: + no indirect 'fatal'; + no multidimensional; + no bareword::filehandles; + +Additionally, any warnings created by modules using L<warnings::register> or +C<warnings::register_categories()> will not be fatalized. + +=head2 VERSION 1 + +Equivalent to: + + use strict; + use warnings FATAL => 'all'; + # and if in dev mode: + no indirect 'fatal'; + no multidimensional; + no bareword::filehandles; =head1 METHODS =head2 import -This method does the setup work described above in L</DESCRIPTION> +This method does the setup work described above in L</DESCRIPTION>. Optionally +accepts a C<version> option to request a specific version's behavior. =head2 VERSION @@ -234,9 +477,9 @@ ensure it only fires on files in your checkout (rather than L<strictures>-using modules you happened to have installed, which was just silly). However, I hope the above clarifies why a heuristic approach is not only necessary but -desirable from a point of view of providing new users with as much safety as possible, -and will allow any future discussion on the subject to focus on "how do we -minimise annoyance to people deploying from checkouts intentionally". +desirable from a point of view of providing new users with as much safety as +possible, and will allow any future discussion on the subject to focus on "how +do we minimise annoyance to people deploying from checkouts intentionally". =head1 SEE ALSO diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/strictures-1.005006/maint/Makefile.PL.include new/strictures-2.000000/maint/Makefile.PL.include --- old/strictures-1.005006/maint/Makefile.PL.include 2014-06-01 08:07:33.000000000 +0200 +++ new/strictures-2.000000/maint/Makefile.PL.include 2015-02-01 21:49:02.000000000 +0100 @@ -3,8 +3,3 @@ use Distar; author 'mst - Matt S. Trout (cpan:MSTROUT) <[email protected]>'; - -manifest_include( - 't/smells-of-vcs' => qr{.*}, - 't/dep_constellations' => '.pm', -); diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/strictures-1.005006/t/crash.t new/strictures-2.000000/t/crash.t --- old/strictures-1.005006/t/crash.t 2015-01-30 13:56:02.000000000 +0100 +++ new/strictures-2.000000/t/crash.t 2015-02-01 21:32:15.000000000 +0100 @@ -1,16 +1,29 @@ -use strictures; +use strict; +use warnings FATAL => 'all'; +use Test::More + $] < 5.008004 ? ( skip_all => "can't test extra loading on perl < 5.8.4" ) + : ( tests => 1 ); +use File::Spec; -use Test::More tests => 1; +my %extras = map { my $m = "$_.pm"; $m =~ s{::}{/}g; $m => 1 } qw( + indirect + multidimensional + bareword::filehandles +); -SKIP: { - skip 'Have all the modules; can\'t check this', 1 - unless not eval { - require indirect; - require multidimensional; - require bareword::filehandles; - 1; - }; +unshift @INC, sub { + my $mod = $_[1]; + die "Can't locate $mod in \@INC\n" + if $extras{$mod}; + return 0; +}; - pass('can manage to survive with some modules missing!'); -} +my $err = do { + local $ENV{PERL_STRICTURES_EXTRA} = 1; + local *STDERR; + open STDERR, '>', File::Spec->devnull; + eval q{use strictures;}; + $@; +}; +is $err, '', 'can manage to survive with some modules missing!'; diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/strictures-1.005006/t/extras.t new/strictures-2.000000/t/extras.t --- old/strictures-1.005006/t/extras.t 2015-01-30 13:56:02.000000000 +0100 +++ new/strictures-2.000000/t/extras.t 2015-02-01 21:32:15.000000000 +0100 @@ -79,7 +79,7 @@ { local $ENV{PERL_STRICTURES_EXTRA} = 1; - local $strictures::extra_load_states = undef; + local %strictures::extra_load_states = (); local @INC = (sub { die "Can't locate $_[1] in \@INC (...).\n" if $extras{$_[1]}; diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/strictures-1.005006/t/strictures.t new/strictures-2.000000/t/strictures.t --- old/strictures-1.005006/t/strictures.t 2015-01-30 13:56:02.000000000 +0100 +++ new/strictures-2.000000/t/strictures.t 2015-02-05 10:49:54.000000000 +0100 @@ -1,36 +1,57 @@ -BEGIN { delete $ENV{PERL_STRICTURES_EXTRA} } +BEGIN { $ENV{PERL_STRICTURES_EXTRA} = 0 } use Test::More qw(no_plan); -our (@us, @expect); +our ($hints, $warning_bits); -sub capture_stuff { [ $^H, ${^WARNING_BITS} ] } +sub capture_hints { + # ignore lexicalized hints + $hints = $^H & ~ 0x20000; + $warning_bits = defined ${^WARNING_BITS} ? (unpack "H*", ${^WARNING_BITS}) : undef; +} -sub capture_us { push @us, capture_stuff } -sub capture_expect { push @expect, capture_stuff } +sub test_hints { + my $name = shift; + my $want_hints = $hints; + my $want_bits = $warning_bits; + capture_hints; + is($hints, $want_hints, "Hints ok for $name"); + is($warning_bits, $want_bits, "Warnings ok for $name"); +} + +{ + use strict; + use warnings FATAL => 'all'; + BEGIN { capture_hints } +} { - BEGIN { $ENV{PERL_STRICTURES_EXTRA} = 0 } use strictures 1; - BEGIN { capture_us } - BEGIN { delete $ENV{PERL_STRICTURES_EXTRA} } + BEGIN { test_hints "version 1" } } { use strict; - use warnings FATAL => 'all'; - BEGIN { capture_expect } + BEGIN { + warnings->import('all'); + warnings->import(FATAL => @strictures::WARNING_CATEGORIES); + warnings->unimport(FATAL => @strictures::V2_NONFATAL); + warnings->import(@strictures::V2_NONFATAL); + warnings->unimport(@strictures::V2_DISABLE); + } + BEGIN { capture_hints } } -# I'm assuming here we'll have more cases later. maybe not. eh. - -foreach my $idx (0 .. $#us) { - is($us[$idx][0], $expect[$idx][0], 'Hints ok for case '.($idx+1)); - is($us[$idx][1], $expect[$idx][1], 'Warnings ok for case '.($idx+1)); +{ + use strictures 2; + BEGIN { test_hints "version 2" } } my $v; eval { $v = strictures->VERSION; 1 } or diag $@; is $v, $strictures::VERSION, '->VERSION returns version correctly'; -ok(!eval q{use strictures 2; 1; }, "Can't use strictures 2 (this is version 1)"); +eval q{ use strictures 3; }; + +like $@, qr/strictures version 3 required/, + "Can't use strictures 3 (this is version 2)"; diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/strictures-1.005006/xt/all-categories.t new/strictures-2.000000/xt/all-categories.t --- old/strictures-1.005006/xt/all-categories.t 1970-01-01 01:00:00.000000000 +0100 +++ new/strictures-2.000000/xt/all-categories.t 2015-02-01 21:32:15.000000000 +0100 @@ -0,0 +1,40 @@ +BEGIN { + if (keys %INC) { + print "1..0 # SKIP can't test categories with additional modules loaded\n"; + exit 0; + } +} + +use strict; +use warnings; + +BEGIN { $ENV{PERL_STRICTURES_EXTRA} = 0 } + +use strictures (); + +# avoid loading Test::More, since it adds warning categories + +my %known_cats; @known_cats{@strictures::WARNING_CATEGORIES} = (); +my %core_cats; @core_cats{grep ! /^(?:all|everything|extra)$/, keys %warnings::Offsets} = (); +my @missing = sort grep { !exists $known_cats{$_} } keys %core_cats; +my @extra = sort grep { !exists $core_cats{$_} } keys %known_cats; + +print "1..2\n"; + +print((@missing ? 'not ' : '') . "ok 1 - strictures includes all warning categories\n"); +if (@missing) { + print STDERR "# strictures is missing categories:\n"; + print STDERR "# $_\n" + for @missing; +} + +print((@extra ? 'not ' : '') . "ok 2 - strictures includes no extra categories\n"); +if (@extra) { + print STDERR "# strictures lists extra categories:\n"; + print STDERR "# $_\n" + for @extra; +} + +if (@missing || @extra) { + exit 1; +}
