Hello community,
here is the log from the commit of package yast2-ruby-bindings for
openSUSE:Factory checked in at 2015-06-05 08:45:29
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Comparing /work/SRC/openSUSE:Factory/yast2-ruby-bindings (Old)
and /work/SRC/openSUSE:Factory/.yast2-ruby-bindings.new (New)
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Package is "yast2-ruby-bindings"
Changes:
--------
--- /work/SRC/openSUSE:Factory/yast2-ruby-bindings/yast2-ruby-bindings.changes
2015-05-27 12:41:00.000000000 +0200
+++
/work/SRC/openSUSE:Factory/.yast2-ruby-bindings.new/yast2-ruby-bindings.changes
2015-06-05 08:45:30.000000000 +0200
@@ -1,0 +2,8 @@
+Wed Jun 3 13:01:29 UTC 2015 - [email protected]
+
+- Fixed "Comparable#== will no more rescue exceptions of #<=>"
+ (boo#933470).
+- Fixed a strdup/delete mismatch (boo#932306).
+- 3.1.34
+
+-------------------------------------------------------------------
Old:
----
yast2-ruby-bindings-3.1.33.tar.bz2
New:
----
yast2-ruby-bindings-3.1.34.tar.bz2
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Other differences:
------------------
++++++ yast2-ruby-bindings.spec ++++++
--- /var/tmp/diff_new_pack.P3n44K/_old 2015-06-05 08:45:31.000000000 +0200
+++ /var/tmp/diff_new_pack.P3n44K/_new 2015-06-05 08:45:31.000000000 +0200
@@ -17,7 +17,7 @@
Name: yast2-ruby-bindings
-Version: 3.1.33
+Version: 3.1.34
Release: 0
Url: https://github.com/yast/yast-ruby-bindings
BuildRoot: %{_tmppath}/%{name}-%{version}-build
++++++ yast2-ruby-bindings-3.1.33.tar.bz2 -> yast2-ruby-bindings-3.1.34.tar.bz2
++++++
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore'
old/yast2-ruby-bindings-3.1.33/package/yast2-ruby-bindings.changes
new/yast2-ruby-bindings-3.1.34/package/yast2-ruby-bindings.changes
--- old/yast2-ruby-bindings-3.1.33/package/yast2-ruby-bindings.changes
2015-05-26 14:50:07.000000000 +0200
+++ new/yast2-ruby-bindings-3.1.34/package/yast2-ruby-bindings.changes
2015-06-03 18:00:08.000000000 +0200
@@ -1,4 +1,12 @@
-------------------------------------------------------------------
+Wed Jun 3 13:01:29 UTC 2015 - [email protected]
+
+- Fixed "Comparable#== will no more rescue exceptions of #<=>"
+ (boo#933470).
+- Fixed a strdup/delete mismatch (boo#932306).
+- 3.1.34
+
+-------------------------------------------------------------------
Mon May 25 10:00:40 UTC 2015 - [email protected]
- add ability to test if scr is local (FATE#317900)
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore'
old/yast2-ruby-bindings-3.1.33/package/yast2-ruby-bindings.spec
new/yast2-ruby-bindings-3.1.34/package/yast2-ruby-bindings.spec
--- old/yast2-ruby-bindings-3.1.33/package/yast2-ruby-bindings.spec
2015-05-26 14:50:07.000000000 +0200
+++ new/yast2-ruby-bindings-3.1.34/package/yast2-ruby-bindings.spec
2015-06-03 18:00:08.000000000 +0200
@@ -17,7 +17,7 @@
Name: yast2-ruby-bindings
-Version: 3.1.33
+Version: 3.1.34
Url: https://github.com/yast/yast-ruby-bindings
Release: 0
BuildRoot: %{_tmppath}/%{name}-%{version}-build
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore' old/yast2-ruby-bindings-3.1.33/src/ruby/yast/path.rb
new/yast2-ruby-bindings-3.1.34/src/ruby/yast/path.rb
--- old/yast2-ruby-bindings-3.1.33/src/ruby/yast/path.rb 2015-05-26
14:50:07.000000000 +0200
+++ new/yast2-ruby-bindings-3.1.34/src/ruby/yast/path.rb 2015-06-03
18:00:08.000000000 +0200
@@ -43,6 +43,7 @@
end
def <=>(other)
+ return nil unless other.is_a? self.class
0.upto(size-1) do |i|
return 1 unless other.send(:components)[i]
#we strip enclosing quotes for complex expression
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore' old/yast2-ruby-bindings-3.1.33/src/ruby/yast/term.rb
new/yast2-ruby-bindings-3.1.34/src/ruby/yast/term.rb
--- old/yast2-ruby-bindings-3.1.33/src/ruby/yast/term.rb 2015-05-26
14:50:07.000000000 +0200
+++ new/yast2-ruby-bindings-3.1.34/src/ruby/yast/term.rb 2015-06-03
18:00:08.000000000 +0200
@@ -88,6 +88,7 @@
end
def <=> (other)
+ return nil unless other.is_a? self.class
res = value <=> other.value
return res if res != 0
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore' old/yast2-ruby-bindings-3.1.33/tests/ruby/ops_spec.rb
new/yast2-ruby-bindings-3.1.34/tests/ruby/ops_spec.rb
--- old/yast2-ruby-bindings-3.1.33/tests/ruby/ops_spec.rb 2015-05-26
14:50:07.000000000 +0200
+++ new/yast2-ruby-bindings-3.1.34/tests/ruby/ops_spec.rb 2015-06-03
18:00:08.000000000 +0200
@@ -163,14 +163,14 @@
end
context "when the container is a term" do
- let(:term) { Yast::Term.new(:a,"a","b") }
+ let(:aterm) { Yast::Term.new(:a,"a","b") }
it "returns value if key exists" do
- expect(Yast::Ops.get(term,1,"n")).to eq("b")
+ expect(Yast::Ops.get(aterm,1,"n")).to eq("b")
end
it "returns default if FIXME" do
- expect(Yast::Ops.get(term,[2],"n")).to eq("n")
+ expect(Yast::Ops.get(aterm,[2],"n")).to eq("n")
end
end
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore' old/yast2-ruby-bindings-3.1.33/tests/ruby/path_spec.rb
new/yast2-ruby-bindings-3.1.34/tests/ruby/path_spec.rb
--- old/yast2-ruby-bindings-3.1.33/tests/ruby/path_spec.rb 2015-05-26
14:50:07.000000000 +0200
+++ new/yast2-ruby-bindings-3.1.34/tests/ruby/path_spec.rb 2015-06-03
18:00:08.000000000 +0200
@@ -1,49 +1,64 @@
#!/usr/bin/env rspec
# encoding: utf-8
-# FIXME: this file was autoconverted from test/unit syntax without
-# adjusting it to good RSpec style (http://betterspecs.org/).
-# Please improve it whenever adding examples.
-
require_relative "test_helper"
require "yast/path"
-describe "PathTest" do
- it "tests initialize" do
- expect(Yast::Path.new(".etc").to_s).to eq(".etc")
- expect(Yast::Path.new('.et?c').to_s).to eq('."et?c"')
- end
-
- it "tests load from string" do
- expect(Yast::Path.from_string("etc").to_s).to eq(".\"etc\"")
- expect(Yast::Path.from_string('et?c').to_s).to eq('."et?c"')
- end
-
- it "tests add" do
- root = Yast::Path.new '.'
- etc = Yast::Path.new '.etc'
- sysconfig = Yast::Path.new '.sysconfig'
- expect((etc + sysconfig).to_s).to eq(".etc.sysconfig")
- expect((etc + 'sysconfig').to_s).to eq('.etc."sysconfig"')
- expect((root+root).to_s).to eq('.')
- expect((root+etc).to_s).to eq('.etc')
- expect((etc+root).to_s).to eq('.etc')
- end
-
- it "tests equals" do
- expect(Yast::Path.new(".\"\x1A\"")).to eq(Yast::Path.new(".\"\x1a\""))
- expect(Yast::Path.new(".\"A\"")).to eq(Yast::Path.new(".\"\x41\""))
- expect(Yast::Path.new('.')).to_not eq(Yast::Path.new(".\"\""))
- end
-
- it "tests comparison" do
- expect(Yast::Path.new('.ba')).to be >= Yast::Path.new('."a?"')
- expect(Yast::Path.new('."b?"')).to be >= Yast::Path.new('.ab')
- end
-
- it "tests clone" do
- etc = Yast::Path.new '.etc.sysconfig.DUMP'
- expect(etc.clone.to_s).to eq('.etc.sysconfig.DUMP')
+describe "Yast::Path" do
+ describe "#initialize" do
+ it "works for simple paths" do
+ expect(Yast::Path.new(".etc").to_s).to eq(".etc")
+ end
+ it "works for complex paths" do
+ expect(Yast::Path.new('.et?c').to_s).to eq('."et?c"')
+ end
+ end
+
+ describe ".from_string" do
+ it "works for simple paths" do
+ expect(Yast::Path.from_string("etc").to_s).to eq(".\"etc\"")
+ end
+ it "works for complex paths" do
+ expect(Yast::Path.from_string('et?c').to_s).to eq('."et?c"')
+ end
+ end
+
+ describe "#+" do
+ it "works" do
+ root = Yast::Path.new '.'
+ etc = Yast::Path.new '.etc'
+ sysconfig = Yast::Path.new '.sysconfig'
+ expect((etc + sysconfig).to_s).to eq(".etc.sysconfig")
+ expect((etc + 'sysconfig').to_s).to eq('.etc."sysconfig"')
+ expect((root+root).to_s).to eq('.')
+ expect((root+etc).to_s).to eq('.etc')
+ expect((etc+root).to_s).to eq('.etc')
+ end
+ end
+
+ describe "#<=>" do
+ it "works for equality with Path" do
+ expect(Yast::Path.new(".\"\x1A\"")).to eq(Yast::Path.new(".\"\x1a\""))
+ expect(Yast::Path.new(".\"A\"")).to eq(Yast::Path.new(".\"\x41\""))
+ expect(Yast::Path.new('.')).to_not eq(Yast::Path.new(".\"\""))
+ end
+
+ it "works for ordering Paths" do
+ expect(Yast::Path.new('.ba')).to be >= Yast::Path.new('."a?"')
+ expect(Yast::Path.new('."b?"')).to be >= Yast::Path.new('.ab')
+ end
+
+ # bsc#933470
+ it "survives comparison with a non-Path" do
+ expect(Yast::Path.new('.foo') <=> 42).to eq nil
+ end
+ end
+
+ describe "#clone" do
+ it "works" do
+ etc = Yast::Path.new '.etc.sysconfig.DUMP'
+ expect(etc.clone.to_s).to eq('.etc.sysconfig.DUMP')
+ end
end
end
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore' old/yast2-ruby-bindings-3.1.33/tests/ruby/term_spec.rb
new/yast2-ruby-bindings-3.1.34/tests/ruby/term_spec.rb
--- old/yast2-ruby-bindings-3.1.33/tests/ruby/term_spec.rb 2015-05-26
14:50:07.000000000 +0200
+++ new/yast2-ruby-bindings-3.1.34/tests/ruby/term_spec.rb 2015-06-03
18:00:08.000000000 +0200
@@ -1,10 +1,6 @@
#!/usr/bin/env rspec
# encoding: utf-8
-# FIXME: this file was autoconverted from test/unit syntax without
-# adjusting it to good RSpec style (http://betterspecs.org/).
-# Please improve it whenever adding examples.
-
require_relative "test_helper"
require "yast/term"
@@ -47,7 +43,7 @@
end
end
- describe "#<<" do
+ describe "#<<" do # " <- unconfuse Emacs string highlighting
it "appends parameter to params" do
t = term(:HBox, 1, 2)
t << 3
@@ -55,7 +51,7 @@
end
end
- describe "comparison" do
+ describe "#<=> (comparison)" do
it "if value and params are equal, then it is equal terms" do
expect(term(:HBox)).to eq(term(:HBox))
end
@@ -75,6 +71,10 @@
it "if value is equal, then use params to comparison" do
expect(term(:HBox, "test")).to be > term(:HBox)
end
+
+ it "if non-term, then uncomparable" do
+ expect(term(:HBox, "test") <=> 42).to eq nil
+ end
end
describe "#size" do
