Hello community, here is the log from the commit of package libproxy for openSUSE:Factory checked in at 2015-07-16 17:16:44 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Comparing /work/SRC/openSUSE:Factory/libproxy (Old) and /work/SRC/openSUSE:Factory/.libproxy.new (New) ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Package is "libproxy" Changes: -------- --- /work/SRC/openSUSE:Factory/libproxy/libproxy-plugins.changes 2014-08-08 10:10:14.000000000 +0200 +++ /work/SRC/openSUSE:Factory/.libproxy.new/libproxy-plugins.changes 2015-07-16 17:16:46.000000000 +0200 @@ -1,0 +2,9 @@ +Fri May 15 10:00:14 UTC 2015 - [email protected] + +- Add libproxy-pxgsettings-signals.patch: Fix for pxgsettins not + actively monitoring gsetting changes. Due to recent changes in + GLib, only values are being monitored, that are read AFTER the + signal handler is attached. +- Adjust baselibs.conf to match what is currenly being built. + +------------------------------------------------------------------- libproxy.changes: same change New: ---- libproxy-pxgsettings-signals.patch ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Other differences: ------------------ ++++++ libproxy-plugins.spec ++++++ --- /var/tmp/diff_new_pack.eMX95O/_old 2015-07-16 17:16:48.000000000 +0200 +++ /var/tmp/diff_new_pack.eMX95O/_new 2015-07-16 17:16:48.000000000 +0200 @@ -1,7 +1,7 @@ # # spec file for package libproxy-plugins # -# Copyright (c) 2014 SUSE LINUX Products GmbH, Nuernberg, Germany. +# Copyright (c) 2015 SUSE LINUX GmbH, Nuernberg, Germany. # # All modifications and additions to the file contributed by third parties # remain the property of their copyright owners, unless otherwise agreed @@ -47,6 +47,8 @@ Patch0: libproxy-pxgsettings-crash.patch # PATCH-FIX-UPSTREAM libproxy-no-libperl.patch [email protected] -- Do not link against libperl. Submitted upstream. Patch1: libproxy-no-libperl.patch +# PATCH-FIX-UPSTREAM libproxy-pxgsettings-signals.patch [email protected] -- Due to changes in glib, signals are not emited on settings that are not read AFTER connecting the signal +Patch2: libproxy-pxgsettings-signals.patch BuildRoot: %{_tmppath}/%{name}-%{version}-build BuildRequires: cmake BuildRequires: gcc-c++ @@ -314,6 +316,7 @@ %setup -q -n %{_sourcename} %patch0 %patch1 +%patch2 -p1 mkdir build %build ++++++ libproxy.spec ++++++ --- /var/tmp/diff_new_pack.eMX95O/_old 2015-07-16 17:16:48.000000000 +0200 +++ /var/tmp/diff_new_pack.eMX95O/_new 2015-07-16 17:16:48.000000000 +0200 @@ -1,7 +1,7 @@ # # spec file for package libproxy # -# Copyright (c) 2014 SUSE LINUX Products GmbH, Nuernberg, Germany. +# Copyright (c) 2015 SUSE LINUX GmbH, Nuernberg, Germany. # # All modifications and additions to the file contributed by third parties # remain the property of their copyright owners, unless otherwise agreed @@ -47,6 +47,8 @@ Patch0: libproxy-pxgsettings-crash.patch # PATCH-FIX-UPSTREAM libproxy-no-libperl.patch [email protected] -- Do not link against libperl. Submitted upstream. Patch1: libproxy-no-libperl.patch +# PATCH-FIX-UPSTREAM libproxy-pxgsettings-signals.patch [email protected] -- Due to changes in glib, signals are not emited on settings that are not read AFTER connecting the signal +Patch2: libproxy-pxgsettings-signals.patch BuildRoot: %{_tmppath}/%{name}-%{version}-build BuildRequires: cmake BuildRequires: gcc-c++ @@ -314,6 +316,7 @@ %setup -q -n %{_sourcename} %patch0 %patch1 +%patch2 -p1 mkdir build %build ++++++ baselibs.conf ++++++ --- /var/tmp/diff_new_pack.eMX95O/_old 2015-07-16 17:16:48.000000000 +0200 +++ /var/tmp/diff_new_pack.eMX95O/_new 2015-07-16 17:16:48.000000000 +0200 @@ -1,12 +1,12 @@ libproxy1 -libproxy1-config-gnome - supplements "packageand(libproxy1-<targettype>:libproxy1-config-gnome)" +#libproxy1-config-gnome +# supplements "packageand(libproxy1-<targettype>:libproxy1-config-gnome)" libproxy1-config-gnome3 supplements "packageand(libproxy1-<targettype>:libproxy1-config-gnome3)" libproxy1-config-kde4 supplements "packageand(libproxy1-<targettype>:libproxy1-config-kde)" -libproxy1-pacrunner-mozjs - supplements "packageand(libproxy1-<targettype>:libproxy1-config-mozjs)" +#libproxy1-pacrunner-mozjs +# supplements "packageand(libproxy1-<targettype>:libproxy1-config-mozjs)" libproxy1-networkmanager supplements "packageand(libproxy1-<targettype>:libproxy1-config-networkmanager)" libproxy1-pacrunner-webkit ++++++ libproxy-pxgsettings-signals.patch ++++++ >From cb0044f2263e8a6ec7b98de3901e6818a3eed60a Mon Sep 17 00:00:00 2001 From: Dominique Leuenberger <[email protected]> Date: Sun, 3 May 2015 14:37:32 +0200 Subject: [PATCH] pxgsettings: g_signal_connect does not emmit changed signals In recent versions of GLIB, it is mandatory to FIRST connect to the changed:: signal and then read values. Without reading the values, it seems there is an initialization missing to start the change monitoring. So: we now first connect the signal handler, directly followed by reading all the settings we care about. --- libproxy/modules/pxgsettings.cpp | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) Index: libproxy-0.4.11/libproxy/modules/pxgsettings.cpp =================================================================== --- libproxy-0.4.11.orig/libproxy/modules/pxgsettings.cpp +++ libproxy-0.4.11/libproxy/modules/pxgsettings.cpp @@ -149,8 +149,8 @@ int main(int argc, char **argv) { for (int i=1; i<argc; i++) { client = g_settings_new(argv[i]); gchar** keys = g_settings_list_keys(client); - for (int j=0; keys[j]; on_value_change(client, keys[j++],argv[i] )); g_signal_connect(client, "changed::", (GCallback) on_value_change, argv[i]); + for (int j=0; keys[j]; on_value_change(client, keys[j++],argv[i] )); }
