Hello community,
here is the log from the commit of package yast2-installation for
openSUSE:Factory checked in at 2015-12-09 19:41:37
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Comparing /work/SRC/openSUSE:Factory/yast2-installation (Old)
and /work/SRC/openSUSE:Factory/.yast2-installation.new (New)
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Package is "yast2-installation"
Changes:
--------
--- /work/SRC/openSUSE:Factory/yast2-installation/yast2-installation.changes
2015-12-01 10:02:47.000000000 +0100
+++
/work/SRC/openSUSE:Factory/.yast2-installation.new/yast2-installation.changes
2015-12-09 19:41:38.000000000 +0100
@@ -1,0 +2,13 @@
+Wed Dec 2 13:55:07 UTC 2015 - [email protected]
+
+- Ensure second stage and YaST-Firstboot don't get killed by
+ getty when running over 2nd or 3rd serial console (bsc#935965)
+- 3.1.164
+
+-------------------------------------------------------------------
+Thu Nov 26 09:09:59 UTC 2015 - [email protected]
+
+- Do not crash in proposal client if zfcp proposal reports itself
+ as unavailable (bnc#956745)
+
+-------------------------------------------------------------------
Old:
----
yast2-installation-3.1.163.tar.bz2
New:
----
yast2-installation-3.1.164.tar.bz2
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Other differences:
------------------
++++++ yast2-installation.spec ++++++
--- /var/tmp/diff_new_pack.Nx4xPp/_old 2015-12-09 19:41:39.000000000 +0100
+++ /var/tmp/diff_new_pack.Nx4xPp/_new 2015-12-09 19:41:39.000000000 +0100
@@ -17,7 +17,7 @@
Name: yast2-installation
-Version: 3.1.163
+Version: 3.1.164
Release: 0
BuildRoot: %{_tmppath}/%{name}-%{version}-build
++++++ YaST2-Firstboot.service ++++++
--- /var/tmp/diff_new_pack.Nx4xPp/_old 2015-12-09 19:41:39.000000000 +0100
+++ /var/tmp/diff_new_pack.Nx4xPp/_new 2015-12-09 19:41:39.000000000 +0100
@@ -1,7 +1,8 @@
[Unit]
Description=YaST2 Firstboot
After=apparmor.service local-fs.target YaST2-Second-Stage.service
plymouth-start.service
[email protected] [email protected] display-manager.service
network.service NetworkManager.service
[email protected] [email protected]
[email protected] [email protected]
+Before=display-manager.service network.service NetworkManager.service
ConditionPathExists=/var/lib/YaST2/reconfig_system
[Service]
++++++ YaST2-Second-Stage.service ++++++
--- /var/tmp/diff_new_pack.Nx4xPp/_old 2015-12-09 19:41:39.000000000 +0100
+++ /var/tmp/diff_new_pack.Nx4xPp/_new 2015-12-09 19:41:39.000000000 +0100
@@ -3,7 +3,8 @@
# If xinetd is enabled, make sure it's already running so we can stop it during
# initialization of the VNC server
After=apparmor.service local-fs.target plymouth-start.service
[email protected] [email protected] display-manager.service
network.service NetworkManager.service SuSEfirewall2_init.service
SuSEfirewall2.service
[email protected] [email protected]
[email protected] [email protected]
+Before=display-manager.service network.service NetworkManager.service
SuSEfirewall2_init.service SuSEfirewall2.service
ConditionPathExists=/var/lib/YaST2/runme_at_boot
[Service]
++++++ yast2-installation-3.1.163.tar.bz2 -> yast2-installation-3.1.164.tar.bz2
++++++
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore'
old/yast2-installation-3.1.163/package/YaST2-Firstboot.service
new/yast2-installation-3.1.164/package/YaST2-Firstboot.service
--- old/yast2-installation-3.1.163/package/YaST2-Firstboot.service
2015-11-26 10:40:03.000000000 +0100
+++ new/yast2-installation-3.1.164/package/YaST2-Firstboot.service
2015-12-02 15:45:07.000000000 +0100
@@ -1,7 +1,8 @@
[Unit]
Description=YaST2 Firstboot
After=apparmor.service local-fs.target YaST2-Second-Stage.service
plymouth-start.service
[email protected] [email protected] display-manager.service
network.service NetworkManager.service
[email protected] [email protected]
[email protected] [email protected]
+Before=display-manager.service network.service NetworkManager.service
ConditionPathExists=/var/lib/YaST2/reconfig_system
[Service]
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore'
old/yast2-installation-3.1.163/package/YaST2-Second-Stage.service
new/yast2-installation-3.1.164/package/YaST2-Second-Stage.service
--- old/yast2-installation-3.1.163/package/YaST2-Second-Stage.service
2015-11-26 10:40:03.000000000 +0100
+++ new/yast2-installation-3.1.164/package/YaST2-Second-Stage.service
2015-12-02 15:45:07.000000000 +0100
@@ -3,7 +3,8 @@
# If xinetd is enabled, make sure it's already running so we can stop it during
# initialization of the VNC server
After=apparmor.service local-fs.target plymouth-start.service
[email protected] [email protected] display-manager.service
network.service NetworkManager.service SuSEfirewall2_init.service
SuSEfirewall2.service
[email protected] [email protected]
[email protected] [email protected]
+Before=display-manager.service network.service NetworkManager.service
SuSEfirewall2_init.service SuSEfirewall2.service
ConditionPathExists=/var/lib/YaST2/runme_at_boot
[Service]
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore'
old/yast2-installation-3.1.163/package/yast2-installation.changes
new/yast2-installation-3.1.164/package/yast2-installation.changes
--- old/yast2-installation-3.1.163/package/yast2-installation.changes
2015-11-26 10:40:03.000000000 +0100
+++ new/yast2-installation-3.1.164/package/yast2-installation.changes
2015-12-02 15:45:07.000000000 +0100
@@ -1,4 +1,17 @@
-------------------------------------------------------------------
+Wed Dec 2 13:55:07 UTC 2015 - [email protected]
+
+- Ensure second stage and YaST-Firstboot don't get killed by
+ getty when running over 2nd or 3rd serial console (bsc#935965)
+- 3.1.164
+
+-------------------------------------------------------------------
+Thu Nov 26 09:09:59 UTC 2015 - [email protected]
+
+- Do not crash in proposal client if zfcp proposal reports itself
+ as unavailable (bnc#956745)
+
+-------------------------------------------------------------------
Wed Nov 25 13:15:19 UTC 2015 - [email protected]
- Save the software selection for using it later in AutoYaST
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore'
old/yast2-installation-3.1.163/package/yast2-installation.spec
new/yast2-installation-3.1.164/package/yast2-installation.spec
--- old/yast2-installation-3.1.163/package/yast2-installation.spec
2015-11-26 10:40:03.000000000 +0100
+++ new/yast2-installation-3.1.164/package/yast2-installation.spec
2015-12-02 15:45:07.000000000 +0100
@@ -17,7 +17,7 @@
Name: yast2-installation
-Version: 3.1.163
+Version: 3.1.164
Release: 0
BuildRoot: %{_tmppath}/%{name}-%{version}-build
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore'
old/yast2-installation-3.1.163/src/lib/installation/proposal_store.rb
new/yast2-installation-3.1.164/src/lib/installation/proposal_store.rb
--- old/yast2-installation-3.1.163/src/lib/installation/proposal_store.rb
2015-11-26 10:40:03.000000000 +0100
+++ new/yast2-installation-3.1.164/src/lib/installation/proposal_store.rb
2015-12-02 15:45:07.000000000 +0100
@@ -143,6 +143,13 @@
# Filter missing proposals out
@proposal_names -= missing_proposals
+
+ unavailable_proposals = @proposal_names.select { |name|
description_for(name).nil? }
+ unless unavailable_proposals.empty?
+ log.info "These proposals report itself as unavailable:
#{unavailable_proposals}"
+ end
+
+ @proposal_names -= unavailable_proposals
end
# returns single list of modules presentation order or list of tabs with
list of modules
@@ -194,6 +201,8 @@
description = Yast::WFM.CallFunction(client, ["Description", {}])
+ return nil unless description
+
unless description.key?("id")
log.warn "proposal client #{client} is missing key 'id' in
#{description}"
@missing_no ||= 1
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore'
old/yast2-installation-3.1.163/test/proposal_store_test.rb
new/yast2-installation-3.1.164/test/proposal_store_test.rb
--- old/yast2-installation-3.1.163/test/proposal_store_test.rb 2015-11-26
10:40:03.000000000 +0100
+++ new/yast2-installation-3.1.164/test/proposal_store_test.rb 2015-12-02
15:45:07.000000000 +0100
@@ -15,6 +15,10 @@
.and_return(data)
end
+ before do
+ allow(Yast::WFM).to receive(:CallFunction).and_return({})
+ end
+
describe "#headline" do
it "use translated label from product control" do
original_label = "Label"
@@ -78,7 +82,7 @@
it "raises exception if used on non-tab proposal" do
mock_properties
- expect { subject.tab_labels }.to raise_error
+ expect { subject.tab_labels }.to raise_error(RuntimeError)
end
end
@@ -94,6 +98,17 @@
end
it "returns array with string names of clients" do
+ allow(Yast::ProductControl).to receive(:getProposals)
+ .and_return([
+ ["test1"],
+ ["test2"]
+ ])
+
+ expect(subject.proposal_names).to include("test1")
+ expect(subject.proposal_names).to include("test2")
+ end
+
+ it "filters out clients that do not exist on media" do
allow(Yast::WFM).to
receive(:ClientExists).with(/test3/).and_return(false)
allow(Yast::ProductControl).to receive(:getProposals)
@@ -105,6 +120,21 @@
expect(subject.proposal_names).to include("test1")
expect(subject.proposal_names).to include("test2")
+ expect(subject.proposal_names).not_to include("test3")
+ end
+
+ it "filters out clients that report themselves as unavailable" do
+ allow(Yast::ProductControl).to receive(:getProposals)
+ .and_return([
+ ["test1"],
+ ["test2"],
+ ["test3"]
+ ])
+
+ allow(Yast::WFM).to receive(:CallFunction).with("test3", ["Description",
anything]).and_return(nil)
+
+ expect(subject.proposal_names).to include("test1")
+ expect(subject.proposal_names).to include("test2")
expect(subject.proposal_names).not_to include("test3")
end
