Hello community, here is the log from the commit of package perl-Archive-Zip for openSUSE:Factory checked in at 2015-12-13 09:36:30 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Comparing /work/SRC/openSUSE:Factory/perl-Archive-Zip (Old) and /work/SRC/openSUSE:Factory/.perl-Archive-Zip.new (New) ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Package is "perl-Archive-Zip" Changes: -------- --- /work/SRC/openSUSE:Factory/perl-Archive-Zip/perl-Archive-Zip.changes 2015-10-01 12:22:24.000000000 +0200 +++ /work/SRC/openSUSE:Factory/.perl-Archive-Zip.new/perl-Archive-Zip.changes 2015-12-13 09:36:31.000000000 +0100 @@ -1,0 +2,12 @@ +Sat Dec 5 09:49:37 UTC 2015 - [email protected] + +- updated to 1.55 + see /usr/share/doc/packages/perl-Archive-Zip/Changes + + 1.55 Fri 04 Dec 2015 + - rt.cpan.org #110064 - fix empty archive issue with OS X gnu tar + + 1.54 Wed 02 Dec 2015 + - Ensure filehandles created by Archive::Zip::tempFile are closed [github/antoniomonty] + +------------------------------------------------------------------- Old: ---- Archive-Zip-1.53.tar.gz New: ---- Archive-Zip-1.55.tar.gz ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Other differences: ------------------ ++++++ perl-Archive-Zip.spec ++++++ --- /var/tmp/diff_new_pack.VAn5Np/_old 2015-12-13 09:36:32.000000000 +0100 +++ /var/tmp/diff_new_pack.VAn5Np/_new 2015-12-13 09:36:32.000000000 +0100 @@ -17,7 +17,7 @@ Name: perl-Archive-Zip -Version: 1.53 +Version: 1.55 Release: 0 %define cpan_name Archive-Zip Summary: Provide an interface to ZIP archive files @@ -31,6 +31,7 @@ BuildRequires: perl BuildRequires: perl-macros BuildRequires: perl(Compress::Raw::Zlib) >= 2.017 +BuildRequires: perl(Test::MockModule) BuildRequires: perl(Test::More) >= 0.88 Requires: perl(Compress::Raw::Zlib) >= 2.017 %{perl_requires} @@ -50,11 +51,11 @@ Members can be created from members in existing Zip files, or from existing directories, files, or strings. -This module uses the the Compress::Raw::Zlib manpage library to read and -write the compressed streams inside the files. +This module uses the Compress::Raw::Zlib library to read and write the +compressed streams inside the files. -One can use the Archive::Zip::MemberRead manpage to read the zip file -archive members as if they were files. +One can use Archive::Zip::MemberRead to read the zip file archive members +as if they were files. %prep %setup -q -n %{cpan_name}-%{version} ++++++ Archive-Zip-1.53.tar.gz -> Archive-Zip-1.55.tar.gz ++++++ diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/Archive-Zip-1.53/Changes new/Archive-Zip-1.55/Changes --- old/Archive-Zip-1.53/Changes 2015-09-23 19:42:31.000000000 +0200 +++ new/Archive-Zip-1.55/Changes 2015-12-04 20:24:44.000000000 +0100 @@ -1,5 +1,11 @@ Revision history for Perl extension Archive-Zip +1.55 Fri 04 Dec 2015 + - rt.cpan.org #110064 - fix empty archive issue with OS X gnu tar + +1.54 Wed 02 Dec 2015 + - Ensure filehandles created by Archive::Zip::tempFile are closed [github/antoniomonty] + 1.53 Wed 22 Sep 2015 - rt.cpan.org #107268 - Archive-Zip-1.52.tar.gz is (nearly) empty Thanks to SREZIC for the spot on my dad brain sleep schedule error diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/Archive-Zip-1.53/MANIFEST new/Archive-Zip-1.55/MANIFEST --- old/Archive-Zip-1.53/MANIFEST 2015-09-23 19:42:37.000000000 +0200 +++ new/Archive-Zip-1.55/MANIFEST 2015-12-04 20:34:49.000000000 +0100 @@ -55,6 +55,7 @@ t/20_bug_github11.t t/21_zip64.t t/22_deflated_dir.t +t/23_closed_handle.t t/badjpeg/expected.jpg t/badjpeg/source.zip t/common.pm diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/Archive-Zip-1.53/META.json new/Archive-Zip-1.55/META.json --- old/Archive-Zip-1.53/META.json 2015-09-23 19:42:37.000000000 +0200 +++ new/Archive-Zip-1.55/META.json 2015-12-04 20:34:49.000000000 +0100 @@ -22,6 +22,7 @@ "prereqs" : { "build" : { "requires" : { + "Test::MockModule" : "0", "Test::More" : "0.88" } }, @@ -53,5 +54,5 @@ "url" : "https://github.com/redhotpenguin/perl-Archive-Zip-svn"; } }, - "version" : "1.53" + "version" : "1.55" } diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/Archive-Zip-1.53/META.yml new/Archive-Zip-1.55/META.yml --- old/Archive-Zip-1.53/META.yml 2015-09-23 19:42:37.000000000 +0200 +++ new/Archive-Zip-1.55/META.yml 2015-12-04 20:34:49.000000000 +0100 @@ -3,6 +3,7 @@ author: - 'Ned Konz <[email protected]>' build_requires: + Test::MockModule: '0' Test::More: '0.88' configure_requires: ExtUtils::MakeMaker: '0' @@ -32,4 +33,4 @@ perl: '5.006' resources: repository: https://github.com/redhotpenguin/perl-Archive-Zip-svn -version: '1.53' +version: '1.55' diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/Archive-Zip-1.53/Makefile.PL new/Archive-Zip-1.55/Makefile.PL --- old/Archive-Zip-1.53/Makefile.PL 2015-09-22 20:32:25.000000000 +0200 +++ new/Archive-Zip-1.55/Makefile.PL 2015-12-02 20:20:52.000000000 +0100 @@ -37,6 +37,7 @@ }, BUILD_REQUIRES => { 'Test::More' => '0.88', + 'Test::MockModule' => 0, }, clean => { FILES => join( ' ', qw{ diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/Archive-Zip-1.53/lib/Archive/Zip/Archive.pm new/Archive-Zip-1.55/lib/Archive/Zip/Archive.pm --- old/Archive-Zip-1.53/lib/Archive/Zip/Archive.pm 2015-09-23 19:41:14.000000000 +0200 +++ new/Archive-Zip-1.55/lib/Archive/Zip/Archive.pm 2015-12-04 20:19:33.000000000 +0100 @@ -13,7 +13,7 @@ use vars qw( $VERSION @ISA ); BEGIN { - $VERSION = '1.53'; + $VERSION = '1.55'; @ISA = qw( Archive::Zip ); if ($^O eq 'MSWin32') { diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/Archive-Zip-1.53/lib/Archive/Zip/BufferedFileHandle.pm new/Archive-Zip-1.55/lib/Archive/Zip/BufferedFileHandle.pm --- old/Archive-Zip-1.53/lib/Archive/Zip/BufferedFileHandle.pm 2015-09-23 19:41:14.000000000 +0200 +++ new/Archive-Zip-1.55/lib/Archive/Zip/BufferedFileHandle.pm 2015-12-04 20:19:33.000000000 +0100 @@ -13,7 +13,7 @@ use vars qw{$VERSION}; BEGIN { - $VERSION = '1.53'; + $VERSION = '1.55'; $VERSION = eval $VERSION; } diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/Archive-Zip-1.53/lib/Archive/Zip/DirectoryMember.pm new/Archive-Zip-1.55/lib/Archive/Zip/DirectoryMember.pm --- old/Archive-Zip-1.53/lib/Archive/Zip/DirectoryMember.pm 2015-09-23 19:41:14.000000000 +0200 +++ new/Archive-Zip-1.55/lib/Archive/Zip/DirectoryMember.pm 2015-12-04 20:19:33.000000000 +0100 @@ -6,7 +6,7 @@ use vars qw( $VERSION @ISA ); BEGIN { - $VERSION = '1.53'; + $VERSION = '1.55'; @ISA = qw( Archive::Zip::Member ); } diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/Archive-Zip-1.53/lib/Archive/Zip/FileMember.pm new/Archive-Zip-1.55/lib/Archive/Zip/FileMember.pm --- old/Archive-Zip-1.53/lib/Archive/Zip/FileMember.pm 2015-09-23 19:41:14.000000000 +0200 +++ new/Archive-Zip-1.55/lib/Archive/Zip/FileMember.pm 2015-12-04 20:19:33.000000000 +0100 @@ -4,7 +4,7 @@ use vars qw( $VERSION @ISA ); BEGIN { - $VERSION = '1.53'; + $VERSION = '1.55'; @ISA = qw ( Archive::Zip::Member ); } diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/Archive-Zip-1.53/lib/Archive/Zip/Member.pm new/Archive-Zip-1.55/lib/Archive/Zip/Member.pm --- old/Archive-Zip-1.53/lib/Archive/Zip/Member.pm 2015-09-23 19:41:14.000000000 +0200 +++ new/Archive-Zip-1.55/lib/Archive/Zip/Member.pm 2015-12-04 20:19:33.000000000 +0100 @@ -6,7 +6,7 @@ use vars qw( $VERSION @ISA ); BEGIN { - $VERSION = '1.53'; + $VERSION = '1.55'; @ISA = qw( Archive::Zip ); if ($^O eq 'MSWin32') { diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/Archive-Zip-1.53/lib/Archive/Zip/MemberRead.pm new/Archive-Zip-1.55/lib/Archive/Zip/MemberRead.pm --- old/Archive-Zip-1.53/lib/Archive/Zip/MemberRead.pm 2015-09-23 19:41:14.000000000 +0200 +++ new/Archive-Zip-1.55/lib/Archive/Zip/MemberRead.pm 2015-12-04 20:19:33.000000000 +0100 @@ -40,7 +40,7 @@ my $nl; BEGIN { - $VERSION = '1.53'; + $VERSION = '1.55'; $VERSION = eval $VERSION; # Requirement for newline conversion. Should check for e.g., DOS and OS/2 as well, but am too lazy. diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/Archive-Zip-1.53/lib/Archive/Zip/MockFileHandle.pm new/Archive-Zip-1.55/lib/Archive/Zip/MockFileHandle.pm --- old/Archive-Zip-1.53/lib/Archive/Zip/MockFileHandle.pm 2015-09-23 19:41:14.000000000 +0200 +++ new/Archive-Zip-1.55/lib/Archive/Zip/MockFileHandle.pm 2015-12-04 20:19:33.000000000 +0100 @@ -10,7 +10,7 @@ use vars qw{$VERSION}; BEGIN { - $VERSION = '1.53'; + $VERSION = '1.55'; $VERSION = eval $VERSION; } diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/Archive-Zip-1.53/lib/Archive/Zip/NewFileMember.pm new/Archive-Zip-1.55/lib/Archive/Zip/NewFileMember.pm --- old/Archive-Zip-1.53/lib/Archive/Zip/NewFileMember.pm 2015-09-23 19:41:14.000000000 +0200 +++ new/Archive-Zip-1.55/lib/Archive/Zip/NewFileMember.pm 2015-12-04 20:19:33.000000000 +0100 @@ -4,7 +4,7 @@ use vars qw( $VERSION @ISA ); BEGIN { - $VERSION = '1.53'; + $VERSION = '1.55'; @ISA = qw ( Archive::Zip::FileMember ); } diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/Archive-Zip-1.53/lib/Archive/Zip/StringMember.pm new/Archive-Zip-1.55/lib/Archive/Zip/StringMember.pm --- old/Archive-Zip-1.53/lib/Archive/Zip/StringMember.pm 2015-09-23 19:41:14.000000000 +0200 +++ new/Archive-Zip-1.55/lib/Archive/Zip/StringMember.pm 2015-12-04 20:19:33.000000000 +0100 @@ -4,7 +4,7 @@ use vars qw( $VERSION @ISA ); BEGIN { - $VERSION = '1.53'; + $VERSION = '1.55'; @ISA = qw( Archive::Zip::Member ); } diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/Archive-Zip-1.53/lib/Archive/Zip/Tree.pm new/Archive-Zip-1.55/lib/Archive/Zip/Tree.pm --- old/Archive-Zip-1.53/lib/Archive/Zip/Tree.pm 2015-09-23 19:41:14.000000000 +0200 +++ new/Archive-Zip-1.55/lib/Archive/Zip/Tree.pm 2015-12-04 20:19:33.000000000 +0100 @@ -4,7 +4,7 @@ use vars qw{$VERSION}; BEGIN { - $VERSION = '1.53'; + $VERSION = '1.55'; } use Archive::Zip; diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/Archive-Zip-1.53/lib/Archive/Zip/ZipFileMember.pm new/Archive-Zip-1.55/lib/Archive/Zip/ZipFileMember.pm --- old/Archive-Zip-1.53/lib/Archive/Zip/ZipFileMember.pm 2015-09-23 19:41:14.000000000 +0200 +++ new/Archive-Zip-1.55/lib/Archive/Zip/ZipFileMember.pm 2015-12-04 20:19:33.000000000 +0100 @@ -4,7 +4,7 @@ use vars qw( $VERSION @ISA ); BEGIN { - $VERSION = '1.53'; + $VERSION = '1.55'; @ISA = qw ( Archive::Zip::FileMember ); } diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/Archive-Zip-1.53/lib/Archive/Zip.pm new/Archive-Zip-1.55/lib/Archive/Zip.pm --- old/Archive-Zip-1.53/lib/Archive/Zip.pm 2015-09-23 19:41:14.000000000 +0200 +++ new/Archive-Zip-1.55/lib/Archive/Zip.pm 2015-12-04 20:19:33.000000000 +0100 @@ -14,7 +14,7 @@ use vars qw( $VERSION @ISA ); BEGIN { - $VERSION = '1.53'; + $VERSION = '1.55'; require Exporter; @ISA = qw( Exporter ); @@ -517,6 +517,7 @@ $dir ? (DIR => $dir) : ()); return (undef, undef) unless $fh; my ($status, $newfh) = _newFileHandle($fh, 'w+'); + $fh->close(); return ($newfh, $filename); } diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/Archive-Zip-1.53/t/23_closed_handle.t new/Archive-Zip-1.55/t/23_closed_handle.t --- old/Archive-Zip-1.53/t/23_closed_handle.t 1970-01-01 01:00:00.000000000 +0100 +++ new/Archive-Zip-1.55/t/23_closed_handle.t 2015-12-02 20:20:52.000000000 +0100 @@ -0,0 +1,38 @@ +#!/usr/bin/perl + +# Test to make sure temporal filehandles created by Archive::Zip::tempFile are closed properly + +use strict; +use warnings; + +use Archive::Zip; +use Test::MockModule; + +use Test::More tests => 2; + +# array to store open filhandles +my @opened_filehandles; + +# mocking File::Temp to store returned filehandles +my $mock_file_temp = Test::MockModule->new('File::Temp'); + +my $previous_tempfile_sub = \&File::Temp::tmpfile; +$mock_file_temp->mock( + tempfile => sub { + my ( $fh, $filename ) = $previous_tempfile_sub->(@_); + push( @opened_filehandles, $fh ); + return ( $fh, $filename ); + } +); + +# calling method +Archive::Zip::tempFile(); + +# testing filehandles are closed +ok( scalar @opened_filehandles == 1, "One filehandle was created" ); +ok( !defined $opened_filehandles[0] + || !defined fileno( $opened_filehandles[0] ) + || fileno( $opened_filehandles[0] ) == -1, + "Filehandle is closed" +); +
