Hello community, here is the log from the commit of package rubygem-minitest for openSUSE:Factory checked in at 2015-12-14 10:13:43 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Comparing /work/SRC/openSUSE:Factory/rubygem-minitest (Old) and /work/SRC/openSUSE:Factory/.rubygem-minitest.new (New) ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Package is "rubygem-minitest" Changes: -------- --- /work/SRC/openSUSE:Factory/rubygem-minitest/rubygem-minitest.changes 2015-10-30 21:53:02.000000000 +0100 +++ /work/SRC/openSUSE:Factory/.rubygem-minitest.new/rubygem-minitest.changes 2015-12-14 10:13:44.000000000 +0100 @@ -1,0 +2,16 @@ +Wed Nov 18 05:38:20 UTC 2015 - [email protected] + +- updated to version 5.8.3 + see installed History.rdoc + + === 5.8.3 / 2015-11-17 + + * 1 minor enhancement: + + * Added extra note about mocks and threads to readme. (zamith) + + * 1 bug fix: + + * Fixed bug in Mock#verify. (pithub/zamith) + +------------------------------------------------------------------- Old: ---- minitest-5.8.2.gem New: ---- minitest-5.8.3.gem ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Other differences: ------------------ ++++++ rubygem-minitest.spec ++++++ --- /var/tmp/diff_new_pack.OCHuDK/_old 2015-12-14 10:13:45.000000000 +0100 +++ /var/tmp/diff_new_pack.OCHuDK/_new 2015-12-14 10:13:45.000000000 +0100 @@ -24,7 +24,7 @@ # Name: rubygem-minitest -Version: 5.8.2 +Version: 5.8.3 Release: 0 %define mod_name minitest %define mod_full_name %{mod_name}-%{version} ++++++ minitest-5.8.2.gem -> minitest-5.8.3.gem ++++++ diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/History.rdoc new/History.rdoc --- old/History.rdoc 2015-10-26 23:54:08.000000000 +0100 +++ new/History.rdoc 2015-11-17 23:59:55.000000000 +0100 @@ -1,3 +1,13 @@ +=== 5.8.3 / 2015-11-17 + +* 1 minor enhancement: + + * Added extra note about mocks and threads to readme. (zamith) + +* 1 bug fix: + + * Fixed bug in Mock#verify. (pithub/zamith) + === 5.8.2 / 2015-10-26 * 1 bug fix: diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/README.rdoc new/README.rdoc --- old/README.rdoc 2015-10-26 23:54:08.000000000 +0100 +++ new/README.rdoc 2015-11-17 23:59:55.000000000 +0100 @@ -219,6 +219,20 @@ end end +**Multi-threading and Mocks** + +Minitest mocks do not support multi-threading if it works, fine, if it doesn't +you can use regular ruby patterns and facilities like local variables. Here's +an example of asserting that code inside a thread is run: + + def test_called_inside_thread + called = false + pr = Proc.new { called = true } + thread = Thread.new(&pr) + thread.join + assert called, "proc not called" + end + === Stubs Mocks and stubs are defined using terminology by Fowler & Meszaros at Files old/checksums.yaml.gz and new/checksums.yaml.gz differ Files old/checksums.yaml.gz.sig and new/checksums.yaml.gz.sig differ Files old/data.tar.gz.sig and new/data.tar.gz.sig differ diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/lib/minitest/mock.rb new/lib/minitest/mock.rb --- old/lib/minitest/mock.rb 2015-10-26 23:54:08.000000000 +0100 +++ new/lib/minitest/mock.rb 2015-11-17 23:59:55.000000000 +0100 @@ -65,8 +65,7 @@ # @mock.verify # => true # # @mock.expect(:uses_one_string, true, ["foo"]) - # @mock.uses_one_string("bar") # => true - # @mock.verify # => raises MockExpectationError + # @mock.uses_one_string("bar") # => raises MockExpectationError def expect(name, retval, args = [], &blk) name = name.to_sym @@ -96,16 +95,11 @@ # expected. def verify - @expected_calls.each do |name, calls| - calls.each do |expected| - raise MockExpectationError, "expected #{__call name, expected}, got [#{__call name, @actual_calls[name]}]" if - @actual_calls.key?(name) and - not @actual_calls[name].include?(expected) - - raise MockExpectationError, "expected #{__call name, expected}" unless - @actual_calls.key?(name) and - @actual_calls[name].include?(expected) - end + @expected_calls.each do |name, expected| + actual = @actual_calls.fetch(name, nil) + raise MockExpectationError, "expected #{__call name, expected[0]}" unless actual + raise MockExpectationError, "expected #{__call name, expected[actual.size]}, got [#{__call name, actual}]" if + actual.size < expected.size end true end diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/lib/minitest.rb new/lib/minitest.rb --- old/lib/minitest.rb 2015-10-26 23:54:08.000000000 +0100 +++ new/lib/minitest.rb 2015-11-17 23:59:55.000000000 +0100 @@ -7,7 +7,7 @@ # :include: README.rdoc module Minitest - VERSION = "5.8.2" # :nodoc: + VERSION = "5.8.3" # :nodoc: ENCS = "".respond_to? :encoding # :nodoc: @@installed_at_exit ||= false diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/metadata new/metadata --- old/metadata 2015-10-26 23:54:08.000000000 +0100 +++ new/metadata 2015-11-17 23:59:55.000000000 +0100 @@ -1,7 +1,7 @@ --- !ruby/object:Gem::Specification name: minitest version: !ruby/object:Gem::Version - version: 5.8.2 + version: 5.8.3 platform: ruby authors: - Ryan Davis @@ -29,7 +29,7 @@ qx3h45R1CAsObX0SQDIT+rRbQrtKz1GHIZTOFYvEJjUY1XmRTZupD3CJ8Q7sDqSy NLq5jm1fq6Y9Uolu3RJbmycf -----END CERTIFICATE----- -date: 2015-10-26 00:00:00.000000000 Z +date: 2015-11-17 00:00:00.000000000 Z dependencies: - !ruby/object:Gem::Dependency name: rdoc Files old/metadata.gz.sig and new/metadata.gz.sig differ diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/test/minitest/test_minitest_mock.rb new/test/minitest/test_minitest_mock.rb --- old/test/minitest/test_minitest_mock.rb 2015-10-26 23:54:08.000000000 +0100 +++ new/test/minitest/test_minitest_mock.rb 2015-11-17 23:59:55.000000000 +0100 @@ -240,6 +240,20 @@ assert_equal exp, e.message end + def test_same_method_expects_with_same_args_blow_up_when_not_all_called + mock = Minitest::Mock.new + mock.expect :foo, nil, [:bar] + mock.expect :foo, nil, [:bar] + + mock.foo :bar + + e = assert_raises(MockExpectationError) { mock.verify } + + exp = "expected foo(:bar) => nil, got [foo(:bar) => nil]" + + assert_equal exp, e.message + end + def test_verify_passes_when_mock_block_returns_true mock = Minitest::Mock.new mock.expect :foo, nil do
