Hello community,

here is the log from the commit of package libXfont for openSUSE:Factory 
checked in at 2015-12-17 15:52:53
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Comparing /work/SRC/openSUSE:Factory/libXfont (Old)
 and      /work/SRC/openSUSE:Factory/.libXfont.new (New)
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++

Package is "libXfont"

Changes:
--------
--- /work/SRC/openSUSE:Factory/libXfont/libXfont.changes        2015-03-19 
21:02:43.000000000 +0100
+++ /work/SRC/openSUSE:Factory/.libXfont.new/libXfont.changes   2015-12-17 
15:52:54.000000000 +0100
@@ -1,0 +2,7 @@
+Tue Dec  8 15:57:08 UTC 2015 - [email protected]
+
+- U_bdfReadCharacters-Allow-negative-DWIDTH-values.patch
+  Negative DWIDTH is legal. This was broken by the fix for
+  CVE-2015-1804. Fixed upstream with commit 1a73d6 (boo#958383).
+
+-------------------------------------------------------------------

New:
----
  U_bdfReadCharacters-Allow-negative-DWIDTH-values.patch

++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++

Other differences:
------------------
++++++ libXfont.spec ++++++
--- /var/tmp/diff_new_pack.osppkr/_old  2015-12-17 15:52:55.000000000 +0100
+++ /var/tmp/diff_new_pack.osppkr/_new  2015-12-17 15:52:55.000000000 +0100
@@ -29,6 +29,7 @@
 #Git-Web:      http://cgit.freedesktop.org/xorg/lib/libXfont/
 Source:         %{name}-%{version}.tar.bz2
 Source1:        baselibs.conf
+Patch0:         U_bdfReadCharacters-Allow-negative-DWIDTH-values.patch
 BuildRoot:      %{_tmppath}/%{name}-%{version}-build
 #git#BuildRequires:    autoconf >= 2.60, automake, libtool
 BuildRequires:  pkgconfig
@@ -82,6 +83,7 @@
 
 %prep
 %setup -q
+%patch0 -p1
 
 %build
 %configure --disable-static

++++++ U_bdfReadCharacters-Allow-negative-DWIDTH-values.patch ++++++
From: Benjamin Tissoires <[email protected]>
Date: Mon Jul 13 14:43:06 2015 -0400
Subject: [PATCH]bdfReadCharacters: Allow negative DWIDTH values
Patch-mainline: Upstream
Git-commit: 1a73d6828dfa03924f2d68644fb5b99afd9c78e2
Git-repo: git://anongit.freedesktop.org/git/xorg/lib/libXfont
References: boo#958383
Signed-off-by: Egbert Eich <[email protected]>

The fix for CVE-2015-1804 prevent DWIDTH to be negative.
However, the spec states that "DWIDTH [...] is a vector indicating the
position of the next glyph’s origin relative to the origin of this glyph."

So negative values are correct.

Found by trying to compile XTS.

Signed-off-by: Benjamin Tissoires <[email protected]>
Reviewed-by: Peter Hutterer <[email protected]>
Signed-off-by: Alan Coopersmith <[email protected]>
---
 src/bitmap/bdfread.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/bitmap/bdfread.c b/src/bitmap/bdfread.c
index a0ace8f..eccd7b7 100644
--- a/src/bitmap/bdfread.c
+++ b/src/bitmap/bdfread.c
@@ -426,7 +426,7 @@ bdfReadCharacters(FontFilePtr file, FontPtr pFont, 
bdfFileState *pState,
            goto BAILOUT;
        }
        /* xCharInfo metrics are stored as INT16 */
-       if ((wx < 0) || (wx > INT16_MAX)) {
+       if ((wx < INT16_MIN) || (wx > INT16_MAX)) {
            bdfError("character '%s' has out of range width, %d\n",
                     charName, wx);
            goto BAILOUT;

Reply via email to