Hello community, here is the log from the commit of package taglib-extras for openSUSE:Factory checked in at 2016-01-09 23:10:22 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Comparing /work/SRC/openSUSE:Factory/taglib-extras (Old) and /work/SRC/openSUSE:Factory/.taglib-extras.new (New) ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Package is "taglib-extras" Changes: -------- --- /work/SRC/openSUSE:Factory/taglib-extras/taglib-extras.changes 2011-09-23 12:47:25.000000000 +0200 +++ /work/SRC/openSUSE:Factory/.taglib-extras.new/taglib-extras.changes 2016-01-09 23:10:23.000000000 +0100 @@ -1,0 +2,7 @@ +Tue Jan 5 13:17:04 UTC 2016 - [email protected] + +- Add taglib-extras-fix-findtaglib-1_10.patch + * The version check did string comparison, which caused 1.10 to be smaller + than 1.x when x is a single digit. https://websvn.kde.org/?view=revision&revision=1444333 + +------------------------------------------------------------------- New: ---- taglib-extras-fix-findtaglib-1_10.patch ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Other differences: ------------------ ++++++ taglib-extras.spec ++++++ --- /var/tmp/diff_new_pack.GWjywS/_old 2016-01-09 23:10:24.000000000 +0100 +++ /var/tmp/diff_new_pack.GWjywS/_new 2016-01-09 23:10:24.000000000 +0100 @@ -1,7 +1,7 @@ # # spec file for package taglib-extras # -# Copyright (c) 2011 SUSE LINUX Products GmbH, Nuernberg, Germany. +# Copyright (c) 2016 SUSE LINUX GmbH, Nuernberg, Germany. # # All modifications and additions to the file contributed by third parties # remain the property of their copyright owners, unless otherwise agreed @@ -15,19 +15,20 @@ # Please submit bugfixes or comments via http://bugs.opensuse.org/ # -# norootforbuild Url: http://amarok.kde.org Name: taglib-extras BuildRequires: libkde4-devel BuildRequires: taglib-devel >= 1.6 +Summary: Extra plugins for TagLib License: LGPL-2.1+ Group: Development/Libraries/C and C++ -Summary: Extra plugins for TagLib Version: 1.0.1 -Release: 10 +Release: 0 Source0: taglib-extras-%version.tar.bz2 +# PATCH-FIX-UPSTREAM taglib-extras-fix-findtaglib-1_10.patch [email protected] -- fix wrong string comparison of version number +Patch0: taglib-extras-fix-findtaglib-1_10.patch BuildRoot: %{_tmppath}/%{name}-%{version}-build Obsoletes: taglib-extras < %{version} Provides: taglib-extras = %{version} @@ -38,9 +39,8 @@ %package devel -License: LGPL-2.1+ -Group: Development/Libraries/C and C++ Summary: Extra plugins for TagLib +Group: Development/Libraries/C and C++ Requires: libtag-extras1 = %{version} libstdc++-devel %description devel @@ -49,9 +49,8 @@ %package -n libtag-extras1 -License: LGPL-2.1+ -Group: System/GUI/KDE Summary: Extra plugins for TagLib +Group: System/GUI/KDE %description -n libtag-extras1 Unofficial TagLib file type plugins maintained by the Amarok project @@ -60,6 +59,7 @@ %prep %setup -q -n %name-%version +%patch0 -p1 %build export CXXFLAGS="%{optflags}" ++++++ taglib-extras-fix-findtaglib-1_10.patch ++++++ Index: b/cmake/modules/FindTaglib.cmake =================================================================== --- a/cmake/modules/FindTaglib.cmake +++ b/cmake/modules/FindTaglib.cmake @@ -29,10 +29,10 @@ if(TAGLIBCONFIG_EXECUTABLE) exec_program(${TAGLIBCONFIG_EXECUTABLE} ARGS --version RETURN_VALUE _return_VALUE OUTPUT_VARIABLE TAGLIB_VERSION) - if(TAGLIB_VERSION STRLESS "${TAGLIB_MIN_VERSION}") + if("${TAGLIB_MIN_VERSION}" VERSION_GREATER TAGLIB_VERSION) message(STATUS "TagLib version not found: version searched :${TAGLIB_MIN_VERSION}, found ${TAGLIB_VERSION}") set(TAGLIB_FOUND FALSE) - else(TAGLIB_VERSION STRLESS "${TAGLIB_MIN_VERSION}") + else("${TAGLIB_MIN_VERSION}" VERSION_GREATER TAGLIB_VERSION) exec_program(${TAGLIBCONFIG_EXECUTABLE} ARGS --libs RETURN_VALUE _return_VALUE OUTPUT_VARIABLE TAGLIB_LIBRARIES) @@ -42,7 +42,7 @@ if(TAGLIBCONFIG_EXECUTABLE) set(TAGLIB_FOUND TRUE) endif(TAGLIB_LIBRARIES AND TAGLIB_CFLAGS) string(REGEX REPLACE " *-I" ";" TAGLIB_INCLUDES "${TAGLIB_CFLAGS}") - endif(TAGLIB_VERSION STRLESS "${TAGLIB_MIN_VERSION}") + endif("${TAGLIB_MIN_VERSION}" VERSION_GREATER TAGLIB_VERSION) mark_as_advanced(TAGLIB_CFLAGS TAGLIB_LIBRARIES TAGLIB_INCLUDES) else(TAGLIBCONFIG_EXECUTABLE)
