Hello community, here is the log from the commit of package kactivities5 for openSUSE:Factory checked in at 2016-02-24 18:53:00 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Comparing /work/SRC/openSUSE:Factory/kactivities5 (Old) and /work/SRC/openSUSE:Factory/.kactivities5.new (New) ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Package is "kactivities5" Changes: -------- --- /work/SRC/openSUSE:Factory/kactivities5/kactivities5.changes 2016-01-20 09:41:18.000000000 +0100 +++ /work/SRC/openSUSE:Factory/.kactivities5.new/kactivities5.changes 2016-02-24 18:53:51.000000000 +0100 @@ -1,0 +2,17 @@ +Sun Feb 7 05:32:00 UTC 2016 - [email protected] + +- Add fix-crash-in-activities-context-menu.patch: fixes a dolphin + and desktop crash when right-clicking on a file and opening the + "Activities" submenu (boo#952139, kde#351485) + +------------------------------------------------------------------- +Sat Feb 6 17:59:01 UTC 2016 - [email protected] + +- Update to 5.19.0 (boo#967668) + * Don't call exec() from QML (kde#357435) + * KActivitiesStats library is now in a separate repository + * Fix crash on exit/logout (boo#965653, kde#348194) + * For more details please see: + https://www.kde.org/announcements/kde-frameworks-5.19.0.php + +------------------------------------------------------------------- Old: ---- kactivities-5.18.0.tar.xz New: ---- fix-crash-in-activities-context-menu.patch kactivities-5.19.0.tar.xz ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Other differences: ------------------ ++++++ kactivities5.spec ++++++ --- /var/tmp/diff_new_pack.RpY6ho/_old 2016-02-24 18:53:52.000000000 +0100 +++ /var/tmp/diff_new_pack.RpY6ho/_new 2016-02-24 18:53:52.000000000 +0100 @@ -18,9 +18,9 @@ %bcond_without lang %define lname libKF5Activities5 -%define _tar_path 5.18 +%define _tar_path 5.19 Name: kactivities5 -Version: 5.18.0 +Version: 5.19.0 Release: 0 %define kf5_version %{version} Summary: KDE Plasma Activities support @@ -29,6 +29,8 @@ Url: http://projects.kde.org/kactivities Source: http://download.kde.org/stable/frameworks/%{_tar_path}/kactivities-%{version}.tar.xz Source1: baselibs.conf +# PATCH-FIX-UPSTREAM fix-crash-in-activities-context-menu.patch boo#952139, kde#351485 -- fixes a dolphin and desktop crash when right-clicking on a file and opening the "Activities" submenu +Patch: fix-crash-in-activities-context-menu.patch BuildRequires: boost-devel >= 1.49.0 BuildRequires: cmake >= 2.8.12 BuildRequires: extra-cmake-modules >= %{_tar_path} @@ -96,6 +98,7 @@ %lang_package -n %lname %prep %setup -q -n kactivities-%{version} +%patch -p1 %build %if 0%{?suse_version} == 1310 ++++++ fix-crash-in-activities-context-menu.patch ++++++ From: David Edmundson <[email protected]> Date: Sat, 06 Feb 2016 18:02:53 +0000 Subject: Fix crash in activities context menu X-Git-Url: http://quickgit.kde.org/?p=kactivities.git&a=commitdiff&h=b3c8ad1ad48d65ea77724f94073909dc8ab97596 --- Fix crash in activities context menu Currently we call deleteLater() from inside ::run which is running in a different thread than the receiving object. (QThread objects live in the thread that created them, not in the thread they create) This patch causes deleteLater to be run in the right thread. QCoreApplication::postEvent is thread safe but it needs to be in the right thread to work out the correct event loop level for deferred delete events. BUG: 351485 REVIEW: 126955 --- --- a/src/workspace/fileitemplugin/FileItemLinkingPlugin.cpp +++ b/src/workspace/fileitemplugin/FileItemLinkingPlugin.cpp @@ -124,7 +124,7 @@ setActions({ action }); } else if (!loaded) { - auto loader = new FileItemLinkingPluginActionLoader(items); + auto loader = FileItemLinkingPluginActionLoader::create(items); static FileItemLinkingPluginActionStaticInit init; --- a/src/workspace/fileitemplugin/FileItemLinkingPluginActionLoader.cpp +++ b/src/workspace/fileitemplugin/FileItemLinkingPluginActionLoader.cpp @@ -39,6 +39,13 @@ #include <KLocalizedString> #include "common/dbus/common.h" + +FileItemLinkingPluginActionLoader* FileItemLinkingPluginActionLoader::create(const KFileItemListProperties &items) +{ + auto l = new FileItemLinkingPluginActionLoader(items); + connect(l, &QThread::finished, l, &QObject::deleteLater); + return l; +} FileItemLinkingPluginActionLoader::FileItemLinkingPluginActionLoader( const KFileItemListProperties &items) @@ -150,8 +157,6 @@ } emit result(actions); - - deleteLater(); } Action --- a/src/workspace/fileitemplugin/FileItemLinkingPluginActionLoader.h +++ b/src/workspace/fileitemplugin/FileItemLinkingPluginActionLoader.h @@ -33,8 +33,7 @@ Q_OBJECT public: - FileItemLinkingPluginActionLoader(const KFileItemListProperties &items); - + static FileItemLinkingPluginActionLoader* create(const KFileItemListProperties &items); void run() Q_DECL_OVERRIDE; Action createAction(const QString &activity, bool link, @@ -46,6 +45,7 @@ void result(const ActionList &actions); private: + FileItemLinkingPluginActionLoader(const KFileItemListProperties &items); KFileItemListProperties items; KActivities::Consumer activities; }; ++++++ kactivities-5.18.0.tar.xz -> kactivities-5.19.0.tar.xz ++++++ ++++ 10245 lines of diff (skipped)
