Hello community,
here is the log from the commit of package perl-DBIx-Connector for
openSUSE:Factory checked in at 2016-02-25 22:02:01
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Comparing /work/SRC/openSUSE:Factory/perl-DBIx-Connector (Old)
and /work/SRC/openSUSE:Factory/.perl-DBIx-Connector.new (New)
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Package is "perl-DBIx-Connector"
Changes:
--------
--- /work/SRC/openSUSE:Factory/perl-DBIx-Connector/perl-DBIx-Connector.changes
2015-02-16 21:13:46.000000000 +0100
+++
/work/SRC/openSUSE:Factory/.perl-DBIx-Connector.new/perl-DBIx-Connector.changes
2016-02-25 22:48:52.000000000 +0100
@@ -1,0 +2,30 @@
+Sun Feb 7 09:48:11 UTC 2016 - [email protected]
+
+- updated to 0.55
+ see /usr/share/doc/packages/perl-DBIx-Connector/Changes
+
+ 0.55 2016-02-05T18:59:24Z
+ - Added versions to the RollbackError exception classes to make PAUSE
+ happy.
+
+ 0.54 2016-02-05T18:52:44Z
+ - Removeed the Pod tests from the distribution.
+ - Fixed the example code for handling `rollback_error` exceptions in
the
+ documentation to properly wrap the transaction in an exception
+ handler. Patch from Perlover (issue #32).
+ - Improved handling of connection failures when RaiseError (or
+ HandleError) is not set. Thanks to Andreas Huber for the report and
+ fix.
+ - Document that `$_` is set locally, not globally, in the methods that
+ set it. Suggested by William Lindley.
+ - The disconnect method no longer longer remove entries from the DBI
+ handle's CachedKids attribute. That behavior appears to be a
+ workaround for a database we don't (yet) support.
+ - Fixed a test failure where the test system has the `$DBI_DSN` or
+ `$DBI_DRIVER` environment variable set. Thanks to Erik Rijkers for
the
+ patch.
+ - Added recommendation to use DBD::Pg 3.5.0 or later to the Pg driver.
+ Earlier versions had an incorrect implementation of the `ping()`
+ method (Issue #41).
+
+-------------------------------------------------------------------
Old:
----
DBIx-Connector-0.53.tar.gz
New:
----
DBIx-Connector-0.55.tar.gz
cpanspec.yml
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Other differences:
------------------
++++++ perl-DBIx-Connector.spec ++++++
--- /var/tmp/diff_new_pack.IcwKbn/_old 2016-02-25 22:48:53.000000000 +0100
+++ /var/tmp/diff_new_pack.IcwKbn/_new 2016-02-25 22:48:53.000000000 +0100
@@ -1,7 +1,7 @@
#
# spec file for package perl-DBIx-Connector
#
-# Copyright (c) 2015 SUSE LINUX GmbH, Nuernberg, Germany.
+# Copyright (c) 2016 SUSE LINUX GmbH, Nuernberg, Germany.
#
# All modifications and additions to the file contributed by third parties
# remain the property of their copyright owners, unless otherwise agreed
@@ -17,36 +17,29 @@
Name: perl-DBIx-Connector
-Version: 0.53
+Version: 0.55
Release: 0
%define cpan_name DBIx-Connector
Summary: Fast, safe DBI connection and transaction management
License: Artistic-1.0 or GPL-1.0+
Group: Development/Libraries/Perl
Url: http://search.cpan.org/dist/DBIx-Connector/
-Source:
http://www.cpan.org/authors/id/D/DW/DWHEELER/%{cpan_name}-%{version}.tar.gz
+Source0:
http://www.cpan.org/authors/id/D/DW/DWHEELER/%{cpan_name}-%{version}.tar.gz
+Source1: cpanspec.yml
BuildArch: noarch
BuildRoot: %{_tmppath}/%{name}-%{version}-build
BuildRequires: perl
BuildRequires: perl-macros
BuildRequires: perl(DBI) >= 1.605
-BuildRequires: perl(Module::Build) >= 0.30
+BuildRequires: perl(Module::Build) >= 0.300000
BuildRequires: perl(Test::MockModule) >= 0.05
BuildRequires: perl(Test::More) >= 0.88
Requires: perl(DBI) >= 1.605
Recommends: perl(DBI) >= 1.614
-Recommends: perl(Test::Pod) >= 1.41
-Recommends: perl(Test::Pod::Coverage) >= 1.06
%{perl_requires}
%description
-This module provides a simple interface for fast and safe DBI connection
-and transaction management. Connecting to a database can be expensive; you
-don't want your application to re-connect every time you need to run a query.
-The efficient thing to do is to hang on to a database handle to maintain a
-connection to the database in order to minimize that overhead. This module
-lets you do that without having to worry about dropped or corrupted
-connections.
+Fast, safe DBI connection and transaction management
%prep
%setup -q -n %{cpan_name}-%{version}
@@ -64,6 +57,6 @@
%files -f %{name}.files
%defattr(-,root,root,755)
-%doc Changes README
+%doc Changes README.md
%changelog
++++++ DBIx-Connector-0.53.tar.gz -> DBIx-Connector-0.55.tar.gz ++++++
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore' old/DBIx-Connector-0.53/Build.PL
new/DBIx-Connector-0.55/Build.PL
--- old/DBIx-Connector-0.53/Build.PL 2013-03-20 07:04:21.000000000 +0100
+++ new/DBIx-Connector-0.55/Build.PL 2016-02-05 19:58:48.000000000 +0100
@@ -18,15 +18,13 @@
'perl' => 5.006002,
},
recommends => {
- 'DBI' => '1.614',
- 'Test::Pod' => '1.41',
- 'Test::Pod::Coverage' => '1.06',
+ 'DBI' => '1.614',
},
meta_merge => {
resources => {
homepage => 'http://search.cpan.org/dist/DBIx-Connector/',
- bugtracker => 'http://github.com/theory/dbix-connector/issues/',
- repository => 'http://github.com/theory/dbix-connector/tree/',
+ bugtracker => 'https://github.com/theory/dbix-connector/issues/',
+ repository => 'https://github.com/theory/dbix-connector',
}
},
)->create_build_script;
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore' old/DBIx-Connector-0.53/Changes
new/DBIx-Connector-0.55/Changes
--- old/DBIx-Connector-0.53/Changes 2013-03-20 07:04:21.000000000 +0100
+++ new/DBIx-Connector-0.55/Changes 2016-02-05 19:58:48.000000000 +0100
@@ -1,5 +1,29 @@
Revision history for Perl extension DBIx::Connector.
+0.55 2016-02-05T18:59:24Z
+ - Added versions to the RollbackError exception classes to make PAUSE
+ happy.
+
+0.54 2016-02-05T18:52:44Z
+ - Removeed the Pod tests from the distribution.
+ - Fixed the example code for handling `rollback_error` exceptions in the
+ documentation to properly wrap the transaction in an exception
+ handler. Patch from Perlover (issue #32).
+ - Improved handling of connection failures when RaiseError (or
+ HandleError) is not set. Thanks to Andreas Huber for the report and
+ fix.
+ - Document that `$_` is set locally, not globally, in the methods that
+ set it. Suggested by William Lindley.
+ - The disconnect method no longer longer remove entries from the DBI
+ handle's CachedKids attribute. That behavior appears to be a
+ workaround for a database we don't (yet) support.
+ - Fixed a test failure where the test system has the `$DBI_DSN` or
+ `$DBI_DRIVER` environment variable set. Thanks to Erik Rijkers for the
+ patch.
+ - Added recommendation to use DBD::Pg 3.5.0 or later to the Pg driver.
+ Earlier versions had an incorrect implementation of the `ping()`
+ method (Issue #41).
+
0.53 2013-03-20T06:04:34Z
- Fixed some documentation typos, thanks to Mike O'Regan (Issue #22).
- Fixed issue where an connection failure caused an unhelpful error
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore' old/DBIx-Connector-0.53/MANIFEST
new/DBIx-Connector-0.55/MANIFEST
--- old/DBIx-Connector-0.53/MANIFEST 2013-03-20 07:04:21.000000000 +0100
+++ new/DBIx-Connector-0.55/MANIFEST 2016-02-05 19:58:48.000000000 +0100
@@ -8,12 +8,10 @@
lib/DBIx/Connector/Driver/Pg.pm
lib/DBIx/Connector/Driver/SQLite.pm
MANIFEST This list of files
-README
+README.md
t/base.t
t/driver.t
t/load.t
-t/pod-coverage.t
-t/pod.t
t/run.t
t/run_fixup.t
t/run_ping.t
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore' old/DBIx-Connector-0.53/META.json
new/DBIx-Connector-0.55/META.json
--- old/DBIx-Connector-0.53/META.json 2013-03-20 07:04:21.000000000 +0100
+++ new/DBIx-Connector-0.55/META.json 2016-02-05 19:58:48.000000000 +0100
@@ -4,7 +4,7 @@
"unknown"
],
"dynamic_config" : 1,
- "generated_by" : "Module::Build version 0.4003, CPAN::Meta::Converter
version 2.120351",
+ "generated_by" : "Module::Build version 0.4212",
"license" : [
"perl_5"
],
@@ -28,9 +28,7 @@
},
"runtime" : {
"recommends" : {
- "DBI" : "1.614",
- "Test::Pod" : "1.41",
- "Test::Pod::Coverage" : "1.06"
+ "DBI" : "1.614"
},
"requires" : {
"DBI" : "1.605",
@@ -41,57 +39,57 @@
"provides" : {
"DBIx::Connector" : {
"file" : "lib/DBIx/Connector.pm",
- "version" : "0.53"
+ "version" : "0.55"
},
"DBIx::Connector::Driver" : {
"file" : "lib/DBIx/Connector/Driver.pm",
- "version" : "0.53"
+ "version" : "0.55"
},
"DBIx::Connector::Driver::MSSQL" : {
"file" : "lib/DBIx/Connector/Driver/MSSQL.pm",
- "version" : "0.53"
+ "version" : "0.55"
},
"DBIx::Connector::Driver::Oracle" : {
"file" : "lib/DBIx/Connector/Driver/Oracle.pm",
- "version" : "0.53"
+ "version" : "0.55"
},
"DBIx::Connector::Driver::Pg" : {
"file" : "lib/DBIx/Connector/Driver/Pg.pm",
- "version" : "0.53"
+ "version" : "0.55"
},
"DBIx::Connector::Driver::SQLite" : {
"file" : "lib/DBIx/Connector/Driver/SQLite.pm",
- "version" : "0.53"
+ "version" : "0.55"
},
"DBIx::Connector::Driver::mysql" : {
"file" : "lib/DBIx/Connector/Driver/mysql.pm",
- "version" : "0.53"
+ "version" : "0.55"
},
"DBIx::Connector::RollbackError" : {
"file" : "lib/DBIx/Connector/Driver.pm",
- "version" : 0
+ "version" : "0.55"
},
"DBIx::Connector::SvpRollbackError" : {
"file" : "lib/DBIx/Connector/Driver.pm",
- "version" : 0
+ "version" : "0.55"
},
"DBIx::Connector::TxnRollbackError" : {
"file" : "lib/DBIx/Connector/Driver.pm",
- "version" : 0
+ "version" : "0.55"
}
},
"release_status" : "stable",
"resources" : {
"bugtracker" : {
- "web" : "http://github.com/theory/dbix-connector/issues/";
+ "web" : "https://github.com/theory/dbix-connector/issues/";
},
"homepage" : "http://search.cpan.org/dist/DBIx-Connector/";,
"license" : [
"http://dev.perl.org/licenses/";
],
"repository" : {
- "url" : "http://github.com/theory/dbix-connector/tree/";
+ "url" : "https://github.com/theory/dbix-connector";
}
},
- "version" : "0.53"
+ "version" : "0.55"
}
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore' old/DBIx-Connector-0.53/META.yml
new/DBIx-Connector-0.55/META.yml
--- old/DBIx-Connector-0.53/META.yml 2013-03-20 07:04:21.000000000 +0100
+++ new/DBIx-Connector-0.55/META.yml 2016-02-05 19:58:48.000000000 +0100
@@ -3,59 +3,57 @@
author:
- unknown
build_requires:
- Module::Build: 0.30
- Test::MockModule: 0.05
- Test::More: 0.88
+ Module::Build: '0.30'
+ Test::MockModule: '0.05'
+ Test::More: '0.88'
configure_requires:
- Module::Build: 0.30
+ Module::Build: '0.30'
dynamic_config: 1
-generated_by: 'Module::Build version 0.4003, CPAN::Meta::Converter version
2.120351'
+generated_by: 'Module::Build version 0.4212, CPAN::Meta::Converter version
2.150001'
license: perl
meta-spec:
url: http://module-build.sourceforge.net/META-spec-v1.4.html
- version: 1.4
+ version: '1.4'
name: DBIx-Connector
provides:
DBIx::Connector:
file: lib/DBIx/Connector.pm
- version: 0.53
+ version: '0.55'
DBIx::Connector::Driver:
file: lib/DBIx/Connector/Driver.pm
- version: 0.53
+ version: '0.55'
DBIx::Connector::Driver::MSSQL:
file: lib/DBIx/Connector/Driver/MSSQL.pm
- version: 0.53
+ version: '0.55'
DBIx::Connector::Driver::Oracle:
file: lib/DBIx/Connector/Driver/Oracle.pm
- version: 0.53
+ version: '0.55'
DBIx::Connector::Driver::Pg:
file: lib/DBIx/Connector/Driver/Pg.pm
- version: 0.53
+ version: '0.55'
DBIx::Connector::Driver::SQLite:
file: lib/DBIx/Connector/Driver/SQLite.pm
- version: 0.53
+ version: '0.55'
DBIx::Connector::Driver::mysql:
file: lib/DBIx/Connector/Driver/mysql.pm
- version: 0.53
+ version: '0.55'
DBIx::Connector::RollbackError:
file: lib/DBIx/Connector/Driver.pm
- version: 0
+ version: '0.55'
DBIx::Connector::SvpRollbackError:
file: lib/DBIx/Connector/Driver.pm
- version: 0
+ version: '0.55'
DBIx::Connector::TxnRollbackError:
file: lib/DBIx/Connector/Driver.pm
- version: 0
+ version: '0.55'
recommends:
- DBI: 1.614
- Test::Pod: 1.41
- Test::Pod::Coverage: 1.06
+ DBI: '1.614'
requires:
- DBI: 1.605
- perl: 5.006002
+ DBI: '1.605'
+ perl: '5.006002'
resources:
- bugtracker: http://github.com/theory/dbix-connector/issues/
+ bugtracker: https://github.com/theory/dbix-connector/issues/
homepage: http://search.cpan.org/dist/DBIx-Connector/
license: http://dev.perl.org/licenses/
- repository: http://github.com/theory/dbix-connector/tree/
-version: 0.53
+ repository: https://github.com/theory/dbix-connector
+version: '0.55'
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore' old/DBIx-Connector-0.53/README
new/DBIx-Connector-0.55/README
--- old/DBIx-Connector-0.53/README 2013-03-20 07:04:21.000000000 +0100
+++ new/DBIx-Connector-0.55/README 1970-01-01 01:00:00.000000000 +0100
@@ -1,75 +0,0 @@
-DBIx/Connection version 0.53
-============================
-
-DBIx::Connector provides a simple interface for fast and safe DBI connection
-and transaction management. Connecting to a database can be expensive; you
-don't want your application to re-connect every time you need to run a query.
-The efficient thing to do is to hang on to a database handle to maintain a
-connection to the database in order to minimize that overhead. DBIx::Connector
-lets you do that without having to worry about dropped or corrupted
-connections.
-
-You might be familiar with Apache::DBI and with the DBI's `connect_cached()`
-constructor. DBIx::Connector serves a similar need, but does a much better
-job. How is it different? I'm glad you asked!
-
-* Fork Safety
-
- Like Apache::DBI, but unlike `connect_cached()`, DBIx::Connector will return
- a new database handle if a new process has been `fork`ed. This happens all
- the time under mod_perl, in POE applications, and elsewhere.
-
-* Thread Safety
-
- Unlike Apache::DBI or `connect_cached()`, DBIx::Connector will return a new
- database handle if a new thread has been spawned. As with `fork`ing,
- spawning a new thread can break database connections.
-
-* Works Anywhere
-
- Unlike Apache::DBI, DBIx::Connector runs anywhere -- inside of mod_perl or
- not. Why limit yourself?
-
-* Explicit Interface
-
- DBIx::Connector has an explicit interface. There is none of the magical
- action-at-a-distance crap that Apache::DBI is guilty of, and no global
- caching. I've personally diagnosed a few issues with Apache::DBI's magic,
- and killed it off in two different applications in favor of
- `connect_cached()`, only to be tripped up by other gotchas. No more.
-
-* Optimistic Execution
-
- If you use `run()` and `txn()`, the database handle will be passed without
- first pinging the server. For the 99% or more of the time when the database
- is just there, you'll save a ton of overhead without the ping.
-
-DBIx::Connector's other feature is transaction management. Borrowing from
-DBIx::Class, DBIx::Connector offers an interface that efficiently handles the
-scoping of database transactions so that you needn't worry about managing the
-transaction yourself. Even better, it offers an interface for savepoints if
-your database supports them. Within a transaction, you can scope savepoints to
-behave like subtransactions, so that you can save some of your work in a
-transaction even if some of it fails.
-
-INSTALLATION
-
-To install this module, type the following:
-
- perl Build.PL
- ./Build
- ./Build test
- ./Build install
-
-Dependencies
-------------
-
-DBIx::Connection requires DBI 1.605 or higher.
-
-Copyright and License
----------------------
-
-Copyright (c) 2009-2010 David E. Wheeler. Some Rights Reserved.
-
-This module is free software; you can redistribute it and/or modify it under
-the same terms as Perl itself.
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore' old/DBIx-Connector-0.53/README.md
new/DBIx-Connector-0.55/README.md
--- old/DBIx-Connector-0.53/README.md 1970-01-01 01:00:00.000000000 +0100
+++ new/DBIx-Connector-0.55/README.md 2016-02-05 19:58:48.000000000 +0100
@@ -0,0 +1,78 @@
+DBIx/Connection version 0.55
+============================
+
+DBIx::Connector provides a simple interface for fast and safe DBI connection
+and transaction management. Connecting to a database can be expensive; you
+don't want your application to re-connect every time you need to run a query.
+The efficient thing to do is to hang on to a database handle to maintain a
+connection to the database in order to minimize that overhead. DBIx::Connector
+lets you do that without having to worry about dropped or corrupted
+connections.
+
+You might be familiar with Apache::DBI and with the DBI's `connect_cached()`
+constructor. DBIx::Connector serves a similar need, but does a much better
+job. How is it different? I'm glad you asked!
+
+* Fork Safety
+
+ Like Apache::DBI, but unlike `connect_cached()`, DBIx::Connector will return
+ a new database handle if a new process has been `fork`ed. This happens all
+ the time under mod_perl, in POE applications, and elsewhere.
+
+* Thread Safety
+
+ Unlike Apache::DBI or `connect_cached()`, DBIx::Connector will return a new
+ database handle if a new thread has been spawned. As with `fork`ing,
+ spawning a new thread can break database connections.
+
+* Works Anywhere
+
+ Unlike Apache::DBI, DBIx::Connector runs anywhere -- inside of mod_perl or
+ not. Why limit yourself?
+
+* Explicit Interface
+
+ DBIx::Connector has an explicit interface. There is none of the magical
+ action-at-a-distance crap that Apache::DBI is guilty of, and no global
+ caching. I've personally diagnosed a few issues with Apache::DBI's magic,
+ and killed it off in two different applications in favor of
+ `connect_cached()`, only to be tripped up by other gotchas. No more.
+
+* Optimistic Execution
+
+ If you use `run()` and `txn()`, the database handle will be passed without
+ first pinging the server. For the 99% or more of the time when the database
+ is just there, you'll save a ton of overhead without the ping.
+
+DBIx::Connector's other feature is transaction management. Borrowing from
+DBIx::Class, DBIx::Connector offers an interface that efficiently handles the
+scoping of database transactions so that you needn't worry about managing the
+transaction yourself. Even better, it offers an interface for savepoints if
+your database supports them. Within a transaction, you can scope savepoints to
+behave like subtransactions, so that you can save some of your work in a
+transaction even if some of it fails.
+
+Installation
+------------
+
+[](https://travis-ci.org/theory/dbix-connector)
+
+To install this module, type the following:
+
+ perl Build.PL
+ ./Build
+ ./Build test
+ ./Build install
+
+Dependencies
+------------
+
+DBIx::Connection requires DBI 1.605 or higher.
+
+Copyright and License
+---------------------
+
+Copyright (c) 2009-2013 David E. Wheeler. Some Rights Reserved.
+
+This module is free software; you can redistribute it and/or modify it under
+the same terms as Perl itself.
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore'
old/DBIx-Connector-0.53/lib/DBIx/Connector/Driver/MSSQL.pm
new/DBIx-Connector-0.55/lib/DBIx/Connector/Driver/MSSQL.pm
--- old/DBIx-Connector-0.53/lib/DBIx/Connector/Driver/MSSQL.pm 2013-03-20
07:04:21.000000000 +0100
+++ new/DBIx-Connector-0.55/lib/DBIx/Connector/Driver/MSSQL.pm 2016-02-05
19:58:48.000000000 +0100
@@ -3,7 +3,7 @@
use strict;
use warnings;
use base 'DBIx::Connector::Driver';
-our $VERSION = '0.53';
+our $VERSION = '0.55';
sub savepoint {
my ($self, $dbh, $name) = @_;
@@ -63,7 +63,7 @@
=head1 Copyright and License
-Copyright (c) 2009-2010 David E. Wheeler. Some Rights Reserved.
+Copyright (c) 2009-2013 David E. Wheeler. Some Rights Reserved.
This module is free software; you can redistribute it and/or modify it under
the same terms as Perl itself.
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore'
old/DBIx-Connector-0.53/lib/DBIx/Connector/Driver/Oracle.pm
new/DBIx-Connector-0.55/lib/DBIx/Connector/Driver/Oracle.pm
--- old/DBIx-Connector-0.53/lib/DBIx/Connector/Driver/Oracle.pm 2013-03-20
07:04:21.000000000 +0100
+++ new/DBIx-Connector-0.55/lib/DBIx/Connector/Driver/Oracle.pm 2016-02-05
19:58:48.000000000 +0100
@@ -3,7 +3,7 @@
use strict;
use warnings;
use base 'DBIx::Connector::Driver';
-our $VERSION = '0.53';
+our $VERSION = '0.55';
# Note from https://rt.cpan.org/Ticket/Display.html?id=47005:
# DBD::Oracle has some shutdown state in which it will return 1 on ping as
@@ -88,7 +88,7 @@
=head1 Copyright and License
-Copyright (c) 2009-2010 David E. Wheeler. Some Rights Reserved.
+Copyright (c) 2009-2013 David E. Wheeler. Some Rights Reserved.
This module is free software; you can redistribute it and/or modify it under
the same terms as Perl itself.
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore' old/DBIx-Connector-0.53/lib/DBIx/Connector/Driver/Pg.pm
new/DBIx-Connector-0.55/lib/DBIx/Connector/Driver/Pg.pm
--- old/DBIx-Connector-0.53/lib/DBIx/Connector/Driver/Pg.pm 2013-03-20
07:04:21.000000000 +0100
+++ new/DBIx-Connector-0.55/lib/DBIx/Connector/Driver/Pg.pm 2016-02-05
19:58:48.000000000 +0100
@@ -3,7 +3,7 @@
use strict;
use warnings;
use base 'DBIx::Connector::Driver';
-our $VERSION = '0.53';
+our $VERSION = '0.55';
sub savepoint {
my ($self, $dbh, $name) = @_;
@@ -40,6 +40,10 @@
=item C<rollback_to>
+B<NOTE:> Due to L<a bug|https://rt.cpan.org/Ticket/Display.html?id=100648> in
+the implementation of DBD::Pg's C<ping> method, DBD::Pg 3.5.0 or later is
+strongly recommended.
+
=back
=head1 Authors
@@ -64,7 +68,7 @@
=head1 Copyright and License
-Copyright (c) 2009-2010 David E. Wheeler. Some Rights Reserved.
+Copyright (c) 2009-2013 David E. Wheeler. Some Rights Reserved.
This module is free software; you can redistribute it and/or modify it under
the same terms as Perl itself.
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore'
old/DBIx-Connector-0.53/lib/DBIx/Connector/Driver/SQLite.pm
new/DBIx-Connector-0.55/lib/DBIx/Connector/Driver/SQLite.pm
--- old/DBIx-Connector-0.53/lib/DBIx/Connector/Driver/SQLite.pm 2013-03-20
07:04:21.000000000 +0100
+++ new/DBIx-Connector-0.55/lib/DBIx/Connector/Driver/SQLite.pm 2016-02-05
19:58:48.000000000 +0100
@@ -3,7 +3,7 @@
use strict;
use warnings;
use base 'DBIx::Connector::Driver';
-our $VERSION = '0.53';
+our $VERSION = '0.55';
sub _connect {
my ($self, $dbh, $dsn, $username, $password, $attrs) = @_;
@@ -69,7 +69,7 @@
=head1 Copyright and License
-Copyright (c) 2009-2010 David E. Wheeler. Some Rights Reserved.
+Copyright (c) 2009-2013 David E. Wheeler. Some Rights Reserved.
This module is free software; you can redistribute it and/or modify it under
the same terms as Perl itself.
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore'
old/DBIx-Connector-0.53/lib/DBIx/Connector/Driver/mysql.pm
new/DBIx-Connector-0.55/lib/DBIx/Connector/Driver/mysql.pm
--- old/DBIx-Connector-0.53/lib/DBIx/Connector/Driver/mysql.pm 2013-03-20
07:04:21.000000000 +0100
+++ new/DBIx-Connector-0.55/lib/DBIx/Connector/Driver/mysql.pm 2016-02-05
19:58:48.000000000 +0100
@@ -3,7 +3,7 @@
use strict;
use warnings;
use base 'DBIx::Connector::Driver';
-our $VERSION = '0.53';
+our $VERSION = '0.55';
sub _connect {
my ($self, $dbh) = @_;
@@ -82,7 +82,7 @@
=head1 Copyright and License
-Copyright (c) 2009-2010 David E. Wheeler. Some Rights Reserved.
+Copyright (c) 2009-2013 David E. Wheeler. Some Rights Reserved.
This module is free software; you can redistribute it and/or modify it under
the same terms as Perl itself.
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore' old/DBIx-Connector-0.53/lib/DBIx/Connector/Driver.pm
new/DBIx-Connector-0.55/lib/DBIx/Connector/Driver.pm
--- old/DBIx-Connector-0.53/lib/DBIx/Connector/Driver.pm 2013-03-20
07:04:21.000000000 +0100
+++ new/DBIx-Connector-0.55/lib/DBIx/Connector/Driver.pm 2016-02-05
19:58:48.000000000 +0100
@@ -2,7 +2,7 @@
use strict;
use warnings;
-our $VERSION = '0.53';
+our $VERSION = '0.55';
DRIVERS: {
my %DRIVERS;
@@ -80,6 +80,7 @@
ROLLBACKERR: {
package DBIx::Connector::RollbackError;
+ our $VERSION = '0.55';
# an exception is always true
use overload bool => sub {1}, '""' => 'as_string', fallback => 1;
@@ -94,10 +95,12 @@
}
package DBIx::Connector::TxnRollbackError;
+ our $VERSION = '0.55';
our @ISA = ('DBIx::Connector::RollbackError');
sub _label { 'Transaction' }
package DBIx::Connector::SvpRollbackError;
+ our $VERSION = '0.55';
our @ISA = ('DBIx::Connector::RollbackError');
sub _label { 'Savepoint' }
}
@@ -228,7 +231,7 @@
=head1 Copyright and License
-Copyright (c) 2009-2010 David E. Wheeler. Some Rights Reserved.
+Copyright (c) 2009-2013 David E. Wheeler. Some Rights Reserved.
This module is free software; you can redistribute it and/or modify it under
the same terms as Perl itself.
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore' old/DBIx-Connector-0.53/lib/DBIx/Connector.pm
new/DBIx-Connector-0.55/lib/DBIx/Connector.pm
--- old/DBIx-Connector-0.53/lib/DBIx/Connector.pm 2013-03-20
07:04:21.000000000 +0100
+++ new/DBIx-Connector-0.55/lib/DBIx/Connector.pm 2016-02-05
19:58:48.000000000 +0100
@@ -6,7 +6,7 @@
use DBI '1.605';
use DBIx::Connector::Driver;
-our $VERSION = '0.53';
+our $VERSION = '0.55';
sub new {
my $class = shift;
@@ -24,14 +24,14 @@
sub _connect {
my $self = shift;
my @args = $self->{_args}->();
- my $dbh = $self->{_dbh} = do {
+ my $dbh = do {
if ($INC{'Apache/DBI.pm'} && $ENV{MOD_PERL}) {
local $DBI::connect_via = 'connect'; # Disable Apache::DBI.
DBI->connect( @args );
} else {
DBI->connect( @args );
}
- } or return;
+ } or return undef;
# Modify default values.
$dbh->STORE(AutoInactiveDestroy => 1) if DBI->VERSION > 1.613 && (
@@ -45,6 +45,7 @@
# Where are we?
$self->{_pid} = $$;
$self->{_tid} = threads->tid if $INC{'threads.pm'};
+ $self->{_dbh} = $dbh;
# Set up the driver and go!
return $self->driver->_connect($dbh, @args);
@@ -132,8 +133,11 @@
my $self = shift;
if (my $dbh = $self->{_dbh}) {
# Some databases need this to stop spewing warnings, according to
- # DBIx::Class::Storage::DBI.
- $dbh->STORE(CachedKids => {});
+ # DBIx::Class::Storage::DBI. Probably Sybase, as the code was added
+ # when Sybase ASA and SQLAnywhere support were added to DBIx::Class.
+ # If that ever becomes an issue for us, add a _disconnect to the
+ # Driver class that does it, don't do it here.
+ # $dbh->STORE(CachedKids => {});
$dbh->disconnect;
$self->{_dbh} = undef;
}
@@ -307,7 +311,7 @@
sub _exec {
my ($dbh, $code, $wantarray) = @_;
- local $_ = $dbh;
+ local $_ = $dbh or return;
# Block prevents exiting via next or last, otherwise no commit/rollback.
NOEXIT: {
return $wantarray ? $code->($dbh) : scalar $code->($dbh)
@@ -542,22 +546,22 @@
For example:
use Try::Tiny;
- $conn->txn(sub {
- try {
+ try {
+ $conn->txn(sub {
# ...
- } catch {
- if (eval { $_->isa('DBIx::Connector::RollbackError') }) {
- say STDERR 'Transaction aborted: ', $_->error;
- say STDERR 'Rollback failed too: ', $_->rollback_error;
- } else {
- warn "Caught exception: $_";
- }
- };
- });
+ });
+ } catch {
+ if (eval { $_->isa('DBIx::Connector::RollbackError') }) {
+ say STDERR 'Transaction aborted: ', $_->error;
+ say STDERR 'Rollback failed too: ', $_->rollback_error;
+ } else {
+ warn "Caught exception: $_";
+ }
+ };
If a L<C<svp()>|/"svp"> rollback fails and its surrounding L<C<txn()>|/"txn">
rollback I<also> fails, the thrown DBIx::Connetor::TxnRollbackError exception
-object will have the the savepoint rollback exception, which will be an
+object will have the savepoint rollback exception, which will be an
DBIx::Connetor::SvpRollbackError exception object in its C<error> attribute:
use Try::Tiny;
@@ -688,9 +692,10 @@
$conn->run(ping => sub { $_->do($query) });
-Simply executes the block, setting C<$_> to and passing in the database
-handle. Returns the value returned by the block in scalar or array context as
-appropriate (and the block can use C<wantarray> to decide what to do).
+Simply executes the block, locally setting C<$_> to and passing in the
+database handle. Returns the value returned by the block in scalar or array
+context as appropriate (and the block can use C<wantarray> to decide what to
+do).
An optional first argument sets the connection mode, overriding that set in
the C<mode()> accessor, and may be one of C<ping>, C<fixup>, or C<no_ping>
@@ -731,8 +736,8 @@
my $sth = $conn->txn(fixup => sub { $_->do($query) });
-Starts a transaction, executes the block, setting C<$_> to and passing in the
-database handle, and commits the transaction. If the block throws an
+Starts a transaction, executes the block, locally setting C<$_> to and passing
+in the database handle, and commits the transaction. If the block throws an
exception, the transaction will be rolled back and the exception re-thrown.
Returns the value returned by the block in scalar or array context as
appropriate (and the block can use C<wantarray> to decide what to do).
@@ -1010,7 +1015,7 @@
=head1 Copyright and License
-Copyright (c) 2009-2010 David E. Wheeler. Some Rights Reserved.
+Copyright (c) 2009-2013 David E. Wheeler. Some Rights Reserved.
This module is free software; you can redistribute it and/or modify it under
the same terms as Perl itself.
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore' old/DBIx-Connector-0.53/t/base.t
new/DBIx-Connector-0.55/t/base.t
--- old/DBIx-Connector-0.53/t/base.t 2013-03-20 07:04:21.000000000 +0100
+++ new/DBIx-Connector-0.55/t/base.t 2016-02-05 19:58:48.000000000 +0100
@@ -10,6 +10,8 @@
BEGIN {
$CLASS = 'DBIx::Connector';
use_ok $CLASS or die;
+ $ENV{ DBI_DSN } = undef;
+ $ENV{ DBI_DRIVER } = undef;
}
# Try the basics.
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore' old/DBIx-Connector-0.53/t/pod-coverage.t
new/DBIx-Connector-0.55/t/pod-coverage.t
--- old/DBIx-Connector-0.53/t/pod-coverage.t 2013-03-20 07:04:21.000000000
+0100
+++ new/DBIx-Connector-0.55/t/pod-coverage.t 1970-01-01 01:00:00.000000000
+0100
@@ -1,10 +0,0 @@
-#!/usr/bin/env perl -w
-
-use strict;
-use warnings;
-use Test::More;
-
-eval "use Test::Pod::Coverage 1.06";
-plan skip_all => 'Test::Pod::Coverage 1.06 required' if $@;
-
-all_pod_coverage_ok();
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore' old/DBIx-Connector-0.53/t/pod.t
new/DBIx-Connector-0.55/t/pod.t
--- old/DBIx-Connector-0.53/t/pod.t 2013-03-20 07:04:21.000000000 +0100
+++ new/DBIx-Connector-0.55/t/pod.t 1970-01-01 01:00:00.000000000 +0100
@@ -1,7 +0,0 @@
-#!/usr/bin/env perl -w
-
-use strict;
-use Test::More;
-eval "use Test::Pod 1.41";
-plan skip_all => "Test::Pod 1.41 required for testing POD" if $@;
-all_pod_files_ok();
++++++ cpanspec.yml ++++++
---
#description_paragraphs: 3
#description: |-
# override description from CPAN
#summary: override summary from CPAN
#no_testing: broken upstream
#sources:
# - source1
# - source2
#patches:
# foo.patch: -p1
# bar.patch:
#preamble: |-
# BuildRequires: gcc-c++
#post_prep: |-
# hunspell=`pkg-config --libs hunspell | sed -e 's,-l,,; s, *,,g'`
# sed -i -e "s,hunspell-X,$hunspell," t/00-prereq.t Makefile.PL
#post_build: |-
# rm unused.files
#post_install: |-
# sed on %{name}.files
#license: SUSE-NonFree
#skip_noarch: 1
#custom_build: |-
#./Build build flags=%{?_smp_mflags} --myflag
#custom_test: |-
#startserver && make test
#ignore_requires: Bizarre::Module
