Hello community, here is the log from the commit of package python3-terminado for openSUSE:Factory checked in at 2016-03-26 15:21:39 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Comparing /work/SRC/openSUSE:Factory/python3-terminado (Old) and /work/SRC/openSUSE:Factory/.python3-terminado.new (New) ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Package is "python3-terminado" Changes: -------- --- /work/SRC/openSUSE:Factory/python3-terminado/python3-terminado.changes 2015-11-04 15:34:33.000000000 +0100 +++ /work/SRC/openSUSE:Factory/.python3-terminado.new/python3-terminado.changes 2016-03-26 15:21:41.000000000 +0100 @@ -1,0 +2,13 @@ +Sat Jan 16 20:57:33 UTC 2016 - [email protected] + +- specfile: + * update copyright year + +- update to version 0.6: + * require tornado 4 + * Close PtyProcess object instead of closing fd directly + * use tornado's check_origin method name + * Change _log -> _logger. + * Make built wheels universal. + +------------------------------------------------------------------- Old: ---- terminado-0.5.tar.gz New: ---- terminado-0.6.tar.gz ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Other differences: ------------------ ++++++ python3-terminado.spec ++++++ --- /var/tmp/diff_new_pack.Lkye6s/_old 2016-03-26 15:21:42.000000000 +0100 +++ /var/tmp/diff_new_pack.Lkye6s/_new 2016-03-26 15:21:42.000000000 +0100 @@ -1,7 +1,7 @@ # # spec file for package python3-terminado # -# Copyright (c) 2015 SUSE LINUX GmbH, Nuernberg, Germany. +# Copyright (c) 2016 SUSE LINUX GmbH, Nuernberg, Germany. # # All modifications and additions to the file contributed by third parties # remain the property of their copyright owners, unless otherwise agreed @@ -17,7 +17,7 @@ Name: python3-terminado -Version: 0.5 +Version: 0.6 Release: 0 Summary: Terminals served to termjs using Tornado websockets License: BSD-2-Clause ++++++ terminado-0.5.tar.gz -> terminado-0.6.tar.gz ++++++ diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/terminado-0.5/PKG-INFO new/terminado-0.6/PKG-INFO --- old/terminado-0.5/PKG-INFO 2015-02-18 23:15:18.000000000 +0100 +++ new/terminado-0.6/PKG-INFO 2016-01-04 15:13:38.000000000 +0100 @@ -1,6 +1,6 @@ Metadata-Version: 1.1 Name: terminado -Version: 0.5 +Version: 0.6 Summary: Terminals served to term.js using Tornado websockets Home-page: https://github.com/takluyver/terminado Author: Thomas Kluyver diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/terminado-0.5/setup.cfg new/terminado-0.6/setup.cfg --- old/terminado-0.5/setup.cfg 1970-01-01 01:00:00.000000000 +0100 +++ new/terminado-0.6/setup.cfg 2015-12-08 20:25:42.000000000 +0100 @@ -0,0 +1,2 @@ +[bdist_wheel] +universal=True diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/terminado-0.5/setup.py new/terminado-0.6/setup.py --- old/terminado-0.5/setup.py 2015-02-18 23:10:27.000000000 +0100 +++ new/terminado-0.6/setup.py 2016-01-04 15:05:02.000000000 +0100 @@ -4,7 +4,7 @@ readme = f.read() setup(name="terminado", - version='0.5', + version='0.6', description="Terminals served to term.js using Tornado websockets", long_description=readme, author='Thomas Kluyver', @@ -22,5 +22,5 @@ "Programming Language :: Python :: 3", "Topic :: Terminals :: Terminal Emulators/X Terminals", ], - install_requires=['ptyprocess', 'tornado'], + install_requires=['ptyprocess', 'tornado>=4'], ) \ No newline at end of file diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/terminado-0.5/terminado/__init__.py new/terminado-0.6/terminado/__init__.py --- old/terminado-0.5/terminado/__init__.py 2015-02-18 23:10:31.000000000 +0100 +++ new/terminado-0.6/terminado/__init__.py 2016-01-04 15:05:02.000000000 +0100 @@ -6,4 +6,4 @@ # Prevent a warning about no attached handlers in Python 2 logging.getLogger(__name__).addHandler(logging.NullHandler()) -__version__ = '0.5' +__version__ = '0.6' diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/terminado-0.5/terminado/management.py new/terminado-0.6/terminado/management.py --- old/terminado-0.5/terminado/management.py 2015-02-18 23:07:06.000000000 +0100 +++ new/terminado-0.6/terminado/management.py 2016-01-04 15:03:54.000000000 +0100 @@ -175,10 +175,9 @@ self.log.info("EOF on FD %d; stopping reading", fd) del self.ptys_by_fd[fd] self.ioloop.remove_handler(fd) - os.close(fd) - - # This should reap the child process - ptywclients.ptyproc.isalive() + + # This closes the fd, and should result in the process being reaped. + ptywclients.ptyproc.close() def pty_read(self, fd, events=None): """Called by the event loop when there is pty data ready to read.""" diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/terminado-0.5/terminado/websocket.py new/terminado-0.6/terminado/websocket.py --- old/terminado-0.5/terminado/websocket.py 2015-02-18 02:05:22.000000000 +0100 +++ new/terminado-0.6/terminado/websocket.py 2016-01-04 15:03:54.000000000 +0100 @@ -54,30 +54,11 @@ self.size = (None, None) self.terminal = None - self._log = logging.getLogger(__name__) + self._logger = logging.getLogger(__name__) - def origin_check(self): - """Reject connections from other origin pages. - - This is superfluous with Tornado >= 4, as the same check was added to - Tornado itself. For now, we keep this around for older versions of - Tornado. - """ - if "Origin" in self.request.headers: - origin = self.request.headers.get("Origin") - else: - origin = self.request.headers.get("Sec-Websocket-Origin", None) - - if not origin: - return False - - host = self.request.headers.get("Host").lower() - ws_host = urlparse(origin).netloc.lower() - if host == ws_host: - return True - else: - self._log.error("pyxterm.origin_check: ERROR %s != %s", host, ws_host) - return False + def origin_check(self, origin=None): + """Deprecated: backward-compat for terminado <= 0.5.""" + return self.check_origin(origin or self.request.headers.get('Origin')) def open(self, url_component=None): """Websocket connection opened. @@ -85,10 +66,8 @@ Call our terminal manager to get a terminal, and connect to it as a client. """ - if not self.origin_check(): - raise tornado.web.HTTPError(404, "Websocket origin mismatch") - self._log.info("TermSocket.open: %s", url_component) + self._logger.info("TermSocket.open: %s", url_component) url_component = _cast_unicode(url_component) self.term_name = url_component or 'tty' @@ -98,7 +77,7 @@ self.terminal.clients.append(self) self.send_json_message(["setup", {}]) - self._log.info("TermSocket.open: Opened %s", self.term_name) + self._logger.info("TermSocket.open: Opened %s", self.term_name) def on_pty_read(self, text): """Data read from pty; send to frontend""" @@ -130,7 +109,7 @@ Disconnect from our terminal, and tell the terminal manager we're disconnecting. """ - self._log.info("Websocket closed") + self._logger.info("Websocket closed") if self.terminal: self.terminal.clients.remove(self) self.terminal.resize_to_smallest()
