Hello community, here is the log from the commit of package virt-viewer for openSUSE:Factory checked in at 2016-08-25 09:57:08 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Comparing /work/SRC/openSUSE:Factory/virt-viewer (Old) and /work/SRC/openSUSE:Factory/.virt-viewer.new (New) ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Package is "virt-viewer" Changes: -------- --- /work/SRC/openSUSE:Factory/virt-viewer/virt-viewer.changes 2016-08-03 11:42:56.000000000 +0200 +++ /work/SRC/openSUSE:Factory/.virt-viewer.new/virt-viewer.changes 2016-08-25 09:57:11.000000000 +0200 @@ -1,0 +2,9 @@ +Fri Aug 19 12:48:53 MDT 2016 - [email protected] + +- bsc#983689 - virt-viewer shows Domain-0 on list of virtual + machines + virtview-dont-show-Domain-0.patch +- Upstream bug fix + 813c775c-fix-filename-leak-on-transfer-dialog.patch + +------------------------------------------------------------------- New: ---- 813c775c-fix-filename-leak-on-transfer-dialog.patch virtview-dont-show-Domain-0.patch ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Other differences: ------------------ ++++++ virt-viewer.spec ++++++ --- /var/tmp/diff_new_pack.CQW9Od/_old 2016-08-25 09:57:12.000000000 +0200 +++ /var/tmp/diff_new_pack.CQW9Od/_new 2016-08-25 09:57:12.000000000 +0200 @@ -32,9 +32,11 @@ Source: https://virt-manager.org/download/sources/virt-viewer/%name-%version.tar.gz Patch1: 35e489d5-fix-display-of-guest-name-in-title-for-vnc.patch Patch2: a62827d2-close-when-seeing-domain-stop-event.patch +Patch3: 813c775c-fix-filename-leak-on-transfer-dialog.patch Patch50: netcat.patch Patch51: virtview-desktop.patch Patch52: reverse-3d5627d7-for-xen.patch +Patch53: virtview-dont-show-Domain-0.patch ExclusiveArch: %ix86 x86_64 s390x BuildRoot: %{_tmppath}/%{name}-%{version}-build @@ -79,9 +81,11 @@ %setup -q %patch1 -p1 %patch2 -p1 +%patch3 -p1 %patch50 -p1 %patch51 -p1 %patch52 -p1 +%patch53 -p1 %build echo "suse_version = %suse_version" ++++++ 813c775c-fix-filename-leak-on-transfer-dialog.patch ++++++ Subject: Fix filename leak on transfer dialog From: Victor Toso [email protected] Wed Aug 3 15:40:14 2016 +0200 Date: Fri Aug 5 10:59:23 2016 +0200: Git: 813c775cc9a111ddb0be9e32e797c61fb797fa55 spice_file_transfer_task_get_filename() was wrongly annotated as transfer none. We can safely free this string after usage. Index: virt-viewer-4.0/src/virt-viewer-file-transfer-dialog.c =================================================================== --- virt-viewer-4.0.orig/src/virt-viewer-file-transfer-dialog.c +++ virt-viewer-4.0/src/virt-viewer-file-transfer-dialog.c @@ -101,11 +101,14 @@ typedef struct { static TaskWidgets *task_widgets_new(SpiceFileTransferTask *task) { TaskWidgets *w = g_new0(TaskWidgets, 1); + gchar *filename; w->vbox = gtk_box_new(GTK_ORIENTATION_VERTICAL, 6); w->hbox = gtk_box_new(GTK_ORIENTATION_HORIZONTAL, 12); w->progress = gtk_progress_bar_new(); - w->label = gtk_label_new(spice_file_transfer_task_get_filename(task)); + filename = spice_file_transfer_task_get_filename(task); + w->label = gtk_label_new(filename); + g_free(filename); w->cancel = gtk_button_new_from_icon_name("gtk-cancel", GTK_ICON_SIZE_SMALL_TOOLBAR); gtk_widget_set_hexpand(w->progress, TRUE); gtk_widget_set_valign(w->progress, GTK_ALIGN_CENTER); ++++++ virtview-dont-show-Domain-0.patch ++++++ References: bsc#983689 A user should not be able to connect to Domain-0. Don't show it in the list. Index: virt-viewer-4.0/src/virt-viewer.c =================================================================== --- virt-viewer-4.0.orig/src/virt-viewer.c +++ virt-viewer-4.0/src/virt-viewer.c @@ -753,6 +753,7 @@ choose_vm(GtkWindow *main_window, virDomainPtr *domains, dom = NULL; int i, vms_running; unsigned int flags = VIR_CONNECT_LIST_DOMAINS_RUNNING; + const char *domain_name; g_return_val_if_fail(vm_name != NULL, NULL); free(*vm_name); @@ -761,8 +762,11 @@ choose_vm(GtkWindow *main_window, vms_running = virConnectListAllDomains(conn, &domains, flags); for (i = 0; i < vms_running; i++) { + domain_name = virDomainGetName(domains[i]); + if (domain_name == NULL || !strcmp(domain_name, "Domain-0")) + continue; gtk_list_store_append(model, &iter); - gtk_list_store_set(model, &iter, 0, virDomainGetName(domains[i]), -1); + gtk_list_store_set(model, &iter, 0, domain_name, -1); virDomainFree(domains[i]); } free(domains);
