Great catch! Dick Zetterberg wrote:
I have found a line of code in the factory PrefixActionFactoryProxy that I think is erroneous. It prevents all lookups of action names with prefixes from being cached.This means that for EACH action invocation you get something like 3-5 tries (depending on your webwork.properties) to find the correct Class object for the action. The results are not cached because of a break statement. The statement was introduced in revision 1.10 and I do not know the reason for it. Perhaps one just forgot some { }? Here is a diff that corrects this problem anyway. I have also filed it in Jira as WW-103. Best regards, Dick Zetterberg [EMAIL PROTECTED] Index: PrefixActionFactoryProxy.java =================================================================== RCS file: /cvsroot/opensymphony/webwork/src/main/webwork/action/factory/PrefixActionFa ctoryProxy.java,v retrieving revision 1.14 diff -r1.14 PrefixActionFactoryProxy.java 32c32 < static String actionPrefix ="webwork.action.test,webwork.action.standard"; ---static String actionPrefix="webwork.action.standard,webwork.action.test"; 87,91c87,92 < if(action != null) break; < < // Put in cache < actionNames.put(aName, actionPrefixes[i] + "."+aName); < break; ---if(action != null) { // Put in cache actionNames.put(aName, actionPrefixes[i] + "."+aName); break; }------------------------------------------------------- This SF.NET email is sponsored by: FREE SSL Guide from Thawte are you planning your Web Server Security? Click here to get a FREE Thawte SSL guide and find the answers to all your SSL security issues. http://ads.sourceforge.net/cgi-bin/redirect.pl?thaw0026en _______________________________________________ Opensymphony-webwork mailing list [EMAIL PROTECTED] https://lists.sourceforge.net/lists/listinfo/opensymphony-webwork
-- AOL - bruceritchie101 ICQ - 9929791 MSN - [EMAIL PROTECTED] http://www.jivesoftware.com/
smime.p7s
Description: S/MIME Cryptographic Signature
