On 15/12/16 06:09, Selva Nair wrote: > > On Wed, Dec 14, 2016 at 4:18 PM, David Sommerseth > <open...@sf.lists.topphemmelig.net > <mailto:open...@sf.lists.topphemmelig.net>> wrote: > > On 13/12/16 22:42, David Sommerseth wrote: > > > > Hi all, > > > > So the first phase of the great reformatting is on its way. I have > > just pushed out a reformatting branch to the following > > repositories: > > > > https://github.com:OpenVPN/openvpn.git > > https://gitlab.com:openvpn/openvpn.git > > git://git.code.sf.net/p/openvpn/openvpn > <http://git.code.sf.net/p/openvpn/openvpn> > > > > An updated reformatting branch have been pushed out. If you have > already fetched the it, git will most likely complain as to make > these tests flow reasonably well without cluttering the git tree > too much we have used forced pushes on this branch. > > And again, the The Great Reformatting patch is PGP signed as well, > which can be verified with 'git log --show-signature'. The > signing key is 0x86CF944C9671FDF2, which is the same as this mail > is signed with. > > > The reformatting looks pretty good for an automated process. The result > agrees with independently running the script on master. > > The only issue I noticed is that some functions, for loops and switch > statements have their opening braces on the same line > ssl.c line 272, tun.c line 697 and many such in the several files. > (try grep ") {$" *.c). > > Probably needed nl_switch_brace, nl_fcall_brace etc in the config -- > urgh.. Too many options is a blessing and bane at the same time..
Agreed. I think that we can do some minor reformatting changes later on if we decide to change some more options. Those reformatting changes will most likely not be as invasive as this one has been. > This is not a show stopper for me. Could be handled manually in future > edits when code in the vicinity is touched.. I will now write a new script which patch contributors should run against modified files before committing and submitting. This should hopefully make it better in the long run. But with that in mind, we will need to re-run the reformat-all.sh script each time we decide to modify uncrustify options. -- kind regards, David Sommerseth OpenVPN Technologies, Inc
signature.asc
Description: OpenPGP digital signature
------------------------------------------------------------------------------ Check out the vibrant tech community on one of the world's most engaging tech sites, SlashDot.org! http://sdm.link/slashdot
_______________________________________________ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel
