David Sommerseth <open...@sf.lists.topphemmelig.net> on Wed, 2017/01/25 18:06: > On 25/01/17 17:04, Christian Hesse wrote: > > From: Christian Hesse <m...@eworm.de> > > > > Drop --with-plugindir, instead use an environment variable PLUGINDIR > > to specify the plugin directory. > > > > This generates a header file src/openvpn/plugindir.h which contains a > > define file the plugindir. > > > > v2: The configure script can not evaluate the final $libdir path. So > > use make to create a header file on the containing the final path. > > > > v3: Fix whitespace errors and gitignore location. > > > > Signed-off-by: Christian Hesse <m...@eworm.de> > > --- > > .gitignore | 1 + > > configure.ac | 14 ++++++-------- > > src/openvpn/Makefile.am | 11 +++++++++-- > > src/openvpn/plugin.c | 1 + > > src/openvpn/plugindir.h.in | 34 ++++++++++++++++++++++++++++++++++ > > 5 files changed, 51 insertions(+), 10 deletions(-) > > create mode 100644 src/openvpn/plugindir.h.in > > > Okay, some more feedback to this thread :) > > As I've said, I think this makes sense. It provides a predictable > plug-in directory which is easily accessible within the C code ... and > it will always be set. So, Feature-ACK. > > But I am wondering about the rationale of adding another header file > (plugindir.h). Why not just add this information to > openvpn-plugin.h.in, which results into openvpn-plugin.h ... and which > plugin.c already includes via plugin.h ... I actually think this path > can be quite useful for third-party plug-ins, being built outside of the > openvpn source tree.
I did not want to be too intrusive. ;) Happy to hear that... About to
prepare a new patch, stay tuned!
--
main(a){char*c=/* Schoene Gruesse */"B?IJj;MEH"
"CX:;",b;for(a/* Best regards my address: */=0;b=c[a++];)
putchar(b-1/(/* Chris cc -ox -xc - && ./x */b/42*2-3)*42);}
pgpiRQV96VKF8.pgp
Description: OpenPGP digital signature
------------------------------------------------------------------------------ Check out the vibrant tech community on one of the world's most engaging tech sites, SlashDot.org! http://sdm.link/slashdot
_______________________________________________ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel
