On Sat, Feb 25, 2017 at 06:45:36PM +0500, Илья Шипицин wrote: > 2017-02-25 16:49 GMT+05:00 David Sommerseth < > open...@sf.lists.topphemmelig.net>: > > > On 25/02/17 10:42, Илья Шипицин wrote: > > > there are two another unused functions in misc.c > > > > > > [src/openvpn/misc.c:661]: (style) The function 'env_set_print' is never > > > used. > > > > This one is useful for debugging purposes, so I let this one stay. I > > did consider an #if 0 around it, to make it more explicit. But I > > thought we have enough of those. It could make some compiler warnings > > go away though disabling it. > > > > > it is good idea to put "#if 0" around debug items (that are not used > generally)
Not sure if there is something similar in the code right now, but wouldn't be better to have this kind of code surrounded by some "#ifdef DEBUG" that can be enabled upon configuration ? Cheers, -- Antonio Quartulli
signature.asc
Description: Digital signature
------------------------------------------------------------------------------ Check out the vibrant tech community on one of the world's most engaging tech sites, SlashDot.org! http://sdm.link/slashdot
_______________________________________________ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel
