Acked-by: Gert Doering <g...@greenie.muc.de>
Stared-at-code, ran unit tests beforehand on FreeBSD/amd64 and
AIX/PowerPC, verified that it *failed* on PowerPC. Ran unit tests
again with the patch, and both FreeBSD/amd64 and AIX/PowerPC succeeded
now, so endianness is taken into account now.
I have not server-tested this, as it "should not" make a difference,
and Arne did test this on s390. The full server tests will run
tonight, though.
As agreed on IRC, I've removed the comment from test_pkt.c that
says "we do not use htons..." because now we do :-)
Your patch has been applied to the master and release/2.6 branch.
commit 67bef0357280040b83f2185c91c4f830ba542d6b (master)
commit 3e63dc9b184b17674dfea3cea7eb55ce15779fb2 (release/2.6)
Author: Arne Schwabe
Date: Tue Dec 6 14:36:47 2022 +0100
Fix connection cookie not including address and fix endianness in test
Signed-off-by: Arne Schwabe <a...@rfc2549.org>
Acked-by: Gert Doering <g...@greenie.muc.de>
Message-Id: <20221206133647.954724-1-a...@rfc2549.org>
URL:
https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg25619.html
Signed-off-by: Gert Doering <g...@greenie.muc.de>
--
kind regards,
Gert Doering
_______________________________________________
Openvpn-devel mailing list
Openvpn-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/openvpn-devel
