Attention is currently required from: flichtenheld, plaisthos. its_Giaan has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/523?usp=email )
Change subject: Http-proxy: fix bug preventing proxy credentials caching ...................................................................... Patch Set 6: (2 comments) File src/openvpn/proxy.c: http://gerrit.openvpn.net/c/openvpn/+/523/comment/42ea2ef6_c71a07f0 : PS6, Line 299: else if (!static_proxy_user_pass.nocache) > Do not actually need to check for nocache here. Since it will never be > defined when nocache is set. […] Acknowledged http://gerrit.openvpn.net/c/openvpn/+/523/comment/19fd5e77_9975a90f : PS6, Line 304: else if (static_proxy_user_pass.nocache && !force) > I think this condition is too complicated. […] I think we need it otherwise in case of nocache true creds would be wiped at the first call of the get_user_pass() and then asked again at the second call (the one with force == false), by checking force we know that we're at the second call of the function so we can clear previous creds since we don't need them anymore. Totally agree about the "else". -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/523?usp=email To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: Ia3e06c0832c4ca0ab868c845279fb71c01a1a78a Gerrit-Change-Number: 523 Gerrit-PatchSet: 6 Gerrit-Owner: its_Giaan <gianma...@mandelbit.com> Gerrit-Reviewer: flichtenheld <fr...@lichtenheld.com> Gerrit-Reviewer: plaisthos <arne-open...@rfc2549.org> Gerrit-CC: openvpn-devel <openvpn-devel@lists.sourceforge.net> Gerrit-Attention: plaisthos <arne-open...@rfc2549.org> Gerrit-Attention: flichtenheld <fr...@lichtenheld.com> Gerrit-Comment-Date: Tue, 12 Mar 2024 11:27:31 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: flichtenheld <fr...@lichtenheld.com> Gerrit-MessageType: comment
_______________________________________________ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel
